From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Nilay Shroff <nilay@linux.ibm.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/3] block: Remove queue freezing from several sysfs store callbacks
Date: Thu, 3 Jul 2025 11:06:46 +0200 [thread overview]
Message-ID: <20250703090646.GE4757@lst.de> (raw)
In-Reply-To: <aGXmJg-ZIuFO9WnP@fedora>
On Thu, Jul 03, 2025 at 10:08:38AM +0800, Ming Lei wrote:
> On Wed, Jul 02, 2025 at 11:24:28AM -0700, Bart Van Assche wrote:
> > Freezing the request queue from inside sysfs store callbacks may cause a
> > deadlock in combination with the dm-multipath driver and the
> > queue_if_no_path option. Additionally, freezing the request queue slows
> > down system boot on systems where sysfs attributes are set synchronously.
> >
> > Fix this by removing the blk_mq_freeze_queue() / blk_mq_unfreeze_queue()
> > calls from the store callbacks that do not strictly need these callbacks.
>
> Please add commit log why freeze isn't needed for these sysfs attributes
> callbacks.
Yes. I'm rather doubtful about some of them, but waiting for a full
explanation. The explanation might be easier to deliver by doing one
patch per attribute.
next prev parent reply other threads:[~2025-07-03 9:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-02 18:24 [PATCH 0/3] Fix a deadlock related to modifying queue attributes Bart Van Assche
2025-07-02 18:24 ` [PATCH 1/3] block: Remove queue freezing from several sysfs store callbacks Bart Van Assche
2025-07-03 2:08 ` Ming Lei
2025-07-03 9:06 ` Christoph Hellwig [this message]
2025-07-02 18:24 ` [PATCH 2/3] block: Restrict the duration of sysfs attribute changes Bart Van Assche
2025-07-03 9:07 ` Christoph Hellwig
2025-07-03 14:54 ` Nilay Shroff
2025-07-02 18:24 ` [PATCH 3/3] block: Move a misplaced comment in queue_wb_lat_store() Bart Van Assche
2025-07-03 9:09 ` [PATCH 0/3] Fix a deadlock related to modifying queue attributes Christoph Hellwig
2025-07-07 18:35 ` Bart Van Assche
2025-07-08 9:57 ` Christoph Hellwig
2025-07-08 16:11 ` Bart Van Assche
2025-07-10 8:03 ` Christoph Hellwig
2025-07-10 19:29 ` Bart Van Assche
2025-10-27 14:43 ` Martin Wilck
2025-10-29 8:58 ` Christoph Hellwig
2025-10-29 9:36 ` Martin Wilck
2025-10-29 9:38 ` Christoph Hellwig
2025-10-29 16:31 ` Bart Van Assche
2025-10-29 17:09 ` Martin Wilck
2025-07-08 17:16 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250703090646.GE4757@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=nilay@linux.ibm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.