All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 0/3] Fix a deadlock related to modifying queue attributes
Date: Thu, 3 Jul 2025 11:09:06 +0200	[thread overview]
Message-ID: <20250703090906.GG4757@lst.de> (raw)
In-Reply-To: <20250702182430.3764163-1-bvanassche@acm.org>

I'm still very doubtful on this whole approach, and I think you are
ignoring the root cause, which is dm-multipath keeping a q_usage_count
reference for an unbounded time.  It is only supposed to be held over
I/O, and I/O is expected to time out.

You'll probably get much farther by changing dm-multipath to not hold
a q_usage_count reference for something not actually under I/O.


  parent reply	other threads:[~2025-07-03  9:09 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-02 18:24 [PATCH 0/3] Fix a deadlock related to modifying queue attributes Bart Van Assche
2025-07-02 18:24 ` [PATCH 1/3] block: Remove queue freezing from several sysfs store callbacks Bart Van Assche
2025-07-03  2:08   ` Ming Lei
2025-07-03  9:06     ` Christoph Hellwig
2025-07-02 18:24 ` [PATCH 2/3] block: Restrict the duration of sysfs attribute changes Bart Van Assche
2025-07-03  9:07   ` Christoph Hellwig
2025-07-03 14:54   ` Nilay Shroff
2025-07-02 18:24 ` [PATCH 3/3] block: Move a misplaced comment in queue_wb_lat_store() Bart Van Assche
2025-07-03  9:09 ` Christoph Hellwig [this message]
2025-07-07 18:35   ` [PATCH 0/3] Fix a deadlock related to modifying queue attributes Bart Van Assche
2025-07-08  9:57     ` Christoph Hellwig
2025-07-08 16:11       ` Bart Van Assche
2025-07-10  8:03         ` Christoph Hellwig
2025-07-10 19:29           ` Bart Van Assche
2025-10-27 14:43           ` Martin Wilck
2025-10-29  8:58             ` Christoph Hellwig
2025-10-29  9:36               ` Martin Wilck
2025-10-29  9:38                 ` Christoph Hellwig
2025-10-29 16:31                   ` Bart Van Assche
2025-10-29 17:09                     ` Martin Wilck
2025-07-08 17:16       ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250703090906.GG4757@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.