From: Christoph Hellwig <hch@lst.de>
To: Martin Wilck <mwilck@suse.com>
Cc: Christoph Hellwig <hch@lst.de>,
Bart Van Assche <bvanassche@acm.org>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
Benjamin Marzinski <bmarzins@redhat.com>,
Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH 0/3] Fix a deadlock related to modifying queue attributes
Date: Wed, 29 Oct 2025 09:58:10 +0100 [thread overview]
Message-ID: <20251029085810.GA32474@lst.de> (raw)
In-Reply-To: <563ef9b02d49fa05418c7a1b0b384d898819e0e9.camel@suse.com>
On Mon, Oct 27, 2025 at 03:43:50PM +0100, Martin Wilck wrote:
> As Bart's patch only addresses the regression introduced by
> b07a889e8335 ("block: move q->sysfs_lock and queue-freeze under
> show/store method"), can we perhaps leave non-sysfs users of queue
> freezing aside in this context?
>
> As far as sysfs users are concerned, what problem do you see with
> Bart's approach to introduce a timeout for freezing the queues, and
> returning an error to user space if this timeout is exceeded?
>
> Would you be willing to accept the set if we'd use the timeout approach
> for all affected sysfs attributes?
Maybe it's because the discussion, but I have no idea what you are
trying to advocate for. But a timeout for a locking operation is
not an option to work around deadlocks.
next prev parent reply other threads:[~2025-10-29 8:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-02 18:24 [PATCH 0/3] Fix a deadlock related to modifying queue attributes Bart Van Assche
2025-07-02 18:24 ` [PATCH 1/3] block: Remove queue freezing from several sysfs store callbacks Bart Van Assche
2025-07-03 2:08 ` Ming Lei
2025-07-03 9:06 ` Christoph Hellwig
2025-07-02 18:24 ` [PATCH 2/3] block: Restrict the duration of sysfs attribute changes Bart Van Assche
2025-07-03 9:07 ` Christoph Hellwig
2025-07-03 14:54 ` Nilay Shroff
2025-07-02 18:24 ` [PATCH 3/3] block: Move a misplaced comment in queue_wb_lat_store() Bart Van Assche
2025-07-03 9:09 ` [PATCH 0/3] Fix a deadlock related to modifying queue attributes Christoph Hellwig
2025-07-07 18:35 ` Bart Van Assche
2025-07-08 9:57 ` Christoph Hellwig
2025-07-08 16:11 ` Bart Van Assche
2025-07-10 8:03 ` Christoph Hellwig
2025-07-10 19:29 ` Bart Van Assche
2025-10-27 14:43 ` Martin Wilck
2025-10-29 8:58 ` Christoph Hellwig [this message]
2025-10-29 9:36 ` Martin Wilck
2025-10-29 9:38 ` Christoph Hellwig
2025-10-29 16:31 ` Bart Van Assche
2025-10-29 17:09 ` Martin Wilck
2025-07-08 17:16 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251029085810.GA32474@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bmarzins@redhat.com \
--cc=bvanassche@acm.org \
--cc=hare@suse.com \
--cc=linux-block@vger.kernel.org \
--cc=mwilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.