[PATCH] erofs: fix to add missing tracepoint in erofs_readahead()

[PATCH] erofs: fix to add missing tracepoint in erofs_readahead()

[Chao Yu]

Commit 771c994ea51f ("erofs: convert all uncompressed cases to iomap")
converts to use iomap interface, it removed trace_erofs_readahead()
tracepoint in the meantime, let's add it back.

Fixes: 771c994ea51f ("erofs: convert all uncompressed cases to iomap")
Signed-off-by: Chao Yu <chao@kernel.org>
---
 fs/erofs/data.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/fs/erofs/data.c b/fs/erofs/data.c
index 6a329c329f43..534ac359976e 100644
--- a/fs/erofs/data.c
+++ b/fs/erofs/data.c
@@ -356,6 +356,9 @@ static int erofs_read_folio(struct file *file, struct folio *folio)
 
 static void erofs_readahead(struct readahead_control *rac)
 {
+	trace_erofs_readahead(rac->mapping->host, readahead_index(rac),
+					readahead_count(rac), true);
+
 	return iomap_readahead(rac, &erofs_iomap_ops);
 }
 
-- 
2.49.0

Re: [PATCH] erofs: fix to add missing tracepoint in erofs_readahead()

[Gao Xiang]

On 2025/7/7 16:48, Chao Yu wrote:
> Commit 771c994ea51f ("erofs: convert all uncompressed cases to iomap")
> converts to use iomap interface, it removed trace_erofs_readahead()
> tracepoint in the meantime, let's add it back.
> 
> Fixes: 771c994ea51f ("erofs: convert all uncompressed cases to iomap")

Thanks Chao, btw, should we add tracepoint to erofs_read_folio() too?

Thanks,
Gao Xiang

> Signed-off-by: Chao Yu <chao@kernel.org>
> ---
>   fs/erofs/data.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/fs/erofs/data.c b/fs/erofs/data.c
> index 6a329c329f43..534ac359976e 100644
> --- a/fs/erofs/data.c
> +++ b/fs/erofs/data.c
> @@ -356,6 +356,9 @@ static int erofs_read_folio(struct file *file, struct folio *folio)
>   
>   static void erofs_readahead(struct readahead_control *rac)
>   {
> +	trace_erofs_readahead(rac->mapping->host, readahead_index(rac),
> +					readahead_count(rac), true);
> +
>   	return iomap_readahead(rac, &erofs_iomap_ops);
>   }
>   

Re: [PATCH] erofs: fix to add missing tracepoint in erofs_readahead()

[Chao Yu]

On 7/7/25 18:17, Gao Xiang wrote:
> 
> 
> On 2025/7/7 16:48, Chao Yu wrote:
>> Commit 771c994ea51f ("erofs: convert all uncompressed cases to iomap")
>> converts to use iomap interface, it removed trace_erofs_readahead()
>> tracepoint in the meantime, let's add it back.
>>
>> Fixes: 771c994ea51f ("erofs: convert all uncompressed cases to iomap")
> 
> Thanks Chao, btw, should we add tracepoint to erofs_read_folio() too?

Xiang, I guess it is useful for debug if we can add it, let me figure out
a patch for that?

Thanks,

> 
> Thanks,
> Gao Xiang
> 
>> Signed-off-by: Chao Yu <chao@kernel.org>
>> ---
>>   fs/erofs/data.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/fs/erofs/data.c b/fs/erofs/data.c
>> index 6a329c329f43..534ac359976e 100644
>> --- a/fs/erofs/data.c
>> +++ b/fs/erofs/data.c
>> @@ -356,6 +356,9 @@ static int erofs_read_folio(struct file *file, struct folio *folio)
>>     static void erofs_readahead(struct readahead_control *rac)
>>   {
>> +    trace_erofs_readahead(rac->mapping->host, readahead_index(rac),
>> +                    readahead_count(rac), true);
>> +
>>       return iomap_readahead(rac, &erofs_iomap_ops);
>>   }
>>   
> 
> 

Re: [PATCH] erofs: fix to add missing tracepoint in erofs_readahead()

[Gao Xiang]

On 2025/7/7 19:22, Chao Yu wrote:
> On 7/7/25 18:17, Gao Xiang wrote:
>>
>>
>> On 2025/7/7 16:48, Chao Yu wrote:
>>> Commit 771c994ea51f ("erofs: convert all uncompressed cases to iomap")
>>> converts to use iomap interface, it removed trace_erofs_readahead()
>>> tracepoint in the meantime, let's add it back.
>>>
>>> Fixes: 771c994ea51f ("erofs: convert all uncompressed cases to iomap")
>>
>> Thanks Chao, btw, should we add tracepoint to erofs_read_folio() too?
> 
> Xiang, I guess it is useful for debug if we can add it, let me figure out
> a patch for that?

Yes, it's up to you if you'd like to submit anothe patch for this.

Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>

Thanks,
Gao Xiang