All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Vadim Fedorenko <vadfed@meta.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Michael Chan <michael.chan@broadcom.com>,
	Pavan Chebbi <pavan.chebbi@broadcom.com>,
	Tariq Toukan <tariqt@nvidia.com>, Gal Pressman <gal@nvidia.com>,
	<intel-wired-lan@lists.osuosl.org>,
	Donald Hunter <donald.hunter@gmail.com>,
	Carolina Jubran <cjubran@nvidia.com>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
	<netdev@vger.kernel.org>,
	Vadim Fedorenko <vadim.fedorenko@linux.dev>
Subject: Re: [Intel-wired-lan] [RFC PATCH v2] ethtool: add FEC bins histogramm report
Date: Fri, 1 Aug 2025 13:06:48 -0700	[thread overview]
Message-ID: <20250801130648.341995ba@kernel.org> (raw)
In-Reply-To: <20250731231019.1809172-1-vadfed@meta.com>

On Thu, 31 Jul 2025 16:10:19 -0700 Vadim Fedorenko wrote:
> - remove sentinel (-1, -1) and use (0, 0) as common array break.
>   bin (0, 0) is still possible but only as a first element of
>   ranges array

I don't see this change in the diff? It's still -1,-1

Also, not seeing per-lane support here.

> diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
> index 1063d5d32fea2..69779b51f1dfd 100644
> --- a/Documentation/netlink/specs/ethtool.yaml
> +++ b/Documentation/netlink/specs/ethtool.yaml
> @@ -1239,6 +1239,30 @@ attribute-sets:
>          name: corr-bits
>          type: binary
>          sub-type: u64
> +      -
> +        name: hist
> +        type: nest
> +        multi-attr: True
> +        nested-attributes: fec-hist
> +      -
> +        name: fec-hist-bin-low
> +        type: uint
> +      -
> +        name: fec-hist-bin-high
> +        type: uint

The bounds can be u32, TBH. The value really is a u16 but we don't want
to waste space on padding in Netlink. Still, no need to go all the way
to uint.

> +        name: fec-hist-bin-val
> +        type: uint

WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Vadim Fedorenko <vadfed@meta.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Michael Chan <michael.chan@broadcom.com>,
	Pavan Chebbi <pavan.chebbi@broadcom.com>,
	Tariq Toukan <tariqt@nvidia.com>, Gal Pressman <gal@nvidia.com>,
	<intel-wired-lan@lists.osuosl.org>,
	Donald Hunter <donald.hunter@gmail.com>,
	Carolina Jubran <cjubran@nvidia.com>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
	<netdev@vger.kernel.org>,
	Vadim Fedorenko <vadim.fedorenko@linux.dev>
Subject: Re: [RFC PATCH v2] ethtool: add FEC bins histogramm report
Date: Fri, 1 Aug 2025 13:06:48 -0700	[thread overview]
Message-ID: <20250801130648.341995ba@kernel.org> (raw)
In-Reply-To: <20250731231019.1809172-1-vadfed@meta.com>

On Thu, 31 Jul 2025 16:10:19 -0700 Vadim Fedorenko wrote:
> - remove sentinel (-1, -1) and use (0, 0) as common array break.
>   bin (0, 0) is still possible but only as a first element of
>   ranges array

I don't see this change in the diff? It's still -1,-1

Also, not seeing per-lane support here.

> diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
> index 1063d5d32fea2..69779b51f1dfd 100644
> --- a/Documentation/netlink/specs/ethtool.yaml
> +++ b/Documentation/netlink/specs/ethtool.yaml
> @@ -1239,6 +1239,30 @@ attribute-sets:
>          name: corr-bits
>          type: binary
>          sub-type: u64
> +      -
> +        name: hist
> +        type: nest
> +        multi-attr: True
> +        nested-attributes: fec-hist
> +      -
> +        name: fec-hist-bin-low
> +        type: uint
> +      -
> +        name: fec-hist-bin-high
> +        type: uint

The bounds can be u32, TBH. The value really is a u16 but we don't want
to waste space on padding in Netlink. Still, no need to go all the way
to uint.

> +        name: fec-hist-bin-val
> +        type: uint

  reply	other threads:[~2025-08-01 20:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-31 23:10 [Intel-wired-lan] [RFC PATCH v2] ethtool: add FEC bins histogramm report Vadim Fedorenko
2025-07-31 23:10 ` Vadim Fedorenko
2025-08-01 20:06 ` Jakub Kicinski [this message]
2025-08-01 20:06   ` Jakub Kicinski
2025-08-01 20:28   ` [Intel-wired-lan] " Vadim Fedorenko
2025-08-01 20:28     ` Vadim Fedorenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250801130648.341995ba@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=cjubran@nvidia.com \
    --cc=donald.hunter@gmail.com \
    --cc=gal@nvidia.com \
    --cc=horms@kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pavan.chebbi@broadcom.com \
    --cc=tariqt@nvidia.com \
    --cc=vadfed@meta.com \
    --cc=vadim.fedorenko@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.