Re: Fwd: New Defects reported by Coverity Scan for Das U-Boot

[Alexander Dahl <ada@thorsis.com>]

Hello,

Am Fri, Jul 25, 2025 at 07:26:45AM -0600 schrieb Tom Rini:
> Here's the latest report. These aren't new issues as much as they are
> Coverity now looking at FPGA code issues.
> 
> ---------- Forwarded message ---------
> From: <scan-admin@coverity.com>
> Date: Thu, Jul 24, 2025 at 8:03 PM
> Subject: New Defects reported by Coverity Scan for Das U-Boot
> To: <tom.rini@gmail.com>
> 
> 
> Hi,
> 
> Please find the latest report on new defect(s) introduced to *Das U-Boot*
> found with Coverity Scan.
> 
>    - *New Defects Found:* 8
>    - 3 defect(s), reported by Coverity Scan earlier, were marked fixed in
>    the recent build analyzed by Coverity Scan.
>    - *Defects Shown:* Showing 8 of 8 defect(s)
> 
> Defect Details
> 

[…]

> ** CID 583148:       Control flow issues  (DEADCODE)
> /drivers/fpga/cyclon2.c: 180           in CYC2_ps_load()
> 
> 
> _____________________________________________________________________________________________
> *** CID 583148:         Control flow issues  (DEADCODE)
> /drivers/fpga/cyclon2.c: 180             in CYC2_ps_load()
> 174     		ret_val = FPGA_SUCCESS;
> 175
> 176     #ifdef CONFIG_SYS_FPGA_PROG_FEEDBACK
> 177     		if (ret_val == FPGA_SUCCESS)
> 178     			puts("Done.\n");
> 179     		else
> >>>     CID 583148:         Control flow issues  (DEADCODE)
> >>>     Execution cannot reach this statement: "puts("Fail.\n");".
> 180     			puts("Fail.\n");
> 181     #endif
> 182
> 183     		/*
> 184     		 * Run the post configuration function if there is one.
> 185     		 */

See
https://lore.kernel.org/u-boot/20250804090816.42603-1-ada@thorsis.com/T/#u
for a fix of the cyclon2 driver.

Greets
Alex