Re: Fwd: New Defects reported by Coverity Scan for Das U-Boot

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 985 bytes --]

On Mon, Mar 09, 2026 at 11:05:27PM +0100, Raphaël Gallais-Pou wrote:
> Hi Tom,
> 
> Regarding both stm32_dsi errors:
> 
> It seems those errors are not linked to the patch you merged recently,
> because it does not change the lines mentioned by Coverity.

Ah, likely so, yes.

> Calls to device_chld_{remove, unbind} are introduced by commit a6d047c0a86b
> ("video: stm32: remove all child of DSI bridge when its probe failed").
> 
> My guess is that since my patch changed the file, it triggered the Coverity
> Scan for the whole file.
> 
> Regardless, ret is overwritten right after the calls, so I don't think
> checking the return value matters here except if there is a log information.
> 
> Tell me if you want me to provide a fix, but in this case I'm not sure to
> see the point.

It would be good to match the usual pattern (drivers/scsi/scsi.c and
drivers/ata/sata.c) even if it's an unlikey chain of events. Please send
a patch, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]