All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 3/6] arm64: dts: broadcom: bcm2712: Add pin controller nodes
  2025-08-11 15:19 [PATCH 0/6] Add peripheral nodes to RaspberryPi 5 DT Andrea della Porta
@ 2025-08-11 15:19 ` Andrea della Porta
  0 siblings, 0 replies; 2+ messages in thread
From: Andrea della Porta @ 2025-08-11 15:19 UTC (permalink / raw)
  To: linus.walleij, robh, krzk+dt, conor+dt, florian.fainelli,
	wahrenst, linux-gpio, devicetree, linux-arm-kernel,
	Catalin Marinas, Will Deacon, iivanov, svarbanov, mbrugger,
	Jonathan Bell, Phil Elwell, Ulf Hansson,
	Broadcom internal kernel review list, Al Cooper, linux-mmc,
	Jiri Slaby, linux-serial
  Cc: Andrea della Porta

From: "Ivan T. Ivanov" <iivanov@suse.de>

Add pin-control devicetree nodes and used them to
explicitly define uSD card interface pin configuration.

Signed-off-by: Ivan T. Ivanov <iivanov@suse.de>
Reviewed-by: Stefan Wahren <wahrenst@gmx.net>
Signed-off-by: Andrea della Porta <andrea.porta@suse.com>
---
 .../dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dts   | 18 ++++++++++++++++++
 arch/arm64/boot/dts/broadcom/bcm2712.dtsi      | 10 ++++++++++
 2 files changed, 28 insertions(+)

diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dts b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dts
index 6ea3c102e0d6..6091a1ff365c 100644
--- a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dts
+++ b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dts
@@ -53,6 +53,21 @@ sd_vcc_reg: sd-vcc-reg {
 	};
 };
 
+&pinctrl {
+	emmc_sd_default: emmc-sd-default-state {
+		pins = "emmc_cmd", "emmc_dat0", "emmc_dat1", "emmc_dat2", "emmc_dat3";
+		bias-pull-up;
+	};
+};
+
+&pinctrl_aon {
+	emmc_aon_cd_default: emmc-aon-cd-default-state {
+		function = "sd_card_g";
+		pins = "aon_gpio5";
+		bias-pull-up;
+	};
+};
+
 /* The Debug UART, on Rpi5 it's on JST-SH 1.0mm 3-pin connector
  * labeled "UART", i.e. the interface with the system console.
  */
@@ -62,12 +77,15 @@ &uart10 {
 
 /* SDIO1 is used to drive the SD card */
 &sdio1 {
+	pinctrl-0 = <&emmc_sd_default>, <&emmc_aon_cd_default>;
+	pinctrl-names = "default";
 	vqmmc-supply = <&sd_io_1v8_reg>;
 	vmmc-supply = <&sd_vcc_reg>;
 	bus-width = <4>;
 	sd-uhs-sdr50;
 	sd-uhs-ddr50;
 	sd-uhs-sdr104;
+	cd-gpios = <&gio_aon 5 GPIO_ACTIVE_LOW>;
 };
 
 &soc {
diff --git a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi b/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
index 0a9212d3106f..8a517261841d 100644
--- a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
+++ b/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
@@ -243,6 +243,16 @@ uart10: serial@7d001000 {
 			status = "disabled";
 		};
 
+		pinctrl: pinctrl@7d504100 {
+			compatible = "brcm,bcm2712c0-pinctrl";
+			reg = <0x7d504100 0x30>;
+		};
+
+		pinctrl_aon: pinctrl@7d510700 {
+			compatible = "brcm,bcm2712c0-aon-pinctrl";
+			reg = <0x7d510700 0x20>;
+		};
+
 		interrupt-controller@7d517000 {
 			compatible = "brcm,bcm7271-l2-intc";
 			reg = <0x7d517000 0x10>;
-- 
2.35.3



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 3/6] arm64: dts: broadcom: bcm2712: Add pin controller nodes
@ 2025-08-13  2:35 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2025-08-13  2:35 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp

:::::: 
:::::: Manual check reason: "dtcheck: binding changes may go via different trees"
:::::: 

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <df99c6a2eeac4bed76bcc6bd74e44a061963256e.1754924348.git.andrea.porta@suse.com>
References: <df99c6a2eeac4bed76bcc6bd74e44a061963256e.1754924348.git.andrea.porta@suse.com>
TO: Andrea della Porta <andrea.porta@suse.com>
TO: linus.walleij@linaro.org
TO: robh@kernel.org
TO: krzk+dt@kernel.org
TO: conor+dt@kernel.org
TO: florian.fainelli@broadcom.com
TO: wahrenst@gmx.net
TO: linux-gpio@vger.kernel.org
TO: devicetree@vger.kernel.org
TO: linux-arm-kernel@lists.infradead.org
TO: Catalin Marinas <catalin.marinas@arm.com>
TO: Will Deacon <will@kernel.org>
TO: iivanov@suse.de
TO: svarbanov@suse.de
TO: mbrugger@suse.com
TO: Jonathan Bell <jonathan@raspberrypi.com>
TO: Phil Elwell <phil@raspberrypi.com>
TO: Ulf Hansson <ulf.hansson@linaro.org>
TO: Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>
TO: Al Cooper <alcooperx@gmail.com>
TO: linux-mmc@vger.kernel.org
TO: Jiri Slaby <jirislaby@kernel.org>
TO: linux-serial@vger.kernel.org
CC: Andrea della Porta <andrea.porta@suse.com>

Hi Andrea,

kernel test robot noticed the following build warnings:

[auto build test WARNING on robh/for-next]
[also build test WARNING on tty/tty-testing tty/tty-next tty/tty-linus rockchip/for-next linus/master v6.17-rc1 next-20250812]
[cannot apply to arm/for-next arm/fixes arm64/for-next/core kvmarm/next shawnguo/for-next soc/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Andrea-della-Porta/dt-bindings-mmc-Add-support-for-capabilities-to-Broadcom-SDHCI-controller/20250811-232101
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/df99c6a2eeac4bed76bcc6bd74e44a061963256e.1754924348.git.andrea.porta%40suse.com
patch subject: [PATCH 3/6] arm64: dts: broadcom: bcm2712: Add pin controller nodes
:::::: branch date: 35 hours ago
:::::: commit date: 35 hours ago
config: arm64-randconfig-051-20250812 (https://download.01.org/0day-ci/archive/20250813/202508130908.mmjdJJFQ-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 3769ce013be2879bf0b329c14a16f5cb766f26ce)
dtschema version: 2025.6.2.dev4+g8f79ddd
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250813/202508130908.mmjdJJFQ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202508130908.mmjdJJFQ-lkp@intel.com/

dtcheck warnings: (new ones prefixed by >>)
   arch/arm64/boot/dts/broadcom/bcm2712.dtsi:504.4-507.31: Warning (interrupt_map): /axi/pcie@1000110000:interrupt-map: Missing property '#address-cells' in node /soc@107c000000/interrupt-controller@7fff9000, using 0 as fallback
   arch/arm64/boot/dts/broadcom/bcm2712.dtsi:504.4-507.31: Warning (interrupt_map): /axi/pcie@1000110000:interrupt-map: Missing property '#address-cells' in node /soc@107c000000/interrupt-controller@7fff9000, using 0 as fallback
   arch/arm64/boot/dts/broadcom/bcm2712.dtsi:543.4-546.31: Warning (interrupt_map): /axi/pcie@1000120000:interrupt-map: Missing property '#address-cells' in node /soc@107c000000/interrupt-controller@7fff9000, using 0 as fallback
   arch/arm64/boot/dts/broadcom/bcm2712.dtsi:543.4-546.31: Warning (interrupt_map): /axi/pcie@1000120000:interrupt-map: Missing property '#address-cells' in node /soc@107c000000/interrupt-controller@7fff9000, using 0 as fallback
   arch/arm64/boot/dts/broadcom/bcm2712.dtsi:543.4-546.31: Warning (interrupt_map): /axi/pcie@1000120000:interrupt-map: Missing property '#address-cells' in node /soc@107c000000/interrupt-controller@7fff9000, using 0 as fallback
   arch/arm64/boot/dts/broadcom/bcm2712.dtsi:543.4-546.31: Warning (interrupt_map): /axi/pcie@1000120000:interrupt-map: Missing property '#address-cells' in node /soc@107c000000/interrupt-controller@7fff9000, using 0 as fallback
   arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: soc@107c000000 (simple-bus): firmware: 'ranges' is a required property
   	from schema $id: http://devicetree.org/schemas/simple-bus.yaml#
   arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: soc@107c000000 (simple-bus): power: 'ranges' is a required property
   	from schema $id: http://devicetree.org/schemas/simple-bus.yaml#
>> arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: /soc@107c000000/pinctrl@7d504100: failed to match any schema with compatible: ['brcm,bcm2712c0-pinctrl']
>> arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: /soc@107c000000/pinctrl@7d510700: failed to match any schema with compatible: ['brcm,bcm2712c0-aon-pinctrl']
   arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: hdmi@7c701400 (brcm,bcm2712-hdmi0): interrupt-names:3: 'wakeup' was expected
   	from schema $id: http://devicetree.org/schemas/display/brcm,bcm2711-hdmi.yaml#
   arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: hdmi@7c701400 (brcm,bcm2712-hdmi0): interrupt-names:4: 'hpd-connected' was expected
   	from schema $id: http://devicetree.org/schemas/display/brcm,bcm2711-hdmi.yaml#
   arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: hdmi@7c701400 (brcm,bcm2712-hdmi0): interrupt-names: ['cec-tx', 'cec-rx', 'cec-low', 'hpd-connected', 'hpd-removed'] is too short
   	from schema $id: http://devicetree.org/schemas/display/brcm,bcm2711-hdmi.yaml#
   arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: hdmi@7c701400 (brcm,bcm2712-hdmi0): interrupts: [[1], [2], [3], [7], [8]] is too short
   	from schema $id: http://devicetree.org/schemas/display/brcm,bcm2711-hdmi.yaml#
   arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: hdmi@7c706400 (brcm,bcm2712-hdmi1): interrupt-names:3: 'wakeup' was expected
   	from schema $id: http://devicetree.org/schemas/display/brcm,bcm2711-hdmi.yaml#
--
   arch/arm64/boot/dts/broadcom/bcm2712.dtsi:504.4-507.31: Warning (interrupt_map): /axi/pcie@1000110000:interrupt-map: Missing property '#address-cells' in node /soc@107c000000/interrupt-controller@7fff9000, using 0 as fallback
   arch/arm64/boot/dts/broadcom/bcm2712.dtsi:504.4-507.31: Warning (interrupt_map): /axi/pcie@1000110000:interrupt-map: Missing property '#address-cells' in node /soc@107c000000/interrupt-controller@7fff9000, using 0 as fallback
   arch/arm64/boot/dts/broadcom/bcm2712.dtsi:543.4-546.31: Warning (interrupt_map): /axi/pcie@1000120000:interrupt-map: Missing property '#address-cells' in node /soc@107c000000/interrupt-controller@7fff9000, using 0 as fallback
   arch/arm64/boot/dts/broadcom/bcm2712.dtsi:543.4-546.31: Warning (interrupt_map): /axi/pcie@1000120000:interrupt-map: Missing property '#address-cells' in node /soc@107c000000/interrupt-controller@7fff9000, using 0 as fallback
   arch/arm64/boot/dts/broadcom/bcm2712.dtsi:543.4-546.31: Warning (interrupt_map): /axi/pcie@1000120000:interrupt-map: Missing property '#address-cells' in node /soc@107c000000/interrupt-controller@7fff9000, using 0 as fallback
   arch/arm64/boot/dts/broadcom/bcm2712.dtsi:543.4-546.31: Warning (interrupt_map): /axi/pcie@1000120000:interrupt-map: Missing property '#address-cells' in node /soc@107c000000/interrupt-controller@7fff9000, using 0 as fallback
   arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dtb: soc@107c000000 (simple-bus): power: 'ranges' is a required property
   	from schema $id: http://devicetree.org/schemas/simple-bus.yaml#
   arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dtb: soc@107c000000 (simple-bus): firmware: 'ranges' is a required property
   	from schema $id: http://devicetree.org/schemas/simple-bus.yaml#
>> arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dtb: /soc@107c000000/pinctrl@7d504100: failed to match any schema with compatible: ['brcm,bcm2712c0-pinctrl']
>> arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dtb: /soc@107c000000/pinctrl@7d510700: failed to match any schema with compatible: ['brcm,bcm2712c0-aon-pinctrl']
   arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dtb: hdmi@7c701400 (brcm,bcm2712-hdmi0): interrupt-names:3: 'wakeup' was expected
   	from schema $id: http://devicetree.org/schemas/display/brcm,bcm2711-hdmi.yaml#
   arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dtb: hdmi@7c701400 (brcm,bcm2712-hdmi0): interrupt-names:4: 'hpd-connected' was expected
   	from schema $id: http://devicetree.org/schemas/display/brcm,bcm2711-hdmi.yaml#
   arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dtb: hdmi@7c701400 (brcm,bcm2712-hdmi0): interrupt-names: ['cec-tx', 'cec-rx', 'cec-low', 'hpd-connected', 'hpd-removed'] is too short
   	from schema $id: http://devicetree.org/schemas/display/brcm,bcm2711-hdmi.yaml#
   arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dtb: hdmi@7c701400 (brcm,bcm2712-hdmi0): interrupts: [[1], [2], [3], [7], [8]] is too short
   	from schema $id: http://devicetree.org/schemas/display/brcm,bcm2711-hdmi.yaml#
   arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dtb: hdmi@7c706400 (brcm,bcm2712-hdmi1): interrupt-names:3: 'wakeup' was expected
   	from schema $id: http://devicetree.org/schemas/display/brcm,bcm2711-hdmi.yaml#
--
   arch/arm64/boot/dts/broadcom/bcm2712.dtsi:504.4-507.31: Warning (interrupt_map): /axi/pcie@1000110000:interrupt-map: Missing property '#address-cells' in node /soc@107c000000/interrupt-controller@7fff9000, using 0 as fallback
   arch/arm64/boot/dts/broadcom/bcm2712.dtsi:504.4-507.31: Warning (interrupt_map): /axi/pcie@1000110000:interrupt-map: Missing property '#address-cells' in node /soc@107c000000/interrupt-controller@7fff9000, using 0 as fallback
   arch/arm64/boot/dts/broadcom/bcm2712.dtsi:543.4-546.31: Warning (interrupt_map): /axi/pcie@1000120000:interrupt-map: Missing property '#address-cells' in node /soc@107c000000/interrupt-controller@7fff9000, using 0 as fallback
   arch/arm64/boot/dts/broadcom/bcm2712.dtsi:543.4-546.31: Warning (interrupt_map): /axi/pcie@1000120000:interrupt-map: Missing property '#address-cells' in node /soc@107c000000/interrupt-controller@7fff9000, using 0 as fallback
   arch/arm64/boot/dts/broadcom/bcm2712.dtsi:543.4-546.31: Warning (interrupt_map): /axi/pcie@1000120000:interrupt-map: Missing property '#address-cells' in node /soc@107c000000/interrupt-controller@7fff9000, using 0 as fallback
   arch/arm64/boot/dts/broadcom/bcm2712.dtsi:543.4-546.31: Warning (interrupt_map): /axi/pcie@1000120000:interrupt-map: Missing property '#address-cells' in node /soc@107c000000/interrupt-controller@7fff9000, using 0 as fallback
   arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dtb: soc@107c000000 (simple-bus): firmware: 'ranges' is a required property
   	from schema $id: http://devicetree.org/schemas/simple-bus.yaml#
   arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dtb: soc@107c000000 (simple-bus): power: 'ranges' is a required property
   	from schema $id: http://devicetree.org/schemas/simple-bus.yaml#
>> arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dtb: /soc@107c000000/pinctrl@7d504100: failed to match any schema with compatible: ['brcm,bcm2712c0-pinctrl']
>> arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dtb: /soc@107c000000/pinctrl@7d510700: failed to match any schema with compatible: ['brcm,bcm2712c0-aon-pinctrl']
   arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dtb: hdmi@7c701400 (brcm,bcm2712-hdmi0): interrupt-names:3: 'wakeup' was expected
   	from schema $id: http://devicetree.org/schemas/display/brcm,bcm2711-hdmi.yaml#
   arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dtb: hdmi@7c701400 (brcm,bcm2712-hdmi0): interrupt-names:4: 'hpd-connected' was expected
   	from schema $id: http://devicetree.org/schemas/display/brcm,bcm2711-hdmi.yaml#
   arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dtb: hdmi@7c701400 (brcm,bcm2712-hdmi0): interrupt-names: ['cec-tx', 'cec-rx', 'cec-low', 'hpd-connected', 'hpd-removed'] is too short
   	from schema $id: http://devicetree.org/schemas/display/brcm,bcm2711-hdmi.yaml#
   arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dtb: hdmi@7c701400 (brcm,bcm2712-hdmi0): interrupts: [[1], [2], [3], [7], [8]] is too short
   	from schema $id: http://devicetree.org/schemas/display/brcm,bcm2711-hdmi.yaml#
   arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dtb: hdmi@7c706400 (brcm,bcm2712-hdmi1): interrupt-names:3: 'wakeup' was expected
   	from schema $id: http://devicetree.org/schemas/display/brcm,bcm2711-hdmi.yaml#

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-08-13  2:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-13  2:35 [PATCH 3/6] arm64: dts: broadcom: bcm2712: Add pin controller nodes kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2025-08-11 15:19 [PATCH 0/6] Add peripheral nodes to RaspberryPi 5 DT Andrea della Porta
2025-08-11 15:19 ` [PATCH 3/6] arm64: dts: broadcom: bcm2712: Add pin controller nodes Andrea della Porta

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.