All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] board: phytec: common: k3: Making setup_mac_from_eeprom optional
@ 2025-08-13 21:31 John Ma
  2025-08-14  6:16 ` Wadim Egorov
  2025-08-21 17:16 ` Tom Rini
  0 siblings, 2 replies; 3+ messages in thread
From: John Ma @ 2025-08-13 21:31 UTC (permalink / raw)
  To: w.egorov, trini, d.schultz, michal.simek, ilias.apalodimas, jma,
	j-humphreys
  Cc: u-boot, upstream

Making the setup_mac_from_eeprom optional for boards without
CONFIG_PHYTEC_SOM_DETECTION_BLOCKS.

Signed-off-by: John Ma <jma@phytec.com>
---
 board/phytec/common/k3/board.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/board/phytec/common/k3/board.c b/board/phytec/common/k3/board.c
index 7f34d71d530..647f93a1d7a 100644
--- a/board/phytec/common/k3/board.c
+++ b/board/phytec/common/k3/board.c
@@ -176,6 +176,7 @@ static void boot_targets_setup(void)
 	env_set("boot_targets", boot_targets);
 }
 
+#if IS_ENABLED(CONFIG_PHYTEC_SOM_DETECTION_BLOCKS)
 static void setup_mac_from_eeprom(void)
 {
 	struct phytec_api3_element *block_element;
@@ -197,13 +198,15 @@ static void setup_mac_from_eeprom(void)
 		}
 	}
 }
+#endif
 
 int board_late_init(void)
 {
 	boot_targets_setup();
 
-	if (IS_ENABLED(CONFIG_PHYTEC_SOM_DETECTION_BLOCKS))
-		setup_mac_from_eeprom();
+#if IS_ENABLED(CONFIG_PHYTEC_SOM_DETECTION_BLOCKS)
+	setup_mac_from_eeprom();
+#endif
 
 #if IS_ENABLED(CONFIG_EFI_HAVE_CAPSULE_SUPPORT)
 	configure_capsule_updates();
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] board: phytec: common: k3: Making setup_mac_from_eeprom optional
  2025-08-13 21:31 [PATCH] board: phytec: common: k3: Making setup_mac_from_eeprom optional John Ma
@ 2025-08-14  6:16 ` Wadim Egorov
  2025-08-21 17:16 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Wadim Egorov @ 2025-08-14  6:16 UTC (permalink / raw)
  To: John Ma, trini, d.schultz, michal.simek, ilias.apalodimas,
	j-humphreys
  Cc: u-boot, upstream



On 8/14/25 12:31 AM, John Ma wrote:
> Making the setup_mac_from_eeprom optional for boards without
> CONFIG_PHYTEC_SOM_DETECTION_BLOCKS.
> 
> Signed-off-by: John Ma <jma@phytec.com>

Reviewed-by: Wadim Egorov <w.egorov@phytec.de>

> ---
>   board/phytec/common/k3/board.c | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/board/phytec/common/k3/board.c b/board/phytec/common/k3/board.c
> index 7f34d71d530..647f93a1d7a 100644
> --- a/board/phytec/common/k3/board.c
> +++ b/board/phytec/common/k3/board.c
> @@ -176,6 +176,7 @@ static void boot_targets_setup(void)
>   	env_set("boot_targets", boot_targets);
>   }
>   
> +#if IS_ENABLED(CONFIG_PHYTEC_SOM_DETECTION_BLOCKS)
>   static void setup_mac_from_eeprom(void)
>   {
>   	struct phytec_api3_element *block_element;
> @@ -197,13 +198,15 @@ static void setup_mac_from_eeprom(void)
>   		}
>   	}
>   }
> +#endif
>   
>   int board_late_init(void)
>   {
>   	boot_targets_setup();
>   
> -	if (IS_ENABLED(CONFIG_PHYTEC_SOM_DETECTION_BLOCKS))
> -		setup_mac_from_eeprom();
> +#if IS_ENABLED(CONFIG_PHYTEC_SOM_DETECTION_BLOCKS)
> +	setup_mac_from_eeprom();
> +#endif
>   
>   #if IS_ENABLED(CONFIG_EFI_HAVE_CAPSULE_SUPPORT)
>   	configure_capsule_updates();


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] board: phytec: common: k3: Making setup_mac_from_eeprom optional
  2025-08-13 21:31 [PATCH] board: phytec: common: k3: Making setup_mac_from_eeprom optional John Ma
  2025-08-14  6:16 ` Wadim Egorov
@ 2025-08-21 17:16 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2025-08-21 17:16 UTC (permalink / raw)
  To: w.egorov, d.schultz, michal.simek, ilias.apalodimas, j-humphreys,
	John Ma
  Cc: u-boot, upstream

On Wed, 13 Aug 2025 14:31:16 -0700, John Ma wrote:

> Making the setup_mac_from_eeprom optional for boards without
> CONFIG_PHYTEC_SOM_DETECTION_BLOCKS.
> 
> 

Applied to u-boot/next, thanks!

[1/1] board: phytec: common: k3: Making setup_mac_from_eeprom optional
      commit: 29ce50acbb40d64aabf789640a2866a9f71aefa6
-- 
Tom



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-08-21 17:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-13 21:31 [PATCH] board: phytec: common: k3: Making setup_mac_from_eeprom optional John Ma
2025-08-14  6:16 ` Wadim Egorov
2025-08-21 17:16 ` Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.