* Re: [PATCH 5/7] arm64: dts: allwinner: a523: add USB3.0 phy node
@ 2025-08-17 19:56 kernel test robot
0 siblings, 0 replies; 9+ messages in thread
From: kernel test robot @ 2025-08-17 19:56 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp
::::::
:::::: Manual check reason: "dtcheck: binding changes may go via different trees"
::::::
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20250816084700.569524-6-iuncuim@gmail.com>
References: <20250816084700.569524-6-iuncuim@gmail.com>
TO: iuncuim <iuncuim@gmail.com>
TO: Rob Herring <robh@kernel.org>
TO: Krzysztof Kozlowski <krzk@kernel.org>
TO: Conor Dooley <conor+dt@kernel.org>
TO: "Chen-Yu Tsai" <wens@csie.org>
TO: Jernej Skrabec <jernej.skrabec@gmail.com>
TO: Samuel Holland <samuel@sholland.org>
TO: Andre Przywara <andre.przywara@arm.com>
TO: Michael Turquette <mturquette@baylibre.com>
TO: Stephen Boyd <sboyd@kernel.org>
TO: Vinod Koul <vkoul@kernel.org>
TO: Kishon Vijay Abraham I <kishon@kernel.org>
TO: Philipp Zabel <p.zabel@pengutronix.de>
CC: devicetree@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: linux-arm-kernel@lists.infradead.org
CC: linux-phy@lists.infradead.org
CC: linux-clk@vger.kernel.org
CC: linux-sunxi@lists.linux.dev
Hi iuncuim,
kernel test robot noticed the following build warnings:
[auto build test WARNING on sunxi/sunxi/for-next]
[also build test WARNING on clk/clk-next krzk/for-next linus/master v6.17-rc1 next-20250815]
[cannot apply to krzk-dt/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/iuncuim/clk-sunxi-ng-a523-add-missing-usb-related-clocks/20250816-165044
base: https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git sunxi/for-next
patch link: https://lore.kernel.org/r/20250816084700.569524-6-iuncuim%40gmail.com
patch subject: [PATCH 5/7] arm64: dts: allwinner: a523: add USB3.0 phy node
:::::: branch date: 35 hours ago
:::::: commit date: 35 hours ago
config: arm64-randconfig-051-20250817 (https://download.01.org/0day-ci/archive/20250818/202508180339.vYWvL98c-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 93d24b6b7b148c47a2fa228a4ef31524fa1d9f3f)
dtschema version: 2025.6.2.dev4+g8f79ddd
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250818/202508180339.vYWvL98c-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202508180339.vYWvL98c-lkp@intel.com/
dtcheck warnings: (new ones prefixed by >>)
'allwinner,sun55i-a523-usb-phy' is not one of ['allwinner,sun20i-d1-usb-phy', 'allwinner,sun50i-a64-usb-phy']
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
arch/arm64/boot/dts/allwinner/sun55i-a527-cubie-a5e.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): reg: [[68158464, 256], [68163584, 256], [69208064, 256], [81788928, 256]] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
arch/arm64/boot/dts/allwinner/sun55i-a527-cubie-a5e.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): reg-names: ['phy_ctrl', 'pmu0', 'pmu1', 'pmu2'] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
arch/arm64/boot/dts/allwinner/sun55i-a527-cubie-a5e.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): reset-names: ['usb0_reset', 'usb1_reset', 'usb2_reset'] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
arch/arm64/boot/dts/allwinner/sun55i-a527-cubie-a5e.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): resets: [[2, 49], [2, 50], [2, 56]] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
>> arch/arm64/boot/dts/allwinner/sun55i-a527-cubie-a5e.dtb: /soc/phy@4f00000: failed to match any schema with compatible: ['allwinner,sun55i-a523-usb3-pcie-phy']
--
'allwinner,sun55i-a523-usb-phy' is not one of ['allwinner,sun20i-d1-usb-phy', 'allwinner,sun50i-a64-usb-phy']
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
arch/arm64/boot/dts/allwinner/sun55i-h728-x96qpro+.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): reg: [[68158464, 256], [68163584, 256], [69208064, 256], [81788928, 256]] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
arch/arm64/boot/dts/allwinner/sun55i-h728-x96qpro+.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): reg-names: ['phy_ctrl', 'pmu0', 'pmu1', 'pmu2'] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
arch/arm64/boot/dts/allwinner/sun55i-h728-x96qpro+.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): reset-names: ['usb0_reset', 'usb1_reset', 'usb2_reset'] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
arch/arm64/boot/dts/allwinner/sun55i-h728-x96qpro+.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): resets: [[2, 49], [2, 50], [2, 56]] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
>> arch/arm64/boot/dts/allwinner/sun55i-h728-x96qpro+.dtb: /soc/phy@4f00000: failed to match any schema with compatible: ['allwinner,sun55i-a523-usb3-pcie-phy']
--
'allwinner,sun55i-a523-usb-phy' is not one of ['allwinner,sun20i-d1-usb-phy', 'allwinner,sun50i-a64-usb-phy']
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): reg: [[68158464, 256], [68163584, 256], [69208064, 256], [81788928, 256]] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): reg-names: ['phy_ctrl', 'pmu0', 'pmu1', 'pmu2'] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): reset-names: ['usb0_reset', 'usb1_reset', 'usb2_reset'] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): resets: [[2, 49], [2, 50], [2, 56]] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
>> arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dtb: /soc/phy@4f00000: failed to match any schema with compatible: ['allwinner,sun55i-a523-usb3-pcie-phy']
--
'allwinner,sun55i-a523-usb-phy' is not one of ['allwinner,sun20i-d1-usb-phy', 'allwinner,sun50i-a64-usb-phy']
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
arch/arm64/boot/dts/allwinner/sun55i-t527-orangepi-4a.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): reg: [[68158464, 256], [68163584, 256], [69208064, 256], [81788928, 256]] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
arch/arm64/boot/dts/allwinner/sun55i-t527-orangepi-4a.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): reg-names: ['phy_ctrl', 'pmu0', 'pmu1', 'pmu2'] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
arch/arm64/boot/dts/allwinner/sun55i-t527-orangepi-4a.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): reset-names: ['usb0_reset', 'usb1_reset', 'usb2_reset'] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
arch/arm64/boot/dts/allwinner/sun55i-t527-orangepi-4a.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): resets: [[2, 49], [2, 50], [2, 56]] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
>> arch/arm64/boot/dts/allwinner/sun55i-t527-orangepi-4a.dtb: /soc/phy@4f00000: failed to match any schema with compatible: ['allwinner,sun55i-a523-usb3-pcie-phy']
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 0/7] arm64: allwinner: a523: add USB3.0 support
@ 2025-08-16 8:46 iuncuim
2025-08-16 8:46 ` iuncuim
0 siblings, 1 reply; 9+ messages in thread
From: iuncuim @ 2025-08-16 8:46 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Andre Przywara, Michael Turquette,
Stephen Boyd, Vinod Koul, Kishon Vijay Abraham I, Philipp Zabel
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-phy, linux-clk,
linux-sunxi
From: Mikhail Kalashnikov <iuncuim@gmail.com>
This series is a draft and does not include patches for dt-bindings.
The first series is necessary for testing on other devices and
initiating discussion.
This series of patches adds USB 3.0 functionality for the
A523/A527/H728/T527 processor.Most of the code is derived from the BSP,
as the datasheet does not fully describe this feature.
I have verified functionality on two of my boards, walnutpi 2b (t527)
and x96qproplus (h728). When testing usb3.0 on x96qproplus, I get
reconnections of my nvme, it looks like the port does not provide enough
current to work. I have encountered similar complaints from users of the
device on Android. In the case of walnutpi, there is no such problem.
Based on 6.17-rc1
Mikhail Kalashnikov (7):
clk: sunxi-ng: a523: add missing usb related clocks
arm64: dts: allwinner: a523: add third usb2 phy
phy: sun4i-usb: a523: add support for the USB2 PHY
phy: allwinner: a523: add USB3/PCIe PHY driver
arm64: dts: allwinner: a523: add USB3.0 phy node
arm64: dts: allwinner: a523: add DWC3 USB3.0 node
arm64: dts: allwinner: a523: activate USB3 for all boards
.../arm64/boot/dts/allwinner/sun55i-a523.dtsi | 52 +++-
.../dts/allwinner/sun55i-a527-cubie-a5e.dts | 8 +
.../dts/allwinner/sun55i-h728-x96qpro+.dts | 8 +
.../dts/allwinner/sun55i-t527-avaota-a1.dts | 8 +
drivers/clk/sunxi-ng/ccu-sun55i-a523.c | 32 +++
drivers/clk/sunxi-ng/ccu-sun55i-a523.h | 2 +-
drivers/phy/allwinner/Kconfig | 9 +
drivers/phy/allwinner/Makefile | 1 +
drivers/phy/allwinner/phy-sun4i-usb.c | 10 +
drivers/phy/allwinner/phy-sun55i-usb3-pcie.c | 267 ++++++++++++++++++
include/dt-bindings/clock/sun55i-a523-ccu.h | 4 +
11 files changed, 392 insertions(+), 9 deletions(-)
create mode 100644 drivers/phy/allwinner/phy-sun55i-usb3-pcie.c
--
2.50.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 5/7] arm64: dts: allwinner: a523: add USB3.0 phy node
2025-08-16 8:46 [PATCH 0/7] arm64: allwinner: a523: add USB3.0 support iuncuim
@ 2025-08-16 8:46 ` iuncuim
0 siblings, 0 replies; 9+ messages in thread
From: iuncuim @ 2025-08-16 8:46 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Andre Przywara, Michael Turquette,
Stephen Boyd, Vinod Koul, Kishon Vijay Abraham I, Philipp Zabel
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-phy, linux-clk,
linux-sunxi
From: Mikhail Kalashnikov <iuncuim@gmail.com>
After adding the phy driver, we can also add phy node. In addition to the
clk and reset lines, the power domain PD_PCIE is declared in this node
according to the bsp dtb. So let's mention it.
Currently, phy driver does not support role selection and only works in
USB3.0 mode.
Signed-off-by: Mikhail Kalashnikov <iuncuim@gmail.com>
---
arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
index e4ed4fa82..233365496 100644
--- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
@@ -606,6 +606,16 @@ mdio0: mdio {
};
};
+ combophy: phy@4f00000 {
+ compatible = "allwinner,sun55i-a523-usb3-pcie-phy";
+ reg = <0x04f00000 0x100000>;
+ clocks = <&ccu CLK_USB3>;
+ resets = <&ccu RST_BUS_PCIE_USB3>;
+ #phy-cells = <0>;
+ power-domains = <&pck600 PD_PCIE>;
+ status = "disabled";
+ };
+
ppu: power-controller@7001400 {
compatible = "allwinner,sun55i-a523-ppu";
reg = <0x07001400 0x400>;
--
2.50.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 5/7] arm64: dts: allwinner: a523: add USB3.0 phy node
@ 2025-08-16 8:46 ` iuncuim
0 siblings, 0 replies; 9+ messages in thread
From: iuncuim @ 2025-08-16 8:46 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Andre Przywara, Michael Turquette,
Stephen Boyd, Vinod Koul, Kishon Vijay Abraham I, Philipp Zabel
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-phy, linux-clk,
linux-sunxi
From: Mikhail Kalashnikov <iuncuim@gmail.com>
After adding the phy driver, we can also add phy node. In addition to the
clk and reset lines, the power domain PD_PCIE is declared in this node
according to the bsp dtb. So let's mention it.
Currently, phy driver does not support role selection and only works in
USB3.0 mode.
Signed-off-by: Mikhail Kalashnikov <iuncuim@gmail.com>
---
arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
index e4ed4fa82..233365496 100644
--- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
@@ -606,6 +606,16 @@ mdio0: mdio {
};
};
+ combophy: phy@4f00000 {
+ compatible = "allwinner,sun55i-a523-usb3-pcie-phy";
+ reg = <0x04f00000 0x100000>;
+ clocks = <&ccu CLK_USB3>;
+ resets = <&ccu RST_BUS_PCIE_USB3>;
+ #phy-cells = <0>;
+ power-domains = <&pck600 PD_PCIE>;
+ status = "disabled";
+ };
+
ppu: power-controller@7001400 {
compatible = "allwinner,sun55i-a523-ppu";
reg = <0x07001400 0x400>;
--
2.50.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 5/7] arm64: dts: allwinner: a523: add USB3.0 phy node
2025-08-16 8:46 ` iuncuim
@ 2025-08-16 9:32 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-16 9:32 UTC (permalink / raw)
To: iuncuim, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, Andre Przywara,
Michael Turquette, Stephen Boyd, Vinod Koul,
Kishon Vijay Abraham I, Philipp Zabel
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-phy, linux-clk,
linux-sunxi
On 16/08/2025 10:46, iuncuim wrote:
> From: Mikhail Kalashnikov <iuncuim@gmail.com>
>
> After adding the phy driver, we can also add phy node. In addition to the
> clk and reset lines, the power domain PD_PCIE is declared in this node
> according to the bsp dtb. So let's mention it.
> Currently, phy driver does not support role selection and only works in
> USB3.0 mode.
>
> Signed-off-by: Mikhail Kalashnikov <iuncuim@gmail.com>
> ---
> arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
Please organize your patches correctly. One DTS was in the middle of
patchset, other is at the end. They all must be at the end, because you
cannot have dependency of driver on DTS.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 5/7] arm64: dts: allwinner: a523: add USB3.0 phy node
@ 2025-08-16 9:32 ` Krzysztof Kozlowski
0 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-16 9:32 UTC (permalink / raw)
To: iuncuim, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, Andre Przywara,
Michael Turquette, Stephen Boyd, Vinod Koul,
Kishon Vijay Abraham I, Philipp Zabel
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-phy, linux-clk,
linux-sunxi
On 16/08/2025 10:46, iuncuim wrote:
> From: Mikhail Kalashnikov <iuncuim@gmail.com>
>
> After adding the phy driver, we can also add phy node. In addition to the
> clk and reset lines, the power domain PD_PCIE is declared in this node
> according to the bsp dtb. So let's mention it.
> Currently, phy driver does not support role selection and only works in
> USB3.0 mode.
>
> Signed-off-by: Mikhail Kalashnikov <iuncuim@gmail.com>
> ---
> arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
Please organize your patches correctly. One DTS was in the middle of
patchset, other is at the end. They all must be at the end, because you
cannot have dependency of driver on DTS.
Best regards,
Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 5/7] arm64: dts: allwinner: a523: add USB3.0 phy node
2025-08-16 8:46 ` iuncuim
@ 2025-08-16 13:49 ` Andre Przywara
-1 siblings, 0 replies; 9+ messages in thread
From: Andre Przywara @ 2025-08-16 13:49 UTC (permalink / raw)
To: iuncuim
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Michael Turquette, Stephen Boyd,
Vinod Koul, Kishon Vijay Abraham I, Philipp Zabel, devicetree,
linux-kernel, linux-arm-kernel, linux-phy, linux-clk, linux-sunxi
On Sat, 16 Aug 2025 16:46:58 +0800
iuncuim <iuncuim@gmail.com> wrote:
Hi,
> From: Mikhail Kalashnikov <iuncuim@gmail.com>
>
> After adding the phy driver, we can also add phy node. In addition to the
> clk and reset lines, the power domain PD_PCIE is declared in this node
> according to the bsp dtb. So let's mention it.
> Currently, phy driver does not support role selection and only works in
> USB3.0 mode.
That's the current limitation of the proposed Linux driver, but should
not affect the binding or DT:
>
> Signed-off-by: Mikhail Kalashnikov <iuncuim@gmail.com>
> ---
> arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> index e4ed4fa82..233365496 100644
> --- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> @@ -606,6 +606,16 @@ mdio0: mdio {
> };
> };
>
> + combophy: phy@4f00000 {
> + compatible = "allwinner,sun55i-a523-usb3-pcie-phy";
> + reg = <0x04f00000 0x100000>;
> + clocks = <&ccu CLK_USB3>;
Will we need more clocks (or resets) when supporting PCIe later? If
yes, we should add them already now, even if they are not used by the
current driver.
> + resets = <&ccu RST_BUS_PCIE_USB3>;
> + #phy-cells = <0>;
I think we should use one PHY cell here, to allow users to select the
PHY path they need. A USB3.0-only driver implementation could choose to
ignore it, or require the number to be 0 only, rejecting anything else.
But this way we keep compatibility with newer DTs.
Cheers,
Andre
> + power-domains = <&pck600 PD_PCIE>;
> + status = "disabled";
> + };
> +
> ppu: power-controller@7001400 {
> compatible = "allwinner,sun55i-a523-ppu";
> reg = <0x07001400 0x400>;
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 5/7] arm64: dts: allwinner: a523: add USB3.0 phy node
@ 2025-08-16 13:49 ` Andre Przywara
0 siblings, 0 replies; 9+ messages in thread
From: Andre Przywara @ 2025-08-16 13:49 UTC (permalink / raw)
To: iuncuim
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Michael Turquette, Stephen Boyd,
Vinod Koul, Kishon Vijay Abraham I, Philipp Zabel, devicetree,
linux-kernel, linux-arm-kernel, linux-phy, linux-clk, linux-sunxi
On Sat, 16 Aug 2025 16:46:58 +0800
iuncuim <iuncuim@gmail.com> wrote:
Hi,
> From: Mikhail Kalashnikov <iuncuim@gmail.com>
>
> After adding the phy driver, we can also add phy node. In addition to the
> clk and reset lines, the power domain PD_PCIE is declared in this node
> according to the bsp dtb. So let's mention it.
> Currently, phy driver does not support role selection and only works in
> USB3.0 mode.
That's the current limitation of the proposed Linux driver, but should
not affect the binding or DT:
>
> Signed-off-by: Mikhail Kalashnikov <iuncuim@gmail.com>
> ---
> arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> index e4ed4fa82..233365496 100644
> --- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> @@ -606,6 +606,16 @@ mdio0: mdio {
> };
> };
>
> + combophy: phy@4f00000 {
> + compatible = "allwinner,sun55i-a523-usb3-pcie-phy";
> + reg = <0x04f00000 0x100000>;
> + clocks = <&ccu CLK_USB3>;
Will we need more clocks (or resets) when supporting PCIe later? If
yes, we should add them already now, even if they are not used by the
current driver.
> + resets = <&ccu RST_BUS_PCIE_USB3>;
> + #phy-cells = <0>;
I think we should use one PHY cell here, to allow users to select the
PHY path they need. A USB3.0-only driver implementation could choose to
ignore it, or require the number to be 0 only, rejecting anything else.
But this way we keep compatibility with newer DTs.
Cheers,
Andre
> + power-domains = <&pck600 PD_PCIE>;
> + status = "disabled";
> + };
> +
> ppu: power-controller@7001400 {
> compatible = "allwinner,sun55i-a523-ppu";
> reg = <0x07001400 0x400>;
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 5/7] arm64: dts: allwinner: a523: add USB3.0 phy node
2025-08-16 13:49 ` Andre Przywara
@ 2025-08-25 15:41 ` Chen-Yu Tsai
-1 siblings, 0 replies; 9+ messages in thread
From: Chen-Yu Tsai @ 2025-08-25 15:41 UTC (permalink / raw)
To: Andre Przywara
Cc: iuncuim, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jernej Skrabec, Samuel Holland, Michael Turquette, Stephen Boyd,
Vinod Koul, Kishon Vijay Abraham I, Philipp Zabel, devicetree,
linux-kernel, linux-arm-kernel, linux-phy, linux-clk, linux-sunxi
On Sat, Aug 16, 2025 at 3:52 PM Andre Przywara <andre.przywara@arm.com> wrote:
>
> On Sat, 16 Aug 2025 16:46:58 +0800
> iuncuim <iuncuim@gmail.com> wrote:
>
> Hi,
>
> > From: Mikhail Kalashnikov <iuncuim@gmail.com>
> >
> > After adding the phy driver, we can also add phy node. In addition to the
> > clk and reset lines, the power domain PD_PCIE is declared in this node
> > according to the bsp dtb. So let's mention it.
> > Currently, phy driver does not support role selection and only works in
> > USB3.0 mode.
>
> That's the current limitation of the proposed Linux driver, but should
> not affect the binding or DT:
>
> >
> > Signed-off-by: Mikhail Kalashnikov <iuncuim@gmail.com>
> > ---
> > arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> > index e4ed4fa82..233365496 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> > @@ -606,6 +606,16 @@ mdio0: mdio {
> > };
> > };
> >
> > + combophy: phy@4f00000 {
> > + compatible = "allwinner,sun55i-a523-usb3-pcie-phy";
> > + reg = <0x04f00000 0x100000>;
> > + clocks = <&ccu CLK_USB3>;
>
> Will we need more clocks (or resets) when supporting PCIe later? If
> yes, we should add them already now, even if they are not used by the
> current driver.
>
> > + resets = <&ccu RST_BUS_PCIE_USB3>;
> > + #phy-cells = <0>;
>
> I think we should use one PHY cell here, to allow users to select the
> PHY path they need. A USB3.0-only driver implementation could choose to
> ignore it, or require the number to be 0 only, rejecting anything else.
> But this way we keep compatibility with newer DTs.
Agreed. It seems this is the common case for combined PHYs. The last
cell tells which type of PHY is to be used.
ChenYu
> Cheers,
> Andre
>
> > + power-domains = <&pck600 PD_PCIE>;
> > + status = "disabled";
> > + };
> > +
> > ppu: power-controller@7001400 {
> > compatible = "allwinner,sun55i-a523-ppu";
> > reg = <0x07001400 0x400>;
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 5/7] arm64: dts: allwinner: a523: add USB3.0 phy node
@ 2025-08-25 15:41 ` Chen-Yu Tsai
0 siblings, 0 replies; 9+ messages in thread
From: Chen-Yu Tsai @ 2025-08-25 15:41 UTC (permalink / raw)
To: Andre Przywara
Cc: iuncuim, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jernej Skrabec, Samuel Holland, Michael Turquette, Stephen Boyd,
Vinod Koul, Kishon Vijay Abraham I, Philipp Zabel, devicetree,
linux-kernel, linux-arm-kernel, linux-phy, linux-clk, linux-sunxi
On Sat, Aug 16, 2025 at 3:52 PM Andre Przywara <andre.przywara@arm.com> wrote:
>
> On Sat, 16 Aug 2025 16:46:58 +0800
> iuncuim <iuncuim@gmail.com> wrote:
>
> Hi,
>
> > From: Mikhail Kalashnikov <iuncuim@gmail.com>
> >
> > After adding the phy driver, we can also add phy node. In addition to the
> > clk and reset lines, the power domain PD_PCIE is declared in this node
> > according to the bsp dtb. So let's mention it.
> > Currently, phy driver does not support role selection and only works in
> > USB3.0 mode.
>
> That's the current limitation of the proposed Linux driver, but should
> not affect the binding or DT:
>
> >
> > Signed-off-by: Mikhail Kalashnikov <iuncuim@gmail.com>
> > ---
> > arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> > index e4ed4fa82..233365496 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> > @@ -606,6 +606,16 @@ mdio0: mdio {
> > };
> > };
> >
> > + combophy: phy@4f00000 {
> > + compatible = "allwinner,sun55i-a523-usb3-pcie-phy";
> > + reg = <0x04f00000 0x100000>;
> > + clocks = <&ccu CLK_USB3>;
>
> Will we need more clocks (or resets) when supporting PCIe later? If
> yes, we should add them already now, even if they are not used by the
> current driver.
>
> > + resets = <&ccu RST_BUS_PCIE_USB3>;
> > + #phy-cells = <0>;
>
> I think we should use one PHY cell here, to allow users to select the
> PHY path they need. A USB3.0-only driver implementation could choose to
> ignore it, or require the number to be 0 only, rejecting anything else.
> But this way we keep compatibility with newer DTs.
Agreed. It seems this is the common case for combined PHYs. The last
cell tells which type of PHY is to be used.
ChenYu
> Cheers,
> Andre
>
> > + power-domains = <&pck600 PD_PCIE>;
> > + status = "disabled";
> > + };
> > +
> > ppu: power-controller@7001400 {
> > compatible = "allwinner,sun55i-a523-ppu";
> > reg = <0x07001400 0x400>;
>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2025-08-25 19:08 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-17 19:56 [PATCH 5/7] arm64: dts: allwinner: a523: add USB3.0 phy node kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2025-08-16 8:46 [PATCH 0/7] arm64: allwinner: a523: add USB3.0 support iuncuim
2025-08-16 8:46 ` [PATCH 5/7] arm64: dts: allwinner: a523: add USB3.0 phy node iuncuim
2025-08-16 8:46 ` iuncuim
2025-08-16 9:32 ` Krzysztof Kozlowski
2025-08-16 9:32 ` Krzysztof Kozlowski
2025-08-16 13:49 ` Andre Przywara
2025-08-16 13:49 ` Andre Przywara
2025-08-25 15:41 ` Chen-Yu Tsai
2025-08-25 15:41 ` Chen-Yu Tsai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.