Re: [PATCH v4 9/9] config: enable comma warnings

[Stephen Hemminger <stephen@networkplumber.org>]

On Mon, 18 Aug 2025 17:36:21 +0100
Bruce Richardson <bruce.richardson@intel.com> wrote:

> > diff --git a/drivers/meson.build b/drivers/meson.build
> > index b62880db02..4c08a1dd9d 100644
> > --- a/drivers/meson.build
> > +++ b/drivers/meson.build
> > @@ -59,7 +59,7 @@ default_cflags = machine_args
> >  default_cflags += ['-DALLOW_EXPERIMENTAL_API']
> >  default_cflags += ['-DALLOW_INTERNAL_API']
> >  
> > -warning_disable_cflags = ['-Wno-format-truncation', '-Wno-address-of-packed-member']
> > +warning_disable_cflags = ['-Wno-format-truncation', '-Wno-address-of-packed-member', '-Wno-comma']  
> 
> Since this patchset has already fixed some drivers, are we at a point where
> we can just disable this warning on a driver-by-driver basis rather than
> globally? That makes it easier to spot where the issues are and easier
> allows incremental improvement.


Would like to get all drivers fixed in final version.
The issue is that several drivers are open coding FOREACH_SAFE macros
and there is other series to address that.