From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [PATCH v5 0/8] avoid unnecessary use of comma operator
Date: Thu, 23 Oct 2025 22:05:46 +0200 [thread overview]
Message-ID: <3190671.o2A3GueYyp@thomas> (raw)
In-Reply-To: <20251017150241.28511-1-stephen@networkplumber.org>
17/10/2025 17:02, Stephen Hemminger:
> Clang has ability to detect suspicious use of comma operator
> where a semicolon would have the same effect.
> Easy enough to fix in DPDK code.
>
> Stephen Hemminger (8):
> eal: replace unnecessary comma operator
> ipsec: replace unnecessary comma operator
> test: replace unnecessary comma operators
> app/testpmd: replace comma operator with bracket
> examples: remove unnecessary use of comma operator
> net/bnx2x: remove unnecessary comma operator
> net/bnxt: remove unnecessary use of comma operator
> config: enable comma warnings
Applied, thanks.
Please could you open bugs for drivers having such commas?
next prev parent reply other threads:[~2025-10-23 20:05 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 23:26 [RFC 0/7] avoid unnecessary use of comma op Stephen Hemminger
2025-03-12 23:26 ` [RFC 1/7] eal: replace unnecessary comma operator Stephen Hemminger
2025-03-12 23:26 ` [RFC 2/7] ipsec: " Stephen Hemminger
2025-03-12 23:27 ` [RFC 3/7] graph: " Stephen Hemminger
2025-03-12 23:27 ` [RFC 4/7] net/mlx4: replace unnecessary comma operators Stephen Hemminger
2025-03-12 23:27 ` [RFC 5/7] net/mlx5: " Stephen Hemminger
2025-03-12 23:27 ` [RFC 6/7] test: " Stephen Hemminger
2025-03-12 23:27 ` [RFC 7/7] app/testpmd: replace comma operator with bracket Stephen Hemminger
2025-08-14 21:28 ` [PATCH v2 0/6] Enable warnings about use of comma operator Stephen Hemminger
2025-08-14 21:28 ` [PATCH v2 1/6] eal: replace unnecessary " Stephen Hemminger
2025-08-15 13:48 ` Konstantin Ananyev
2025-08-18 7:59 ` Bruce Richardson
2025-08-14 21:28 ` [PATCH v2 2/6] ipsec: " Stephen Hemminger
2025-08-15 13:47 ` Konstantin Ananyev
2025-08-18 8:00 ` Bruce Richardson
2025-08-18 8:14 ` Morten Brørup
2025-08-14 21:28 ` [PATCH v2 3/6] graph: " Stephen Hemminger
2025-08-15 13:49 ` Konstantin Ananyev
2025-08-18 8:01 ` Bruce Richardson
2025-08-14 21:28 ` [PATCH v2 4/6] test: replace unnecessary comma operators Stephen Hemminger
2025-08-15 13:50 ` Konstantin Ananyev
2025-08-18 8:02 ` Bruce Richardson
2025-08-14 21:28 ` [PATCH v2 5/6] app/testpmd: replace comma operator with bracket Stephen Hemminger
2025-08-18 8:05 ` Bruce Richardson
2025-08-14 21:28 ` [PATCH v2 6/6] config: enable comma warnings Stephen Hemminger
2025-08-15 14:00 ` Konstantin Ananyev
2025-08-15 0:30 ` [PATCH v2 0/6] Enable warnings about use of comma operator fengchengwen
2025-08-15 6:40 ` Morten Brørup
2025-08-15 16:15 ` Stephen Hemminger
2025-08-15 16:26 ` [PATCH v3 0/7] avoid unnecessary " Stephen Hemminger
2025-08-15 16:26 ` [PATCH v3 1/7] eal: replace unnecessary " Stephen Hemminger
2025-08-15 16:26 ` [PATCH v3 2/7] ipsec: " Stephen Hemminger
2025-08-15 16:26 ` [PATCH v3 3/7] graph: " Stephen Hemminger
2025-08-15 16:26 ` [PATCH v3 4/7] test: replace unnecessary comma operators Stephen Hemminger
2025-08-16 7:37 ` Morten Brørup
2025-08-15 16:26 ` [PATCH v3 5/7] app/testpmd: replace comma operator with bracket Stephen Hemminger
2025-08-15 16:26 ` [PATCH v3 6/7] examples: remove unnecessary use of comma operator Stephen Hemminger
2025-08-15 16:26 ` [PATCH v3 7/7] config: enable comma warnings Stephen Hemminger
2025-08-16 7:45 ` [PATCH v3 0/7] avoid unnecessary use of comma operator Morten Brørup
2025-08-18 16:18 ` [PATCH v4 0/9] avoid unnecessary use of commaa operator Stephen Hemminger
2025-08-18 16:18 ` [PATCH v4 1/9] eal: replace unnecessary comma operator Stephen Hemminger
2025-08-18 16:18 ` [PATCH v4 2/9] ipsec: " Stephen Hemminger
2025-08-18 16:32 ` Bruce Richardson
2025-08-18 16:34 ` Bruce Richardson
2025-08-18 16:18 ` [PATCH v4 3/9] graph: " Stephen Hemminger
2025-08-18 16:18 ` [PATCH v4 4/9] test: replace unnecessary comma operators Stephen Hemminger
2025-08-18 16:18 ` [PATCH v4 5/9] app/testpmd: replace comma operator with bracket Stephen Hemminger
2025-08-18 16:18 ` [PATCH v4 6/9] examples: remove unnecessary use of comma operator Stephen Hemminger
2025-08-18 16:18 ` [PATCH v4 7/9] net/bnx2x: remove unnecessary " Stephen Hemminger
2025-08-18 16:18 ` [PATCH v4 8/9] net/bnxt: remove unnecessary use of " Stephen Hemminger
2025-08-18 16:18 ` [PATCH v4 9/9] config: enable comma warnings Stephen Hemminger
2025-08-18 16:36 ` Bruce Richardson
2025-08-18 17:15 ` Stephen Hemminger
2025-10-17 15:02 ` [PATCH v5 0/8] avoid unnecessary use of comma operator Stephen Hemminger
2025-10-17 15:02 ` [PATCH v5 1/8] eal: replace unnecessary " Stephen Hemminger
2025-10-17 15:02 ` [PATCH v5 2/8] ipsec: " Stephen Hemminger
2025-10-17 15:02 ` [PATCH v5 3/8] test: replace unnecessary comma operators Stephen Hemminger
2025-10-17 15:02 ` [PATCH v5 4/8] app/testpmd: replace comma operator with bracket Stephen Hemminger
2025-10-17 15:02 ` [PATCH v5 5/8] examples: remove unnecessary use of comma operator Stephen Hemminger
2025-10-17 15:41 ` Bruce Richardson
2025-10-20 6:40 ` fengchengwen
2025-10-17 15:02 ` [PATCH v5 6/8] net/bnx2x: remove unnecessary " Stephen Hemminger
2025-10-17 15:02 ` [PATCH v5 7/8] net/bnxt: remove unnecessary use of " Stephen Hemminger
2025-10-17 15:02 ` [PATCH v5 8/8] config: enable comma warnings Stephen Hemminger
2025-10-17 15:42 ` Bruce Richardson
2025-10-23 20:05 ` Thomas Monjalon [this message]
2025-10-23 23:49 ` [PATCH v5 0/8] avoid unnecessary use of comma operator Stephen Hemminger
2025-10-24 6:30 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3190671.o2A3GueYyp@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.