RE: [PATCH v2 4/6] test: replace unnecessary comma operators

[Konstantin Ananyev <konstantin.ananyev@huawei.com>]

> Use of comma as statement separator is discouraged and
> reported as warning by clang with -Wcomma
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  app/test/test_compressdev.c          | 4 ++--
>  app/test/test_link_bonding_rssconf.c | 2 +-
>  app/test/test_thash.c                | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c
> index c217ad6cda..dcea8e2f30 100644
> --- a/app/test/test_compressdev.c
> +++ b/app/test/test_compressdev.c
> @@ -273,7 +273,7 @@ testsuite_setup(void)
> 
>  	/* Initializes default values for compress/decompress xforms */
>  	ts_params->def_comp_xform->type = RTE_COMP_COMPRESS;
> -	ts_params->def_comp_xform->compress.algo = RTE_COMP_ALGO_DEFLATE,
> +	ts_params->def_comp_xform->compress.algo = RTE_COMP_ALGO_DEFLATE;
>  	ts_params->def_comp_xform->compress.deflate.huffman =
>  						RTE_COMP_HUFFMAN_DEFAULT;
>  	ts_params->def_comp_xform->compress.level = RTE_COMP_LEVEL_PMD_DEFAULT;
> @@ -281,7 +281,7 @@ testsuite_setup(void)
>  	ts_params->def_comp_xform->compress.window_size = DEFAULT_WINDOW_SIZE;
> 
>  	ts_params->def_decomp_xform->type = RTE_COMP_DECOMPRESS;
> -	ts_params->def_decomp_xform->decompress.algo = RTE_COMP_ALGO_DEFLATE,
> +	ts_params->def_decomp_xform->decompress.algo = RTE_COMP_ALGO_DEFLATE;
>  	ts_params->def_decomp_xform->decompress.chksum = RTE_COMP_CHECKSUM_NONE;
>  	ts_params->def_decomp_xform->decompress.window_size = DEFAULT_WINDOW_SIZE;
> 
> diff --git a/app/test/test_link_bonding_rssconf.c b/app/test/test_link_bonding_rssconf.c
> index 2cb689b1de..693b0ccd12 100644
> --- a/app/test/test_link_bonding_rssconf.c
> +++ b/app/test/test_link_bonding_rssconf.c
> @@ -384,7 +384,7 @@ test_propagate(void)
>  		}
> 
>  		memset(bond_rss_key, i, sizeof(bond_rss_key));
> -		bond_rss_conf.rss_hf = default_rss_hf,
> +		bond_rss_conf.rss_hf = default_rss_hf;
>  		bond_rss_conf.rss_key = bond_rss_key;
>  		bond_rss_conf.rss_key_len = 40;
> 
> diff --git a/app/test/test_thash.c b/app/test/test_thash.c
> index 33b0c6adac..398db71839 100644
> --- a/app/test/test_thash.c
> +++ b/app/test/test_thash.c
> @@ -910,7 +910,7 @@ test_adjust_tuple_mult_reta(void)
>  {
>  	uint32_t i, j, np, nt;
> 
> -	nt = 0, np = 0;
> +	nt = 0; np = 0;
>  	for (i = 0; i < CHAR_BIT; i++) {
>  		for (j = 6; j <= RTE_THASH_RETA_SZ_MAX - i; j++) {
>  			np += (test_adjust_tuple_mb(j, i) == 0);
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
 

> 2.47.2