* [Intel-wired-lan] [PATCH v1 iwl-next 0/2] igbvf: ethtool statistics improvements
@ 2025-08-13 7:50 ` Kohei Enju
0 siblings, 0 replies; 15+ messages in thread
From: Kohei Enju @ 2025-08-13 7:50 UTC (permalink / raw)
To: intel-wired-lan, netdev, linux-kernel
Cc: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, kohei.enju, Kohei Enju
This series contains:
1. Add missing lbtx_packets and lbtx_bytes counters that are available
in hardware but not exposed via ethtool
2. Remove rx_long_byte_count counter that shows the same value as
rx_bytes
Tested on Intel Corporation I350 Gigabit Network Connection.
Kohei Enju (2):
igbvf: add lbtx_packets and lbtx_bytes to ethtool statistics
igbvf: remove duplicated counter rx_long_byte_count from ethtool
statistics
drivers/net/ethernet/intel/igbvf/ethtool.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--
2.48.1
^ permalink raw reply [flat|nested] 15+ messages in thread* [PATCH v1 iwl-next 0/2] igbvf: ethtool statistics improvements @ 2025-08-13 7:50 ` Kohei Enju 0 siblings, 0 replies; 15+ messages in thread From: Kohei Enju @ 2025-08-13 7:50 UTC (permalink / raw) To: intel-wired-lan, netdev, linux-kernel Cc: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, kohei.enju, Kohei Enju This series contains: 1. Add missing lbtx_packets and lbtx_bytes counters that are available in hardware but not exposed via ethtool 2. Remove rx_long_byte_count counter that shows the same value as rx_bytes Tested on Intel Corporation I350 Gigabit Network Connection. Kohei Enju (2): igbvf: add lbtx_packets and lbtx_bytes to ethtool statistics igbvf: remove duplicated counter rx_long_byte_count from ethtool statistics drivers/net/ethernet/intel/igbvf/ethtool.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.48.1 ^ permalink raw reply [flat|nested] 15+ messages in thread
* [Intel-wired-lan] [PATCH v1 iwl-next 1/2] igbvf: add lbtx_packets and lbtx_bytes to ethtool statistics 2025-08-13 7:50 ` Kohei Enju @ 2025-08-13 7:50 ` Kohei Enju -1 siblings, 0 replies; 15+ messages in thread From: Kohei Enju @ 2025-08-13 7:50 UTC (permalink / raw) To: intel-wired-lan, netdev, linux-kernel Cc: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, kohei.enju, Kohei Enju Currently ethtool shows lbrx_packets and lbrx_bytes (Good RX Packets/Octets loopback Count), but doesn't show the TX-side equivalents (lbtx_packets and lbtx_bytes). Add visibility of those missing statistics by adding them to ethtool statistics. In addition, the order of lbrx_bytes and lbrx_packets is not consistent with non-loopback statistics (rx_packets, rx_bytes). Therefore, align the order by swapping positions of lbrx_bytes and lbrx_packets. Tested on Intel Corporation I350 Gigabit Network Connection. Before: # ethtool -S ens5 | grep -E "x_(bytes|packets)" rx_packets: 135 tx_packets: 106 rx_bytes: 16010 tx_bytes: 12451 lbrx_bytes: 1148 lbrx_packets: 12 After: # ethtool -S ens5 | grep -E "x_(bytes|packets)" rx_packets: 748 tx_packets: 304 rx_bytes: 81513 tx_bytes: 33698 lbrx_packets: 97 lbtx_packets: 109 lbrx_bytes: 12090 lbtx_bytes: 12401 Tested-by: Kohei Enju <enjuk@amazon.com> Signed-off-by: Kohei Enju <enjuk@amazon.com> --- drivers/net/ethernet/intel/igbvf/ethtool.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igbvf/ethtool.c b/drivers/net/ethernet/intel/igbvf/ethtool.c index 773895c663fd..c6defc495f13 100644 --- a/drivers/net/ethernet/intel/igbvf/ethtool.c +++ b/drivers/net/ethernet/intel/igbvf/ethtool.c @@ -30,8 +30,10 @@ static const struct igbvf_stats igbvf_gstrings_stats[] = { { "rx_bytes", IGBVF_STAT(stats.gorc, stats.base_gorc) }, { "tx_bytes", IGBVF_STAT(stats.gotc, stats.base_gotc) }, { "multicast", IGBVF_STAT(stats.mprc, stats.base_mprc) }, - { "lbrx_bytes", IGBVF_STAT(stats.gorlbc, stats.base_gorlbc) }, { "lbrx_packets", IGBVF_STAT(stats.gprlbc, stats.base_gprlbc) }, + { "lbtx_packets", IGBVF_STAT(stats.gptlbc, stats.base_gptlbc) }, + { "lbrx_bytes", IGBVF_STAT(stats.gorlbc, stats.base_gorlbc) }, + { "lbtx_bytes", IGBVF_STAT(stats.gotlbc, stats.base_gotlbc) }, { "tx_restart_queue", IGBVF_STAT(restart_queue, zero_base) }, { "tx_timeout_count", IGBVF_STAT(tx_timeout_count, zero_base) }, { "rx_long_byte_count", IGBVF_STAT(stats.gorc, stats.base_gorc) }, -- 2.48.1 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v1 iwl-next 1/2] igbvf: add lbtx_packets and lbtx_bytes to ethtool statistics @ 2025-08-13 7:50 ` Kohei Enju 0 siblings, 0 replies; 15+ messages in thread From: Kohei Enju @ 2025-08-13 7:50 UTC (permalink / raw) To: intel-wired-lan, netdev, linux-kernel Cc: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, kohei.enju, Kohei Enju Currently ethtool shows lbrx_packets and lbrx_bytes (Good RX Packets/Octets loopback Count), but doesn't show the TX-side equivalents (lbtx_packets and lbtx_bytes). Add visibility of those missing statistics by adding them to ethtool statistics. In addition, the order of lbrx_bytes and lbrx_packets is not consistent with non-loopback statistics (rx_packets, rx_bytes). Therefore, align the order by swapping positions of lbrx_bytes and lbrx_packets. Tested on Intel Corporation I350 Gigabit Network Connection. Before: # ethtool -S ens5 | grep -E "x_(bytes|packets)" rx_packets: 135 tx_packets: 106 rx_bytes: 16010 tx_bytes: 12451 lbrx_bytes: 1148 lbrx_packets: 12 After: # ethtool -S ens5 | grep -E "x_(bytes|packets)" rx_packets: 748 tx_packets: 304 rx_bytes: 81513 tx_bytes: 33698 lbrx_packets: 97 lbtx_packets: 109 lbrx_bytes: 12090 lbtx_bytes: 12401 Tested-by: Kohei Enju <enjuk@amazon.com> Signed-off-by: Kohei Enju <enjuk@amazon.com> --- drivers/net/ethernet/intel/igbvf/ethtool.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igbvf/ethtool.c b/drivers/net/ethernet/intel/igbvf/ethtool.c index 773895c663fd..c6defc495f13 100644 --- a/drivers/net/ethernet/intel/igbvf/ethtool.c +++ b/drivers/net/ethernet/intel/igbvf/ethtool.c @@ -30,8 +30,10 @@ static const struct igbvf_stats igbvf_gstrings_stats[] = { { "rx_bytes", IGBVF_STAT(stats.gorc, stats.base_gorc) }, { "tx_bytes", IGBVF_STAT(stats.gotc, stats.base_gotc) }, { "multicast", IGBVF_STAT(stats.mprc, stats.base_mprc) }, - { "lbrx_bytes", IGBVF_STAT(stats.gorlbc, stats.base_gorlbc) }, { "lbrx_packets", IGBVF_STAT(stats.gprlbc, stats.base_gprlbc) }, + { "lbtx_packets", IGBVF_STAT(stats.gptlbc, stats.base_gptlbc) }, + { "lbrx_bytes", IGBVF_STAT(stats.gorlbc, stats.base_gorlbc) }, + { "lbtx_bytes", IGBVF_STAT(stats.gotlbc, stats.base_gotlbc) }, { "tx_restart_queue", IGBVF_STAT(restart_queue, zero_base) }, { "tx_timeout_count", IGBVF_STAT(tx_timeout_count, zero_base) }, { "rx_long_byte_count", IGBVF_STAT(stats.gorc, stats.base_gorc) }, -- 2.48.1 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [Intel-wired-lan] [PATCH v1 iwl-next 1/2] igbvf: add lbtx_packets and lbtx_bytes to ethtool statistics 2025-08-13 7:50 ` Kohei Enju (?) @ 2025-08-13 8:18 ` Paul Menzel 2025-08-13 8:47 ` Kohei Enju 2025-08-26 15:51 ` Simon Horman -1 siblings, 2 replies; 15+ messages in thread From: Paul Menzel @ 2025-08-13 8:18 UTC (permalink / raw) To: Kohei Enju Cc: intel-wired-lan, netdev, linux-kernel, Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, kohei.enju Dear Kohei, Thank you for your patch. Am 13.08.25 um 09:50 schrieb Kohei Enju: > Currently ethtool shows lbrx_packets and lbrx_bytes (Good RX > Packets/Octets loopback Count), but doesn't show the TX-side equivalents > (lbtx_packets and lbtx_bytes). Add visibility of those missing > statistics by adding them to ethtool statistics. > > In addition, the order of lbrx_bytes and lbrx_packets is not consistent > with non-loopback statistics (rx_packets, rx_bytes). Therefore, align > the order by swapping positions of lbrx_bytes and lbrx_packets. > > Tested on Intel Corporation I350 Gigabit Network Connection. > > Before: > # ethtool -S ens5 | grep -E "x_(bytes|packets)" > rx_packets: 135 > tx_packets: 106 > rx_bytes: 16010 > tx_bytes: 12451 > lbrx_bytes: 1148 > lbrx_packets: 12 > > After: > # ethtool -S ens5 | grep -E "x_(bytes|packets)" > rx_packets: 748 > tx_packets: 304 > rx_bytes: 81513 > tx_bytes: 33698 > lbrx_packets: 97 > lbtx_packets: 109 > lbrx_bytes: 12090 > lbtx_bytes: 12401 > > Tested-by: Kohei Enju <enjuk@amazon.com> No need to resend, but I believe, you only add a Tested-by: tag, if the person differs from the author/Signed-off-by: tag. > Signed-off-by: Kohei Enju <enjuk@amazon.com> > --- > drivers/net/ethernet/intel/igbvf/ethtool.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/igbvf/ethtool.c b/drivers/net/ethernet/intel/igbvf/ethtool.c > index 773895c663fd..c6defc495f13 100644 > --- a/drivers/net/ethernet/intel/igbvf/ethtool.c > +++ b/drivers/net/ethernet/intel/igbvf/ethtool.c > @@ -30,8 +30,10 @@ static const struct igbvf_stats igbvf_gstrings_stats[] = { > { "rx_bytes", IGBVF_STAT(stats.gorc, stats.base_gorc) }, > { "tx_bytes", IGBVF_STAT(stats.gotc, stats.base_gotc) }, > { "multicast", IGBVF_STAT(stats.mprc, stats.base_mprc) }, > - { "lbrx_bytes", IGBVF_STAT(stats.gorlbc, stats.base_gorlbc) }, > { "lbrx_packets", IGBVF_STAT(stats.gprlbc, stats.base_gprlbc) }, > + { "lbtx_packets", IGBVF_STAT(stats.gptlbc, stats.base_gptlbc) }, > + { "lbrx_bytes", IGBVF_STAT(stats.gorlbc, stats.base_gorlbc) }, > + { "lbtx_bytes", IGBVF_STAT(stats.gotlbc, stats.base_gotlbc) }, > { "tx_restart_queue", IGBVF_STAT(restart_queue, zero_base) }, > { "tx_timeout_count", IGBVF_STAT(tx_timeout_count, zero_base) }, > { "rx_long_byte_count", IGBVF_STAT(stats.gorc, stats.base_gorc) }, Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de> Kind regards, Paul ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-wired-lan] [PATCH v1 iwl-next 1/2] igbvf: add lbtx_packets and lbtx_bytes to ethtool statistics 2025-08-13 8:18 ` [Intel-wired-lan] " Paul Menzel @ 2025-08-13 8:47 ` Kohei Enju 2025-08-26 15:51 ` Simon Horman 1 sibling, 0 replies; 15+ messages in thread From: Kohei Enju @ 2025-08-13 8:47 UTC (permalink / raw) To: pmenzel Cc: andrew+netdev, anthony.l.nguyen, davem, edumazet, enjuk, intel-wired-lan, kohei.enju, kuba, linux-kernel, netdev, pabeni, przemyslaw.kitszel On Wed, 13 Aug 2025 10:18:29 +0200, Paul Menzel wrote: > Dear Kohei, > > > Thank you for your patch. > > Am 13.08.25 um 09:50 schrieb Kohei Enju: > > Currently ethtool shows lbrx_packets and lbrx_bytes (Good RX > > Packets/Octets loopback Count), but doesn't show the TX-side equivalents > > (lbtx_packets and lbtx_bytes). Add visibility of those missing > > statistics by adding them to ethtool statistics. > > > > In addition, the order of lbrx_bytes and lbrx_packets is not consistent > > with non-loopback statistics (rx_packets, rx_bytes). Therefore, align > > the order by swapping positions of lbrx_bytes and lbrx_packets. > > > > Tested on Intel Corporation I350 Gigabit Network Connection. > > > > Before: > > # ethtool -S ens5 | grep -E "x_(bytes|packets)" > > rx_packets: 135 > > tx_packets: 106 > > rx_bytes: 16010 > > tx_bytes: 12451 > > lbrx_bytes: 1148 > > lbrx_packets: 12 > > > > After: > > # ethtool -S ens5 | grep -E "x_(bytes|packets)" > > rx_packets: 748 > > tx_packets: 304 > > rx_bytes: 81513 > > tx_bytes: 33698 > > lbrx_packets: 97 > > lbtx_packets: 109 > > lbrx_bytes: 12090 > > lbtx_bytes: 12401 > > > > Tested-by: Kohei Enju <enjuk@amazon.com> > > No need to resend, but I believe, you only add a Tested-by: tag, if the > person differs from the author/Signed-off-by: tag. Oh, I didn't know that. Thank you for the feedback. Since I want to resend the other patch[1] after updating as you pointed out, I'll resend this series as v2 including this patch without the Tested-by: tag. [1] https://lore.kernel.org/intel-wired-lan/20250813075206.70114-3-enjuk@amazon.com/ > > Signed-off-by: Kohei Enju <enjuk@amazon.com> > > --- > > drivers/net/ethernet/intel/igbvf/ethtool.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/ethernet/intel/igbvf/ethtool.c b/drivers/net/ethernet/intel/igbvf/ethtool.c > > index 773895c663fd..c6defc495f13 100644 > > --- a/drivers/net/ethernet/intel/igbvf/ethtool.c > > +++ b/drivers/net/ethernet/intel/igbvf/ethtool.c > > @@ -30,8 +30,10 @@ static const struct igbvf_stats igbvf_gstrings_stats[] = { > > { "rx_bytes", IGBVF_STAT(stats.gorc, stats.base_gorc) }, > > { "tx_bytes", IGBVF_STAT(stats.gotc, stats.base_gotc) }, > > { "multicast", IGBVF_STAT(stats.mprc, stats.base_mprc) }, > > - { "lbrx_bytes", IGBVF_STAT(stats.gorlbc, stats.base_gorlbc) }, > > { "lbrx_packets", IGBVF_STAT(stats.gprlbc, stats.base_gprlbc) }, > > + { "lbtx_packets", IGBVF_STAT(stats.gptlbc, stats.base_gptlbc) }, > > + { "lbrx_bytes", IGBVF_STAT(stats.gorlbc, stats.base_gorlbc) }, > > + { "lbtx_bytes", IGBVF_STAT(stats.gotlbc, stats.base_gotlbc) }, > > { "tx_restart_queue", IGBVF_STAT(restart_queue, zero_base) }, > > { "tx_timeout_count", IGBVF_STAT(tx_timeout_count, zero_base) }, > > { "rx_long_byte_count", IGBVF_STAT(stats.gorc, stats.base_gorc) }, > > Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de> > > > Kind regards, > > Paul Thank you for reviewing! ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-wired-lan] [PATCH v1 iwl-next 1/2] igbvf: add lbtx_packets and lbtx_bytes to ethtool statistics 2025-08-13 8:18 ` [Intel-wired-lan] " Paul Menzel 2025-08-13 8:47 ` Kohei Enju @ 2025-08-26 15:51 ` Simon Horman 2025-08-28 10:16 ` Romanowski, Rafal 1 sibling, 1 reply; 15+ messages in thread From: Simon Horman @ 2025-08-26 15:51 UTC (permalink / raw) To: Paul Menzel Cc: Kohei Enju, intel-wired-lan, netdev, linux-kernel, Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, kohei.enju On Wed, Aug 13, 2025 at 10:18:29AM +0200, Paul Menzel wrote: > Dear Kohei, > > > Thank you for your patch. > > Am 13.08.25 um 09:50 schrieb Kohei Enju: > > Currently ethtool shows lbrx_packets and lbrx_bytes (Good RX > > Packets/Octets loopback Count), but doesn't show the TX-side equivalents > > (lbtx_packets and lbtx_bytes). Add visibility of those missing > > statistics by adding them to ethtool statistics. > > > > In addition, the order of lbrx_bytes and lbrx_packets is not consistent > > with non-loopback statistics (rx_packets, rx_bytes). Therefore, align > > the order by swapping positions of lbrx_bytes and lbrx_packets. > > > > Tested on Intel Corporation I350 Gigabit Network Connection. > > > > Before: > > # ethtool -S ens5 | grep -E "x_(bytes|packets)" > > rx_packets: 135 > > tx_packets: 106 > > rx_bytes: 16010 > > tx_bytes: 12451 > > lbrx_bytes: 1148 > > lbrx_packets: 12 > > > > After: > > # ethtool -S ens5 | grep -E "x_(bytes|packets)" > > rx_packets: 748 > > tx_packets: 304 > > rx_bytes: 81513 > > tx_bytes: 33698 > > lbrx_packets: 97 > > lbtx_packets: 109 > > lbrx_bytes: 12090 > > lbtx_bytes: 12401 > > > > Tested-by: Kohei Enju <enjuk@amazon.com> > > No need to resend, but I believe, you only add a Tested-by: tag, if the > person differs from the author/Signed-off-by: tag. +1 > > > Signed-off-by: Kohei Enju <enjuk@amazon.com> > > --- > > drivers/net/ethernet/intel/igbvf/ethtool.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/ethernet/intel/igbvf/ethtool.c b/drivers/net/ethernet/intel/igbvf/ethtool.c > > index 773895c663fd..c6defc495f13 100644 > > --- a/drivers/net/ethernet/intel/igbvf/ethtool.c > > +++ b/drivers/net/ethernet/intel/igbvf/ethtool.c > > @@ -30,8 +30,10 @@ static const struct igbvf_stats igbvf_gstrings_stats[] = { > > { "rx_bytes", IGBVF_STAT(stats.gorc, stats.base_gorc) }, > > { "tx_bytes", IGBVF_STAT(stats.gotc, stats.base_gotc) }, > > { "multicast", IGBVF_STAT(stats.mprc, stats.base_mprc) }, > > - { "lbrx_bytes", IGBVF_STAT(stats.gorlbc, stats.base_gorlbc) }, > > { "lbrx_packets", IGBVF_STAT(stats.gprlbc, stats.base_gprlbc) }, > > + { "lbtx_packets", IGBVF_STAT(stats.gptlbc, stats.base_gptlbc) }, > > + { "lbrx_bytes", IGBVF_STAT(stats.gorlbc, stats.base_gorlbc) }, > > + { "lbtx_bytes", IGBVF_STAT(stats.gotlbc, stats.base_gotlbc) }, > > { "tx_restart_queue", IGBVF_STAT(restart_queue, zero_base) }, > > { "tx_timeout_count", IGBVF_STAT(tx_timeout_count, zero_base) }, > > { "rx_long_byte_count", IGBVF_STAT(stats.gorc, stats.base_gorc) }, > > Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de> Also +1 Reviewed-by: Simon Horman <horms@kernel.org> ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-wired-lan] [PATCH v1 iwl-next 1/2] igbvf: add lbtx_packets and lbtx_bytes to ethtool statistics 2025-08-26 15:51 ` Simon Horman @ 2025-08-28 10:16 ` Romanowski, Rafal 0 siblings, 0 replies; 15+ messages in thread From: Romanowski, Rafal @ 2025-08-28 10:16 UTC (permalink / raw) To: Simon Horman, Paul Menzel Cc: Kohei Enju, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Nguyen, Anthony L, Kitszel, Przemyslaw, Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, kohei.enju@gmail.com > -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Simon > Horman > Sent: Tuesday, August 26, 2025 5:52 PM > To: Paul Menzel <pmenzel@molgen.mpg.de> > Cc: Kohei Enju <enjuk@amazon.com>; intel-wired-lan@lists.osuosl.org; > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Nguyen, Anthony L > <anthony.l.nguyen@intel.com>; Kitszel, Przemyslaw > <przemyslaw.kitszel@intel.com>; Andrew Lunn <andrew+netdev@lunn.ch>; > David S. Miller <davem@davemloft.net>; Eric Dumazet > <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni > <pabeni@redhat.com>; kohei.enju@gmail.com > Subject: Re: [Intel-wired-lan] [PATCH v1 iwl-next 1/2] igbvf: add lbtx_packets and > lbtx_bytes to ethtool statistics > > On Wed, Aug 13, 2025 at 10:18:29AM +0200, Paul Menzel wrote: > > Dear Kohei, > > > > > > Thank you for your patch. > > > > Am 13.08.25 um 09:50 schrieb Kohei Enju: > > > Currently ethtool shows lbrx_packets and lbrx_bytes (Good RX > > > Packets/Octets loopback Count), but doesn't show the TX-side > > > equivalents (lbtx_packets and lbtx_bytes). Add visibility of those > > > missing statistics by adding them to ethtool statistics. > > > > > > In addition, the order of lbrx_bytes and lbrx_packets is not > > > consistent with non-loopback statistics (rx_packets, rx_bytes). > > > Therefore, align the order by swapping positions of lbrx_bytes and > lbrx_packets. > > > > > > Tested on Intel Corporation I350 Gigabit Network Connection. > > > > > > Before: > > > # ethtool -S ens5 | grep -E "x_(bytes|packets)" > > > rx_packets: 135 > > > tx_packets: 106 > > > rx_bytes: 16010 > > > tx_bytes: 12451 > > > lbrx_bytes: 1148 > > > lbrx_packets: 12 > > > > > > After: > > > # ethtool -S ens5 | grep -E "x_(bytes|packets)" > > > rx_packets: 748 > > > tx_packets: 304 > > > rx_bytes: 81513 > > > tx_bytes: 33698 > > > lbrx_packets: 97 > > > lbtx_packets: 109 > > > lbrx_bytes: 12090 > > > lbtx_bytes: 12401 > > > > > > Tested-by: Kohei Enju <enjuk@amazon.com> > > > > No need to resend, but I believe, you only add a Tested-by: tag, if > > the person differs from the author/Signed-off-by: tag. > > +1 > > > > > > Signed-off-by: Kohei Enju <enjuk@amazon.com> > > > --- > > > drivers/net/ethernet/intel/igbvf/ethtool.c | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/net/ethernet/intel/igbvf/ethtool.c > > > b/drivers/net/ethernet/intel/igbvf/ethtool.c > > > index 773895c663fd..c6defc495f13 100644 > > > --- a/drivers/net/ethernet/intel/igbvf/ethtool.c > > > +++ b/drivers/net/ethernet/intel/igbvf/ethtool.c > > > @@ -30,8 +30,10 @@ static const struct igbvf_stats igbvf_gstrings_stats[] = { > > > { "rx_bytes", IGBVF_STAT(stats.gorc, stats.base_gorc) }, > > > { "tx_bytes", IGBVF_STAT(stats.gotc, stats.base_gotc) }, > > > { "multicast", IGBVF_STAT(stats.mprc, stats.base_mprc) }, > > > - { "lbrx_bytes", IGBVF_STAT(stats.gorlbc, stats.base_gorlbc) }, > > > { "lbrx_packets", IGBVF_STAT(stats.gprlbc, stats.base_gprlbc) }, > > > + { "lbtx_packets", IGBVF_STAT(stats.gptlbc, stats.base_gptlbc) }, > > > + { "lbrx_bytes", IGBVF_STAT(stats.gorlbc, stats.base_gorlbc) }, > > > + { "lbtx_bytes", IGBVF_STAT(stats.gotlbc, stats.base_gotlbc) }, > > > { "tx_restart_queue", IGBVF_STAT(restart_queue, zero_base) }, > > > { "tx_timeout_count", IGBVF_STAT(tx_timeout_count, zero_base) }, > > > { "rx_long_byte_count", IGBVF_STAT(stats.gorc, stats.base_gorc) > > > }, > > > > Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de> > > Also +1 > > Reviewed-by: Simon Horman <horms@kernel.org> Tested-by: Rafal Romanowski <rafal.romanowski@intel.com> ^ permalink raw reply [flat|nested] 15+ messages in thread
* RE: [Intel-wired-lan] [PATCH v1 iwl-next 1/2] igbvf: add lbtx_packets and lbtx_bytes to ethtool statistics @ 2025-08-28 10:16 ` Romanowski, Rafal 0 siblings, 0 replies; 15+ messages in thread From: Romanowski, Rafal @ 2025-08-28 10:16 UTC (permalink / raw) To: Simon Horman, Paul Menzel Cc: Kohei Enju, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Nguyen, Anthony L, Kitszel, Przemyslaw, Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, kohei.enju@gmail.com > -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Simon > Horman > Sent: Tuesday, August 26, 2025 5:52 PM > To: Paul Menzel <pmenzel@molgen.mpg.de> > Cc: Kohei Enju <enjuk@amazon.com>; intel-wired-lan@lists.osuosl.org; > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Nguyen, Anthony L > <anthony.l.nguyen@intel.com>; Kitszel, Przemyslaw > <przemyslaw.kitszel@intel.com>; Andrew Lunn <andrew+netdev@lunn.ch>; > David S. Miller <davem@davemloft.net>; Eric Dumazet > <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni > <pabeni@redhat.com>; kohei.enju@gmail.com > Subject: Re: [Intel-wired-lan] [PATCH v1 iwl-next 1/2] igbvf: add lbtx_packets and > lbtx_bytes to ethtool statistics > > On Wed, Aug 13, 2025 at 10:18:29AM +0200, Paul Menzel wrote: > > Dear Kohei, > > > > > > Thank you for your patch. > > > > Am 13.08.25 um 09:50 schrieb Kohei Enju: > > > Currently ethtool shows lbrx_packets and lbrx_bytes (Good RX > > > Packets/Octets loopback Count), but doesn't show the TX-side > > > equivalents (lbtx_packets and lbtx_bytes). Add visibility of those > > > missing statistics by adding them to ethtool statistics. > > > > > > In addition, the order of lbrx_bytes and lbrx_packets is not > > > consistent with non-loopback statistics (rx_packets, rx_bytes). > > > Therefore, align the order by swapping positions of lbrx_bytes and > lbrx_packets. > > > > > > Tested on Intel Corporation I350 Gigabit Network Connection. > > > > > > Before: > > > # ethtool -S ens5 | grep -E "x_(bytes|packets)" > > > rx_packets: 135 > > > tx_packets: 106 > > > rx_bytes: 16010 > > > tx_bytes: 12451 > > > lbrx_bytes: 1148 > > > lbrx_packets: 12 > > > > > > After: > > > # ethtool -S ens5 | grep -E "x_(bytes|packets)" > > > rx_packets: 748 > > > tx_packets: 304 > > > rx_bytes: 81513 > > > tx_bytes: 33698 > > > lbrx_packets: 97 > > > lbtx_packets: 109 > > > lbrx_bytes: 12090 > > > lbtx_bytes: 12401 > > > > > > Tested-by: Kohei Enju <enjuk@amazon.com> > > > > No need to resend, but I believe, you only add a Tested-by: tag, if > > the person differs from the author/Signed-off-by: tag. > > +1 > > > > > > Signed-off-by: Kohei Enju <enjuk@amazon.com> > > > --- > > > drivers/net/ethernet/intel/igbvf/ethtool.c | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/net/ethernet/intel/igbvf/ethtool.c > > > b/drivers/net/ethernet/intel/igbvf/ethtool.c > > > index 773895c663fd..c6defc495f13 100644 > > > --- a/drivers/net/ethernet/intel/igbvf/ethtool.c > > > +++ b/drivers/net/ethernet/intel/igbvf/ethtool.c > > > @@ -30,8 +30,10 @@ static const struct igbvf_stats igbvf_gstrings_stats[] = { > > > { "rx_bytes", IGBVF_STAT(stats.gorc, stats.base_gorc) }, > > > { "tx_bytes", IGBVF_STAT(stats.gotc, stats.base_gotc) }, > > > { "multicast", IGBVF_STAT(stats.mprc, stats.base_mprc) }, > > > - { "lbrx_bytes", IGBVF_STAT(stats.gorlbc, stats.base_gorlbc) }, > > > { "lbrx_packets", IGBVF_STAT(stats.gprlbc, stats.base_gprlbc) }, > > > + { "lbtx_packets", IGBVF_STAT(stats.gptlbc, stats.base_gptlbc) }, > > > + { "lbrx_bytes", IGBVF_STAT(stats.gorlbc, stats.base_gorlbc) }, > > > + { "lbtx_bytes", IGBVF_STAT(stats.gotlbc, stats.base_gotlbc) }, > > > { "tx_restart_queue", IGBVF_STAT(restart_queue, zero_base) }, > > > { "tx_timeout_count", IGBVF_STAT(tx_timeout_count, zero_base) }, > > > { "rx_long_byte_count", IGBVF_STAT(stats.gorc, stats.base_gorc) > > > }, > > > > Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de> > > Also +1 > > Reviewed-by: Simon Horman <horms@kernel.org> Tested-by: Rafal Romanowski <rafal.romanowski@intel.com> ^ permalink raw reply [flat|nested] 15+ messages in thread
* [Intel-wired-lan] [PATCH v1 iwl-next 2/2] igbvf: remove duplicated counter rx_long_byte_count from ethtool statistics 2025-08-13 7:50 ` Kohei Enju @ 2025-08-13 7:50 ` Kohei Enju -1 siblings, 0 replies; 15+ messages in thread From: Kohei Enju @ 2025-08-13 7:50 UTC (permalink / raw) To: intel-wired-lan, netdev, linux-kernel Cc: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, kohei.enju, Kohei Enju rx_long_byte_count shows the value of the GORC (Good Octets Received Count) register. However, the register value is already shown as rx_bytes and they always show the same value. Remove rx_long_byte_count as the Intel ethernet driver e1000e did in commit 0a939912cf9c ("e1000e: cleanup redundant statistics counter"). Tested on Intel Corporation I350 Gigabit Network Connection. Tested-by: Kohei Enju <enjuk@amazon.com> Signed-off-by: Kohei Enju <enjuk@amazon.com> --- drivers/net/ethernet/intel/igbvf/ethtool.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igbvf/ethtool.c b/drivers/net/ethernet/intel/igbvf/ethtool.c index c6defc495f13..9c08ebfad804 100644 --- a/drivers/net/ethernet/intel/igbvf/ethtool.c +++ b/drivers/net/ethernet/intel/igbvf/ethtool.c @@ -36,7 +36,6 @@ static const struct igbvf_stats igbvf_gstrings_stats[] = { { "lbtx_bytes", IGBVF_STAT(stats.gotlbc, stats.base_gotlbc) }, { "tx_restart_queue", IGBVF_STAT(restart_queue, zero_base) }, { "tx_timeout_count", IGBVF_STAT(tx_timeout_count, zero_base) }, - { "rx_long_byte_count", IGBVF_STAT(stats.gorc, stats.base_gorc) }, { "rx_csum_offload_good", IGBVF_STAT(hw_csum_good, zero_base) }, { "rx_csum_offload_errors", IGBVF_STAT(hw_csum_err, zero_base) }, { "rx_header_split", IGBVF_STAT(rx_hdr_split, zero_base) }, -- 2.48.1 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v1 iwl-next 2/2] igbvf: remove duplicated counter rx_long_byte_count from ethtool statistics @ 2025-08-13 7:50 ` Kohei Enju 0 siblings, 0 replies; 15+ messages in thread From: Kohei Enju @ 2025-08-13 7:50 UTC (permalink / raw) To: intel-wired-lan, netdev, linux-kernel Cc: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, kohei.enju, Kohei Enju rx_long_byte_count shows the value of the GORC (Good Octets Received Count) register. However, the register value is already shown as rx_bytes and they always show the same value. Remove rx_long_byte_count as the Intel ethernet driver e1000e did in commit 0a939912cf9c ("e1000e: cleanup redundant statistics counter"). Tested on Intel Corporation I350 Gigabit Network Connection. Tested-by: Kohei Enju <enjuk@amazon.com> Signed-off-by: Kohei Enju <enjuk@amazon.com> --- drivers/net/ethernet/intel/igbvf/ethtool.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igbvf/ethtool.c b/drivers/net/ethernet/intel/igbvf/ethtool.c index c6defc495f13..9c08ebfad804 100644 --- a/drivers/net/ethernet/intel/igbvf/ethtool.c +++ b/drivers/net/ethernet/intel/igbvf/ethtool.c @@ -36,7 +36,6 @@ static const struct igbvf_stats igbvf_gstrings_stats[] = { { "lbtx_bytes", IGBVF_STAT(stats.gotlbc, stats.base_gotlbc) }, { "tx_restart_queue", IGBVF_STAT(restart_queue, zero_base) }, { "tx_timeout_count", IGBVF_STAT(tx_timeout_count, zero_base) }, - { "rx_long_byte_count", IGBVF_STAT(stats.gorc, stats.base_gorc) }, { "rx_csum_offload_good", IGBVF_STAT(hw_csum_good, zero_base) }, { "rx_csum_offload_errors", IGBVF_STAT(hw_csum_err, zero_base) }, { "rx_header_split", IGBVF_STAT(rx_hdr_split, zero_base) }, -- 2.48.1 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [Intel-wired-lan] [PATCH v1 iwl-next 2/2] igbvf: remove duplicated counter rx_long_byte_count from ethtool statistics 2025-08-13 7:50 ` Kohei Enju (?) @ 2025-08-13 8:20 ` Paul Menzel 2025-08-13 8:54 ` Kohei Enju -1 siblings, 1 reply; 15+ messages in thread From: Paul Menzel @ 2025-08-13 8:20 UTC (permalink / raw) To: Kohei Enju Cc: intel-wired-lan, netdev, linux-kernel, Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, kohei.enju Dear Kohei, Thank you for your patch. Am 13.08.25 um 09:50 schrieb Kohei Enju: > rx_long_byte_count shows the value of the GORC (Good Octets Received > Count) register. However, the register value is already shown as > rx_bytes and they always show the same value. > > Remove rx_long_byte_count as the Intel ethernet driver e1000e did in > commit 0a939912cf9c ("e1000e: cleanup redundant statistics counter"). > > Tested on Intel Corporation I350 Gigabit Network Connection. > > Tested-by: Kohei Enju <enjuk@amazon.com> > Signed-off-by: Kohei Enju <enjuk@amazon.com> > --- > drivers/net/ethernet/intel/igbvf/ethtool.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/igbvf/ethtool.c b/drivers/net/ethernet/intel/igbvf/ethtool.c > index c6defc495f13..9c08ebfad804 100644 > --- a/drivers/net/ethernet/intel/igbvf/ethtool.c > +++ b/drivers/net/ethernet/intel/igbvf/ethtool.c > @@ -36,7 +36,6 @@ static const struct igbvf_stats igbvf_gstrings_stats[] = { > { "lbtx_bytes", IGBVF_STAT(stats.gotlbc, stats.base_gotlbc) }, > { "tx_restart_queue", IGBVF_STAT(restart_queue, zero_base) }, > { "tx_timeout_count", IGBVF_STAT(tx_timeout_count, zero_base) }, > - { "rx_long_byte_count", IGBVF_STAT(stats.gorc, stats.base_gorc) }, > { "rx_csum_offload_good", IGBVF_STAT(hw_csum_good, zero_base) }, > { "rx_csum_offload_errors", IGBVF_STAT(hw_csum_err, zero_base) }, > { "rx_header_split", IGBVF_STAT(rx_hdr_split, zero_base) }, Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de> Kind regards, Paul PS: Should you resend, *redundant* instead of *duplicated* might better describe the removed counter. ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-wired-lan] [PATCH v1 iwl-next 2/2] igbvf: remove duplicated counter rx_long_byte_count from ethtool statistics 2025-08-13 8:20 ` [Intel-wired-lan] " Paul Menzel @ 2025-08-13 8:54 ` Kohei Enju 0 siblings, 0 replies; 15+ messages in thread From: Kohei Enju @ 2025-08-13 8:54 UTC (permalink / raw) To: pmenzel Cc: andrew+netdev, anthony.l.nguyen, davem, edumazet, enjuk, intel-wired-lan, kohei.enju, kuba, linux-kernel, netdev, pabeni, przemyslaw.kitszel On Wed, 13 Aug 2025 10:20:33 +0200, Paul Menzel wrote: > Dear Kohei, > > > Thank you for your patch. > > Am 13.08.25 um 09:50 schrieb Kohei Enju: > > rx_long_byte_count shows the value of the GORC (Good Octets Received > > Count) register. However, the register value is already shown as > > rx_bytes and they always show the same value. > > > > Remove rx_long_byte_count as the Intel ethernet driver e1000e did in > > commit 0a939912cf9c ("e1000e: cleanup redundant statistics counter"). > > > > Tested on Intel Corporation I350 Gigabit Network Connection. > > > > Tested-by: Kohei Enju <enjuk@amazon.com> > > Signed-off-by: Kohei Enju <enjuk@amazon.com> > > --- > > drivers/net/ethernet/intel/igbvf/ethtool.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/net/ethernet/intel/igbvf/ethtool.c b/drivers/net/ethernet/intel/igbvf/ethtool.c > > index c6defc495f13..9c08ebfad804 100644 > > --- a/drivers/net/ethernet/intel/igbvf/ethtool.c > > +++ b/drivers/net/ethernet/intel/igbvf/ethtool.c > > @@ -36,7 +36,6 @@ static const struct igbvf_stats igbvf_gstrings_stats[] = { > > { "lbtx_bytes", IGBVF_STAT(stats.gotlbc, stats.base_gotlbc) }, > > { "tx_restart_queue", IGBVF_STAT(restart_queue, zero_base) }, > > { "tx_timeout_count", IGBVF_STAT(tx_timeout_count, zero_base) }, > > - { "rx_long_byte_count", IGBVF_STAT(stats.gorc, stats.base_gorc) }, > > { "rx_csum_offload_good", IGBVF_STAT(hw_csum_good, zero_base) }, > > { "rx_csum_offload_errors", IGBVF_STAT(hw_csum_err, zero_base) }, > > { "rx_header_split", IGBVF_STAT(rx_hdr_split, zero_base) }, > > Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de> Thank you for reviewing! > > Kind regards, > > Paul > > > PS: Should you resend, *redundant* instead of *duplicated* might better > describe the removed counter. Sure, I resend this patch as v2 with the changes: - s/duplicated/redundant/ - Remove Tested-by: tag - Add Reviewed-by: tag Thanks for the feedback. ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-wired-lan] [PATCH v1 iwl-next 2/2] igbvf: remove duplicated counter rx_long_byte_count from ethtool statistics 2025-08-13 7:50 ` Kohei Enju @ 2025-08-26 15:52 ` Simon Horman -1 siblings, 0 replies; 15+ messages in thread From: Simon Horman @ 2025-08-26 15:52 UTC (permalink / raw) To: Kohei Enju Cc: intel-wired-lan, netdev, linux-kernel, Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, kohei.enju On Wed, Aug 13, 2025 at 04:50:51PM +0900, Kohei Enju wrote: > rx_long_byte_count shows the value of the GORC (Good Octets Received > Count) register. However, the register value is already shown as > rx_bytes and they always show the same value. > > Remove rx_long_byte_count as the Intel ethernet driver e1000e did in > commit 0a939912cf9c ("e1000e: cleanup redundant statistics counter"). > > Tested on Intel Corporation I350 Gigabit Network Connection. > > Tested-by: Kohei Enju <enjuk@amazon.com> > Signed-off-by: Kohei Enju <enjuk@amazon.com> Reviewed-by: Simon Horman <horms@kernel.org> ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v1 iwl-next 2/2] igbvf: remove duplicated counter rx_long_byte_count from ethtool statistics @ 2025-08-26 15:52 ` Simon Horman 0 siblings, 0 replies; 15+ messages in thread From: Simon Horman @ 2025-08-26 15:52 UTC (permalink / raw) To: Kohei Enju Cc: intel-wired-lan, netdev, linux-kernel, Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, kohei.enju On Wed, Aug 13, 2025 at 04:50:51PM +0900, Kohei Enju wrote: > rx_long_byte_count shows the value of the GORC (Good Octets Received > Count) register. However, the register value is already shown as > rx_bytes and they always show the same value. > > Remove rx_long_byte_count as the Intel ethernet driver e1000e did in > commit 0a939912cf9c ("e1000e: cleanup redundant statistics counter"). > > Tested on Intel Corporation I350 Gigabit Network Connection. > > Tested-by: Kohei Enju <enjuk@amazon.com> > Signed-off-by: Kohei Enju <enjuk@amazon.com> Reviewed-by: Simon Horman <horms@kernel.org> ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2025-08-28 10:23 UTC | newest] Thread overview: 15+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-08-13 7:50 [Intel-wired-lan] [PATCH v1 iwl-next 0/2] igbvf: ethtool statistics improvements Kohei Enju 2025-08-13 7:50 ` Kohei Enju 2025-08-13 7:50 ` [Intel-wired-lan] [PATCH v1 iwl-next 1/2] igbvf: add lbtx_packets and lbtx_bytes to ethtool statistics Kohei Enju 2025-08-13 7:50 ` Kohei Enju 2025-08-13 8:18 ` [Intel-wired-lan] " Paul Menzel 2025-08-13 8:47 ` Kohei Enju 2025-08-26 15:51 ` Simon Horman 2025-08-28 10:16 ` Romanowski, Rafal 2025-08-28 10:16 ` Romanowski, Rafal 2025-08-13 7:50 ` [Intel-wired-lan] [PATCH v1 iwl-next 2/2] igbvf: remove duplicated counter rx_long_byte_count from " Kohei Enju 2025-08-13 7:50 ` Kohei Enju 2025-08-13 8:20 ` [Intel-wired-lan] " Paul Menzel 2025-08-13 8:54 ` Kohei Enju 2025-08-26 15:52 ` Simon Horman 2025-08-26 15:52 ` Simon Horman
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.