From: Simon Horman <horms@kernel.org>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: intel-wired-lan@lists.osuosl.org,
Tony Nguyen <anthony.l.nguyen@intel.com>,
netdev@vger.kernel.org, Greg KH <gregkh@linuxfoundation.org>,
jeremiah.kyle@intel.com, leszek.pepiak@intel.com,
Lukasz Czapnik <lukasz.czapnik@intel.com>,
Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net 5/8] i40e: fix validation of VF state in get resources
Date: Tue, 26 Aug 2025 17:33:16 +0100 [thread overview]
Message-ID: <20250826163316.GD5892@horms.kernel.org> (raw)
In-Reply-To: <20250813104552.61027-6-przemyslaw.kitszel@intel.com>
On Wed, Aug 13, 2025 at 12:45:15PM +0200, Przemek Kitszel wrote:
> From: Lukasz Czapnik <lukasz.czapnik@intel.com>
>
> VF state I40E_VF_STATE_ACTIVE is not the only state in which
> VF is actually active so it should not be used to determine
> if a VF is allowed to obtain resources.
>
> Use I40E_VF_STATE_RESOURCES_LOADED that is set only in
> i40e_vc_get_vf_resources_msg() and cleared during reset.
>
> Fixes: 61125b8be85d ("i40e: Fix failed opcode appearing if handling messages from VF")
I suspect this could be
Fixes: 5c3c48ac6bf5 ("i40e: implement virtual device interface")
But I guess that either way is fine.
> Cc: stable@vger.kernel.org
> Signed-off-by: Lukasz Czapnik <lukasz.czapnik@intel.com>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: intel-wired-lan@lists.osuosl.org,
Tony Nguyen <anthony.l.nguyen@intel.com>,
netdev@vger.kernel.org, Greg KH <gregkh@linuxfoundation.org>,
jeremiah.kyle@intel.com, leszek.pepiak@intel.com,
Lukasz Czapnik <lukasz.czapnik@intel.com>,
Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Subject: Re: [PATCH iwl-net 5/8] i40e: fix validation of VF state in get resources
Date: Tue, 26 Aug 2025 17:33:16 +0100 [thread overview]
Message-ID: <20250826163316.GD5892@horms.kernel.org> (raw)
In-Reply-To: <20250813104552.61027-6-przemyslaw.kitszel@intel.com>
On Wed, Aug 13, 2025 at 12:45:15PM +0200, Przemek Kitszel wrote:
> From: Lukasz Czapnik <lukasz.czapnik@intel.com>
>
> VF state I40E_VF_STATE_ACTIVE is not the only state in which
> VF is actually active so it should not be used to determine
> if a VF is allowed to obtain resources.
>
> Use I40E_VF_STATE_RESOURCES_LOADED that is set only in
> i40e_vc_get_vf_resources_msg() and cleared during reset.
>
> Fixes: 61125b8be85d ("i40e: Fix failed opcode appearing if handling messages from VF")
I suspect this could be
Fixes: 5c3c48ac6bf5 ("i40e: implement virtual device interface")
But I guess that either way is fine.
> Cc: stable@vger.kernel.org
> Signed-off-by: Lukasz Czapnik <lukasz.czapnik@intel.com>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-08-26 16:33 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 10:45 [Intel-wired-lan] [PATCH iwl-net 0/8] i40e: virtchnl improvements Przemek Kitszel
2025-08-13 10:45 ` Przemek Kitszel
2025-08-13 10:45 ` [Intel-wired-lan] [PATCH iwl-net 1/8] i40e: add validation for ring_len param Przemek Kitszel
2025-08-13 10:45 ` Przemek Kitszel
2025-08-26 16:35 ` [Intel-wired-lan] " Simon Horman
2025-08-26 16:35 ` Simon Horman
2025-09-18 9:02 ` [Intel-wired-lan] " Romanowski, Rafal
2025-09-18 9:02 ` Romanowski, Rafal
2025-08-13 10:45 ` [Intel-wired-lan] [PATCH iwl-net 2/8] i40e: fix idx validation in i40e_validate_queue_map Przemek Kitszel
2025-08-13 10:45 ` Przemek Kitszel
2025-08-26 16:35 ` [Intel-wired-lan] " Simon Horman
2025-08-26 16:35 ` Simon Horman
[not found] ` <PH0PR11MB5013AA7A01FEA5A0D5B172A59606A@PH0PR11MB5013.namprd11.prod.outlook.com>
2025-09-02 12:56 ` [Intel-wired-lan] " Kamakshi, NelloreX
2025-08-13 10:45 ` [Intel-wired-lan] [PATCH iwl-net 3/8] i40e: fix idx validation in config queues msg Przemek Kitszel
2025-08-13 10:45 ` Przemek Kitszel
2025-08-26 16:35 ` [Intel-wired-lan] " Simon Horman
2025-08-26 16:35 ` Simon Horman
[not found] ` <PH0PR11MB5013D93E5E69AB35CA9BAD0F9606A@PH0PR11MB5013.namprd11.prod.outlook.com>
2025-09-02 12:52 ` [Intel-wired-lan] " Kamakshi, NelloreX
2025-08-13 10:45 ` [Intel-wired-lan] [PATCH iwl-net 4/8] i40e: fix input validation logic for action_meta Przemek Kitszel
2025-08-13 10:45 ` Przemek Kitszel
2025-08-26 16:35 ` [Intel-wired-lan] " Simon Horman
2025-08-26 16:35 ` Simon Horman
2025-09-18 9:02 ` [Intel-wired-lan] " Romanowski, Rafal
2025-09-18 9:02 ` Romanowski, Rafal
2025-08-13 10:45 ` [Intel-wired-lan] [PATCH iwl-net 5/8] i40e: fix validation of VF state in get resources Przemek Kitszel
2025-08-13 10:45 ` Przemek Kitszel
2025-08-26 16:33 ` Simon Horman [this message]
2025-08-26 16:33 ` Simon Horman
2025-08-26 20:02 ` [Intel-wired-lan] " Przemek Kitszel
2025-08-26 20:02 ` Przemek Kitszel
2025-09-18 9:03 ` [Intel-wired-lan] " Romanowski, Rafal
2025-09-18 9:03 ` Romanowski, Rafal
2025-08-26 16:36 ` Simon Horman
2025-08-26 16:36 ` Simon Horman
2025-08-13 10:45 ` [Intel-wired-lan] [PATCH iwl-net 6/8] i40e: add max boundary check for VF filters Przemek Kitszel
2025-08-13 10:45 ` Przemek Kitszel
2025-08-26 16:36 ` [Intel-wired-lan] " Simon Horman
2025-08-26 16:36 ` Simon Horman
2025-09-18 9:03 ` [Intel-wired-lan] " Romanowski, Rafal
2025-09-18 9:03 ` Romanowski, Rafal
2025-08-13 10:45 ` [Intel-wired-lan] [PATCH iwl-net 7/8] i40e: add mask to apply valid bits for itr_idx Przemek Kitszel
2025-08-13 10:45 ` Przemek Kitszel
2025-08-26 16:34 ` [Intel-wired-lan] " Simon Horman
2025-08-26 16:34 ` Simon Horman
2025-08-26 19:56 ` [Intel-wired-lan] " Przemek Kitszel
2025-08-26 19:56 ` Przemek Kitszel
2025-09-18 9:04 ` [Intel-wired-lan] " Romanowski, Rafal
2025-09-18 9:04 ` Romanowski, Rafal
2025-08-13 10:45 ` [Intel-wired-lan] [PATCH iwl-net 8/8] i40e: improve VF MAC filters accounting Przemek Kitszel
2025-08-13 10:45 ` Przemek Kitszel
2025-08-26 16:36 ` [Intel-wired-lan] " Simon Horman
2025-08-26 16:36 ` Simon Horman
2025-09-18 9:04 ` [Intel-wired-lan] " Romanowski, Rafal
2025-09-18 9:04 ` Romanowski, Rafal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250826163316.GD5892@horms.kernel.org \
--to=horms@kernel.org \
--cc=aleksandr.loktionov@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeremiah.kyle@intel.com \
--cc=leszek.pepiak@intel.com \
--cc=lukasz.czapnik@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.