From: Stephen Hemminger <stephen@networkplumber.org>
To: Schneide <schneide@qti.qualcomm.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
Reshma Pattan <reshma.pattan@intel.com>,
Jerin Jacob <jerinj@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Zhirun Yan <yanzhirun_163@163.com>
Subject: Re: [PATCH v1] pcapng: allow any protocol link type for the interface block
Date: Wed, 27 Aug 2025 10:21:32 -0700 [thread overview]
Message-ID: <20250827102000.2accd146@hermes.local> (raw)
In-Reply-To: <20250827153852.1066521-1-schneide@qti.qualcomm.com>
On Wed, 27 Aug 2025 09:38:52 -0600
Schneide <schneide@qti.qualcomm.com> wrote:
> diff --git a/lib/pcapng/rte_pcapng.h b/lib/pcapng/rte_pcapng.h
> index 48f2b57564..1b3f9b9464 100644
> --- a/lib/pcapng/rte_pcapng.h
> +++ b/lib/pcapng/rte_pcapng.h
> @@ -28,6 +28,9 @@
> extern "C" {
> #endif
>
> +/* default link type for ethernet traffic */
> +#define DLT_EN10MB 1
> +
>
It would be good idea to guard this definition with #ifdef so
that if user includes pcap.h first, there is not conflict.
#ifndef DLT_EN10MB
#define DLT_EN10MB 1 /* Ethernet (10Mb) */
#endif
next prev parent reply other threads:[~2025-08-27 17:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-27 15:38 [PATCH v1] pcapng: allow any protocol link type for the interface block Schneide
2025-08-27 16:06 ` Stephen Hemminger
2025-08-27 17:21 ` Stephen Hemminger [this message]
2025-08-27 22:32 ` [PATCH v2] " Schneide
2025-09-25 23:54 ` Stephen Hemminger
2025-10-15 19:24 ` Thomas Monjalon
2025-09-26 0:04 ` Stephen Hemminger
2025-09-27 9:28 ` Thomas Monjalon
2025-09-29 17:34 ` Dylan Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250827102000.2accd146@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=reshma.pattan@intel.com \
--cc=schneide@qti.qualcomm.com \
--cc=thomas@monjalon.net \
--cc=yanzhirun_163@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.