Re: [PATCH v2] pcapng: allow any protocol link type for the interface block

[Stephen Hemminger <stephen@networkplumber.org>]

On Wed, 27 Aug 2025 16:32:15 -0600
Schneide <schneide@qti.qualcomm.com> wrote:

> From: Dylan Schneider <schneide@qti.qualcomm.com>
> 
> Allow the user to specify protocol link type when creating pcapng files.
> This change is needed to specify the protocol type in the pcapng file,
> DLT_EN10MB specifies ethernet packets only. This will allow dissectors
> for other protocols to be used on files generated by pcapng.
> 
> Includes a breaking change to rte_pcapng_add_interface to add link_type
> parameter. Existing calls to the function have been updated to pass
> DLT_EN10MB for the link type argument.
> 
> Fixes: d1da6d0d04c7 ("pcapng: require per-interface information")
> Signed-off-by: Dylan Schneider <schneide@qti.qualcomm.com>
> Cc: stephen@networkplumber.org
> ---
> v2:
> * Remove function versioning
> * Define DLT_EN10MB macro only if it has not been defined
> 
>  .mailmap                               |  1 +
>  app/dumpcap/main.c                     |  5 +++--
>  app/test/test_pcapng.c                 |  8 ++++----
>  doc/guides/rel_notes/release_25_11.rst |  4 ++++
>  lib/graph/graph_pcap.c                 |  2 +-
>  lib/pcapng/rte_pcapng.c                |  4 ++--
>  lib/pcapng/rte_pcapng.h                | 10 +++++++++-
>  7 files changed, 24 insertions(+), 10 deletions(-)


Acked-by: Stephen Hemminger <stephen@networplumber.org>