From: Thomas Monjalon <thomas@monjalon.net>
To: Schneide <schneide@qti.qualcomm.com>
Cc: dev@dpdk.org, Reshma Pattan <reshma.pattan@intel.com>,
Jerin Jacob <jerinj@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Zhirun Yan <yanzhirun_163@163.com>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v2] pcapng: allow any protocol link type for the interface block
Date: Sat, 27 Sep 2025 11:28:37 +0200 [thread overview]
Message-ID: <3296173.BjyWNHgNrj@thomas> (raw)
In-Reply-To: <20250925170447.2ae8d5bf@hermes.local>
26/09/2025 02:04, Stephen Hemminger:
> On Wed, 27 Aug 2025 16:32:15 -0600
> Schneide <schneide@qti.qualcomm.com> wrote:
>
> >
> > +* pcapng: Changed the API for adding interfaces to include a link type argument.
> > + The link type was previously hardcoded to the ethernet link type in the API.
> > + This argument is added to ``rte_pcapng_add_interface``.
> > + These functions are versioned to retain binary compatibility until the next LTS release.
>
> Since link connector is now merged, and that wording might overlap and
> be confusing. Would be could to add reference to pcap-linktype.7 man
> page.
I'm not sure it overlaps.
RTE_ETH_LINK_CONNECTOR is about Ethernet cables while
pcap link type will be simply Ethernet type.
This being said, I don't understand the immediate benefit of this commit.
Why pcap link type would not be always Ethernet in DPDK case?
I think the only benefit is for future if other link types are added.
Is there something else I'm missing?
next prev parent reply other threads:[~2025-09-27 9:28 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-27 15:38 [PATCH v1] pcapng: allow any protocol link type for the interface block Schneide
2025-08-27 16:06 ` Stephen Hemminger
2025-08-27 17:21 ` Stephen Hemminger
2025-08-27 22:32 ` [PATCH v2] " Schneide
2025-09-25 23:54 ` Stephen Hemminger
2025-10-15 19:24 ` Thomas Monjalon
2025-09-26 0:04 ` Stephen Hemminger
2025-09-27 9:28 ` Thomas Monjalon [this message]
2025-09-29 17:34 ` Dylan Schneider
-- strict thread matches above, loose matches on Subject: below --
2025-05-29 17:16 [PATCH] " Schneide
2025-06-05 23:02 ` [PATCH v2] " Schneide
2025-06-06 15:13 ` Stephen Hemminger
2025-06-06 21:52 ` Schneide
2025-06-08 22:16 ` Stephen Hemminger
2025-06-08 22:19 ` Stephen Hemminger
2025-06-08 22:23 ` Stephen Hemminger
2025-06-08 22:30 ` Stephen Hemminger
2025-06-08 22:34 ` Stephen Hemminger
2025-06-09 15:51 ` Dylan Schneider
2025-06-09 16:24 ` Stephen Hemminger
2025-06-16 14:29 ` Dylan Schneider
2025-06-24 15:15 ` Dylan Schneider
2025-06-09 21:19 ` Schneide
2025-06-16 18:05 ` Stephen Hemminger
2025-06-26 13:57 ` Stephen Hemminger
2025-06-27 16:05 ` Thomas Monjalon
2025-06-27 17:39 ` Thomas Monjalon
2025-06-27 17:46 ` Dylan Schneider
2025-06-27 18:27 ` Thomas Monjalon
2025-06-30 13:50 ` Dylan Schneider
2025-06-30 14:28 ` Thomas Monjalon
2025-07-02 19:30 ` Dylan Schneider
2025-07-03 13:27 ` Thomas Monjalon
2025-07-03 16:29 ` Dylan Schneider
2025-07-03 16:41 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3296173.BjyWNHgNrj@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=reshma.pattan@intel.com \
--cc=schneide@qti.qualcomm.com \
--cc=stephen@networkplumber.org \
--cc=yanzhirun_163@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.