From: Rob Herring <robh@kernel.org>
To: Manikanta Guntupalli <manikanta.guntupalli@amd.com>
Cc: git@amd.com, michal.simek@amd.com, alexandre.belloni@bootlin.com,
Frank.Li@nxp.com, krzk+dt@kernel.org, conor+dt@kernel.org,
kees@kernel.org, gustavoars@kernel.org,
jarkko.nikula@linux.intel.com, linux-i3c@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org, radhey.shyam.pandey@amd.com,
srinivas.goud@amd.com, shubhrajyoti.datta@amd.com,
manion05gk@gmail.com
Subject: Re: [PATCH V3 1/2] dt-bindings: i3c: Add AMD I3C master controller support
Date: Wed, 3 Sep 2025 15:47:38 -0500 [thread overview]
Message-ID: <20250903204738.GA2744698-robh@kernel.org> (raw)
In-Reply-To: <20250903095906.3260804-2-manikanta.guntupalli@amd.com>
On Wed, Sep 03, 2025 at 03:29:05PM +0530, Manikanta Guntupalli wrote:
> Add device tree binding documentation for the AMD I3C master controller.
>
> Signed-off-by: Manikanta Guntupalli <manikanta.guntupalli@amd.com>
> ---
> Changes for V2:
> Updated commit subject and description.
> Moved allOf to after required.
> Removed xlnx,num-targets property.
>
> Changes for V3:
> Updated commit description.
> Corrected the order of properties and removed resets property.
> Added compatible to required list.
> Added interrupts to example.
> ---
> .../devicetree/bindings/i3c/xlnx,axi-i3c.yaml | 53 +++++++++++++++++++
> 1 file changed, 53 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/i3c/xlnx,axi-i3c.yaml
>
> diff --git a/Documentation/devicetree/bindings/i3c/xlnx,axi-i3c.yaml b/Documentation/devicetree/bindings/i3c/xlnx,axi-i3c.yaml
> new file mode 100644
> index 000000000000..32f73c31121e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i3c/xlnx,axi-i3c.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i3c/xlnx,axi-i3c.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: AMD I3C master
> +
> +maintainers:
> + - Manikanta Guntupalli <manikanta.guntupalli@amd.com>
> +
> +description:
> + The AXI-I3C IP is an I3C Controller with an AXI4-Lite interface, compatible
> + with the MIPI I3C Specification v1.1.1. The design includes bidirectional I/O
> + buffers that implement open collector drivers for the SDA and SCL signals.
> + External pull-up resistors are required to properly hold the bus at a Logic-1
> + level when the drivers are released.
> +
> +properties:
> + compatible:
> + const: xlnx,axi-i3c-1.0
Where does the version number come from? This must correspond to some
h/w documentation or it is useless.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Manikanta Guntupalli <manikanta.guntupalli@amd.com>
Cc: git@amd.com, michal.simek@amd.com, alexandre.belloni@bootlin.com,
Frank.Li@nxp.com, krzk+dt@kernel.org, conor+dt@kernel.org,
kees@kernel.org, gustavoars@kernel.org,
jarkko.nikula@linux.intel.com, linux-i3c@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org, radhey.shyam.pandey@amd.com,
srinivas.goud@amd.com, shubhrajyoti.datta@amd.com,
manion05gk@gmail.com
Subject: Re: [PATCH V3 1/2] dt-bindings: i3c: Add AMD I3C master controller support
Date: Wed, 3 Sep 2025 15:47:38 -0500 [thread overview]
Message-ID: <20250903204738.GA2744698-robh@kernel.org> (raw)
In-Reply-To: <20250903095906.3260804-2-manikanta.guntupalli@amd.com>
On Wed, Sep 03, 2025 at 03:29:05PM +0530, Manikanta Guntupalli wrote:
> Add device tree binding documentation for the AMD I3C master controller.
>
> Signed-off-by: Manikanta Guntupalli <manikanta.guntupalli@amd.com>
> ---
> Changes for V2:
> Updated commit subject and description.
> Moved allOf to after required.
> Removed xlnx,num-targets property.
>
> Changes for V3:
> Updated commit description.
> Corrected the order of properties and removed resets property.
> Added compatible to required list.
> Added interrupts to example.
> ---
> .../devicetree/bindings/i3c/xlnx,axi-i3c.yaml | 53 +++++++++++++++++++
> 1 file changed, 53 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/i3c/xlnx,axi-i3c.yaml
>
> diff --git a/Documentation/devicetree/bindings/i3c/xlnx,axi-i3c.yaml b/Documentation/devicetree/bindings/i3c/xlnx,axi-i3c.yaml
> new file mode 100644
> index 000000000000..32f73c31121e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i3c/xlnx,axi-i3c.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i3c/xlnx,axi-i3c.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: AMD I3C master
> +
> +maintainers:
> + - Manikanta Guntupalli <manikanta.guntupalli@amd.com>
> +
> +description:
> + The AXI-I3C IP is an I3C Controller with an AXI4-Lite interface, compatible
> + with the MIPI I3C Specification v1.1.1. The design includes bidirectional I/O
> + buffers that implement open collector drivers for the SDA and SCL signals.
> + External pull-up resistors are required to properly hold the bus at a Logic-1
> + level when the drivers are released.
> +
> +properties:
> + compatible:
> + const: xlnx,axi-i3c-1.0
Where does the version number come from? This must correspond to some
h/w documentation or it is useless.
Rob
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2025-09-03 20:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 9:59 [PATCH V3 0/2] Add AMD I3C master controller driver and bindings Manikanta Guntupalli
2025-09-03 9:59 ` Manikanta Guntupalli
2025-09-03 9:59 ` [PATCH V3 1/2] dt-bindings: i3c: Add AMD I3C master controller support Manikanta Guntupalli
2025-09-03 9:59 ` Manikanta Guntupalli
2025-09-03 20:47 ` Rob Herring [this message]
2025-09-03 20:47 ` Rob Herring
2025-09-04 6:08 ` Michal Simek
2025-09-04 6:08 ` Michal Simek
2025-09-03 9:59 ` [PATCH V3 2/2] i3c: master: Add AMD I3C bus controller driver Manikanta Guntupalli
2025-09-03 9:59 ` Manikanta Guntupalli
2025-09-04 12:26 ` kernel test robot
2025-09-04 12:26 ` kernel test robot
2025-09-04 12:37 ` kernel test robot
2025-09-04 12:37 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250903204738.GA2744698-robh@kernel.org \
--to=robh@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@amd.com \
--cc=gustavoars@kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=kees@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manikanta.guntupalli@amd.com \
--cc=manion05gk@gmail.com \
--cc=michal.simek@amd.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=shubhrajyoti.datta@amd.com \
--cc=srinivas.goud@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.