Re: [PATCH V3 2/2] i3c: master: Add AMD I3C bus controller driver

[kernel test robot <lkp@intel.com>]

Hi Manikanta,

kernel test robot noticed the following build errors:

[auto build test ERROR on robh/for-next]
[also build test ERROR on linus/master v6.17-rc4 next-20250904]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Manikanta-Guntupalli/dt-bindings-i3c-Add-AMD-I3C-master-controller-support/20250903-220233
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20250903095906.3260804-3-manikanta.guntupalli%40amd.com
patch subject: [PATCH V3 2/2] i3c: master: Add AMD I3C bus controller driver
config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20250904/202509042018.CCuFpnkb-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250904/202509042018.CCuFpnkb-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509042018.CCuFpnkb-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

>> drivers/i3c/master/amd-i3c-master.c:182:9: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     182 |         return FIELD_GET(XI3C_RESP_CODE_MASK, response_data);
         |                ^
   drivers/i3c/master/amd-i3c-master.c:338:29: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     338 |         while (cmd->rx_len > 0 && !xi3c_is_resp_available(master)) {
         |                                    ^
   drivers/i3c/master/amd-i3c-master.c:102:8: note: expanded from macro 'xi3c_is_resp_available'
     102 |         ((u8)(FIELD_GET(XI3C_SR_RESP_NOT_EMPTY_MASK,                            \
         |               ^
   drivers/i3c/master/amd-i3c-master.c:382:29: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     382 |         while (cmd->tx_len > 0 && !xi3c_is_resp_available(master)) {
         |                                    ^
   drivers/i3c/master/amd-i3c-master.c:102:8: note: expanded from macro 'xi3c_is_resp_available'
     102 |         ((u8)(FIELD_GET(XI3C_SR_RESP_NOT_EMPTY_MASK,                            \
         |               ^
   drivers/i3c/master/amd-i3c-master.c:592:20: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     592 |                 pid_bcr_dcr[i] = FIELD_GET(XI3C_PID_MASK,
         |                                  ^
>> drivers/i3c/master/amd-i3c-master.c:592:30: warning: shift count >= width of type [-Wshift-count-overflow]
     592 |                 pid_bcr_dcr[i] = FIELD_GET(XI3C_PID_MASK,
         |                                            ^~~~~~~~~~~~~
   drivers/i3c/master/amd-i3c-master.c:53:26: note: expanded from macro 'XI3C_PID_MASK'
      53 | #define XI3C_PID_MASK                           GENMASK(63, 16)
         |                                                 ^~~~~~~~~~~~~~~
   include/linux/bits.h:51:24: note: expanded from macro 'GENMASK'
      51 | #define GENMASK(h, l)           GENMASK_TYPE(unsigned long, h, l)
         |                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/bits.h:49:20: note: expanded from macro 'GENMASK_TYPE'
      49 |               type_max(t) >> (BITS_PER_TYPE(t) - 1 - (h)))))
         |                           ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/i3c/master/amd-i3c-master.c:835:6: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     835 |         if (xi3c_getrevisionnumber(master) == 0)
         |             ^
   drivers/i3c/master/amd-i3c-master.c:90:8: note: expanded from macro 'xi3c_getrevisionnumber'
      90 |         ((u8)(FIELD_GET(XI3C_REV_NUM_MASK,                                      \
         |               ^
   drivers/i3c/master/amd-i3c-master.c:925:15: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     925 |         info.pid = ((FIELD_GET(XI3C_PID1_MASK, pid1_bcr_dcr) << 32) |
         |                      ^
   drivers/i3c/master/amd-i3c-master.c:925:55: warning: shift count >= width of type [-Wshift-count-overflow]
     925 |         info.pid = ((FIELD_GET(XI3C_PID1_MASK, pid1_bcr_dcr) << 32) |
         |                                                              ^  ~~
   2 warnings and 6 errors generated.


vim +/FIELD_GET +182 drivers/i3c/master/amd-i3c-master.c

   164	
   165	static int xi3c_get_response(struct xi3c_master *master)
   166	{
   167		u32 resp_reg, response_data;
   168		int ret;
   169	
   170		ret = readl_poll_timeout(master->membase + XI3C_SR_OFFSET,
   171					 resp_reg,
   172					 resp_reg & XI3C_SR_RESP_NOT_EMPTY_MASK,
   173					 0, XI3C_XFER_TIMEOUT_MS);
   174		if (ret) {
   175			dev_err(master->dev, "AXI I3C response timeout\n");
   176			return ret;
   177		}
   178	
   179		response_data = readl(master->membase + XI3C_RESP_STATUS_FIFO_OFFSET);
   180	
   181		/* Return response code */
 > 182		return FIELD_GET(XI3C_RESP_CODE_MASK, response_data);
   183	}
   184	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki