From: Simon Horman <horms@kernel.org>
To: mheib@redhat.com
Cc: intel-wired-lan@lists.osuosl.org,
przemyslawx.patynowski@intel.com, jiri@resnulli.us,
netdev@vger.kernel.org, jacob.e.keller@intel.com,
aleksandr.loktionov@intel.com, anthony.l.nguyen@intel.com,
przemyslaw.kitszel@intel.com
Subject: Re: [Intel-wired-lan] [PATCH net-next, v3, 1/2] devlink: Add new "max_mac_per_vf" generic device param
Date: Fri, 5 Sep 2025 13:22:38 +0100 [thread overview]
Message-ID: <20250905122238.GA553991@horms.kernel.org> (raw)
In-Reply-To: <20250903214305.57724-1-mheib@redhat.com>
On Thu, Sep 04, 2025 at 12:43:04AM +0300, mheib@redhat.com wrote:
> From: Mohammad Heib <mheib@redhat.com>
>
> Add a new device generic parameter to controls the maximum
> number of MAC filters allowed per VF.
>
> For example, to limit a VF to 3 MAC addresses:
> $ devlink dev param set pci/0000:3b:00.0 name max_mac_per_vf \
> value 3 \
> cmode runtime
>
> Signed-off-by: Mohammad Heib <mheib@redhat.com>
Overall this looks good to me, thanks.
Reviewed-by: Simon Horman <horms@kernel.org>
One point: This patch-set applies cleanly to iwl but not net-next.
If it is to be picked up by Tony and go via the iwl tree, then all good
on my side. But if it is targeted at net-next then you'll need to
rebase and repost.
...
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: mheib@redhat.com
Cc: intel-wired-lan@lists.osuosl.org,
przemyslawx.patynowski@intel.com, jiri@resnulli.us,
netdev@vger.kernel.org, jacob.e.keller@intel.com,
aleksandr.loktionov@intel.com, anthony.l.nguyen@intel.com,
przemyslaw.kitszel@intel.com
Subject: Re: [PATCH net-next,v3,1/2] devlink: Add new "max_mac_per_vf" generic device param
Date: Fri, 5 Sep 2025 13:22:38 +0100 [thread overview]
Message-ID: <20250905122238.GA553991@horms.kernel.org> (raw)
In-Reply-To: <20250903214305.57724-1-mheib@redhat.com>
On Thu, Sep 04, 2025 at 12:43:04AM +0300, mheib@redhat.com wrote:
> From: Mohammad Heib <mheib@redhat.com>
>
> Add a new device generic parameter to controls the maximum
> number of MAC filters allowed per VF.
>
> For example, to limit a VF to 3 MAC addresses:
> $ devlink dev param set pci/0000:3b:00.0 name max_mac_per_vf \
> value 3 \
> cmode runtime
>
> Signed-off-by: Mohammad Heib <mheib@redhat.com>
Overall this looks good to me, thanks.
Reviewed-by: Simon Horman <horms@kernel.org>
One point: This patch-set applies cleanly to iwl but not net-next.
If it is to be picked up by Tony and go via the iwl tree, then all good
on my side. But if it is targeted at net-next then you'll need to
rebase and repost.
...
next prev parent reply other threads:[~2025-09-05 12:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 21:43 [Intel-wired-lan] [PATCH net-next, v3, 1/2] devlink: Add new "max_mac_per_vf" generic device param mheib
2025-09-03 21:43 ` [PATCH net-next,v3,1/2] " mheib
2025-09-03 21:43 ` [Intel-wired-lan] [PATCH net-next, v3, 2/2] i40e: support generic devlink param "max_mac_per_vf" mheib
2025-09-03 21:43 ` [PATCH net-next,v3,2/2] " mheib
2025-09-03 22:25 ` [Intel-wired-lan] [PATCH net-next, v3, 2/2] " Jacob Keller
2025-09-03 22:25 ` [PATCH net-next,v3,2/2] " Jacob Keller
2025-09-05 11:46 ` [Intel-wired-lan] [PATCH net-next, v3, 2/2] " Simon Horman
2025-09-05 11:46 ` [PATCH net-next,v3,2/2] " Simon Horman
2025-09-05 23:29 ` [Intel-wired-lan] [PATCH net-next, v3, 2/2] " Jacob Keller
2025-09-05 23:29 ` [PATCH net-next,v3,2/2] " Jacob Keller
2025-09-07 10:10 ` [Intel-wired-lan] [PATCH net-next, v3, 2/2] " mohammad heib
2025-09-07 10:10 ` [PATCH net-next,v3,2/2] " mohammad heib
2025-09-04 6:04 ` [Intel-wired-lan] [PATCH net-next, v3, 2/2] " Loktionov, Aleksandr
2025-09-04 6:04 ` [PATCH net-next,v3,2/2] " Loktionov, Aleksandr
2025-09-05 12:25 ` [Intel-wired-lan] [PATCH net-next, v3, 2/2] " Simon Horman
2025-09-05 12:25 ` [PATCH net-next,v3,2/2] " Simon Horman
2025-09-07 10:07 ` [Intel-wired-lan] [PATCH net-next, v3, 2/2] " mohammad heib
2025-09-07 10:07 ` [PATCH net-next,v3,2/2] " mohammad heib
2025-09-05 12:22 ` Simon Horman [this message]
2025-09-05 12:22 ` [PATCH net-next,v3,1/2] devlink: Add new "max_mac_per_vf" generic device param Simon Horman
2025-09-07 9:07 ` [Intel-wired-lan] [PATCH net-next, v3, 1/2] " mohammad heib
2025-09-07 9:07 ` [PATCH net-next,v3,1/2] " mohammad heib
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250905122238.GA553991@horms.kernel.org \
--to=horms@kernel.org \
--cc=aleksandr.loktionov@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=mheib@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
--cc=przemyslawx.patynowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.