From: Simon Horman <horms@kernel.org>
To: Tariq Toukan <tariqt@nvidia.com>
Cc: Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>, Mark Bloch <mbloch@nvidia.com>,
Julia Lawall <Julia.Lawall@inria.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
Richard Cochran <richardcochran@gmail.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org, cocci@inria.fr,
Gal Pressman <gal@nvidia.com>
Subject: Re: [cocci] [PATCH net-next 2/2] net/mlx5: Use %pe format specifier for error pointers
Date: Fri, 19 Sep 2025 17:55:14 +0100 [thread overview]
Message-ID: <20250919165514.GC589507@horms.kernel.org> (raw)
In-Reply-To: <1758192227-701925-3-git-send-email-tariqt@nvidia.com>
On Thu, Sep 18, 2025 at 01:43:47PM +0300, Tariq Toukan wrote:
> From: Gal Pressman <gal@nvidia.com>
>
> Using the coccinelle test introduced in previous commit
> (scripts/coccinelle/misc/ptr_err_to_pe.cocci), convert error logging
> throughout the mlx5 driver to use the %pe format specifier instead of
> PTR_ERR() with integer format specifiers.
>
> Signed-off-by: Gal Pressman <gal@nvidia.com>
> Reviewed-by: Alexei Lazar <alazar@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Simple, mechanical change that improves readability.
Looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Tariq Toukan <tariqt@nvidia.com>
Cc: Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>, Mark Bloch <mbloch@nvidia.com>,
Julia Lawall <Julia.Lawall@inria.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
Richard Cochran <richardcochran@gmail.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org, cocci@inria.fr,
Gal Pressman <gal@nvidia.com>
Subject: Re: [PATCH net-next 2/2] net/mlx5: Use %pe format specifier for error pointers
Date: Fri, 19 Sep 2025 17:55:14 +0100 [thread overview]
Message-ID: <20250919165514.GC589507@horms.kernel.org> (raw)
In-Reply-To: <1758192227-701925-3-git-send-email-tariqt@nvidia.com>
On Thu, Sep 18, 2025 at 01:43:47PM +0300, Tariq Toukan wrote:
> From: Gal Pressman <gal@nvidia.com>
>
> Using the coccinelle test introduced in previous commit
> (scripts/coccinelle/misc/ptr_err_to_pe.cocci), convert error logging
> throughout the mlx5 driver to use the %pe format specifier instead of
> PTR_ERR() with integer format specifiers.
>
> Signed-off-by: Gal Pressman <gal@nvidia.com>
> Reviewed-by: Alexei Lazar <alazar@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Simple, mechanical change that improves readability.
Looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-09-25 13:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 10:43 [cocci] [PATCH net-next 0/2] scripts/coccinelle: Symbolic error names script Tariq Toukan
2025-09-18 10:43 ` Tariq Toukan
2025-09-18 10:43 ` [cocci] [PATCH net-next 1/2] scripts/coccinelle: Find PTR_ERR() to %pe candidates Tariq Toukan
2025-09-18 10:43 ` Tariq Toukan
2025-09-19 16:54 ` [cocci] " Simon Horman
2025-09-19 16:54 ` Simon Horman
2025-09-22 23:36 ` [cocci] " Jakub Kicinski
2025-09-22 23:36 ` Jakub Kicinski
2025-09-25 15:07 ` [cocci] " Markus Elfring
2025-09-28 11:40 ` Gal Pressman
2025-09-28 12:00 ` Markus Elfring
2025-09-28 13:24 ` Gal Pressman
2025-09-28 14:16 ` Markus Elfring
2025-09-28 16:40 ` Gal Pressman
2025-09-28 17:51 ` [cocci] [1/2] " Markus Elfring
2025-09-28 12:23 ` [cocci] [PATCH net-next 1/2] " Julia Lawall
2025-09-28 13:17 ` Gal Pressman
2025-09-18 10:43 ` [cocci] [PATCH net-next 2/2] net/mlx5: Use %pe format specifier for error pointers Tariq Toukan
2025-09-18 10:43 ` Tariq Toukan
2025-09-19 16:55 ` Simon Horman [this message]
2025-09-19 16:55 ` Simon Horman
2025-09-26 19:50 ` [cocci] [PATCH net-next 0/2] scripts/coccinelle: Symbolic error names script patchwork-bot+netdevbpf
2025-09-26 19:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250919165514.GC589507@horms.kernel.org \
--to=horms@kernel.org \
--cc=Julia.Lawall@inria.fr \
--cc=andrew+netdev@lunn.ch \
--cc=cocci@inria.fr \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.palix@imag.fr \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.