From: Jakub Kicinski <kuba@kernel.org>
To: "Julia Lawall" <Julia.Lawall@inria.fr>,
Nicolas Palix <nicolas.palix@imag.fr>
Cc: Tariq Toukan <tariqt@nvidia.com>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>, Mark Bloch <mbloch@nvidia.com>,
Richard Cochran <richardcochran@gmail.com>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-rdma@vger.kernel.org>, <cocci@inria.fr>,
"Gal Pressman" <gal@nvidia.com>
Subject: Re: [cocci] [PATCH net-next 1/2] scripts/coccinelle: Find PTR_ERR() to %pe candidates
Date: Mon, 22 Sep 2025 16:36:40 -0700 [thread overview]
Message-ID: <20250922163640.2fc887e4@kernel.org> (raw)
In-Reply-To: <1758192227-701925-2-git-send-email-tariqt@nvidia.com>
On Thu, 18 Sep 2025 13:43:46 +0300 Tariq Toukan wrote:
> Add a new Coccinelle script to identify places where PTR_ERR() is used
> in print functions and suggest using the %pe format specifier instead.
>
> For printing error pointers (i.e., a pointer for which IS_ERR() is true)
> %pe will print a symbolic error name (e.g,. -EINVAL), opposed to the raw
> errno (e.g,. -22) produced by PTR_ERR().
> It also makes the code cleaner by saving a redundant call to PTR_ERR().
>
> The script supports context, report, and org modes.
>
> Example transformation:
> printk("Error: %ld\n", PTR_ERR(ptr)); // Before
> printk("Error: %pe\n", ptr); // After
Hi Julia, Nicolas,
would you be willing to give us a review tag for this script?
Would you prefer to take the script via your tree?
https://lore.kernel.org/all/1758192227-701925-2-git-send-email-tariqt@nvidia.com/
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: "Julia Lawall" <Julia.Lawall@inria.fr>,
Nicolas Palix <nicolas.palix@imag.fr>
Cc: Tariq Toukan <tariqt@nvidia.com>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>, Mark Bloch <mbloch@nvidia.com>,
Richard Cochran <richardcochran@gmail.com>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-rdma@vger.kernel.org>, <cocci@inria.fr>,
"Gal Pressman" <gal@nvidia.com>
Subject: Re: [PATCH net-next 1/2] scripts/coccinelle: Find PTR_ERR() to %pe candidates
Date: Mon, 22 Sep 2025 16:36:40 -0700 [thread overview]
Message-ID: <20250922163640.2fc887e4@kernel.org> (raw)
In-Reply-To: <1758192227-701925-2-git-send-email-tariqt@nvidia.com>
On Thu, 18 Sep 2025 13:43:46 +0300 Tariq Toukan wrote:
> Add a new Coccinelle script to identify places where PTR_ERR() is used
> in print functions and suggest using the %pe format specifier instead.
>
> For printing error pointers (i.e., a pointer for which IS_ERR() is true)
> %pe will print a symbolic error name (e.g,. -EINVAL), opposed to the raw
> errno (e.g,. -22) produced by PTR_ERR().
> It also makes the code cleaner by saving a redundant call to PTR_ERR().
>
> The script supports context, report, and org modes.
>
> Example transformation:
> printk("Error: %ld\n", PTR_ERR(ptr)); // Before
> printk("Error: %pe\n", ptr); // After
Hi Julia, Nicolas,
would you be willing to give us a review tag for this script?
Would you prefer to take the script via your tree?
https://lore.kernel.org/all/1758192227-701925-2-git-send-email-tariqt@nvidia.com/
next prev parent reply other threads:[~2025-09-25 13:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 10:43 [cocci] [PATCH net-next 0/2] scripts/coccinelle: Symbolic error names script Tariq Toukan
2025-09-18 10:43 ` Tariq Toukan
2025-09-18 10:43 ` [cocci] [PATCH net-next 1/2] scripts/coccinelle: Find PTR_ERR() to %pe candidates Tariq Toukan
2025-09-18 10:43 ` Tariq Toukan
2025-09-19 16:54 ` [cocci] " Simon Horman
2025-09-19 16:54 ` Simon Horman
2025-09-22 23:36 ` Jakub Kicinski [this message]
2025-09-22 23:36 ` Jakub Kicinski
2025-09-25 15:07 ` [cocci] " Markus Elfring
2025-09-28 11:40 ` Gal Pressman
2025-09-28 12:00 ` Markus Elfring
2025-09-28 13:24 ` Gal Pressman
2025-09-28 14:16 ` Markus Elfring
2025-09-28 16:40 ` Gal Pressman
2025-09-28 17:51 ` [cocci] [1/2] " Markus Elfring
2025-09-28 12:23 ` [cocci] [PATCH net-next 1/2] " Julia Lawall
2025-09-28 13:17 ` Gal Pressman
2025-09-18 10:43 ` [cocci] [PATCH net-next 2/2] net/mlx5: Use %pe format specifier for error pointers Tariq Toukan
2025-09-18 10:43 ` Tariq Toukan
2025-09-19 16:55 ` [cocci] " Simon Horman
2025-09-19 16:55 ` Simon Horman
2025-09-26 19:50 ` [cocci] [PATCH net-next 0/2] scripts/coccinelle: Symbolic error names script patchwork-bot+netdevbpf
2025-09-26 19:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250922163640.2fc887e4@kernel.org \
--to=kuba@kernel.org \
--cc=Julia.Lawall@inria.fr \
--cc=andrew+netdev@lunn.ch \
--cc=cocci@inria.fr \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.palix@imag.fr \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.