Re: [PATCH 11/11] ecryptfs: use new start_creaing/start_removing APIs

[kernel test robot <lkp@intel.com>]

Hi NeilBrown,

kernel test robot noticed the following build errors:

[auto build test ERROR on brauner-vfs/vfs.all]
[also build test ERROR on next-20250925]
[cannot apply to driver-core/driver-core-testing driver-core/driver-core-next driver-core/driver-core-linus viro-vfs/for-next linus/master v6.17-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/NeilBrown/debugfs-rename-end_creating-to-debugfs_end_creating/20250926-105302
base:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.all
patch link:    https://lore.kernel.org/r/20250926025015.1747294-12-neilb%40ownmail.net
patch subject: [PATCH 11/11] ecryptfs: use new start_creaing/start_removing APIs
config: x86_64-buildonly-randconfig-003-20250926 (https://download.01.org/0day-ci/archive/20250926/202509262333.TsoLDUkJ-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250926/202509262333.TsoLDUkJ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509262333.TsoLDUkJ-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   Warning: fs/namei.c:2815 function parameter 'de' not described in 'end_dirop'
   Warning: fs/namei.c:2836 function parameter 'de' not described in 'end_dirop_mkdir'
   Warning: fs/namei.c:2836 function parameter 'parent' not described in 'end_dirop_mkdir'
   Warning: fs/namei.c:3276 function parameter 'idmap' not described in 'start_creating'
   Warning: fs/namei.c:3276 function parameter 'parent' not described in 'start_creating'
   Warning: fs/namei.c:3276 function parameter 'name' not described in 'start_creating'
   Warning: fs/namei.c:3303 function parameter 'idmap' not described in 'start_removing'
   Warning: fs/namei.c:3303 function parameter 'parent' not described in 'start_removing'
   Warning: fs/namei.c:3303 function parameter 'name' not described in 'start_removing'
   Warning: fs/namei.c:3332 function parameter 'idmap' not described in 'start_creating_killable'
   Warning: fs/namei.c:3332 function parameter 'parent' not described in 'start_creating_killable'
   Warning: fs/namei.c:3332 function parameter 'name' not described in 'start_creating_killable'
   Warning: fs/namei.c:3363 function parameter 'idmap' not described in 'start_removing_killable'
   Warning: fs/namei.c:3363 function parameter 'parent' not described in 'start_removing_killable'
   Warning: fs/namei.c:3363 function parameter 'name' not described in 'start_removing_killable'
   Warning: fs/namei.c:3386 function parameter 'parent' not described in 'start_creating_noperm'
   Warning: fs/namei.c:3386 function parameter 'name' not described in 'start_creating_noperm'
   Warning: fs/namei.c:3411 function parameter 'parent' not described in 'start_removing_noperm'
   Warning: fs/namei.c:3411 function parameter 'name' not described in 'start_removing_noperm'
>> Warning: fs/namei.c:3437 function parameter 'parent' not described in 'start_creating_dentry'
>> Warning: fs/namei.c:3437 function parameter 'child' not described in 'start_creating_dentry'
   Warning: fs/namei.c:3470 function parameter 'parent' not described in 'start_removing_dentry'
   Warning: fs/namei.c:3470 function parameter 'child' not described in 'start_removing_dentry'
--
   fs/ecryptfs/inode.c: In function 'ecryptfs_rename':
>> fs/ecryptfs/inode.c:630:14: error: implicit declaration of function 'start_renaming_two_dentry'; did you mean 'start_renaming_two_dentrys'? [-Wimplicit-function-declaration]
     630 |         rc = start_renaming_two_dentry(&rd, lower_old_dentry, lower_new_dentry);
         |              ^~~~~~~~~~~~~~~~~~~~~~~~~
         |              start_renaming_two_dentrys


vim +630 fs/ecryptfs/inode.c

   602	
   603	static int
   604	ecryptfs_rename(struct mnt_idmap *idmap, struct inode *old_dir,
   605			struct dentry *old_dentry, struct inode *new_dir,
   606			struct dentry *new_dentry, unsigned int flags)
   607	{
   608		int rc;
   609		struct dentry *lower_old_dentry;
   610		struct dentry *lower_new_dentry;
   611		struct dentry *lower_old_dir_dentry;
   612		struct dentry *lower_new_dir_dentry;
   613		struct inode *target_inode;
   614		struct renamedata rd = {};
   615	
   616		if (flags)
   617			return -EINVAL;
   618	
   619		lower_old_dir_dentry = ecryptfs_dentry_to_lower(old_dentry->d_parent);
   620		lower_new_dir_dentry = ecryptfs_dentry_to_lower(new_dentry->d_parent);
   621	
   622		lower_old_dentry = ecryptfs_dentry_to_lower(old_dentry);
   623		lower_new_dentry = ecryptfs_dentry_to_lower(new_dentry);
   624	
   625		target_inode = d_inode(new_dentry);
   626	
   627		rd.mnt_idmap  = &nop_mnt_idmap;
   628		rd.old_parent = lower_old_dir_dentry;
   629		rd.new_parent = lower_new_dir_dentry;
 > 630		rc = start_renaming_two_dentry(&rd, lower_old_dentry, lower_new_dentry);
   631		if (rc)
   632			return rc;
   633	
   634		rc = vfs_rename(&rd);
   635		if (rc)
   636			goto out_lock;
   637		if (target_inode)
   638			fsstack_copy_attr_all(target_inode,
   639					      ecryptfs_inode_to_lower(target_inode));
   640		fsstack_copy_attr_all(new_dir, d_inode(lower_new_dir_dentry));
   641		if (new_dir != old_dir)
   642			fsstack_copy_attr_all(old_dir, d_inode(lower_old_dir_dentry));
   643	out_lock:
   644		end_renaming(&rd);
   645		return rc;
   646	}
   647	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki