Re: [PATCH 01/11] debugfs: rename end_creating() to debugfs_end_creating()

[Jeff Layton <jlayton@kernel.org>]

On Fri, 2025-09-26 at 12:49 +1000, NeilBrown wrote:
> From: NeilBrown <neil@brown.name>
> 
> By not using the generic end_creating() name here we are free to use it
> more globally for a more generic function.
> This should have been done when start_creating() was renamed.
> 
> Signed-off-by: NeilBrown <neil@brown.name>
> ---
>  fs/debugfs/inode.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
> index 661a99a7dfbe..b863c8d0cbcd 100644
> --- a/fs/debugfs/inode.c
> +++ b/fs/debugfs/inode.c
> @@ -411,7 +411,7 @@ static struct dentry *failed_creating(struct dentry *dentry)
>  	return ERR_PTR(-ENOMEM);
>  }
>  
> -static struct dentry *end_creating(struct dentry *dentry)
> +static struct dentry *debugfs_end_creating(struct dentry *dentry)
>  {
>  	inode_unlock(d_inode(dentry->d_parent));
>  	return dentry;
> @@ -458,7 +458,7 @@ static struct dentry *__debugfs_create_file(const char *name, umode_t mode,
>  
>  	d_instantiate(dentry, inode);
>  	fsnotify_create(d_inode(dentry->d_parent), dentry);
> -	return end_creating(dentry);
> +	return debugfs_end_creating(dentry);
>  }
>  
>  struct dentry *debugfs_create_file_full(const char *name, umode_t mode,
> @@ -605,7 +605,7 @@ struct dentry *debugfs_create_dir(const char *name, struct dentry *parent)
>  	d_instantiate(dentry, inode);
>  	inc_nlink(d_inode(dentry->d_parent));
>  	fsnotify_mkdir(d_inode(dentry->d_parent), dentry);
> -	return end_creating(dentry);
> +	return debugfs_end_creating(dentry);
>  }
>  EXPORT_SYMBOL_GPL(debugfs_create_dir);
>  
> @@ -652,7 +652,7 @@ struct dentry *debugfs_create_automount(const char *name,
>  	d_instantiate(dentry, inode);
>  	inc_nlink(d_inode(dentry->d_parent));
>  	fsnotify_mkdir(d_inode(dentry->d_parent), dentry);
> -	return end_creating(dentry);
> +	return debugfs_end_creating(dentry);
>  }
>  EXPORT_SYMBOL(debugfs_create_automount);
>  
> @@ -705,7 +705,7 @@ struct dentry *debugfs_create_symlink(const char *name, struct dentry *parent,
>  	inode->i_op = &debugfs_symlink_inode_operations;
>  	inode->i_link = link;
>  	d_instantiate(dentry, inode);
> -	return end_creating(dentry);
> +	return debugfs_end_creating(dentry);
>  }
>  EXPORT_SYMBOL_GPL(debugfs_create_symlink);
>  

Reviewed-by: Jeff Layton <jlayton@kernel.org>