From: kernel test robot <lkp@intel.com>
To: NeilBrown <neilb@ownmail.net>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
Amir Goldstein <amir73il@gmail.com>,
Jeff Layton <jlayton@kernel.org>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 09/11] VFS/ovl/smb: introduce start_renaming_dentry()
Date: Fri, 26 Sep 2025 23:43:27 +0800 [thread overview]
Message-ID: <202509262345.LLJy17UN-lkp@intel.com> (raw)
In-Reply-To: <20250926025015.1747294-10-neilb@ownmail.net>
Hi NeilBrown,
kernel test robot noticed the following build warnings:
[auto build test WARNING on brauner-vfs/vfs.all]
[also build test WARNING on next-20250925]
[cannot apply to driver-core/driver-core-testing driver-core/driver-core-next driver-core/driver-core-linus viro-vfs/for-next linus/master v6.17-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/NeilBrown/debugfs-rename-end_creating-to-debugfs_end_creating/20250926-105302
base: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.all
patch link: https://lore.kernel.org/r/20250926025015.1747294-10-neilb%40ownmail.net
patch subject: [PATCH 09/11] VFS/ovl/smb: introduce start_renaming_dentry()
config: x86_64-buildonly-randconfig-001-20250926 (https://download.01.org/0day-ci/archive/20250926/202509262345.LLJy17UN-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250926/202509262345.LLJy17UN-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509262345.LLJy17UN-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> fs/overlayfs/super.c:609:7: warning: variable 'dest' is uninitialized when used here [-Wuninitialized]
609 | dput(dest);
| ^~~~
fs/overlayfs/super.c:559:21: note: initialize the variable 'dest' to silence this warning
559 | struct dentry *dest;
| ^
| = NULL
1 warning generated.
vim +/dest +609 fs/overlayfs/super.c
6ee8acf0f72b89 Miklos Szeredi 2017-11-09 550
cad218ab332078 Amir Goldstein 2020-02-20 551 /*
cad218ab332078 Amir Goldstein 2020-02-20 552 * Returns 1 if RENAME_WHITEOUT is supported, 0 if not supported and
cad218ab332078 Amir Goldstein 2020-02-20 553 * negative values if error is encountered.
cad218ab332078 Amir Goldstein 2020-02-20 554 */
576bb263450bbb Christian Brauner 2022-04-04 555 static int ovl_check_rename_whiteout(struct ovl_fs *ofs)
cad218ab332078 Amir Goldstein 2020-02-20 556 {
576bb263450bbb Christian Brauner 2022-04-04 557 struct dentry *workdir = ofs->workdir;
cad218ab332078 Amir Goldstein 2020-02-20 558 struct dentry *temp;
cad218ab332078 Amir Goldstein 2020-02-20 559 struct dentry *dest;
cad218ab332078 Amir Goldstein 2020-02-20 560 struct dentry *whiteout;
cad218ab332078 Amir Goldstein 2020-02-20 561 struct name_snapshot name;
18cc48cabac8b0 NeilBrown 2025-09-26 562 struct renamedata rd = {};
18cc48cabac8b0 NeilBrown 2025-09-26 563 char name2[OVL_TEMPNAME_SIZE];
cad218ab332078 Amir Goldstein 2020-02-20 564 int err;
cad218ab332078 Amir Goldstein 2020-02-20 565
576bb263450bbb Christian Brauner 2022-04-04 566 temp = ovl_create_temp(ofs, workdir, OVL_CATTR(S_IFREG | 0));
cad218ab332078 Amir Goldstein 2020-02-20 567 err = PTR_ERR(temp);
cad218ab332078 Amir Goldstein 2020-02-20 568 if (IS_ERR(temp))
d2c995581c7c5d NeilBrown 2025-07-16 569 return err;
cad218ab332078 Amir Goldstein 2020-02-20 570
18cc48cabac8b0 NeilBrown 2025-09-26 571 rd.mnt_idmap = ovl_upper_mnt_idmap(ofs);
18cc48cabac8b0 NeilBrown 2025-09-26 572 rd.old_parent = workdir;
18cc48cabac8b0 NeilBrown 2025-09-26 573 rd.new_parent = workdir;
18cc48cabac8b0 NeilBrown 2025-09-26 574 rd.flags = RENAME_WHITEOUT;
18cc48cabac8b0 NeilBrown 2025-09-26 575 ovl_tempname(name2);
18cc48cabac8b0 NeilBrown 2025-09-26 576 err = start_renaming_dentry(&rd, 0, temp, &QSTR(name2));
d2c995581c7c5d NeilBrown 2025-07-16 577 if (err) {
d2c995581c7c5d NeilBrown 2025-07-16 578 dput(temp);
d2c995581c7c5d NeilBrown 2025-07-16 579 return err;
d2c995581c7c5d NeilBrown 2025-07-16 580 }
cad218ab332078 Amir Goldstein 2020-02-20 581
cad218ab332078 Amir Goldstein 2020-02-20 582 /* Name is inline and stable - using snapshot as a copy helper */
cad218ab332078 Amir Goldstein 2020-02-20 583 take_dentry_name_snapshot(&name, temp);
18cc48cabac8b0 NeilBrown 2025-09-26 584 err = ovl_do_rename_rd(&rd);
18cc48cabac8b0 NeilBrown 2025-09-26 585 end_renaming(&rd);
cad218ab332078 Amir Goldstein 2020-02-20 586 if (err) {
cad218ab332078 Amir Goldstein 2020-02-20 587 if (err == -EINVAL)
cad218ab332078 Amir Goldstein 2020-02-20 588 err = 0;
cad218ab332078 Amir Goldstein 2020-02-20 589 goto cleanup_temp;
cad218ab332078 Amir Goldstein 2020-02-20 590 }
cad218ab332078 Amir Goldstein 2020-02-20 591
09d56cc88c2470 NeilBrown 2025-07-16 592 whiteout = ovl_lookup_upper_unlocked(ofs, name.name.name,
09d56cc88c2470 NeilBrown 2025-07-16 593 workdir, name.name.len);
cad218ab332078 Amir Goldstein 2020-02-20 594 err = PTR_ERR(whiteout);
cad218ab332078 Amir Goldstein 2020-02-20 595 if (IS_ERR(whiteout))
cad218ab332078 Amir Goldstein 2020-02-20 596 goto cleanup_temp;
cad218ab332078 Amir Goldstein 2020-02-20 597
bc8df7a3dc0359 Alexander Larsson 2023-08-23 598 err = ovl_upper_is_whiteout(ofs, whiteout);
cad218ab332078 Amir Goldstein 2020-02-20 599
cad218ab332078 Amir Goldstein 2020-02-20 600 /* Best effort cleanup of whiteout and temp file */
cad218ab332078 Amir Goldstein 2020-02-20 601 if (err)
fe4d3360f9cbb5 NeilBrown 2025-07-16 602 ovl_cleanup(ofs, workdir, whiteout);
cad218ab332078 Amir Goldstein 2020-02-20 603 dput(whiteout);
cad218ab332078 Amir Goldstein 2020-02-20 604
cad218ab332078 Amir Goldstein 2020-02-20 605 cleanup_temp:
fe4d3360f9cbb5 NeilBrown 2025-07-16 606 ovl_cleanup(ofs, workdir, temp);
cad218ab332078 Amir Goldstein 2020-02-20 607 release_dentry_name_snapshot(&name);
cad218ab332078 Amir Goldstein 2020-02-20 608 dput(temp);
cad218ab332078 Amir Goldstein 2020-02-20 @609 dput(dest);
cad218ab332078 Amir Goldstein 2020-02-20 610
cad218ab332078 Amir Goldstein 2020-02-20 611 return err;
cad218ab332078 Amir Goldstein 2020-02-20 612 }
cad218ab332078 Amir Goldstein 2020-02-20 613
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-09-26 15:44 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-26 2:49 [PATCH 00/11] Create APIs to centralise locking for directory ops NeilBrown
2025-09-26 2:49 ` [PATCH 01/11] debugfs: rename end_creating() to debugfs_end_creating() NeilBrown
2025-09-27 9:13 ` Amir Goldstein
2025-09-27 11:29 ` Jeff Layton
2025-09-26 2:49 ` [PATCH 02/11] VFS: introduce start_dirop() and end_dirop() NeilBrown
2025-09-26 16:41 ` Amir Goldstein
2025-09-27 11:32 ` NeilBrown
2025-09-26 2:49 ` [PATCH 03/11] VFS/nfsd/cachefiles/ovl: add start_creating() and end_creating() NeilBrown
2025-09-29 12:37 ` Jeff Layton
2025-09-30 5:37 ` NeilBrown
2025-09-30 10:19 ` Jeff Layton
2025-09-30 8:54 ` Amir Goldstein
2025-10-01 3:15 ` NeilBrown
2025-10-02 10:52 ` Amir Goldstein
2025-09-26 2:49 ` [PATCH 04/11] VFS/nfsd/cachefiles/ovl: introduce start_removing() and end_removing() NeilBrown
2025-09-27 9:12 ` Amir Goldstein
2025-10-02 17:02 ` Jeff Layton
2025-09-26 2:49 ` [PATCH 05/11] VFS: introduce start_creating_noperm() and start_removing_noperm() NeilBrown
2025-09-28 12:26 ` Amir Goldstein
2025-10-02 17:13 ` Jeff Layton
2025-09-26 2:49 ` [PATCH 06/11] VFS: introduce start_removing_dentry() NeilBrown
2025-09-27 9:32 ` Amir Goldstein
2025-09-27 11:55 ` NeilBrown
2025-10-02 17:19 ` Jeff Layton
2025-09-26 2:49 ` [PATCH 07/11] VFS: add start_creating_killable() and start_removing_killable() NeilBrown
2025-09-28 12:05 ` Amir Goldstein
2025-09-29 1:44 ` NeilBrown
2025-09-26 2:49 ` [PATCH 08/11] VFS/nfsd/ovl: introduce start_renaming() and end_renaming() NeilBrown
2025-09-29 11:23 ` Amir Goldstein
2025-09-26 2:49 ` [PATCH 09/11] VFS/ovl/smb: introduce start_renaming_dentry() NeilBrown
2025-09-26 15:43 ` kernel test robot [this message]
2025-09-26 17:17 ` kernel test robot
2025-09-30 7:08 ` Amir Goldstein
2025-10-01 1:45 ` NeilBrown
2025-10-02 10:56 ` Amir Goldstein
2025-10-01 4:35 ` NeilBrown
2025-09-26 2:49 ` [PATCH 10/11] Add start_renaming_two_dentrys() NeilBrown
2025-09-30 7:46 ` Amir Goldstein
2025-10-01 4:14 ` NeilBrown
2025-09-26 2:49 ` [PATCH 11/11] ecryptfs: use new start_creaing/start_removing APIs NeilBrown
2025-09-26 16:03 ` kernel test robot
2025-09-28 12:50 ` Amir Goldstein
2025-09-29 5:26 ` NeilBrown
2025-09-29 7:53 ` Amir Goldstein
2025-10-01 1:31 ` NeilBrown
2025-10-02 10:25 ` Amir Goldstein
2025-09-26 15:47 ` [PATCH 00/11] Create APIs to centralise locking for directory ops Amir Goldstein
2025-09-27 11:20 ` NeilBrown
2025-10-01 5:04 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202509262345.LLJy17UN-lkp@intel.com \
--to=lkp@intel.com \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=neilb@ownmail.net \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.