Re: [PATCH 1/4] dt-bindings: iio: adc: Add the Renesas RZ/N1 ADC

[Herve Codina <herve.codina@bootlin.com>]

Hi Krzysztof,

On Thu, 16 Oct 2025 17:49:33 +0200
Krzysztof Kozlowski <krzk@kernel.org> wrote:

> On 15/10/2025 16:28, Herve Codina (Schneider Electric) wrote:
> > +  clocks:
> > +    items:
> > +      - description: APB internal bus clock
> > +      - description: ADC clock
> > +
> > +  clock-names:
> > +    items:
> > +      - const: pclk
> > +      - const: adc-clk  
> 
> Just 'adc'
> 
> clk is redundant

Ok, will be update.

...

> > +
> > +additionalProperties: false  
> 
> This goes just before example

Ok, will be update

> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - clocks
> > +  - clock-names
> > +  - power-domains
> > +  - '#io-channel-cells'
> > +
> > +dependencies:
> > +  # None or both adc1-avdd-supply / adc1-vref-supply should be present
> > +  adc1-avdd-supply: [ adc1-vref-supply ]
> > +  adc1-vref-supply: [ adc1-avdd-supply ]
> > +  # None or both adc2-avdd-supply / adc2-vref-supply should be present
> > +  adc2-avdd-supply: [ adc2-vref-supply ]
> > +  adc2-vref-supply: [ adc2-avdd-supply ]  
> 
> Above seems unnecessary. The anyOf below should already enforce that, no?

Yes, I will remove the above dependencies and keep only the anyOf.

> 
> > +
> > +# At least one of avvd/vref supplies
> > +anyOf:
> > +  - required:
> > +      - adc1-vref-supply
> > +      - adc1-avdd-supply
> > +  - required:
> > +      - adc2-vref-supply
> > +      - adc2-avdd-supply
> > +  
> 

Best regards,
Hervé