From: Marc Zyngier <maz@kernel.org>
To: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Mark Rutland <mark.rutland@arm.com>,
Will Deacon <will@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Rob Herring <robh@kernel.org>,
Saravana Kannan <saravanak@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sven Peter <sven@kernel.org>, Janne Grunau <j@jannau.net>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
James Clark <james.clark@linaro.org>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Jinjie Ruan <ruanjinjie@huawei.com>,
Alexandru Elisei <alexandru.elisei@arm.com>
Subject: [PATCH v4 15/26] genirq: Update request_percpu_nmi() to take an affinity
Date: Mon, 20 Oct 2025 13:29:32 +0100 [thread overview]
Message-ID: <20251020122944.3074811-16-maz@kernel.org> (raw)
In-Reply-To: <20251020122944.3074811-1-maz@kernel.org>
Continue spreading the notion of affinity to the percpu interrupt
request code by updating the call sites that use request_percpu_nmi()
(all two of them) to take an affinity pointer. This pointer is
firmly NULL for now.
Tested-by: Will Deacon <will@kernel.org>
Signed-off-by: Marc Zyngier <maz@kernel.org>
---
arch/arm64/kernel/smp.c | 2 +-
drivers/perf/arm_pmu.c | 2 +-
include/linux/interrupt.h | 4 ++--
kernel/irq/manage.c | 12 +++++++-----
4 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
index 68cea3a4a35ca..6fb838eee2e7d 100644
--- a/arch/arm64/kernel/smp.c
+++ b/arch/arm64/kernel/smp.c
@@ -1094,7 +1094,7 @@ static void ipi_setup_sgi(int ipi)
irq = ipi_irq_base + ipi;
if (ipi_should_be_nmi(ipi)) {
- err = request_percpu_nmi(irq, ipi_handler, "IPI", &irq_stat);
+ err = request_percpu_nmi(irq, ipi_handler, "IPI", NULL, &irq_stat);
WARN(err, "Could not request IRQ %d as NMI, err=%d\n", irq, err);
} else {
err = request_percpu_irq(irq, ipi_handler, "IPI", &irq_stat);
diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c
index 5c310e803dd78..22c601b46c858 100644
--- a/drivers/perf/arm_pmu.c
+++ b/drivers/perf/arm_pmu.c
@@ -659,7 +659,7 @@ int armpmu_request_irq(int irq, int cpu)
irq_ops = &pmunmi_ops;
}
} else if (armpmu_count_irq_users(irq) == 0) {
- err = request_percpu_nmi(irq, handler, "arm-pmu", &cpu_armpmu);
+ err = request_percpu_nmi(irq, handler, "arm-pmu", NULL, &cpu_armpmu);
/* If cannot get an NMI, get a normal interrupt */
if (err) {
diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
index 52147d5f432b3..81506ab759b81 100644
--- a/include/linux/interrupt.h
+++ b/include/linux/interrupt.h
@@ -197,8 +197,8 @@ request_percpu_irq(unsigned int irq, irq_handler_t handler,
}
extern int __must_check
-request_percpu_nmi(unsigned int irq, irq_handler_t handler,
- const char *devname, void __percpu *dev);
+request_percpu_nmi(unsigned int irq, irq_handler_t handler, const char *name,
+ const struct cpumask *affinity, void __percpu *dev_id);
extern const void *free_irq(unsigned int, void *);
extern void free_percpu_irq(unsigned int, void __percpu *);
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 5f4c651677436..b1a3140e5f3c9 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -2527,6 +2527,7 @@ EXPORT_SYMBOL_GPL(__request_percpu_irq);
* @irq: Interrupt line to allocate
* @handler: Function to be called when the IRQ occurs.
* @name: An ascii name for the claiming device
+ * @affinity: A cpumask describing the target CPUs for this interrupt
* @dev_id: A percpu cookie passed back to the handler function
*
* This call allocates interrupt resources for a per CPU NMI. Per CPU NMIs
@@ -2543,8 +2544,8 @@ EXPORT_SYMBOL_GPL(__request_percpu_irq);
* If the interrupt line cannot be used to deliver NMIs, function
* will fail returning a negative value.
*/
-int request_percpu_nmi(unsigned int irq, irq_handler_t handler,
- const char *name, void __percpu *dev_id)
+int request_percpu_nmi(unsigned int irq, irq_handler_t handler, const char *name,
+ const struct cpumask *affinity, void __percpu *dev_id)
{
struct irqaction *action;
struct irq_desc *desc;
@@ -2561,12 +2562,13 @@ int request_percpu_nmi(unsigned int irq, irq_handler_t handler,
!irq_supports_nmi(desc))
return -EINVAL;
- /* The line cannot already be NMI */
- if (irq_is_nmi(desc))
+ /* The line cannot be NMI already if the new request covers all CPUs */
+ if (irq_is_nmi(desc) &&
+ (!affinity || cpumask_equal(affinity, cpu_possible_mask)))
return -EINVAL;
action = create_percpu_irqaction(handler, IRQF_NO_THREAD | IRQF_NOBALANCING,
- name, NULL, dev_id);
+ name, affinity, dev_id);
if (!action)
return -ENOMEM;
--
2.47.3
next prev parent reply other threads:[~2025-10-20 12:30 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 12:29 [PATCH v4 00/26] genirq: Add support for percpu_devid IRQ affinity Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 01/26] irqdomain: Add firmware info reporting interface Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 02/26] ACPI: irq: Add IRQ affinity " Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] ACPI: irq: Add interrupt " tip-bot2 for Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 03/26] of/irq: Add IRQ " Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] of/irq: Add interrupt " tip-bot2 for Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 04/26] platform: Add firmware-agnostic irq and affinity retrieval interface Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 05/26] irqchip/gic-v3: Add FW info retrieval support Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-11-12 16:54 ` [PATCH v4 05/26] " Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 06/26] irqchip/apple-aic: " Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 07/26] coresight: trbe: Convert to new IRQ affinity retrieval API Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] coresight: trbe: Convert to the new interrupt " tip-bot2 for Marc Zyngier
2025-11-12 16:58 ` [PATCH v4 07/26] coresight: trbe: Convert to new IRQ " Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 08/26] perf: arm_pmu: " Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] perf: arm_pmu: Convert to the new interrupt " tip-bot2 for Marc Zyngier
2025-11-12 16:59 ` [PATCH v4 08/26] perf: arm_pmu: Convert to new IRQ " Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 09/26] perf: arm_spe_pmu: " Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] perf: arm_spe_pmu: Convert to new interrupt " tip-bot2 for Marc Zyngier
2025-11-12 17:58 ` [PATCH v4 09/26] perf: arm_spe_pmu: Convert to new IRQ " Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 10/26] irqchip/gic-v3: Switch high priority PPIs over to handle_percpu_devid_irq() Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-11-12 18:06 ` [PATCH v4 10/26] " Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 11/26] genirq: Kill handle_percpu_devid_fasteoi_nmi() Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-11-12 18:07 ` [PATCH v4 11/26] " Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 12/26] genirq: Merge irqaction::{dev_id,percpu_dev_id} Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-11-12 18:09 ` [PATCH v4 12/26] " Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 13/26] genirq: Factor-in percpu irqaction creation Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 14/26] genirq: Add affinity to percpu_devid interrupt requests Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-11-12 18:13 ` [PATCH v4 14/26] " Jonathan Cameron
2025-11-13 13:37 ` Marc Zyngier
2025-10-20 12:29 ` Marc Zyngier [this message]
2025-10-27 16:31 ` [tip: irq/core] genirq: Update request_percpu_nmi() to take an affinity tip-bot2 for Marc Zyngier
2025-11-12 18:15 ` [PATCH v4 15/26] " Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 16/26] genirq: Allow per-cpu interrupt sharing for non-overlapping affinities Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-11-12 18:25 ` [PATCH v4 16/26] " Jonathan Cameron
2025-12-04 10:56 ` Daniel Thompson
2025-12-04 14:21 ` Marc Zyngier
2025-12-05 9:19 ` Daniel Thompson
2025-10-20 12:29 ` [PATCH v4 17/26] genirq: Add request_percpu_irq_affinity() helper Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-11-12 18:27 ` [PATCH v4 17/26] " Jonathan Cameron
2025-11-13 13:39 ` Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 18/26] perf: arm_pmu: Request specific affinities for percpu NMI/IRQ Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] perf: arm_pmu: Request specific affinities for per CPU NMIs/interrupts tip-bot2 for Will Deacon
2025-11-12 18:31 ` [PATCH v4 18/26] perf: arm_pmu: Request specific affinities for percpu NMI/IRQ Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 19/26] perf: arm_spe_pmu: Request specific affinities for percpu IRQ Marc Zyngier
2025-10-27 16:30 ` [tip: irq/core] perf: arm_spe_pmu: Request specific affinities for per CPU interrupts tip-bot2 for Marc Zyngier
2025-11-12 18:31 ` [PATCH v4 19/26] perf: arm_spe_pmu: Request specific affinities for percpu IRQ Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 20/26] coresight: trbe: " Marc Zyngier
2025-10-27 16:30 ` [tip: irq/core] coresight: trbe: Request specific affinities for per CPU interrupts tip-bot2 for Marc Zyngier
2025-11-12 18:32 ` [PATCH v4 20/26] coresight: trbe: Request specific affinities for percpu IRQ Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 21/26] irqchip/gic-v3: Drop support for custom PPI partitions Marc Zyngier
2025-10-27 16:30 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 22/26] irqchip/apple-aic: Drop support for custom PMU irq partitions Marc Zyngier
2025-10-27 16:30 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 23/26] irqchip: Kill irq-partition-percpu Marc Zyngier
2025-10-27 16:30 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 24/26] genirq: Kill irq_{g,s}et_percpu_devid_partition() Marc Zyngier
2025-10-27 16:30 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 25/26] irqdomain: Kill of_node_to_fwnode() helper Marc Zyngier
2025-10-27 16:30 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-11-12 18:35 ` [PATCH v4 25/26] " Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 26/26] perf: arm_pmu: Kill last use of per-CPU cpu_armpmu pointer Marc Zyngier
2025-10-27 16:30 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251020122944.3074811-16-maz@kernel.org \
--to=maz@kernel.org \
--cc=alexandru.elisei@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=j@jannau.net \
--cc=james.clark@linaro.org \
--cc=jonathan.cameron@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=ruanjinjie@huawei.com \
--cc=saravanak@google.com \
--cc=suzuki.poulose@arm.com \
--cc=sven@kernel.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.