From: Marc Zyngier <maz@kernel.org>
To: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Mark Rutland <mark.rutland@arm.com>,
Will Deacon <will@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Rob Herring <robh@kernel.org>,
Saravana Kannan <saravanak@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sven Peter <sven@kernel.org>, Janne Grunau <j@jannau.net>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
James Clark <james.clark@linaro.org>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Jinjie Ruan <ruanjinjie@huawei.com>,
Alexandru Elisei <alexandru.elisei@arm.com>
Subject: [PATCH v4 22/26] irqchip/apple-aic: Drop support for custom PMU irq partitions
Date: Mon, 20 Oct 2025 13:29:39 +0100 [thread overview]
Message-ID: <20251020122944.3074811-23-maz@kernel.org> (raw)
In-Reply-To: <20251020122944.3074811-1-maz@kernel.org>
Similarly to what has been done for GICv3, drop the irq partitioning
support from the AIC driver, effectively merging the two per-cpu
interrupts for the PMU.
Reviewed-by: Sven Peter <sven@kernel.org>
Tested-by: Will Deacon <will@kernel.org>
Signed-off-by: Marc Zyngier <maz@kernel.org>
---
drivers/irqchip/irq-apple-aic.c | 28 +++++++---------------------
1 file changed, 7 insertions(+), 21 deletions(-)
diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c
index cb8b6f40ce8d3..6305d25b9e77b 100644
--- a/drivers/irqchip/irq-apple-aic.c
+++ b/drivers/irqchip/irq-apple-aic.c
@@ -578,16 +578,9 @@ static void __exception_irq_entry aic_handle_fiq(struct pt_regs *regs)
}
if ((read_sysreg_s(SYS_IMP_APL_PMCR0_EL1) & (PMCR0_IMODE | PMCR0_IACT)) ==
- (FIELD_PREP(PMCR0_IMODE, PMCR0_IMODE_FIQ) | PMCR0_IACT)) {
- int irq;
- if (cpumask_test_cpu(smp_processor_id(),
- &aic_irqc->fiq_aff[AIC_CPU_PMU_P]->aff))
- irq = AIC_CPU_PMU_P;
- else
- irq = AIC_CPU_PMU_E;
+ (FIELD_PREP(PMCR0_IMODE, PMCR0_IMODE_FIQ) | PMCR0_IACT))
generic_handle_domain_irq(aic_irqc->hw_domain,
- AIC_FIQ_HWIRQ(irq));
- }
+ AIC_FIQ_HWIRQ(AIC_CPU_PMU_P));
if (static_branch_likely(&use_fast_ipi) &&
(FIELD_GET(UPMCR0_IMODE, read_sysreg_s(SYS_IMP_APL_UPMCR0_EL1)) == UPMCR0_IMODE_FIQ) &&
@@ -632,18 +625,7 @@ static int aic_irq_domain_map(struct irq_domain *id, unsigned int irq,
handle_fasteoi_irq, NULL, NULL);
irqd_set_single_target(irq_desc_get_irq_data(irq_to_desc(irq)));
} else {
- int fiq = FIELD_GET(AIC_EVENT_NUM, hw);
-
- switch (fiq) {
- case AIC_CPU_PMU_P:
- case AIC_CPU_PMU_E:
- irq_set_percpu_devid_partition(irq, &ic->fiq_aff[fiq]->aff);
- break;
- default:
- irq_set_percpu_devid(irq);
- break;
- }
-
+ irq_set_percpu_devid(irq);
irq_domain_set_info(id, irq, hw, &fiq_chip, id->host_data,
handle_percpu_devid_irq, NULL, NULL);
}
@@ -732,6 +714,10 @@ static int aic_irq_domain_translate(struct irq_domain *id,
break;
}
}
+
+ /* Merge the two PMUs on a single interrupt */
+ if (*hwirq == AIC_CPU_PMU_E)
+ *hwirq = AIC_CPU_PMU_P;
break;
default:
return -EINVAL;
--
2.47.3
next prev parent reply other threads:[~2025-10-20 12:30 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 12:29 [PATCH v4 00/26] genirq: Add support for percpu_devid IRQ affinity Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 01/26] irqdomain: Add firmware info reporting interface Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 02/26] ACPI: irq: Add IRQ affinity " Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] ACPI: irq: Add interrupt " tip-bot2 for Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 03/26] of/irq: Add IRQ " Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] of/irq: Add interrupt " tip-bot2 for Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 04/26] platform: Add firmware-agnostic irq and affinity retrieval interface Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 05/26] irqchip/gic-v3: Add FW info retrieval support Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-11-12 16:54 ` [PATCH v4 05/26] " Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 06/26] irqchip/apple-aic: " Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 07/26] coresight: trbe: Convert to new IRQ affinity retrieval API Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] coresight: trbe: Convert to the new interrupt " tip-bot2 for Marc Zyngier
2025-11-12 16:58 ` [PATCH v4 07/26] coresight: trbe: Convert to new IRQ " Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 08/26] perf: arm_pmu: " Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] perf: arm_pmu: Convert to the new interrupt " tip-bot2 for Marc Zyngier
2025-11-12 16:59 ` [PATCH v4 08/26] perf: arm_pmu: Convert to new IRQ " Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 09/26] perf: arm_spe_pmu: " Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] perf: arm_spe_pmu: Convert to new interrupt " tip-bot2 for Marc Zyngier
2025-11-12 17:58 ` [PATCH v4 09/26] perf: arm_spe_pmu: Convert to new IRQ " Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 10/26] irqchip/gic-v3: Switch high priority PPIs over to handle_percpu_devid_irq() Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-11-12 18:06 ` [PATCH v4 10/26] " Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 11/26] genirq: Kill handle_percpu_devid_fasteoi_nmi() Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-11-12 18:07 ` [PATCH v4 11/26] " Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 12/26] genirq: Merge irqaction::{dev_id,percpu_dev_id} Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-11-12 18:09 ` [PATCH v4 12/26] " Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 13/26] genirq: Factor-in percpu irqaction creation Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 14/26] genirq: Add affinity to percpu_devid interrupt requests Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-11-12 18:13 ` [PATCH v4 14/26] " Jonathan Cameron
2025-11-13 13:37 ` Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 15/26] genirq: Update request_percpu_nmi() to take an affinity Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-11-12 18:15 ` [PATCH v4 15/26] " Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 16/26] genirq: Allow per-cpu interrupt sharing for non-overlapping affinities Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-11-12 18:25 ` [PATCH v4 16/26] " Jonathan Cameron
2025-12-04 10:56 ` Daniel Thompson
2025-12-04 14:21 ` Marc Zyngier
2025-12-05 9:19 ` Daniel Thompson
2025-10-20 12:29 ` [PATCH v4 17/26] genirq: Add request_percpu_irq_affinity() helper Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-11-12 18:27 ` [PATCH v4 17/26] " Jonathan Cameron
2025-11-13 13:39 ` Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 18/26] perf: arm_pmu: Request specific affinities for percpu NMI/IRQ Marc Zyngier
2025-10-27 16:31 ` [tip: irq/core] perf: arm_pmu: Request specific affinities for per CPU NMIs/interrupts tip-bot2 for Will Deacon
2025-11-12 18:31 ` [PATCH v4 18/26] perf: arm_pmu: Request specific affinities for percpu NMI/IRQ Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 19/26] perf: arm_spe_pmu: Request specific affinities for percpu IRQ Marc Zyngier
2025-10-27 16:30 ` [tip: irq/core] perf: arm_spe_pmu: Request specific affinities for per CPU interrupts tip-bot2 for Marc Zyngier
2025-11-12 18:31 ` [PATCH v4 19/26] perf: arm_spe_pmu: Request specific affinities for percpu IRQ Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 20/26] coresight: trbe: " Marc Zyngier
2025-10-27 16:30 ` [tip: irq/core] coresight: trbe: Request specific affinities for per CPU interrupts tip-bot2 for Marc Zyngier
2025-11-12 18:32 ` [PATCH v4 20/26] coresight: trbe: Request specific affinities for percpu IRQ Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 21/26] irqchip/gic-v3: Drop support for custom PPI partitions Marc Zyngier
2025-10-27 16:30 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-10-20 12:29 ` Marc Zyngier [this message]
2025-10-27 16:30 ` [tip: irq/core] irqchip/apple-aic: Drop support for custom PMU irq partitions tip-bot2 for Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 23/26] irqchip: Kill irq-partition-percpu Marc Zyngier
2025-10-27 16:30 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 24/26] genirq: Kill irq_{g,s}et_percpu_devid_partition() Marc Zyngier
2025-10-27 16:30 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 25/26] irqdomain: Kill of_node_to_fwnode() helper Marc Zyngier
2025-10-27 16:30 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-11-12 18:35 ` [PATCH v4 25/26] " Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 26/26] perf: arm_pmu: Kill last use of per-CPU cpu_armpmu pointer Marc Zyngier
2025-10-27 16:30 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251020122944.3074811-23-maz@kernel.org \
--to=maz@kernel.org \
--cc=alexandru.elisei@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=j@jannau.net \
--cc=james.clark@linaro.org \
--cc=jonathan.cameron@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=ruanjinjie@huawei.com \
--cc=saravanak@google.com \
--cc=suzuki.poulose@arm.com \
--cc=sven@kernel.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.