All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Mark Rutland <mark.rutland@arm.com>,
	Will Deacon <will@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Saravana Kannan <saravanak@google.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sven Peter <sven@kernel.org>, Janne Grunau <j@jannau.net>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	James Clark <james.clark@linaro.org>,
	Jonathan Cameron <jonathan.cameron@huawei.com>,
	Jinjie Ruan <ruanjinjie@huawei.com>,
	Alexandru Elisei <alexandru.elisei@arm.com>
Subject: [PATCH v4 23/26] irqchip: Kill irq-partition-percpu
Date: Mon, 20 Oct 2025 13:29:40 +0100	[thread overview]
Message-ID: <20251020122944.3074811-24-maz@kernel.org> (raw)
In-Reply-To: <20251020122944.3074811-1-maz@kernel.org>

This code is now completely unused, and nobody will ever miss it.

Tested-by: Will Deacon <will@kernel.org>
Signed-off-by: Marc Zyngier <maz@kernel.org>
---
 drivers/irqchip/Kconfig                      |   3 -
 drivers/irqchip/Makefile                     |   1 -
 drivers/irqchip/irq-partition-percpu.c       | 241 -------------------
 include/linux/irqchip/irq-partition-percpu.h |  53 ----
 4 files changed, 298 deletions(-)
 delete mode 100644 drivers/irqchip/irq-partition-percpu.c
 delete mode 100644 include/linux/irqchip/irq-partition-percpu.h

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 648b3618fc784..5dddb4c9442ad 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -450,9 +450,6 @@ config LS_SCFG_MSI
 	depends on PCI_MSI
 	select IRQ_MSI_LIB
 
-config PARTITION_PERCPU
-	bool
-
 config STM32MP_EXTI
 	tristate "STM32MP extended interrupts and event controller"
 	depends on (ARCH_STM32 && !ARM_SINGLE_ARMV7M) || COMPILE_TEST
diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile
index 3de083f5484cc..6a229443efe08 100644
--- a/drivers/irqchip/Makefile
+++ b/drivers/irqchip/Makefile
@@ -36,7 +36,6 @@ obj-$(CONFIG_ARM_GIC_V3)		+= irq-gic-v3.o irq-gic-v3-mbi.o irq-gic-common.o
 obj-$(CONFIG_ARM_GIC_ITS_PARENT)	+= irq-gic-its-msi-parent.o
 obj-$(CONFIG_ARM_GIC_V3_ITS)		+= irq-gic-v3-its.o irq-gic-v4.o
 obj-$(CONFIG_ARM_GIC_V3_ITS_FSL_MC)	+= irq-gic-v3-its-fsl-mc-msi.o
-obj-$(CONFIG_PARTITION_PERCPU)		+= irq-partition-percpu.o
 obj-$(CONFIG_ARM_GIC_V5)		+= irq-gic-v5.o irq-gic-v5-irs.o irq-gic-v5-its.o \
 					   irq-gic-v5-iwb.o
 obj-$(CONFIG_HISILICON_IRQ_MBIGEN)	+= irq-mbigen.o
diff --git a/drivers/irqchip/irq-partition-percpu.c b/drivers/irqchip/irq-partition-percpu.c
deleted file mode 100644
index 4441ffe149ea0..0000000000000
--- a/drivers/irqchip/irq-partition-percpu.c
+++ /dev/null
@@ -1,241 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0-only
-/*
- * Copyright (C) 2016 ARM Limited, All Rights Reserved.
- * Author: Marc Zyngier <marc.zyngier@arm.com>
- */
-
-#include <linux/bitops.h>
-#include <linux/interrupt.h>
-#include <linux/irqchip.h>
-#include <linux/irqchip/chained_irq.h>
-#include <linux/irqchip/irq-partition-percpu.h>
-#include <linux/irqdomain.h>
-#include <linux/seq_file.h>
-#include <linux/slab.h>
-
-struct partition_desc {
-	int				nr_parts;
-	struct partition_affinity	*parts;
-	struct irq_domain		*domain;
-	struct irq_desc			*chained_desc;
-	unsigned long			*bitmap;
-	struct irq_domain_ops		ops;
-};
-
-static bool partition_check_cpu(struct partition_desc *part,
-				unsigned int cpu, unsigned int hwirq)
-{
-	return cpumask_test_cpu(cpu, &part->parts[hwirq].mask);
-}
-
-static void partition_irq_mask(struct irq_data *d)
-{
-	struct partition_desc *part = irq_data_get_irq_chip_data(d);
-	struct irq_chip *chip = irq_desc_get_chip(part->chained_desc);
-	struct irq_data *data = irq_desc_get_irq_data(part->chained_desc);
-
-	if (partition_check_cpu(part, smp_processor_id(), d->hwirq) &&
-	    chip->irq_mask)
-		chip->irq_mask(data);
-}
-
-static void partition_irq_unmask(struct irq_data *d)
-{
-	struct partition_desc *part = irq_data_get_irq_chip_data(d);
-	struct irq_chip *chip = irq_desc_get_chip(part->chained_desc);
-	struct irq_data *data = irq_desc_get_irq_data(part->chained_desc);
-
-	if (partition_check_cpu(part, smp_processor_id(), d->hwirq) &&
-	    chip->irq_unmask)
-		chip->irq_unmask(data);
-}
-
-static int partition_irq_set_irqchip_state(struct irq_data *d,
-					   enum irqchip_irq_state which,
-					   bool val)
-{
-	struct partition_desc *part = irq_data_get_irq_chip_data(d);
-	struct irq_chip *chip = irq_desc_get_chip(part->chained_desc);
-	struct irq_data *data = irq_desc_get_irq_data(part->chained_desc);
-
-	if (partition_check_cpu(part, smp_processor_id(), d->hwirq) &&
-	    chip->irq_set_irqchip_state)
-		return chip->irq_set_irqchip_state(data, which, val);
-
-	return -EINVAL;
-}
-
-static int partition_irq_get_irqchip_state(struct irq_data *d,
-					   enum irqchip_irq_state which,
-					   bool *val)
-{
-	struct partition_desc *part = irq_data_get_irq_chip_data(d);
-	struct irq_chip *chip = irq_desc_get_chip(part->chained_desc);
-	struct irq_data *data = irq_desc_get_irq_data(part->chained_desc);
-
-	if (partition_check_cpu(part, smp_processor_id(), d->hwirq) &&
-	    chip->irq_get_irqchip_state)
-		return chip->irq_get_irqchip_state(data, which, val);
-
-	return -EINVAL;
-}
-
-static int partition_irq_set_type(struct irq_data *d, unsigned int type)
-{
-	struct partition_desc *part = irq_data_get_irq_chip_data(d);
-	struct irq_chip *chip = irq_desc_get_chip(part->chained_desc);
-	struct irq_data *data = irq_desc_get_irq_data(part->chained_desc);
-
-	if (chip->irq_set_type)
-		return chip->irq_set_type(data, type);
-
-	return -EINVAL;
-}
-
-static void partition_irq_print_chip(struct irq_data *d, struct seq_file *p)
-{
-	struct partition_desc *part = irq_data_get_irq_chip_data(d);
-	struct irq_chip *chip = irq_desc_get_chip(part->chained_desc);
-	struct irq_data *data = irq_desc_get_irq_data(part->chained_desc);
-
-	seq_printf(p, "%5s-%lu", chip->name, data->hwirq);
-}
-
-static struct irq_chip partition_irq_chip = {
-	.irq_mask		= partition_irq_mask,
-	.irq_unmask		= partition_irq_unmask,
-	.irq_set_type		= partition_irq_set_type,
-	.irq_get_irqchip_state	= partition_irq_get_irqchip_state,
-	.irq_set_irqchip_state	= partition_irq_set_irqchip_state,
-	.irq_print_chip		= partition_irq_print_chip,
-};
-
-static void partition_handle_irq(struct irq_desc *desc)
-{
-	struct partition_desc *part = irq_desc_get_handler_data(desc);
-	struct irq_chip *chip = irq_desc_get_chip(desc);
-	int cpu = smp_processor_id();
-	int hwirq;
-
-	chained_irq_enter(chip, desc);
-
-	for_each_set_bit(hwirq, part->bitmap, part->nr_parts) {
-		if (partition_check_cpu(part, cpu, hwirq))
-			break;
-	}
-
-	if (unlikely(hwirq == part->nr_parts))
-		handle_bad_irq(desc);
-	else
-		generic_handle_domain_irq(part->domain, hwirq);
-
-	chained_irq_exit(chip, desc);
-}
-
-static int partition_domain_alloc(struct irq_domain *domain, unsigned int virq,
-				  unsigned int nr_irqs, void *arg)
-{
-	int ret;
-	irq_hw_number_t hwirq;
-	unsigned int type;
-	struct irq_fwspec *fwspec = arg;
-	struct partition_desc *part;
-
-	BUG_ON(nr_irqs != 1);
-	ret = domain->ops->translate(domain, fwspec, &hwirq, &type);
-	if (ret)
-		return ret;
-
-	part = domain->host_data;
-
-	set_bit(hwirq, part->bitmap);
-	irq_set_chained_handler_and_data(irq_desc_get_irq(part->chained_desc),
-					 partition_handle_irq, part);
-	irq_set_percpu_devid_partition(virq, &part->parts[hwirq].mask);
-	irq_domain_set_info(domain, virq, hwirq, &partition_irq_chip, part,
-			    handle_percpu_devid_irq, NULL, NULL);
-	irq_set_status_flags(virq, IRQ_NOAUTOEN);
-
-	return 0;
-}
-
-static void partition_domain_free(struct irq_domain *domain, unsigned int virq,
-				  unsigned int nr_irqs)
-{
-	struct irq_data *d;
-
-	BUG_ON(nr_irqs != 1);
-
-	d = irq_domain_get_irq_data(domain, virq);
-	irq_set_handler(virq, NULL);
-	irq_domain_reset_irq_data(d);
-}
-
-int partition_translate_id(struct partition_desc *desc, void *partition_id)
-{
-	struct partition_affinity *part = NULL;
-	int i;
-
-	for (i = 0; i < desc->nr_parts; i++) {
-		if (desc->parts[i].partition_id == partition_id) {
-			part = &desc->parts[i];
-			break;
-		}
-	}
-
-	if (WARN_ON(!part)) {
-		pr_err("Failed to find partition\n");
-		return -EINVAL;
-	}
-
-	return i;
-}
-
-struct partition_desc *partition_create_desc(struct fwnode_handle *fwnode,
-					     struct partition_affinity *parts,
-					     int nr_parts,
-					     int chained_irq,
-					     const struct irq_domain_ops *ops)
-{
-	struct partition_desc *desc;
-	struct irq_domain *d;
-
-	BUG_ON(!ops->select || !ops->translate);
-
-	desc = kzalloc(sizeof(*desc), GFP_KERNEL);
-	if (!desc)
-		return NULL;
-
-	desc->ops = *ops;
-	desc->ops.free = partition_domain_free;
-	desc->ops.alloc = partition_domain_alloc;
-
-	d = irq_domain_create_linear(fwnode, nr_parts, &desc->ops, desc);
-	if (!d)
-		goto out;
-	desc->domain = d;
-
-	desc->bitmap = bitmap_zalloc(nr_parts, GFP_KERNEL);
-	if (WARN_ON(!desc->bitmap))
-		goto out;
-
-	desc->chained_desc = irq_to_desc(chained_irq);
-	desc->nr_parts = nr_parts;
-	desc->parts = parts;
-
-	return desc;
-out:
-	if (d)
-		irq_domain_remove(d);
-	kfree(desc);
-
-	return NULL;
-}
-
-struct irq_domain *partition_get_domain(struct partition_desc *dsc)
-{
-	if (dsc)
-		return dsc->domain;
-
-	return NULL;
-}
diff --git a/include/linux/irqchip/irq-partition-percpu.h b/include/linux/irqchip/irq-partition-percpu.h
deleted file mode 100644
index b35ee22c278f8..0000000000000
--- a/include/linux/irqchip/irq-partition-percpu.h
+++ /dev/null
@@ -1,53 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-/*
- * Copyright (C) 2016 ARM Limited, All Rights Reserved.
- * Author: Marc Zyngier <marc.zyngier@arm.com>
- */
-
-#ifndef __LINUX_IRQCHIP_IRQ_PARTITION_PERCPU_H
-#define __LINUX_IRQCHIP_IRQ_PARTITION_PERCPU_H
-
-#include <linux/fwnode.h>
-#include <linux/cpumask_types.h>
-#include <linux/irqdomain.h>
-
-struct partition_affinity {
-	cpumask_t			mask;
-	void				*partition_id;
-};
-
-struct partition_desc;
-
-#ifdef CONFIG_PARTITION_PERCPU
-int partition_translate_id(struct partition_desc *desc, void *partition_id);
-struct partition_desc *partition_create_desc(struct fwnode_handle *fwnode,
-					     struct partition_affinity *parts,
-					     int nr_parts,
-					     int chained_irq,
-					     const struct irq_domain_ops *ops);
-struct irq_domain *partition_get_domain(struct partition_desc *dsc);
-#else
-static inline int partition_translate_id(struct partition_desc *desc,
-					 void *partition_id)
-{
-	return -EINVAL;
-}
-
-static inline
-struct partition_desc *partition_create_desc(struct fwnode_handle *fwnode,
-					     struct partition_affinity *parts,
-					     int nr_parts,
-					     int chained_irq,
-					     const struct irq_domain_ops *ops)
-{
-	return NULL;
-}
-
-static inline
-struct irq_domain *partition_get_domain(struct partition_desc *dsc)
-{
-	return NULL;
-}
-#endif
-
-#endif /* __LINUX_IRQCHIP_IRQ_PARTITION_PERCPU_H */
-- 
2.47.3


  parent reply	other threads:[~2025-10-20 12:30 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-20 12:29 [PATCH v4 00/26] genirq: Add support for percpu_devid IRQ affinity Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 01/26] irqdomain: Add firmware info reporting interface Marc Zyngier
2025-10-27 16:31   ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 02/26] ACPI: irq: Add IRQ affinity " Marc Zyngier
2025-10-27 16:31   ` [tip: irq/core] ACPI: irq: Add interrupt " tip-bot2 for Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 03/26] of/irq: Add IRQ " Marc Zyngier
2025-10-27 16:31   ` [tip: irq/core] of/irq: Add interrupt " tip-bot2 for Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 04/26] platform: Add firmware-agnostic irq and affinity retrieval interface Marc Zyngier
2025-10-27 16:31   ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 05/26] irqchip/gic-v3: Add FW info retrieval support Marc Zyngier
2025-10-27 16:31   ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-11-12 16:54   ` [PATCH v4 05/26] " Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 06/26] irqchip/apple-aic: " Marc Zyngier
2025-10-27 16:31   ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 07/26] coresight: trbe: Convert to new IRQ affinity retrieval API Marc Zyngier
2025-10-27 16:31   ` [tip: irq/core] coresight: trbe: Convert to the new interrupt " tip-bot2 for Marc Zyngier
2025-11-12 16:58   ` [PATCH v4 07/26] coresight: trbe: Convert to new IRQ " Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 08/26] perf: arm_pmu: " Marc Zyngier
2025-10-27 16:31   ` [tip: irq/core] perf: arm_pmu: Convert to the new interrupt " tip-bot2 for Marc Zyngier
2025-11-12 16:59   ` [PATCH v4 08/26] perf: arm_pmu: Convert to new IRQ " Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 09/26] perf: arm_spe_pmu: " Marc Zyngier
2025-10-27 16:31   ` [tip: irq/core] perf: arm_spe_pmu: Convert to new interrupt " tip-bot2 for Marc Zyngier
2025-11-12 17:58   ` [PATCH v4 09/26] perf: arm_spe_pmu: Convert to new IRQ " Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 10/26] irqchip/gic-v3: Switch high priority PPIs over to handle_percpu_devid_irq() Marc Zyngier
2025-10-27 16:31   ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-11-12 18:06   ` [PATCH v4 10/26] " Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 11/26] genirq: Kill handle_percpu_devid_fasteoi_nmi() Marc Zyngier
2025-10-27 16:31   ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-11-12 18:07   ` [PATCH v4 11/26] " Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 12/26] genirq: Merge irqaction::{dev_id,percpu_dev_id} Marc Zyngier
2025-10-27 16:31   ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-11-12 18:09   ` [PATCH v4 12/26] " Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 13/26] genirq: Factor-in percpu irqaction creation Marc Zyngier
2025-10-27 16:31   ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 14/26] genirq: Add affinity to percpu_devid interrupt requests Marc Zyngier
2025-10-27 16:31   ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-11-12 18:13   ` [PATCH v4 14/26] " Jonathan Cameron
2025-11-13 13:37     ` Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 15/26] genirq: Update request_percpu_nmi() to take an affinity Marc Zyngier
2025-10-27 16:31   ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-11-12 18:15   ` [PATCH v4 15/26] " Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 16/26] genirq: Allow per-cpu interrupt sharing for non-overlapping affinities Marc Zyngier
2025-10-27 16:31   ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-11-12 18:25   ` [PATCH v4 16/26] " Jonathan Cameron
2025-12-04 10:56   ` Daniel Thompson
2025-12-04 14:21     ` Marc Zyngier
2025-12-05  9:19       ` Daniel Thompson
2025-10-20 12:29 ` [PATCH v4 17/26] genirq: Add request_percpu_irq_affinity() helper Marc Zyngier
2025-10-27 16:31   ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-11-12 18:27   ` [PATCH v4 17/26] " Jonathan Cameron
2025-11-13 13:39     ` Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 18/26] perf: arm_pmu: Request specific affinities for percpu NMI/IRQ Marc Zyngier
2025-10-27 16:31   ` [tip: irq/core] perf: arm_pmu: Request specific affinities for per CPU NMIs/interrupts tip-bot2 for Will Deacon
2025-11-12 18:31   ` [PATCH v4 18/26] perf: arm_pmu: Request specific affinities for percpu NMI/IRQ Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 19/26] perf: arm_spe_pmu: Request specific affinities for percpu IRQ Marc Zyngier
2025-10-27 16:30   ` [tip: irq/core] perf: arm_spe_pmu: Request specific affinities for per CPU interrupts tip-bot2 for Marc Zyngier
2025-11-12 18:31   ` [PATCH v4 19/26] perf: arm_spe_pmu: Request specific affinities for percpu IRQ Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 20/26] coresight: trbe: " Marc Zyngier
2025-10-27 16:30   ` [tip: irq/core] coresight: trbe: Request specific affinities for per CPU interrupts tip-bot2 for Marc Zyngier
2025-11-12 18:32   ` [PATCH v4 20/26] coresight: trbe: Request specific affinities for percpu IRQ Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 21/26] irqchip/gic-v3: Drop support for custom PPI partitions Marc Zyngier
2025-10-27 16:30   ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 22/26] irqchip/apple-aic: Drop support for custom PMU irq partitions Marc Zyngier
2025-10-27 16:30   ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-10-20 12:29 ` Marc Zyngier [this message]
2025-10-27 16:30   ` [tip: irq/core] irqchip: Kill irq-partition-percpu tip-bot2 for Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 24/26] genirq: Kill irq_{g,s}et_percpu_devid_partition() Marc Zyngier
2025-10-27 16:30   ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-10-20 12:29 ` [PATCH v4 25/26] irqdomain: Kill of_node_to_fwnode() helper Marc Zyngier
2025-10-27 16:30   ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-11-12 18:35   ` [PATCH v4 25/26] " Jonathan Cameron
2025-10-20 12:29 ` [PATCH v4 26/26] perf: arm_pmu: Kill last use of per-CPU cpu_armpmu pointer Marc Zyngier
2025-10-27 16:30   ` [tip: irq/core] " tip-bot2 for Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251020122944.3074811-24-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=alexandru.elisei@arm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=j@jannau.net \
    --cc=james.clark@linaro.org \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=ruanjinjie@huawei.com \
    --cc=saravanak@google.com \
    --cc=suzuki.poulose@arm.com \
    --cc=sven@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.