All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jamin Lin via <qemu-arm@nongnu.org>
To: "Cédric Le Goater" <clg@kaod.org>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Steven Lee" <steven_lee@aspeedtech.com>,
	"Troy Lee" <leetroy@gmail.com>,
	"Andrew Jeffery" <andrew@codeconstruct.com.au>,
	"Joel Stanley" <joel@jms.id.au>,
	"open list:ASPEED BMCs" <qemu-arm@nongnu.org>,
	"open list:All patches CC here" <qemu-devel@nongnu.org>
Cc: <jamin_lin@aspeedtech.com>, <troy_lee@aspeedtech.com>,
	<kane_chen@aspeedtech.com>
Subject: [PATCH v1 01/13] hw/arm/aspeed: Move AspeedMachineState definition to common header for reuse
Date: Thu, 23 Oct 2025 18:01:34 +0800	[thread overview]
Message-ID: <20251023100150.295370-2-jamin_lin@aspeedtech.com> (raw)
In-Reply-To: <20251023100150.295370-1-jamin_lin@aspeedtech.com>

Aspeed machines will be moved into split C files for better
modularization and future maintenance.

To allow all machine implementations to reuse the same
AspeedMachineState structure, the struct definition is moved
from aspeed.c to the shared header aspeed.h.

This change centralizes the common state structure used across
all Aspeed machine models, reduces redundancy, and simplifies
future refactoring work for new machines.

No functional changes.

Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
 include/hw/arm/aspeed.h | 14 ++++++++++++++
 hw/arm/aspeed.c         | 14 --------------
 2 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/include/hw/arm/aspeed.h b/include/hw/arm/aspeed.h
index 6c36455656..383ebb9759 100644
--- a/include/hw/arm/aspeed.h
+++ b/include/hw/arm/aspeed.h
@@ -11,6 +11,7 @@
 
 #include "hw/boards.h"
 #include "qom/object.h"
+#include "hw/arm/aspeed_soc.h"
 
 typedef struct AspeedMachineState AspeedMachineState;
 
@@ -24,6 +25,19 @@ DECLARE_OBJ_CHECKERS(AspeedMachineState, AspeedMachineClass,
 #define ASPEED_MAC2_ON   (1 << 2)
 #define ASPEED_MAC3_ON   (1 << 3)
 
+struct AspeedMachineState {
+    /* Private */
+    MachineState parent_obj;
+    /* Public */
+
+    AspeedSoCState *soc;
+    MemoryRegion boot_rom;
+    bool mmio_exec;
+    uint32_t uart_chosen;
+    char *fmc_model;
+    char *spi_model;
+    uint32_t hw_strap1;
+};
 
 struct AspeedMachineClass {
     MachineClass parent_obj;
diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
index 1bc9e534ba..761b526994 100644
--- a/hw/arm/aspeed.c
+++ b/hw/arm/aspeed.c
@@ -35,20 +35,6 @@ static struct arm_boot_info aspeed_board_binfo = {
     .board_id = -1, /* device-tree-only board */
 };
 
-struct AspeedMachineState {
-    /* Private */
-    MachineState parent_obj;
-    /* Public */
-
-    AspeedSoCState *soc;
-    MemoryRegion boot_rom;
-    bool mmio_exec;
-    uint32_t uart_chosen;
-    char *fmc_model;
-    char *spi_model;
-    uint32_t hw_strap1;
-};
-
 /* On 32-bit hosts, lower RAM to 1G because of the 2047 MB limit */
 #if HOST_LONG_BITS == 32
 #define ASPEED_RAM_SIZE(sz) MIN((sz), 1 * GiB)
-- 
2.43.0



WARNING: multiple messages have this Message-ID (diff)
From: Jamin Lin via <qemu-devel@nongnu.org>
To: "Cédric Le Goater" <clg@kaod.org>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Steven Lee" <steven_lee@aspeedtech.com>,
	"Troy Lee" <leetroy@gmail.com>,
	"Andrew Jeffery" <andrew@codeconstruct.com.au>,
	"Joel Stanley" <joel@jms.id.au>,
	"open list:ASPEED BMCs" <qemu-arm@nongnu.org>,
	"open list:All patches CC here" <qemu-devel@nongnu.org>
Cc: <jamin_lin@aspeedtech.com>, <troy_lee@aspeedtech.com>,
	<kane_chen@aspeedtech.com>
Subject: [PATCH v1 01/13] hw/arm/aspeed: Move AspeedMachineState definition to common header for reuse
Date: Thu, 23 Oct 2025 18:01:34 +0800	[thread overview]
Message-ID: <20251023100150.295370-2-jamin_lin@aspeedtech.com> (raw)
In-Reply-To: <20251023100150.295370-1-jamin_lin@aspeedtech.com>

Aspeed machines will be moved into split C files for better
modularization and future maintenance.

To allow all machine implementations to reuse the same
AspeedMachineState structure, the struct definition is moved
from aspeed.c to the shared header aspeed.h.

This change centralizes the common state structure used across
all Aspeed machine models, reduces redundancy, and simplifies
future refactoring work for new machines.

No functional changes.

Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
 include/hw/arm/aspeed.h | 14 ++++++++++++++
 hw/arm/aspeed.c         | 14 --------------
 2 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/include/hw/arm/aspeed.h b/include/hw/arm/aspeed.h
index 6c36455656..383ebb9759 100644
--- a/include/hw/arm/aspeed.h
+++ b/include/hw/arm/aspeed.h
@@ -11,6 +11,7 @@
 
 #include "hw/boards.h"
 #include "qom/object.h"
+#include "hw/arm/aspeed_soc.h"
 
 typedef struct AspeedMachineState AspeedMachineState;
 
@@ -24,6 +25,19 @@ DECLARE_OBJ_CHECKERS(AspeedMachineState, AspeedMachineClass,
 #define ASPEED_MAC2_ON   (1 << 2)
 #define ASPEED_MAC3_ON   (1 << 3)
 
+struct AspeedMachineState {
+    /* Private */
+    MachineState parent_obj;
+    /* Public */
+
+    AspeedSoCState *soc;
+    MemoryRegion boot_rom;
+    bool mmio_exec;
+    uint32_t uart_chosen;
+    char *fmc_model;
+    char *spi_model;
+    uint32_t hw_strap1;
+};
 
 struct AspeedMachineClass {
     MachineClass parent_obj;
diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
index 1bc9e534ba..761b526994 100644
--- a/hw/arm/aspeed.c
+++ b/hw/arm/aspeed.c
@@ -35,20 +35,6 @@ static struct arm_boot_info aspeed_board_binfo = {
     .board_id = -1, /* device-tree-only board */
 };
 
-struct AspeedMachineState {
-    /* Private */
-    MachineState parent_obj;
-    /* Public */
-
-    AspeedSoCState *soc;
-    MemoryRegion boot_rom;
-    bool mmio_exec;
-    uint32_t uart_chosen;
-    char *fmc_model;
-    char *spi_model;
-    uint32_t hw_strap1;
-};
-
 /* On 32-bit hosts, lower RAM to 1G because of the 2047 MB limit */
 #if HOST_LONG_BITS == 32
 #define ASPEED_RAM_SIZE(sz) MIN((sz), 1 * GiB)
-- 
2.43.0



  reply	other threads:[~2025-10-23 10:02 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-23 10:01 [PATCH v1 00/13] Split AST2500 SoC machines into separate source files for maintainability Jamin Lin via
2025-10-23 10:01 ` Jamin Lin via
2025-10-23 10:01 ` Jamin Lin via [this message]
2025-10-23 10:01   ` [PATCH v1 01/13] hw/arm/aspeed: Move AspeedMachineState definition to common header for reuse Jamin Lin via
2025-10-29 17:06   ` [SPAM] " Cédric Le Goater
2025-10-23 10:01 ` [PATCH v1 02/13] hw/arm/aspeed: Make aspeed_machine_class_init_cpus_defaults() globally accessible Jamin Lin via
2025-10-23 10:01   ` Jamin Lin via
2025-10-29 17:08   ` [SPAM] " Cédric Le Goater
2025-10-23 10:01 ` [PATCH v1 03/13] hw/arm/aspeed: Make create_pca9552() globally accessible for reuse Jamin Lin via
2025-10-23 10:01   ` Jamin Lin via
2025-10-29 17:08   ` [SPAM] " Cédric Le Goater
2025-10-31  6:45     ` Jamin Lin
2025-10-31  6:59       ` Cédric Le Goater
2025-10-23 10:01 ` [PATCH v1 04/13] hw/arm/aspeed: Make create_pca9554() available for use by other Aspeed machines Jamin Lin via
2025-10-23 10:01   ` Jamin Lin via
2025-10-29 17:09   ` [SPAM] " Cédric Le Goater
2025-10-23 10:01 ` [PATCH v1 05/13] hw/arm/aspeed: Split FP5280G2 machine into a separate source file for maintenance Jamin Lin via
2025-10-23 10:01   ` Jamin Lin via
2025-10-29 17:09   ` [SPAM] " Cédric Le Goater
2025-10-23 10:01 ` [PATCH v1 06/13] hw/arm/aspeed: Split G220A machine into a separate source file for better maintenance Jamin Lin via
2025-10-23 10:01   ` Jamin Lin via
2025-10-29 17:09   ` [SPAM] " Cédric Le Goater
2025-10-23 10:01 ` [PATCH v1 07/13] hw/arm/aspeed: Split Tiogapass machine into a separate source file for cleanup Jamin Lin via
2025-10-23 10:01   ` Jamin Lin via
2025-10-29 17:09   ` [SPAM] " Cédric Le Goater
2025-10-23 10:01 ` [PATCH v1 08/13] hw/arm/aspeed: Split YosemiteV2 machine into a separate source file for maintainability Jamin Lin via
2025-10-23 10:01   ` Jamin Lin via
2025-10-29 17:09   ` [SPAM] " Cédric Le Goater
2025-10-23 10:01 ` [PATCH v1 09/13] hw/arm/aspeed: Split Witherspoon " Jamin Lin via
2025-10-23 10:01   ` Jamin Lin via
2025-10-29 17:09   ` [SPAM] " Cédric Le Goater
2025-10-23 10:01 ` [PATCH v1 10/13] hw/arm/aspeed: Split Sonorapass " Jamin Lin via
2025-10-23 10:01   ` Jamin Lin via
2025-10-29 17:09   ` [SPAM] " Cédric Le Goater
2025-10-23 10:01 ` [PATCH v1 11/13] hw/arm/aspeed: Split Romulus " Jamin Lin via
2025-10-23 10:01   ` Jamin Lin via
2025-10-29 17:09   ` [SPAM] " Cédric Le Goater
2025-10-23 10:01 ` [PATCH v1 12/13] hw/arm/aspeed: Split Supermicro X11SPI machine into a separate " Jamin Lin via
2025-10-23 10:01   ` Jamin Lin via
2025-10-29 17:10   ` [SPAM] " Cédric Le Goater
2025-10-23 10:01 ` [PATCH v1 13/13] hw/arm/aspeed: Split AST2500 EVB machine into a separate source " Jamin Lin via
2025-10-23 10:01   ` Jamin Lin via
2025-10-29 17:10   ` [SPAM] " Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251023100150.295370-2-jamin_lin@aspeedtech.com \
    --to=qemu-arm@nongnu.org \
    --cc=andrew@codeconstruct.com.au \
    --cc=clg@kaod.org \
    --cc=jamin_lin@aspeedtech.com \
    --cc=joel@jms.id.au \
    --cc=kane_chen@aspeedtech.com \
    --cc=leetroy@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=steven_lee@aspeedtech.com \
    --cc=troy_lee@aspeedtech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.