All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Erdfelt <johannes@erdfelt.com>
To: Alex Elder <elder@riscstar.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	bhelgaas@google.com, lpieralisi@kernel.org,
	kwilczynski@kernel.org, mani@kernel.org, vkoul@kernel.org,
	kishon@kernel.org, dlan@gentoo.org, guodong@riscstar.com,
	pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu,
	alex@ghiti.fr, p.zabel@pengutronix.de,
	christian.bruel@foss.st.com, shradha.t@samsung.com,
	krishna.chundru@oss.qualcomm.com, qiang.yu@oss.qualcomm.com,
	namcao@linutronix.de, thippeswamy.havalige@amd.com,
	inochiama@gmail.com, devicetree@vger.kernel.org,
	linux-pci@vger.kernel.org, linux-phy@lists.infradead.org,
	spacemit@lists.linux.dev, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/7] Introduce SpacemiT K1 PCIe phy and host controller
Date: Tue, 28 Oct 2025 13:48:32 -0700	[thread overview]
Message-ID: <20251028204832.GN15521@sventech.com> (raw)
In-Reply-To: <82848c80-15e0-4c0e-a3f6-821a7f4778a5@riscstar.com>

On Tue, Oct 28, 2025, Alex Elder <elder@riscstar.com> wrote:
> On 10/28/25 1:42 PM, Johannes Erdfelt wrote:
> > I have been testing this patchset recently as well, but on an Orange Pi
> > RV2 board instead (and an extra RV2 specific patch to enable power to
> > the M.2 slot).
> > 
> > I ran into the same symptoms you had ("QID 0 timeout" after about 60
> > seconds). However, I'm using an Intel 600p. I can confirm my NVME drive
> > seems to work fine with the "pcie_aspm=off" workaround as well.
> 
> I don't see this problem, and haven't tried to reproduce it yet.
> 
> Mani told me I needed to add these lines to ensure the "runtime
> PM hierarchy of PCIe chain" won't be "broken":
> 
> 	pm_runtime_set_active()
> 	pm_runtime_no_callbacks()
> 	devm_pm_runtime_enable()
> 
> Just out of curiosity, could you try with those lines added
> just before these assignments in k1_pcie_probe()?
> 
> 	k1->pci.dev = dev;
> 	k1->pci.ops = &k1_pcie_ops;
> 	dw_pcie_cap_set(&k1->pci, REQ_RES);
> 
> I doubt it will fix what you're seeing, but at the moment I'm
> working on something else.

Unfortunately there is no difference with the runtime PM hierarchy
additions.

JE


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Johannes Erdfelt <johannes@erdfelt.com>
To: Alex Elder <elder@riscstar.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	bhelgaas@google.com, lpieralisi@kernel.org,
	kwilczynski@kernel.org, mani@kernel.org, vkoul@kernel.org,
	kishon@kernel.org, dlan@gentoo.org, guodong@riscstar.com,
	pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu,
	alex@ghiti.fr, p.zabel@pengutronix.de,
	christian.bruel@foss.st.com, shradha.t@samsung.com,
	krishna.chundru@oss.qualcomm.com, qiang.yu@oss.qualcomm.com,
	namcao@linutronix.de, thippeswamy.havalige@amd.com,
	inochiama@gmail.com, devicetree@vger.kernel.org,
	linux-pci@vger.kernel.org, linux-phy@lists.infradead.org,
	spacemit@lists.linux.dev, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/7] Introduce SpacemiT K1 PCIe phy and host controller
Date: Tue, 28 Oct 2025 13:48:32 -0700	[thread overview]
Message-ID: <20251028204832.GN15521@sventech.com> (raw)
In-Reply-To: <82848c80-15e0-4c0e-a3f6-821a7f4778a5@riscstar.com>

On Tue, Oct 28, 2025, Alex Elder <elder@riscstar.com> wrote:
> On 10/28/25 1:42 PM, Johannes Erdfelt wrote:
> > I have been testing this patchset recently as well, but on an Orange Pi
> > RV2 board instead (and an extra RV2 specific patch to enable power to
> > the M.2 slot).
> > 
> > I ran into the same symptoms you had ("QID 0 timeout" after about 60
> > seconds). However, I'm using an Intel 600p. I can confirm my NVME drive
> > seems to work fine with the "pcie_aspm=off" workaround as well.
> 
> I don't see this problem, and haven't tried to reproduce it yet.
> 
> Mani told me I needed to add these lines to ensure the "runtime
> PM hierarchy of PCIe chain" won't be "broken":
> 
> 	pm_runtime_set_active()
> 	pm_runtime_no_callbacks()
> 	devm_pm_runtime_enable()
> 
> Just out of curiosity, could you try with those lines added
> just before these assignments in k1_pcie_probe()?
> 
> 	k1->pci.dev = dev;
> 	k1->pci.ops = &k1_pcie_ops;
> 	dw_pcie_cap_set(&k1->pci, REQ_RES);
> 
> I doubt it will fix what you're seeing, but at the moment I'm
> working on something else.

Unfortunately there is no difference with the runtime PM hierarchy
additions.

JE


WARNING: multiple messages have this Message-ID (diff)
From: Johannes Erdfelt <johannes@erdfelt.com>
To: Alex Elder <elder@riscstar.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	bhelgaas@google.com, lpieralisi@kernel.org,
	kwilczynski@kernel.org, mani@kernel.org, vkoul@kernel.org,
	kishon@kernel.org, dlan@gentoo.org, guodong@riscstar.com,
	pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu,
	alex@ghiti.fr, p.zabel@pengutronix.de,
	christian.bruel@foss.st.com, shradha.t@samsung.com,
	krishna.chundru@oss.qualcomm.com, qiang.yu@oss.qualcomm.com,
	namcao@linutronix.de, thippeswamy.havalige@amd.com,
	inochiama@gmail.com, devicetree@vger.kernel.org,
	linux-pci@vger.kernel.org, linux-phy@lists.infradead.org,
	spacemit@lists.linux.dev, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/7] Introduce SpacemiT K1 PCIe phy and host controller
Date: Tue, 28 Oct 2025 13:48:32 -0700	[thread overview]
Message-ID: <20251028204832.GN15521@sventech.com> (raw)
In-Reply-To: <82848c80-15e0-4c0e-a3f6-821a7f4778a5@riscstar.com>

On Tue, Oct 28, 2025, Alex Elder <elder@riscstar.com> wrote:
> On 10/28/25 1:42 PM, Johannes Erdfelt wrote:
> > I have been testing this patchset recently as well, but on an Orange Pi
> > RV2 board instead (and an extra RV2 specific patch to enable power to
> > the M.2 slot).
> > 
> > I ran into the same symptoms you had ("QID 0 timeout" after about 60
> > seconds). However, I'm using an Intel 600p. I can confirm my NVME drive
> > seems to work fine with the "pcie_aspm=off" workaround as well.
> 
> I don't see this problem, and haven't tried to reproduce it yet.
> 
> Mani told me I needed to add these lines to ensure the "runtime
> PM hierarchy of PCIe chain" won't be "broken":
> 
> 	pm_runtime_set_active()
> 	pm_runtime_no_callbacks()
> 	devm_pm_runtime_enable()
> 
> Just out of curiosity, could you try with those lines added
> just before these assignments in k1_pcie_probe()?
> 
> 	k1->pci.dev = dev;
> 	k1->pci.ops = &k1_pcie_ops;
> 	dw_pcie_cap_set(&k1->pci, REQ_RES);
> 
> I doubt it will fix what you're seeing, but at the moment I'm
> working on something else.

Unfortunately there is no difference with the runtime PM hierarchy
additions.

JE


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2025-10-28 20:48 UTC|newest]

Thread overview: 120+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-13 15:35 [PATCH v2 0/7] Introduce SpacemiT K1 PCIe phy and host controller Alex Elder
2025-10-13 15:35 ` Alex Elder
2025-10-13 15:35 ` Alex Elder
2025-10-13 15:35 ` [PATCH v2 1/7] dt-bindings: phy: spacemit: add SpacemiT PCIe/combo PHY Alex Elder
2025-10-13 15:35   ` Alex Elder
2025-10-13 15:35   ` Alex Elder
2025-10-15 14:52   ` Rob Herring
2025-10-15 14:52     ` Rob Herring
2025-10-15 14:52     ` Rob Herring
2025-10-17 16:20     ` Alex Elder
2025-10-17 16:20       ` Alex Elder
2025-10-17 16:20       ` Alex Elder
2025-10-13 15:35 ` [PATCH v2 2/7] dt-bindings: phy: spacemit: introduce PCIe PHY Alex Elder
2025-10-13 15:35   ` Alex Elder
2025-10-13 15:35   ` Alex Elder
2025-10-15 16:41   ` Rob Herring (Arm)
2025-10-15 16:41     ` Rob Herring (Arm)
2025-10-15 16:41     ` Rob Herring (Arm)
2025-10-17 16:20     ` Alex Elder
2025-10-17 16:20       ` Alex Elder
2025-10-17 16:20       ` Alex Elder
2025-10-13 15:35 ` [PATCH v2 3/7] dt-bindings: pci: spacemit: introduce PCIe host controller Alex Elder
2025-10-13 15:35   ` Alex Elder
2025-10-13 15:35   ` Alex Elder
2025-10-14  1:55   ` Yao Zi
2025-10-14  1:55     ` Yao Zi
2025-10-14  1:55     ` Yao Zi
2025-10-14  1:57     ` Alex Elder
2025-10-14  1:57       ` Alex Elder
2025-10-14  1:57       ` Alex Elder
2025-10-15 16:47   ` Rob Herring
2025-10-15 16:47     ` Rob Herring
2025-10-15 16:47     ` Rob Herring
2025-10-17 16:20     ` Alex Elder
2025-10-17 16:20       ` Alex Elder
2025-10-17 16:20       ` Alex Elder
2025-10-26 16:38   ` Manivannan Sadhasivam
2025-10-26 16:38     ` Manivannan Sadhasivam
2025-10-26 16:38     ` Manivannan Sadhasivam
2025-10-27 22:24     ` Alex Elder
2025-10-27 22:24       ` Alex Elder
2025-10-27 22:24       ` Alex Elder
2025-10-28  5:58       ` Manivannan Sadhasivam
2025-10-28  5:58         ` Manivannan Sadhasivam
2025-10-28  5:58         ` Manivannan Sadhasivam
2025-10-30  0:10         ` Alex Elder
2025-10-30  0:10           ` Alex Elder
2025-10-30  0:10           ` Alex Elder
2025-10-13 15:35 ` [PATCH v2 4/7] phy: spacemit: introduce PCIe/combo PHY Alex Elder
2025-10-13 15:35   ` Alex Elder
2025-10-13 15:35   ` Alex Elder
2025-10-15 21:51   ` Aurelien Jarno
2025-10-15 21:51     ` Aurelien Jarno
2025-10-15 21:51     ` Aurelien Jarno
2025-10-17 16:21     ` Alex Elder
2025-10-17 16:21       ` Alex Elder
2025-10-17 16:21       ` Alex Elder
2025-10-13 15:35 ` [PATCH v2 5/7] PCI: spacemit: introduce SpacemiT PCIe host driver Alex Elder
2025-10-13 15:35   ` Alex Elder
2025-10-13 15:35   ` Alex Elder
2025-10-26 16:55   ` Manivannan Sadhasivam
2025-10-26 16:55     ` Manivannan Sadhasivam
2025-10-26 16:55     ` Manivannan Sadhasivam
2025-10-27 22:24     ` Alex Elder
2025-10-27 22:24       ` Alex Elder
2025-10-27 22:24       ` Alex Elder
2025-10-28  7:06       ` Manivannan Sadhasivam
2025-10-28  7:06         ` Manivannan Sadhasivam
2025-10-28  7:06         ` Manivannan Sadhasivam
2025-10-30  0:10         ` Alex Elder
2025-10-30  0:10           ` Alex Elder
2025-10-30  0:10           ` Alex Elder
2025-10-31  6:05           ` Manivannan Sadhasivam
2025-10-31  6:05             ` Manivannan Sadhasivam
2025-10-31  6:05             ` Manivannan Sadhasivam
2025-10-31 13:38             ` Alex Elder
2025-10-31 13:38               ` Alex Elder
2025-10-31 13:38               ` Alex Elder
2025-10-13 15:35 ` [PATCH v2 6/7] riscv: dts: spacemit: add a PCIe regulator Alex Elder
2025-10-13 15:35   ` Alex Elder
2025-10-13 15:35   ` Alex Elder
2025-10-13 15:35 ` [PATCH v2 7/7] riscv: dts: spacemit: PCIe and PHY-related updates Alex Elder
2025-10-13 15:35   ` Alex Elder
2025-10-13 15:35   ` Alex Elder
2025-10-16 16:47 ` [PATCH v2 0/7] Introduce SpacemiT K1 PCIe phy and host controller Aurelien Jarno
2025-10-16 16:47   ` Aurelien Jarno
2025-10-16 16:47   ` Aurelien Jarno
2025-10-17 16:21   ` Alex Elder
2025-10-17 16:21     ` Alex Elder
2025-10-17 16:21     ` Alex Elder
2025-10-28 17:59     ` Aurelien Jarno
2025-10-28 17:59       ` Aurelien Jarno
2025-10-28 17:59       ` Aurelien Jarno
2025-10-28 18:42       ` Johannes Erdfelt
2025-10-28 18:42         ` Johannes Erdfelt
2025-10-28 18:42         ` Johannes Erdfelt
2025-10-28 19:10         ` Alex Elder
2025-10-28 19:10           ` Alex Elder
2025-10-28 19:10           ` Alex Elder
2025-10-28 20:48           ` Johannes Erdfelt [this message]
2025-10-28 20:48             ` Johannes Erdfelt
2025-10-28 20:48             ` Johannes Erdfelt
2025-10-28 20:49             ` Alex Elder
2025-10-28 20:49               ` Alex Elder
2025-10-28 20:49               ` Alex Elder
2025-10-30 16:41             ` Manivannan Sadhasivam
2025-10-30 16:41               ` Manivannan Sadhasivam
2025-10-30 16:41               ` Manivannan Sadhasivam
2025-10-30 17:49               ` Aurelien Jarno
2025-10-30 17:49                 ` Aurelien Jarno
2025-10-30 17:49                 ` Aurelien Jarno
2025-10-31  6:10                 ` Manivannan Sadhasivam
2025-10-31  6:10                   ` Manivannan Sadhasivam
2025-10-31  6:10                   ` Manivannan Sadhasivam
2025-11-03 16:42                   ` Alex Elder
2025-11-03 16:42                     ` Alex Elder
2025-11-03 16:42                     ` Alex Elder
2025-10-28 21:08           ` Aurelien Jarno
2025-10-28 21:08             ` Aurelien Jarno
2025-10-28 21:08             ` Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251028204832.GN15521@sventech.com \
    --to=johannes@erdfelt.com \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=bhelgaas@google.com \
    --cc=christian.bruel@foss.st.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlan@gentoo.org \
    --cc=elder@riscstar.com \
    --cc=guodong@riscstar.com \
    --cc=inochiama@gmail.com \
    --cc=kishon@kernel.org \
    --cc=krishna.chundru@oss.qualcomm.com \
    --cc=krzk+dt@kernel.org \
    --cc=kwilczynski@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=namcao@linutronix.de \
    --cc=p.zabel@pengutronix.de \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=qiang.yu@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=shradha.t@samsung.com \
    --cc=spacemit@lists.linux.dev \
    --cc=thippeswamy.havalige@amd.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.