Re: [PATCH 04/10] xfs: move struct xfs_log_iovec to xfs_log_priv.h

["Darrick J. Wong" <djwong@kernel.org>]

On Thu, Oct 30, 2025 at 03:49:14PM +0100, Christoph Hellwig wrote:
> This structure is now only used by the core logging and CIL code.
> 
> Also remove the unused typedef.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

wooo, -typedef
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  fs/xfs/libxfs/xfs_log_format.h | 7 -------
>  fs/xfs/xfs_log_priv.h          | 6 ++++++
>  2 files changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/fs/xfs/libxfs/xfs_log_format.h b/fs/xfs/libxfs/xfs_log_format.h
> index 908e7060428c..3f5a24dda907 100644
> --- a/fs/xfs/libxfs/xfs_log_format.h
> +++ b/fs/xfs/libxfs/xfs_log_format.h
> @@ -184,13 +184,6 @@ struct xlog_rec_header {
>  #define XLOG_REC_SIZE_OTHER	offsetofend(struct xlog_rec_header, h_size)
>  #endif /* __i386__ */
>  
> -/* not an on-disk structure, but needed by log recovery in userspace */
> -struct xfs_log_iovec {
> -	void		*i_addr;	/* beginning address of region */
> -	int		i_len;		/* length in bytes of region */
> -	uint		i_type;		/* type of region */
> -};
> -
>  /*
>   * Transaction Header definitions.
>   *
> diff --git a/fs/xfs/xfs_log_priv.h b/fs/xfs/xfs_log_priv.h
> index d2410e78b7f5..b7b3f61aa2ae 100644
> --- a/fs/xfs/xfs_log_priv.h
> +++ b/fs/xfs/xfs_log_priv.h
> @@ -13,6 +13,12 @@ struct xlog;
>  struct xlog_ticket;
>  struct xfs_mount;
>  
> +struct xfs_log_iovec {
> +	void			*i_addr;/* beginning address of region */
> +	int			i_len;	/* length in bytes of region */
> +	uint			i_type;	/* type of region */
> +};
> +
>  /*
>   * get client id from packed copy.
>   *
> -- 
> 2.47.3
> 
>