Re: [PATCH 05/10] xfs: move struct xfs_log_vec to xfs_log_priv.h

["Darrick J. Wong" <djwong@kernel.org>]

On Thu, Oct 30, 2025 at 03:49:15PM +0100, Christoph Hellwig wrote:
> The log_vec is a private type for the log/CIL code and should not be
> exposed to anything else.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  fs/xfs/xfs_log.h      | 12 ------------
>  fs/xfs/xfs_log_priv.h | 12 ++++++++++++
>  2 files changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/fs/xfs/xfs_log.h b/fs/xfs/xfs_log.h
> index c4930e925fed..0f23812b0b31 100644
> --- a/fs/xfs/xfs_log.h
> +++ b/fs/xfs/xfs_log.h
> @@ -9,18 +9,6 @@
>  struct xlog_format_buf;
>  struct xfs_cil_ctx;
>  
> -struct xfs_log_vec {
> -	struct list_head	lv_list;	/* CIL lv chain ptrs */
> -	uint32_t		lv_order_id;	/* chain ordering info */
> -	int			lv_niovecs;	/* number of iovecs in lv */
> -	struct xfs_log_iovec	*lv_iovecp;	/* iovec array */
> -	struct xfs_log_item	*lv_item;	/* owner */
> -	char			*lv_buf;	/* formatted buffer */
> -	int			lv_bytes;	/* accounted space in buffer */
> -	int			lv_buf_used;	/* buffer space used so far */
> -	int			lv_alloc_size;	/* size of allocated lv */
> -};
> -
>  /* Region types for iovec's i_type */
>  #define XLOG_REG_TYPE_BFORMAT		1
>  #define XLOG_REG_TYPE_BCHUNK		2
> diff --git a/fs/xfs/xfs_log_priv.h b/fs/xfs/xfs_log_priv.h
> index b7b3f61aa2ae..cf1e4ce61a8c 100644
> --- a/fs/xfs/xfs_log_priv.h
> +++ b/fs/xfs/xfs_log_priv.h
> @@ -19,6 +19,18 @@ struct xfs_log_iovec {
>  	uint			i_type;	/* type of region */
>  };
>  
> +struct xfs_log_vec {
> +	struct list_head	lv_list;	/* CIL lv chain ptrs */
> +	uint32_t		lv_order_id;	/* chain ordering info */
> +	int			lv_niovecs;	/* number of iovecs in lv */
> +	struct xfs_log_iovec	*lv_iovecp;	/* iovec array */
> +	struct xfs_log_item	*lv_item;	/* owner */
> +	char			*lv_buf;	/* formatted buffer */
> +	int			lv_bytes;	/* accounted space in buffer */
> +	int			lv_buf_used;	/* buffer space used so far */
> +	int			lv_alloc_size;	/* size of allocated lv */
> +};
> +
>  /*
>   * get client id from packed copy.
>   *
> -- 
> 2.47.3
> 
>