Re: [Patch v3 1/2] mm/huge_memory: introduce enum split_type for clarity

[Wei Yang <richard.weiyang@gmail.com>]

On Thu, Nov 06, 2025 at 11:17:00AM +0100, David Hildenbrand (Red Hat) wrote:
>On 06.11.25 04:41, Wei Yang wrote:
>> We currently handle two distinct types of large folio splitting:
>>    * uniform split
>>    * non-uniform split
>> 
>> Differentiating between these types using a simple boolean variable is
>> not obvious and can harm code readability.
>> 
>> This commit introduces enum split_type to explicitly define these two
>> types. Replacing the existing boolean variable with this enumeration
>> significantly improves code clarity and expressiveness when dealing with
>> folio splitting logic.
>> 
>> No functional change is expected.
>> 
>> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
>> Cc: Zi Yan <ziy@nvidia.com>
>> Cc: "David Hildenbrand (Red Hat)" <david@kernel.org>
>> ---
>
>...
>
>>   		 * Unfreeze after-split folios and put them back to the right
>> @@ -4149,8 +4149,8 @@ int __split_huge_page_to_list_to_order(struct page *page, struct list_head *list
>>   {
>>   	struct folio *folio = page_folio(page);
>> -	return __folio_split(folio, new_order, &folio->page, page, list, true,
>> -				unmapped);
>> +	return __folio_split(folio, new_order, &folio->page, page, list,
>> +				SPLIT_TYPE_UNIFORM, unmapped);
>>   }
>>   /**
>> @@ -4181,7 +4181,7 @@ int folio_split(struct folio *folio, unsigned int new_order,
>>   		struct page *split_at, struct list_head *list)
>>   {
>>   	return __folio_split(folio, new_order, split_at, &folio->page, list,
>> -			false, false);
>> +				SPLIT_TYPE_NON_UNIFORM, false);
>
>Looks like both these are not properly aligned.
>
>Should be
>
>return __folio_split(folio, new_order, split_at, &folio->page, list,
>		     SPLIT_TYPE_NON_UNIFORM, false);
>

Thanks.

@Andrew

Would you mind helping adjust this :-)

>
>Thanks!
>
>Acked-by: David Hildenbrand (Red Hat) <david@kernel.org>
>
>-- 
>Cheers
>
>David

-- 
Wei Yang
Help you, Help me