* [PATCH v3 0/2] riscv: spacemit: initial support for OrangePi R2S @ 2025-11-10 22:06 ` michael.opdenacker 0 siblings, 0 replies; 20+ messages in thread From: michael.opdenacker @ 2025-11-10 22:06 UTC (permalink / raw) To: Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Yixun Lan Cc: Michael Opdenacker, linux-riscv, spacemit From: Michael Opdenacker <michael.opdenacker@rootcommit.com> This adds initial support for the OrangePi R2S board [1], which is marketed as using the Ky X1 SoC but is in fact identical to the SpacemiT K1 SoC [2]. What makes this board attractive is its 4 Ethernet ports (2 x Gigagit RGMII with an external Motorcomm YT8531C PHY, and 2 x 2.5 Gigabit Ethernet with RTL8125BG on an internal PCI Express bus), its small form factor and its attractive pricing like other OrangePi boards. What is supported: - Serial console on serial UART - 8 GB eMMC - 2x Gigabit RGMII Ethernet ports This patch series is based on Spacemit's Linux tree, "linux-for-next" branch [3] Link: http://www.orangepi.org/html/hardWare/computerAndMicrocontrollers/details/Orange-Pi-R2S.html [1] Link: https://www.spacemit.com/en/key-stone-k1 [2] Link: https://github.com/spacemit-com/linux/commits/k1/dt-for-next [3] Changes in V3 - DT bindings: insert new compatible string in alphanumeric order (feedback from Krzysztof Kozlowski) - OrangePi R2S: remove useless description text in commit message (feedback from Yixun Lan) Changes in V2 - Squash 3 commits for initial DTS, Ethernet & PDMA, and eMMC ========== eMMC tests ========== Read tests ---------- hdparm -t --direct /dev/mmcblk0 /dev/mmcblk0: Timing O_DIRECT disk reads: 846 MB in 3.01 seconds = 281.52 MB/sec Write tests ----------- dd if=/dev/zero of=/dev/mmcblk0p2 bs=4M oflag=direct status=progress 7600078848 bytes (7.6 GB, 7.1 GiB) copied, 127 s, 59.8 MB/s dd: error writing '/dev/mmcblk0p2': No space left on device 1825+0 records in 1824+0 records out 7650410496 bytes (7.7 GB, 7.1 GiB) copied, 127.866 s, 59.8 MB/s ============== Ethernet tests ============== Tests on eth0 ------------- root@orangepi-rv2-mainline:~# iperf3 -c 172.24.0.1 Connecting to host 172.24.0.1, port 5201 [ 5] local 172.24.0.2 port 51354 connected to 172.24.0.1 port 5201 [ ID] Interval Transfer Bitrate Retr Cwnd [ 5] 0.00-1.00 sec 113 MBytes 947 Mbits/sec 0 395 KBytes [ 5] 1.00-2.00 sec 113 MBytes 945 Mbits/sec 0 395 KBytes [ 5] 2.00-3.00 sec 112 MBytes 936 Mbits/sec 0 395 KBytes [ 5] 3.00-4.00 sec 112 MBytes 942 Mbits/sec 0 395 KBytes [ 5] 4.00-5.00 sec 112 MBytes 941 Mbits/sec 0 395 KBytes [ 5] 5.00-6.00 sec 112 MBytes 940 Mbits/sec 0 409 KBytes [ 5] 6.00-7.00 sec 113 MBytes 948 Mbits/sec 0 409 KBytes [ 5] 7.00-8.00 sec 112 MBytes 940 Mbits/sec 0 409 KBytes [ 5] 8.00-9.00 sec 112 MBytes 941 Mbits/sec 0 414 KBytes [ 5] 9.00-10.03 sec 113 MBytes 919 Mbits/sec 0 414 KBytes - - - - - - - - - - - - - - - - - - - - - - - - - [ ID] Interval Transfer Bitrate Retr [ 5] 0.00-10.03 sec 1.10 GBytes 940 Mbits/sec 0 sender [ 5] 0.00-10.04 sec 1.10 GBytes 939 Mbits/sec receiver iperf Done. root@orangepi-rv2-mainline:~# iperf3 -s ----------------------------------------------------------- Server listening on 5201 (test #1) ----------------------------------------------------------- Accepted connection from 172.24.0.1, port 38326 [ 5] local 172.24.0.2 port 5201 connected to 172.24.0.1 port 38332 [ ID] Interval Transfer Bitrate [ 5] 0.00-1.00 sec 112 MBytes 935 Mbits/sec [ 5] 1.00-2.00 sec 112 MBytes 942 Mbits/sec [ 5] 2.00-3.00 sec 112 MBytes 941 Mbits/sec [ 5] 3.00-4.00 sec 112 MBytes 941 Mbits/sec [ 5] 4.00-5.00 sec 112 MBytes 942 Mbits/sec [ 5] 5.00-6.00 sec 112 MBytes 942 Mbits/sec [ 5] 6.00-7.00 sec 112 MBytes 942 Mbits/sec [ 5] 7.00-8.00 sec 112 MBytes 942 Mbits/sec [ 5] 8.00-9.00 sec 112 MBytes 941 Mbits/sec [ 5] 9.00-10.00 sec 112 MBytes 943 Mbits/sec [ 5] 10.00-10.01 sec 384 KBytes 725 Mbits/sec - - - - - - - - - - - - - - - - - - - - - - - - - [ ID] Interval Transfer Bitrate [ 5] 0.00-10.01 sec 1.10 GBytes 941 Mbits/sec receiver Tests on eth1 ------------------ root@orangepi-rv2-mainline:~# iperf3 -c 172.24.0.1 Connecting to host 172.24.0.1, port 5201 [ 5] local 172.24.0.2 port 60564 connected to 172.24.0.1 port 5201 [ ID] Interval Transfer Bitrate Retr Cwnd [ 5] 0.00-1.00 sec 113 MBytes 947 Mbits/sec 0 423 KBytes [ 5] 1.00-2.00 sec 113 MBytes 945 Mbits/sec 0 423 KBytes [ 5] 2.00-3.00 sec 112 MBytes 943 Mbits/sec 0 423 KBytes [ 5] 3.00-4.00 sec 112 MBytes 938 Mbits/sec 0 423 KBytes [ 5] 4.00-5.00 sec 112 MBytes 944 Mbits/sec 0 423 KBytes [ 5] 5.00-6.00 sec 112 MBytes 936 Mbits/sec 0 423 KBytes [ 5] 6.00-7.00 sec 112 MBytes 943 Mbits/sec 0 423 KBytes [ 5] 7.00-8.00 sec 112 MBytes 940 Mbits/sec 0 423 KBytes [ 5] 8.00-9.00 sec 113 MBytes 951 Mbits/sec 0 639 KBytes [ 5] 9.00-10.01 sec 112 MBytes 934 Mbits/sec 0 639 KBytes - - - - - - - - - - - - - - - - - - - - - - - - - [ ID] Interval Transfer Bitrate Retr [ 5] 0.00-10.01 sec 1.10 GBytes 943 Mbits/sec 0 sender [ 5] 0.00-10.02 sec 1.10 GBytes 940 Mbits/sec receiver iperf Done. root@orangepi-rv2-mainline:~# iperf3 -s 172.24.0.1 ----------------------------------------------------------- Server listening on 5201 (test #1) ----------------------------------------------------------- Accepted connection from 172.24.0.1, port 49628 [ 5] local 172.24.0.2 port 5201 connected to 172.24.0.1 port 49640 [ ID] Interval Transfer Bitrate [ 5] 0.00-1.00 sec 112 MBytes 934 Mbits/sec [ 5] 1.00-2.00 sec 112 MBytes 942 Mbits/sec [ 5] 2.00-3.00 sec 112 MBytes 942 Mbits/sec [ 5] 3.00-4.00 sec 112 MBytes 942 Mbits/sec [ 5] 4.00-5.00 sec 112 MBytes 941 Mbits/sec [ 5] 5.00-6.00 sec 112 MBytes 942 Mbits/sec [ 5] 6.00-7.00 sec 112 MBytes 942 Mbits/sec [ 5] 7.00-8.00 sec 112 MBytes 942 Mbits/sec [ 5] 8.00-9.00 sec 112 MBytes 942 Mbits/sec [ 5] 9.00-10.00 sec 112 MBytes 941 Mbits/sec [ 5] 10.00-10.01 sec 640 KBytes 1.14 Gbits/sec - - - - - - - - - - - - - - - - - - - - - - - - - [ ID] Interval Transfer Bitrate [ 5] 0.00-10.01 sec 1.10 GBytes 941 Mbits/sec receiver Michael Opdenacker (2): dt-bindings: riscv: spacemit: Add OrangePi R2S board riscv: dts: spacemit: Add OrangePi R2S board device tree .../devicetree/bindings/riscv/spacemit.yaml | 1 + arch/riscv/boot/dts/spacemit/Makefile | 1 + .../boot/dts/spacemit/k1-orangepi-r2s.dts | 90 +++++++++++++++++++ 3 files changed, 92 insertions(+) create mode 100644 arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v3 0/2] riscv: spacemit: initial support for OrangePi R2S @ 2025-11-10 22:06 ` michael.opdenacker 0 siblings, 0 replies; 20+ messages in thread From: michael.opdenacker @ 2025-11-10 22:06 UTC (permalink / raw) To: Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Yixun Lan Cc: Michael Opdenacker, linux-riscv, spacemit From: Michael Opdenacker <michael.opdenacker@rootcommit.com> This adds initial support for the OrangePi R2S board [1], which is marketed as using the Ky X1 SoC but is in fact identical to the SpacemiT K1 SoC [2]. What makes this board attractive is its 4 Ethernet ports (2 x Gigagit RGMII with an external Motorcomm YT8531C PHY, and 2 x 2.5 Gigabit Ethernet with RTL8125BG on an internal PCI Express bus), its small form factor and its attractive pricing like other OrangePi boards. What is supported: - Serial console on serial UART - 8 GB eMMC - 2x Gigabit RGMII Ethernet ports This patch series is based on Spacemit's Linux tree, "linux-for-next" branch [3] Link: http://www.orangepi.org/html/hardWare/computerAndMicrocontrollers/details/Orange-Pi-R2S.html [1] Link: https://www.spacemit.com/en/key-stone-k1 [2] Link: https://github.com/spacemit-com/linux/commits/k1/dt-for-next [3] Changes in V3 - DT bindings: insert new compatible string in alphanumeric order (feedback from Krzysztof Kozlowski) - OrangePi R2S: remove useless description text in commit message (feedback from Yixun Lan) Changes in V2 - Squash 3 commits for initial DTS, Ethernet & PDMA, and eMMC ========== eMMC tests ========== Read tests ---------- hdparm -t --direct /dev/mmcblk0 /dev/mmcblk0: Timing O_DIRECT disk reads: 846 MB in 3.01 seconds = 281.52 MB/sec Write tests ----------- dd if=/dev/zero of=/dev/mmcblk0p2 bs=4M oflag=direct status=progress 7600078848 bytes (7.6 GB, 7.1 GiB) copied, 127 s, 59.8 MB/s dd: error writing '/dev/mmcblk0p2': No space left on device 1825+0 records in 1824+0 records out 7650410496 bytes (7.7 GB, 7.1 GiB) copied, 127.866 s, 59.8 MB/s ============== Ethernet tests ============== Tests on eth0 ------------- root@orangepi-rv2-mainline:~# iperf3 -c 172.24.0.1 Connecting to host 172.24.0.1, port 5201 [ 5] local 172.24.0.2 port 51354 connected to 172.24.0.1 port 5201 [ ID] Interval Transfer Bitrate Retr Cwnd [ 5] 0.00-1.00 sec 113 MBytes 947 Mbits/sec 0 395 KBytes [ 5] 1.00-2.00 sec 113 MBytes 945 Mbits/sec 0 395 KBytes [ 5] 2.00-3.00 sec 112 MBytes 936 Mbits/sec 0 395 KBytes [ 5] 3.00-4.00 sec 112 MBytes 942 Mbits/sec 0 395 KBytes [ 5] 4.00-5.00 sec 112 MBytes 941 Mbits/sec 0 395 KBytes [ 5] 5.00-6.00 sec 112 MBytes 940 Mbits/sec 0 409 KBytes [ 5] 6.00-7.00 sec 113 MBytes 948 Mbits/sec 0 409 KBytes [ 5] 7.00-8.00 sec 112 MBytes 940 Mbits/sec 0 409 KBytes [ 5] 8.00-9.00 sec 112 MBytes 941 Mbits/sec 0 414 KBytes [ 5] 9.00-10.03 sec 113 MBytes 919 Mbits/sec 0 414 KBytes - - - - - - - - - - - - - - - - - - - - - - - - - [ ID] Interval Transfer Bitrate Retr [ 5] 0.00-10.03 sec 1.10 GBytes 940 Mbits/sec 0 sender [ 5] 0.00-10.04 sec 1.10 GBytes 939 Mbits/sec receiver iperf Done. root@orangepi-rv2-mainline:~# iperf3 -s ----------------------------------------------------------- Server listening on 5201 (test #1) ----------------------------------------------------------- Accepted connection from 172.24.0.1, port 38326 [ 5] local 172.24.0.2 port 5201 connected to 172.24.0.1 port 38332 [ ID] Interval Transfer Bitrate [ 5] 0.00-1.00 sec 112 MBytes 935 Mbits/sec [ 5] 1.00-2.00 sec 112 MBytes 942 Mbits/sec [ 5] 2.00-3.00 sec 112 MBytes 941 Mbits/sec [ 5] 3.00-4.00 sec 112 MBytes 941 Mbits/sec [ 5] 4.00-5.00 sec 112 MBytes 942 Mbits/sec [ 5] 5.00-6.00 sec 112 MBytes 942 Mbits/sec [ 5] 6.00-7.00 sec 112 MBytes 942 Mbits/sec [ 5] 7.00-8.00 sec 112 MBytes 942 Mbits/sec [ 5] 8.00-9.00 sec 112 MBytes 941 Mbits/sec [ 5] 9.00-10.00 sec 112 MBytes 943 Mbits/sec [ 5] 10.00-10.01 sec 384 KBytes 725 Mbits/sec - - - - - - - - - - - - - - - - - - - - - - - - - [ ID] Interval Transfer Bitrate [ 5] 0.00-10.01 sec 1.10 GBytes 941 Mbits/sec receiver Tests on eth1 ------------------ root@orangepi-rv2-mainline:~# iperf3 -c 172.24.0.1 Connecting to host 172.24.0.1, port 5201 [ 5] local 172.24.0.2 port 60564 connected to 172.24.0.1 port 5201 [ ID] Interval Transfer Bitrate Retr Cwnd [ 5] 0.00-1.00 sec 113 MBytes 947 Mbits/sec 0 423 KBytes [ 5] 1.00-2.00 sec 113 MBytes 945 Mbits/sec 0 423 KBytes [ 5] 2.00-3.00 sec 112 MBytes 943 Mbits/sec 0 423 KBytes [ 5] 3.00-4.00 sec 112 MBytes 938 Mbits/sec 0 423 KBytes [ 5] 4.00-5.00 sec 112 MBytes 944 Mbits/sec 0 423 KBytes [ 5] 5.00-6.00 sec 112 MBytes 936 Mbits/sec 0 423 KBytes [ 5] 6.00-7.00 sec 112 MBytes 943 Mbits/sec 0 423 KBytes [ 5] 7.00-8.00 sec 112 MBytes 940 Mbits/sec 0 423 KBytes [ 5] 8.00-9.00 sec 113 MBytes 951 Mbits/sec 0 639 KBytes [ 5] 9.00-10.01 sec 112 MBytes 934 Mbits/sec 0 639 KBytes - - - - - - - - - - - - - - - - - - - - - - - - - [ ID] Interval Transfer Bitrate Retr [ 5] 0.00-10.01 sec 1.10 GBytes 943 Mbits/sec 0 sender [ 5] 0.00-10.02 sec 1.10 GBytes 940 Mbits/sec receiver iperf Done. root@orangepi-rv2-mainline:~# iperf3 -s 172.24.0.1 ----------------------------------------------------------- Server listening on 5201 (test #1) ----------------------------------------------------------- Accepted connection from 172.24.0.1, port 49628 [ 5] local 172.24.0.2 port 5201 connected to 172.24.0.1 port 49640 [ ID] Interval Transfer Bitrate [ 5] 0.00-1.00 sec 112 MBytes 934 Mbits/sec [ 5] 1.00-2.00 sec 112 MBytes 942 Mbits/sec [ 5] 2.00-3.00 sec 112 MBytes 942 Mbits/sec [ 5] 3.00-4.00 sec 112 MBytes 942 Mbits/sec [ 5] 4.00-5.00 sec 112 MBytes 941 Mbits/sec [ 5] 5.00-6.00 sec 112 MBytes 942 Mbits/sec [ 5] 6.00-7.00 sec 112 MBytes 942 Mbits/sec [ 5] 7.00-8.00 sec 112 MBytes 942 Mbits/sec [ 5] 8.00-9.00 sec 112 MBytes 942 Mbits/sec [ 5] 9.00-10.00 sec 112 MBytes 941 Mbits/sec [ 5] 10.00-10.01 sec 640 KBytes 1.14 Gbits/sec - - - - - - - - - - - - - - - - - - - - - - - - - [ ID] Interval Transfer Bitrate [ 5] 0.00-10.01 sec 1.10 GBytes 941 Mbits/sec receiver Michael Opdenacker (2): dt-bindings: riscv: spacemit: Add OrangePi R2S board riscv: dts: spacemit: Add OrangePi R2S board device tree .../devicetree/bindings/riscv/spacemit.yaml | 1 + arch/riscv/boot/dts/spacemit/Makefile | 1 + .../boot/dts/spacemit/k1-orangepi-r2s.dts | 90 +++++++++++++++++++ 3 files changed, 92 insertions(+) create mode 100644 arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v3 1/2] dt-bindings: riscv: spacemit: Add OrangePi R2S board 2025-11-10 22:06 ` michael.opdenacker @ 2025-11-10 22:06 ` michael.opdenacker -1 siblings, 0 replies; 20+ messages in thread From: michael.opdenacker @ 2025-11-10 22:06 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Yixun Lan, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Yangyu Chen Cc: Michael Opdenacker, devicetree, linux-riscv, spacemit, linux-kernel From: Michael Opdenacker <michael.opdenacker@rootcommit.com> Document the compatible string for the OrangePi R2S board [1], which is marketed as using the Ky X1 SoC but is in fact identical to the SpacemiT K1 SoC [2]. Link: http://www.orangepi.org/html/hardWare/computerAndMicrocontrollers/details/Orange-Pi-R2S.html [1] Link: https://www.spacemit.com/en/key-stone-k1 [2] Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com> --- Documentation/devicetree/bindings/riscv/spacemit.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/riscv/spacemit.yaml b/Documentation/devicetree/bindings/riscv/spacemit.yaml index 52fe39296031..9c49482002f7 100644 --- a/Documentation/devicetree/bindings/riscv/spacemit.yaml +++ b/Documentation/devicetree/bindings/riscv/spacemit.yaml @@ -23,6 +23,7 @@ properties: - bananapi,bpi-f3 - milkv,jupiter - spacemit,musepi-pro + - xunlong,orangepi-r2s - xunlong,orangepi-rv2 - const: spacemit,k1 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH v3 1/2] dt-bindings: riscv: spacemit: Add OrangePi R2S board @ 2025-11-10 22:06 ` michael.opdenacker 0 siblings, 0 replies; 20+ messages in thread From: michael.opdenacker @ 2025-11-10 22:06 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Yixun Lan, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Yangyu Chen Cc: Michael Opdenacker, devicetree, linux-riscv, spacemit, linux-kernel From: Michael Opdenacker <michael.opdenacker@rootcommit.com> Document the compatible string for the OrangePi R2S board [1], which is marketed as using the Ky X1 SoC but is in fact identical to the SpacemiT K1 SoC [2]. Link: http://www.orangepi.org/html/hardWare/computerAndMicrocontrollers/details/Orange-Pi-R2S.html [1] Link: https://www.spacemit.com/en/key-stone-k1 [2] Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com> --- Documentation/devicetree/bindings/riscv/spacemit.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/riscv/spacemit.yaml b/Documentation/devicetree/bindings/riscv/spacemit.yaml index 52fe39296031..9c49482002f7 100644 --- a/Documentation/devicetree/bindings/riscv/spacemit.yaml +++ b/Documentation/devicetree/bindings/riscv/spacemit.yaml @@ -23,6 +23,7 @@ properties: - bananapi,bpi-f3 - milkv,jupiter - spacemit,musepi-pro + - xunlong,orangepi-r2s - xunlong,orangepi-rv2 - const: spacemit,k1 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: riscv: spacemit: Add OrangePi R2S board 2025-11-10 22:06 ` michael.opdenacker @ 2025-11-11 7:43 ` Krzysztof Kozlowski -1 siblings, 0 replies; 20+ messages in thread From: Krzysztof Kozlowski @ 2025-11-11 7:43 UTC (permalink / raw) To: michael.opdenacker Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Yixun Lan, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Yangyu Chen, devicetree, linux-riscv, spacemit, linux-kernel On Mon, Nov 10, 2025 at 10:06:48PM +0000, michael.opdenacker@rootcommit.com wrote: > From: Michael Opdenacker <michael.opdenacker@rootcommit.com> > > Document the compatible string for the OrangePi R2S board [1], which > is marketed as using the Ky X1 SoC but is in fact identical to > the SpacemiT K1 SoC [2]. Different SoC means different compatible. It is very, very unlikely that different vendor made same die, which would warrant same compatible. Identical does not mean the same die, so your explanation is not complete. Best regards, Krzysztof _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: riscv: spacemit: Add OrangePi R2S board @ 2025-11-11 7:43 ` Krzysztof Kozlowski 0 siblings, 0 replies; 20+ messages in thread From: Krzysztof Kozlowski @ 2025-11-11 7:43 UTC (permalink / raw) To: michael.opdenacker Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Yixun Lan, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Yangyu Chen, devicetree, linux-riscv, spacemit, linux-kernel On Mon, Nov 10, 2025 at 10:06:48PM +0000, michael.opdenacker@rootcommit.com wrote: > From: Michael Opdenacker <michael.opdenacker@rootcommit.com> > > Document the compatible string for the OrangePi R2S board [1], which > is marketed as using the Ky X1 SoC but is in fact identical to > the SpacemiT K1 SoC [2]. Different SoC means different compatible. It is very, very unlikely that different vendor made same die, which would warrant same compatible. Identical does not mean the same die, so your explanation is not complete. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: riscv: spacemit: Add OrangePi R2S board 2025-11-11 7:43 ` Krzysztof Kozlowski @ 2025-11-11 10:11 ` Yixun Lan -1 siblings, 0 replies; 20+ messages in thread From: Yixun Lan @ 2025-11-11 10:11 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: michael.opdenacker, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Yangyu Chen, devicetree, linux-riscv, spacemit, linux-kernel Hi Krzysztof, On 08:43 Tue 11 Nov , Krzysztof Kozlowski wrote: > On Mon, Nov 10, 2025 at 10:06:48PM +0000, michael.opdenacker@rootcommit.com wrote: > > From: Michael Opdenacker <michael.opdenacker@rootcommit.com> > > > > Document the compatible string for the OrangePi R2S board [1], which > > is marketed as using the Ky X1 SoC but is in fact identical to Maybe, just say it "same" to clarify the ambiguity? > > the SpacemiT K1 SoC [2]. > > Different SoC means different compatible. It is very, very unlikely that > different vendor made same die, which would warrant same compatible. > Identical does not mean the same die, so your explanation is not > complete. Unfortunately, it's true that Ky X1 is just a rebrand of SpacemiT K1 SoC. I guess it's a marketing strategy although personally I don't know what's the motivation behind and even wish it never happens.. -- Yixun Lan (dlan) _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: riscv: spacemit: Add OrangePi R2S board @ 2025-11-11 10:11 ` Yixun Lan 0 siblings, 0 replies; 20+ messages in thread From: Yixun Lan @ 2025-11-11 10:11 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: michael.opdenacker, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Yangyu Chen, devicetree, linux-riscv, spacemit, linux-kernel Hi Krzysztof, On 08:43 Tue 11 Nov , Krzysztof Kozlowski wrote: > On Mon, Nov 10, 2025 at 10:06:48PM +0000, michael.opdenacker@rootcommit.com wrote: > > From: Michael Opdenacker <michael.opdenacker@rootcommit.com> > > > > Document the compatible string for the OrangePi R2S board [1], which > > is marketed as using the Ky X1 SoC but is in fact identical to Maybe, just say it "same" to clarify the ambiguity? > > the SpacemiT K1 SoC [2]. > > Different SoC means different compatible. It is very, very unlikely that > different vendor made same die, which would warrant same compatible. > Identical does not mean the same die, so your explanation is not > complete. Unfortunately, it's true that Ky X1 is just a rebrand of SpacemiT K1 SoC. I guess it's a marketing strategy although personally I don't know what's the motivation behind and even wish it never happens.. -- Yixun Lan (dlan) ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: riscv: spacemit: Add OrangePi R2S board 2025-11-11 10:11 ` Yixun Lan @ 2025-11-11 10:13 ` Krzysztof Kozlowski -1 siblings, 0 replies; 20+ messages in thread From: Krzysztof Kozlowski @ 2025-11-11 10:13 UTC (permalink / raw) To: Yixun Lan Cc: michael.opdenacker, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Yangyu Chen, devicetree, linux-riscv, spacemit, linux-kernel On 11/11/2025 11:11, Yixun Lan wrote: > Hi Krzysztof, > > On 08:43 Tue 11 Nov , Krzysztof Kozlowski wrote: >> On Mon, Nov 10, 2025 at 10:06:48PM +0000, michael.opdenacker@rootcommit.com wrote: >>> From: Michael Opdenacker <michael.opdenacker@rootcommit.com> >>> >>> Document the compatible string for the OrangePi R2S board [1], which >>> is marketed as using the Ky X1 SoC but is in fact identical to > Maybe, just say it "same" to clarify the ambiguity? What is exactly "same"? Same die? Or same blocks/pieces? Whichever you choose please make it very explicit. Best regards, Krzysztof _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: riscv: spacemit: Add OrangePi R2S board @ 2025-11-11 10:13 ` Krzysztof Kozlowski 0 siblings, 0 replies; 20+ messages in thread From: Krzysztof Kozlowski @ 2025-11-11 10:13 UTC (permalink / raw) To: Yixun Lan Cc: michael.opdenacker, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Yangyu Chen, devicetree, linux-riscv, spacemit, linux-kernel On 11/11/2025 11:11, Yixun Lan wrote: > Hi Krzysztof, > > On 08:43 Tue 11 Nov , Krzysztof Kozlowski wrote: >> On Mon, Nov 10, 2025 at 10:06:48PM +0000, michael.opdenacker@rootcommit.com wrote: >>> From: Michael Opdenacker <michael.opdenacker@rootcommit.com> >>> >>> Document the compatible string for the OrangePi R2S board [1], which >>> is marketed as using the Ky X1 SoC but is in fact identical to > Maybe, just say it "same" to clarify the ambiguity? What is exactly "same"? Same die? Or same blocks/pieces? Whichever you choose please make it very explicit. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: riscv: spacemit: Add OrangePi R2S board 2025-11-11 10:13 ` Krzysztof Kozlowski @ 2025-11-11 10:29 ` Michael Opdenacker -1 siblings, 0 replies; 20+ messages in thread From: Michael Opdenacker @ 2025-11-11 10:29 UTC (permalink / raw) To: Krzysztof Kozlowski, Yixun Lan Cc: michael.opdenacker, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Yangyu Chen, devicetree, linux-riscv, spacemit, linux-kernel, Troy Mitchell Greetings Thanks one more time for the reviews! On 11/11/25 11:13, Krzysztof Kozlowski wrote: > On 11/11/2025 11:11, Yixun Lan wrote: >> Hi Krzysztof, >> >> On 08:43 Tue 11 Nov , Krzysztof Kozlowski wrote: >>> On Mon, Nov 10, 2025 at 10:06:48PM +0000, michael.opdenacker@rootcommit.com wrote: >>>> From: Michael Opdenacker <michael.opdenacker@rootcommit.com> >>>> >>>> Document the compatible string for the OrangePi R2S board [1], which >>>> is marketed as using the Ky X1 SoC but is in fact identical to >> Maybe, just say it "same" to clarify the ambiguity? > What is exactly "same"? Same die? Or same blocks/pieces? Whichever you > choose please make it very explicit. Maybe Troy Mitchell from Spacemit can shed light on this question. Anyway, I could use the same wording as in this commit introducing "OrangePi RV2": https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch?id=bab8dea259100a99e047fd11a48940b229d30031 "The board is described as using the Ky X1 SoC, which, based on available downstream sources and testing, appears to be identical or very closely related to the SpacemiT K1 SoC". What do you think? Cheers, Michael -- Michael Opdenacker Root Commit Yocto Project and OpenEmbedded Training course - Learn by doing: https://rootcommit.com/training/yocto/ _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: riscv: spacemit: Add OrangePi R2S board @ 2025-11-11 10:29 ` Michael Opdenacker 0 siblings, 0 replies; 20+ messages in thread From: Michael Opdenacker @ 2025-11-11 10:29 UTC (permalink / raw) To: Krzysztof Kozlowski, Yixun Lan Cc: michael.opdenacker, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Yangyu Chen, devicetree, linux-riscv, spacemit, linux-kernel, Troy Mitchell Greetings Thanks one more time for the reviews! On 11/11/25 11:13, Krzysztof Kozlowski wrote: > On 11/11/2025 11:11, Yixun Lan wrote: >> Hi Krzysztof, >> >> On 08:43 Tue 11 Nov , Krzysztof Kozlowski wrote: >>> On Mon, Nov 10, 2025 at 10:06:48PM +0000, michael.opdenacker@rootcommit.com wrote: >>>> From: Michael Opdenacker <michael.opdenacker@rootcommit.com> >>>> >>>> Document the compatible string for the OrangePi R2S board [1], which >>>> is marketed as using the Ky X1 SoC but is in fact identical to >> Maybe, just say it "same" to clarify the ambiguity? > What is exactly "same"? Same die? Or same blocks/pieces? Whichever you > choose please make it very explicit. Maybe Troy Mitchell from Spacemit can shed light on this question. Anyway, I could use the same wording as in this commit introducing "OrangePi RV2": https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch?id=bab8dea259100a99e047fd11a48940b229d30031 "The board is described as using the Ky X1 SoC, which, based on available downstream sources and testing, appears to be identical or very closely related to the SpacemiT K1 SoC". What do you think? Cheers, Michael -- Michael Opdenacker Root Commit Yocto Project and OpenEmbedded Training course - Learn by doing: https://rootcommit.com/training/yocto/ ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: riscv: spacemit: Add OrangePi R2S board 2025-11-11 10:29 ` Michael Opdenacker @ 2025-11-11 10:34 ` Krzysztof Kozlowski -1 siblings, 0 replies; 20+ messages in thread From: Krzysztof Kozlowski @ 2025-11-11 10:34 UTC (permalink / raw) To: Michael Opdenacker, Yixun Lan Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Yangyu Chen, devicetree, linux-riscv, spacemit, linux-kernel, Troy Mitchell On 11/11/2025 11:29, Michael Opdenacker wrote: > Greetings > > Thanks one more time for the reviews! > > On 11/11/25 11:13, Krzysztof Kozlowski wrote: >> On 11/11/2025 11:11, Yixun Lan wrote: >>> Hi Krzysztof, >>> >>> On 08:43 Tue 11 Nov , Krzysztof Kozlowski wrote: >>>> On Mon, Nov 10, 2025 at 10:06:48PM +0000, michael.opdenacker@rootcommit.com wrote: >>>>> From: Michael Opdenacker <michael.opdenacker@rootcommit.com> >>>>> >>>>> Document the compatible string for the OrangePi R2S board [1], which >>>>> is marketed as using the Ky X1 SoC but is in fact identical to >>> Maybe, just say it "same" to clarify the ambiguity? >> What is exactly "same"? Same die? Or same blocks/pieces? Whichever you >> choose please make it very explicit. > > Maybe Troy Mitchell from Spacemit can shed light on this question. > > Anyway, I could use the same wording as in this commit introducing > "OrangePi RV2": > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch?id=bab8dea259100a99e047fd11a48940b229d30031 > > "The board is described as using the Ky X1 SoC, which, based on > available downstream sources and testing, appears to be identical or > very closely related to the SpacemiT K1 SoC". > > What do you think? This clearly suggests they are not identical thus you should have also dedicated compatible. Let me then precise, I thought it is obvious, that except writing it more detailed in commit msg, you also need proper binding expressing this. If this is not the same die and they look compatible, then usually it means you need a compatible. Best regards, Krzysztof _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: riscv: spacemit: Add OrangePi R2S board @ 2025-11-11 10:34 ` Krzysztof Kozlowski 0 siblings, 0 replies; 20+ messages in thread From: Krzysztof Kozlowski @ 2025-11-11 10:34 UTC (permalink / raw) To: Michael Opdenacker, Yixun Lan Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Yangyu Chen, devicetree, linux-riscv, spacemit, linux-kernel, Troy Mitchell On 11/11/2025 11:29, Michael Opdenacker wrote: > Greetings > > Thanks one more time for the reviews! > > On 11/11/25 11:13, Krzysztof Kozlowski wrote: >> On 11/11/2025 11:11, Yixun Lan wrote: >>> Hi Krzysztof, >>> >>> On 08:43 Tue 11 Nov , Krzysztof Kozlowski wrote: >>>> On Mon, Nov 10, 2025 at 10:06:48PM +0000, michael.opdenacker@rootcommit.com wrote: >>>>> From: Michael Opdenacker <michael.opdenacker@rootcommit.com> >>>>> >>>>> Document the compatible string for the OrangePi R2S board [1], which >>>>> is marketed as using the Ky X1 SoC but is in fact identical to >>> Maybe, just say it "same" to clarify the ambiguity? >> What is exactly "same"? Same die? Or same blocks/pieces? Whichever you >> choose please make it very explicit. > > Maybe Troy Mitchell from Spacemit can shed light on this question. > > Anyway, I could use the same wording as in this commit introducing > "OrangePi RV2": > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch?id=bab8dea259100a99e047fd11a48940b229d30031 > > "The board is described as using the Ky X1 SoC, which, based on > available downstream sources and testing, appears to be identical or > very closely related to the SpacemiT K1 SoC". > > What do you think? This clearly suggests they are not identical thus you should have also dedicated compatible. Let me then precise, I thought it is obvious, that except writing it more detailed in commit msg, you also need proper binding expressing this. If this is not the same die and they look compatible, then usually it means you need a compatible. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: riscv: spacemit: Add OrangePi R2S board 2025-11-11 10:34 ` Krzysztof Kozlowski @ 2025-11-11 11:37 ` Michael Opdenacker -1 siblings, 0 replies; 20+ messages in thread From: Michael Opdenacker @ 2025-11-11 11:37 UTC (permalink / raw) To: Krzysztof Kozlowski, Yixun Lan Cc: michael.opdenacker, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Yangyu Chen, devicetree, linux-riscv, spacemit, linux-kernel, Troy Mitchell Hi Krzystof, On 11/11/25 11:34, Krzysztof Kozlowski wrote: > On 11/11/2025 11:29, Michael Opdenacker wrote: >> Greetings >> >> Thanks one more time for the reviews! >> >> On 11/11/25 11:13, Krzysztof Kozlowski wrote: >>> On 11/11/2025 11:11, Yixun Lan wrote: >>>> Hi Krzysztof, >>>> >>>> On 08:43 Tue 11 Nov , Krzysztof Kozlowski wrote: >>>>> On Mon, Nov 10, 2025 at 10:06:48PM +0000, michael.opdenacker@rootcommit.com wrote: >>>>>> From: Michael Opdenacker <michael.opdenacker@rootcommit.com> >>>>>> >>>>>> Document the compatible string for the OrangePi R2S board [1], which >>>>>> is marketed as using the Ky X1 SoC but is in fact identical to >>>> Maybe, just say it "same" to clarify the ambiguity? >>> What is exactly "same"? Same die? Or same blocks/pieces? Whichever you >>> choose please make it very explicit. >> Maybe Troy Mitchell from Spacemit can shed light on this question. >> >> Anyway, I could use the same wording as in this commit introducing >> "OrangePi RV2": >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch?id=bab8dea259100a99e047fd11a48940b229d30031 >> >> "The board is described as using the Ky X1 SoC, which, based on >> available downstream sources and testing, appears to be identical or >> very closely related to the SpacemiT K1 SoC". >> >> What do you think? > This clearly suggests they are not identical thus you should have also > dedicated compatible. Let me then precise, I thought it is obvious, that > except writing it more detailed in commit msg, you also need proper > binding expressing this. If this is not the same die and they look > compatible, then usually it means you need a compatible. Note quite, the sentence I reused says "identical *or* very closely related". Anyway, that's not up to me to decide, as what you suggest would mean to fix the DTS for OrangePi RV2 too. I was just trying to share code for this board too in a very similar way to what was shared for OrangePi RV2, so that people can use the mainline kernel to collaborate and make support for this board better than the custom code produced by the board vendor... Cheers Michael. -- Michael Opdenacker Root Commit Yocto Project and OpenEmbedded Training course - Learn by doing: https://rootcommit.com/training/yocto/ _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: riscv: spacemit: Add OrangePi R2S board @ 2025-11-11 11:37 ` Michael Opdenacker 0 siblings, 0 replies; 20+ messages in thread From: Michael Opdenacker @ 2025-11-11 11:37 UTC (permalink / raw) To: Krzysztof Kozlowski, Yixun Lan Cc: michael.opdenacker, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Yangyu Chen, devicetree, linux-riscv, spacemit, linux-kernel, Troy Mitchell Hi Krzystof, On 11/11/25 11:34, Krzysztof Kozlowski wrote: > On 11/11/2025 11:29, Michael Opdenacker wrote: >> Greetings >> >> Thanks one more time for the reviews! >> >> On 11/11/25 11:13, Krzysztof Kozlowski wrote: >>> On 11/11/2025 11:11, Yixun Lan wrote: >>>> Hi Krzysztof, >>>> >>>> On 08:43 Tue 11 Nov , Krzysztof Kozlowski wrote: >>>>> On Mon, Nov 10, 2025 at 10:06:48PM +0000, michael.opdenacker@rootcommit.com wrote: >>>>>> From: Michael Opdenacker <michael.opdenacker@rootcommit.com> >>>>>> >>>>>> Document the compatible string for the OrangePi R2S board [1], which >>>>>> is marketed as using the Ky X1 SoC but is in fact identical to >>>> Maybe, just say it "same" to clarify the ambiguity? >>> What is exactly "same"? Same die? Or same blocks/pieces? Whichever you >>> choose please make it very explicit. >> Maybe Troy Mitchell from Spacemit can shed light on this question. >> >> Anyway, I could use the same wording as in this commit introducing >> "OrangePi RV2": >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch?id=bab8dea259100a99e047fd11a48940b229d30031 >> >> "The board is described as using the Ky X1 SoC, which, based on >> available downstream sources and testing, appears to be identical or >> very closely related to the SpacemiT K1 SoC". >> >> What do you think? > This clearly suggests they are not identical thus you should have also > dedicated compatible. Let me then precise, I thought it is obvious, that > except writing it more detailed in commit msg, you also need proper > binding expressing this. If this is not the same die and they look > compatible, then usually it means you need a compatible. Note quite, the sentence I reused says "identical *or* very closely related". Anyway, that's not up to me to decide, as what you suggest would mean to fix the DTS for OrangePi RV2 too. I was just trying to share code for this board too in a very similar way to what was shared for OrangePi RV2, so that people can use the mainline kernel to collaborate and make support for this board better than the custom code produced by the board vendor... Cheers Michael. -- Michael Opdenacker Root Commit Yocto Project and OpenEmbedded Training course - Learn by doing: https://rootcommit.com/training/yocto/ ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: riscv: spacemit: Add OrangePi R2S board 2025-11-11 10:34 ` Krzysztof Kozlowski @ 2025-11-11 11:41 ` Yixun Lan -1 siblings, 0 replies; 20+ messages in thread From: Yixun Lan @ 2025-11-11 11:41 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Michael Opdenacker, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Yangyu Chen, devicetree, linux-riscv, spacemit, linux-kernel, Troy Mitchell Hi All, On 11:34 Tue 11 Nov , Krzysztof Kozlowski wrote: > On 11/11/2025 11:29, Michael Opdenacker wrote: > > Greetings > > > > Thanks one more time for the reviews! > > > > On 11/11/25 11:13, Krzysztof Kozlowski wrote: > >> On 11/11/2025 11:11, Yixun Lan wrote: > >>> Hi Krzysztof, > >>> > >>> On 08:43 Tue 11 Nov , Krzysztof Kozlowski wrote: > >>>> On Mon, Nov 10, 2025 at 10:06:48PM +0000, michael.opdenacker@rootcommit.com wrote: > >>>>> From: Michael Opdenacker <michael.opdenacker@rootcommit.com> > >>>>> > >>>>> Document the compatible string for the OrangePi R2S board [1], which > >>>>> is marketed as using the Ky X1 SoC but is in fact identical to > >>> Maybe, just say it "same" to clarify the ambiguity? > >> What is exactly "same"? Same die? Or same blocks/pieces? Whichever you > >> choose please make it very explicit. > > > > Maybe Troy Mitchell from Spacemit can shed light on this question. > > > > Anyway, I could use the same wording as in this commit introducing > > "OrangePi RV2": > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch?id=bab8dea259100a99e047fd11a48940b229d30031 > > > > "The board is described as using the Ky X1 SoC, which, based on > > available downstream sources and testing, appears to be identical or > > very closely related to the SpacemiT K1 SoC". sorry for bringing confusion in previous series, we had no further discussion on this.. > > > > What do you think? > > This clearly suggests they are not identical thus you should have also > dedicated compatible. Let me then precise, I thought it is obvious, that > except writing it more detailed in commit msg, you also need proper > binding expressing this. If this is not the same die and they look > compatible, then usually it means you need a compatible. > to be explicit, the Xy X1 has same die, same packaging as SpacemiT K1, so we should not introduce new compatible in the SoC level, but a new board compatible in patch [1/2] is ok to me I hope this clarify this issue.. -- Yixun Lan (dlan) _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: riscv: spacemit: Add OrangePi R2S board @ 2025-11-11 11:41 ` Yixun Lan 0 siblings, 0 replies; 20+ messages in thread From: Yixun Lan @ 2025-11-11 11:41 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Michael Opdenacker, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Yangyu Chen, devicetree, linux-riscv, spacemit, linux-kernel, Troy Mitchell Hi All, On 11:34 Tue 11 Nov , Krzysztof Kozlowski wrote: > On 11/11/2025 11:29, Michael Opdenacker wrote: > > Greetings > > > > Thanks one more time for the reviews! > > > > On 11/11/25 11:13, Krzysztof Kozlowski wrote: > >> On 11/11/2025 11:11, Yixun Lan wrote: > >>> Hi Krzysztof, > >>> > >>> On 08:43 Tue 11 Nov , Krzysztof Kozlowski wrote: > >>>> On Mon, Nov 10, 2025 at 10:06:48PM +0000, michael.opdenacker@rootcommit.com wrote: > >>>>> From: Michael Opdenacker <michael.opdenacker@rootcommit.com> > >>>>> > >>>>> Document the compatible string for the OrangePi R2S board [1], which > >>>>> is marketed as using the Ky X1 SoC but is in fact identical to > >>> Maybe, just say it "same" to clarify the ambiguity? > >> What is exactly "same"? Same die? Or same blocks/pieces? Whichever you > >> choose please make it very explicit. > > > > Maybe Troy Mitchell from Spacemit can shed light on this question. > > > > Anyway, I could use the same wording as in this commit introducing > > "OrangePi RV2": > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch?id=bab8dea259100a99e047fd11a48940b229d30031 > > > > "The board is described as using the Ky X1 SoC, which, based on > > available downstream sources and testing, appears to be identical or > > very closely related to the SpacemiT K1 SoC". sorry for bringing confusion in previous series, we had no further discussion on this.. > > > > What do you think? > > This clearly suggests they are not identical thus you should have also > dedicated compatible. Let me then precise, I thought it is obvious, that > except writing it more detailed in commit msg, you also need proper > binding expressing this. If this is not the same die and they look > compatible, then usually it means you need a compatible. > to be explicit, the Xy X1 has same die, same packaging as SpacemiT K1, so we should not introduce new compatible in the SoC level, but a new board compatible in patch [1/2] is ok to me I hope this clarify this issue.. -- Yixun Lan (dlan) ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v3 2/2] riscv: dts: spacemit: Add OrangePi R2S board device tree 2025-11-10 22:06 ` michael.opdenacker @ 2025-11-10 22:06 ` michael.opdenacker -1 siblings, 0 replies; 20+ messages in thread From: michael.opdenacker @ 2025-11-10 22:06 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Yixun Lan, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti Cc: Michael Opdenacker, devicetree, linux-riscv, spacemit, linux-kernel From: Michael Opdenacker <michael.opdenacker@rootcommit.com> Add initial device tree support for the OrangePi RV2 board [1], which is marketed as using the Ky X1 SoC but has been confirmed to be identical to the SpacemiT K1 [2]. Enable UART0, to boot into a serial console Two Gigabit Ethernet ports with RGMII interface standard support are enabled, each port is connected to an external Motorcomm YT8531C PHY chip which uses the GPIO for reset control. Enable PDMA. Enable 8 GB eMMC chip for storage. Link: http://www.orangepi.org/html/hardWare/computerAndMicrocontrollers/details/Orange-Pi-R2S.html [1] Link: https://www.spacemit.com/en/key-stone-k1 [2] Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com> --- arch/riscv/boot/dts/spacemit/Makefile | 1 + .../boot/dts/spacemit/k1-orangepi-r2s.dts | 90 +++++++++++++++++++ 2 files changed, 91 insertions(+) create mode 100644 arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts diff --git a/arch/riscv/boot/dts/spacemit/Makefile b/arch/riscv/boot/dts/spacemit/Makefile index 942ecb38bea0..96b3a13a3944 100644 --- a/arch/riscv/boot/dts/spacemit/Makefile +++ b/arch/riscv/boot/dts/spacemit/Makefile @@ -3,3 +3,4 @@ dtb-$(CONFIG_ARCH_SPACEMIT) += k1-bananapi-f3.dtb dtb-$(CONFIG_ARCH_SPACEMIT) += k1-milkv-jupiter.dtb dtb-$(CONFIG_ARCH_SPACEMIT) += k1-musepi-pro.dtb dtb-$(CONFIG_ARCH_SPACEMIT) += k1-orangepi-rv2.dtb +dtb-$(CONFIG_ARCH_SPACEMIT) += k1-orangepi-r2s.dtb diff --git a/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts b/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts new file mode 100644 index 000000000000..58098c4a2aab --- /dev/null +++ b/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts @@ -0,0 +1,90 @@ +// SPDX-License-Identifier: (GPL-2.0 OR MIT) +/* + * Copyright (C) 2025 Michael Opdenacker <michael.opdenacker@rootcommit.com> + */ + +/dts-v1/; + +#include "k1.dtsi" +#include "k1-pinctrl.dtsi" + +/ { + model = "OrangePi R2S"; + compatible = "xunlong,orangepi-r2s", "spacemit,k1"; + + aliases { + serial0 = &uart0; + ethernet0 = ð0; + ethernet1 = ð1; + }; + + chosen { + stdout-path = "serial0"; + }; +}; + +&emmc { + bus-width = <8>; + mmc-hs400-1_8v; + mmc-hs400-enhanced-strobe; + non-removable; + no-sd; + no-sdio; + status = "okay"; +}; + +ð0 { + phy-handle = <&rgmii0>; + phy-mode = "rgmii-id"; + pinctrl-names = "default"; + pinctrl-0 = <&gmac0_cfg>; + rx-internal-delay-ps = <0>; + tx-internal-delay-ps = <0>; + status = "okay"; + + mdio-bus { + #address-cells = <0x1>; + #size-cells = <0x0>; + + reset-gpios = <&gpio K1_GPIO(110) GPIO_ACTIVE_LOW>; + reset-delay-us = <10000>; + reset-post-delay-us = <100000>; + + rgmii0: phy@1 { + reg = <0x1>; + }; + }; +}; + +ð1 { + phy-handle = <&rgmii1>; + phy-mode = "rgmii-id"; + pinctrl-names = "default"; + pinctrl-0 = <&gmac1_cfg>; + rx-internal-delay-ps = <0>; + tx-internal-delay-ps = <250>; + status = "okay"; + + mdio-bus { + #address-cells = <0x1>; + #size-cells = <0x0>; + + reset-gpios = <&gpio K1_GPIO(115) GPIO_ACTIVE_LOW>; + reset-delay-us = <10000>; + reset-post-delay-us = <100000>; + + rgmii1: phy@1 { + reg = <0x1>; + }; + }; +}; + +&pdma { + status = "okay"; +}; + +&uart0 { + pinctrl-names = "default"; + pinctrl-0 = <&uart0_2_cfg>; + status = "okay"; +}; _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH v3 2/2] riscv: dts: spacemit: Add OrangePi R2S board device tree @ 2025-11-10 22:06 ` michael.opdenacker 0 siblings, 0 replies; 20+ messages in thread From: michael.opdenacker @ 2025-11-10 22:06 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Yixun Lan, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti Cc: Michael Opdenacker, devicetree, linux-riscv, spacemit, linux-kernel From: Michael Opdenacker <michael.opdenacker@rootcommit.com> Add initial device tree support for the OrangePi RV2 board [1], which is marketed as using the Ky X1 SoC but has been confirmed to be identical to the SpacemiT K1 [2]. Enable UART0, to boot into a serial console Two Gigabit Ethernet ports with RGMII interface standard support are enabled, each port is connected to an external Motorcomm YT8531C PHY chip which uses the GPIO for reset control. Enable PDMA. Enable 8 GB eMMC chip for storage. Link: http://www.orangepi.org/html/hardWare/computerAndMicrocontrollers/details/Orange-Pi-R2S.html [1] Link: https://www.spacemit.com/en/key-stone-k1 [2] Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com> --- arch/riscv/boot/dts/spacemit/Makefile | 1 + .../boot/dts/spacemit/k1-orangepi-r2s.dts | 90 +++++++++++++++++++ 2 files changed, 91 insertions(+) create mode 100644 arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts diff --git a/arch/riscv/boot/dts/spacemit/Makefile b/arch/riscv/boot/dts/spacemit/Makefile index 942ecb38bea0..96b3a13a3944 100644 --- a/arch/riscv/boot/dts/spacemit/Makefile +++ b/arch/riscv/boot/dts/spacemit/Makefile @@ -3,3 +3,4 @@ dtb-$(CONFIG_ARCH_SPACEMIT) += k1-bananapi-f3.dtb dtb-$(CONFIG_ARCH_SPACEMIT) += k1-milkv-jupiter.dtb dtb-$(CONFIG_ARCH_SPACEMIT) += k1-musepi-pro.dtb dtb-$(CONFIG_ARCH_SPACEMIT) += k1-orangepi-rv2.dtb +dtb-$(CONFIG_ARCH_SPACEMIT) += k1-orangepi-r2s.dtb diff --git a/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts b/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts new file mode 100644 index 000000000000..58098c4a2aab --- /dev/null +++ b/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts @@ -0,0 +1,90 @@ +// SPDX-License-Identifier: (GPL-2.0 OR MIT) +/* + * Copyright (C) 2025 Michael Opdenacker <michael.opdenacker@rootcommit.com> + */ + +/dts-v1/; + +#include "k1.dtsi" +#include "k1-pinctrl.dtsi" + +/ { + model = "OrangePi R2S"; + compatible = "xunlong,orangepi-r2s", "spacemit,k1"; + + aliases { + serial0 = &uart0; + ethernet0 = ð0; + ethernet1 = ð1; + }; + + chosen { + stdout-path = "serial0"; + }; +}; + +&emmc { + bus-width = <8>; + mmc-hs400-1_8v; + mmc-hs400-enhanced-strobe; + non-removable; + no-sd; + no-sdio; + status = "okay"; +}; + +ð0 { + phy-handle = <&rgmii0>; + phy-mode = "rgmii-id"; + pinctrl-names = "default"; + pinctrl-0 = <&gmac0_cfg>; + rx-internal-delay-ps = <0>; + tx-internal-delay-ps = <0>; + status = "okay"; + + mdio-bus { + #address-cells = <0x1>; + #size-cells = <0x0>; + + reset-gpios = <&gpio K1_GPIO(110) GPIO_ACTIVE_LOW>; + reset-delay-us = <10000>; + reset-post-delay-us = <100000>; + + rgmii0: phy@1 { + reg = <0x1>; + }; + }; +}; + +ð1 { + phy-handle = <&rgmii1>; + phy-mode = "rgmii-id"; + pinctrl-names = "default"; + pinctrl-0 = <&gmac1_cfg>; + rx-internal-delay-ps = <0>; + tx-internal-delay-ps = <250>; + status = "okay"; + + mdio-bus { + #address-cells = <0x1>; + #size-cells = <0x0>; + + reset-gpios = <&gpio K1_GPIO(115) GPIO_ACTIVE_LOW>; + reset-delay-us = <10000>; + reset-post-delay-us = <100000>; + + rgmii1: phy@1 { + reg = <0x1>; + }; + }; +}; + +&pdma { + status = "okay"; +}; + +&uart0 { + pinctrl-names = "default"; + pinctrl-0 = <&uart0_2_cfg>; + status = "okay"; +}; ^ permalink raw reply related [flat|nested] 20+ messages in thread
end of thread, other threads:[~2025-11-11 11:45 UTC | newest] Thread overview: 20+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-11-10 22:06 [PATCH v3 0/2] riscv: spacemit: initial support for OrangePi R2S michael.opdenacker 2025-11-10 22:06 ` michael.opdenacker 2025-11-10 22:06 ` [PATCH v3 1/2] dt-bindings: riscv: spacemit: Add OrangePi R2S board michael.opdenacker 2025-11-10 22:06 ` michael.opdenacker 2025-11-11 7:43 ` Krzysztof Kozlowski 2025-11-11 7:43 ` Krzysztof Kozlowski 2025-11-11 10:11 ` Yixun Lan 2025-11-11 10:11 ` Yixun Lan 2025-11-11 10:13 ` Krzysztof Kozlowski 2025-11-11 10:13 ` Krzysztof Kozlowski 2025-11-11 10:29 ` Michael Opdenacker 2025-11-11 10:29 ` Michael Opdenacker 2025-11-11 10:34 ` Krzysztof Kozlowski 2025-11-11 10:34 ` Krzysztof Kozlowski 2025-11-11 11:37 ` Michael Opdenacker 2025-11-11 11:37 ` Michael Opdenacker 2025-11-11 11:41 ` Yixun Lan 2025-11-11 11:41 ` Yixun Lan 2025-11-10 22:06 ` [PATCH v3 2/2] riscv: dts: spacemit: Add OrangePi R2S board device tree michael.opdenacker 2025-11-10 22:06 ` michael.opdenacker
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.