* [PATCH] accel/ivpu: Fix warning due to undefined CONFIG_PROC_FS
@ 2025-11-12 7:19 Karol Wachowski
2025-11-12 7:52 ` Andrzej Kacprowski
2025-11-12 8:26 ` Falkowski, Maciej
0 siblings, 2 replies; 4+ messages in thread
From: Karol Wachowski @ 2025-11-12 7:19 UTC (permalink / raw)
To: dri-devel
Cc: oded.gabbay, jeff.hugo, maciej.falkowski, lizhi.hou,
Karol Wachowski
Change #if to #ifdef CONFIG_PROC_FS to fix warning reported by test robot:
drivers/accel/ivpu/ivpu_drv.c:458:5: warning: "CONFIG_PROC_FS" is not defined, evaluates to 0 [-Wundef]
Fixes: 63cc028484ab ("accel/ivpu: Add fdinfo support for memory statistics")
Signed-off-by: Karol Wachowski <karol.wachowski@linux.intel.com>
---
drivers/accel/ivpu/ivpu_drv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/accel/ivpu/ivpu_drv.c b/drivers/accel/ivpu/ivpu_drv.c
index ce7dbd473059..3d6fccdefdd6 100644
--- a/drivers/accel/ivpu/ivpu_drv.c
+++ b/drivers/accel/ivpu/ivpu_drv.c
@@ -455,7 +455,7 @@ int ivpu_shutdown(struct ivpu_device *vdev)
static const struct file_operations ivpu_fops = {
.owner = THIS_MODULE,
DRM_ACCEL_FOPS,
-#if CONFIG_PROC_FS
+#ifdef CONFIG_PROC_FS
.show_fdinfo = drm_show_fdinfo,
#endif
};
@@ -472,7 +472,7 @@ static const struct drm_driver driver = {
.ioctls = ivpu_drm_ioctls,
.num_ioctls = ARRAY_SIZE(ivpu_drm_ioctls),
.fops = &ivpu_fops,
-#if CONFIG_PROC_FS
+#ifdef CONFIG_PROC_FS
.show_fdinfo = drm_show_memory_stats,
#endif
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] accel/ivpu: Fix warning due to undefined CONFIG_PROC_FS
2025-11-12 7:19 [PATCH] accel/ivpu: Fix warning due to undefined CONFIG_PROC_FS Karol Wachowski
@ 2025-11-12 7:52 ` Andrzej Kacprowski
2025-11-12 8:26 ` Falkowski, Maciej
1 sibling, 0 replies; 4+ messages in thread
From: Andrzej Kacprowski @ 2025-11-12 7:52 UTC (permalink / raw)
To: Karol Wachowski, dri-devel
Cc: oded.gabbay, jeff.hugo, maciej.falkowski, lizhi.hou
On 11/12/2025 8:19 AM, Karol Wachowski wrote:
> Change #if to #ifdef CONFIG_PROC_FS to fix warning reported by test robot:
> drivers/accel/ivpu/ivpu_drv.c:458:5: warning: "CONFIG_PROC_FS" is not defined, evaluates to 0 [-Wundef]
>
> Fixes: 63cc028484ab ("accel/ivpu: Add fdinfo support for memory statistics")
> Signed-off-by: Karol Wachowski <karol.wachowski@linux.intel.com>
> ---
> drivers/accel/ivpu/ivpu_drv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/accel/ivpu/ivpu_drv.c b/drivers/accel/ivpu/ivpu_drv.c
> index ce7dbd473059..3d6fccdefdd6 100644
> --- a/drivers/accel/ivpu/ivpu_drv.c
> +++ b/drivers/accel/ivpu/ivpu_drv.c
> @@ -455,7 +455,7 @@ int ivpu_shutdown(struct ivpu_device *vdev)
> static const struct file_operations ivpu_fops = {
> .owner = THIS_MODULE,
> DRM_ACCEL_FOPS,
> -#if CONFIG_PROC_FS
> +#ifdef CONFIG_PROC_FS
> .show_fdinfo = drm_show_fdinfo,
> #endif
> };
> @@ -472,7 +472,7 @@ static const struct drm_driver driver = {
> .ioctls = ivpu_drm_ioctls,
> .num_ioctls = ARRAY_SIZE(ivpu_drm_ioctls),
> .fops = &ivpu_fops,
> -#if CONFIG_PROC_FS
> +#ifdef CONFIG_PROC_FS
> .show_fdinfo = drm_show_memory_stats,
> #endif
>
Reviewed-by: Andrzej.Kacprowski@linux.intel.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] accel/ivpu: Fix warning due to undefined CONFIG_PROC_FS
2025-11-12 7:19 [PATCH] accel/ivpu: Fix warning due to undefined CONFIG_PROC_FS Karol Wachowski
2025-11-12 7:52 ` Andrzej Kacprowski
@ 2025-11-12 8:26 ` Falkowski, Maciej
1 sibling, 0 replies; 4+ messages in thread
From: Falkowski, Maciej @ 2025-11-12 8:26 UTC (permalink / raw)
To: Karol Wachowski, dri-devel; +Cc: oded.gabbay, jeff.hugo, lizhi.hou
Reviewed-by: Maciej Falkowski <maciej.falkowski@linux.intel.com>
On 11/12/2025 8:19 AM, Karol Wachowski wrote:
> Change #if to #ifdef CONFIG_PROC_FS to fix warning reported by test robot:
> drivers/accel/ivpu/ivpu_drv.c:458:5: warning: "CONFIG_PROC_FS" is not defined, evaluates to 0 [-Wundef]
>
> Fixes: 63cc028484ab ("accel/ivpu: Add fdinfo support for memory statistics")
> Signed-off-by: Karol Wachowski <karol.wachowski@linux.intel.com>
> ---
> drivers/accel/ivpu/ivpu_drv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/accel/ivpu/ivpu_drv.c b/drivers/accel/ivpu/ivpu_drv.c
> index ce7dbd473059..3d6fccdefdd6 100644
> --- a/drivers/accel/ivpu/ivpu_drv.c
> +++ b/drivers/accel/ivpu/ivpu_drv.c
> @@ -455,7 +455,7 @@ int ivpu_shutdown(struct ivpu_device *vdev)
> static const struct file_operations ivpu_fops = {
> .owner = THIS_MODULE,
> DRM_ACCEL_FOPS,
> -#if CONFIG_PROC_FS
> +#ifdef CONFIG_PROC_FS
> .show_fdinfo = drm_show_fdinfo,
> #endif
> };
> @@ -472,7 +472,7 @@ static const struct drm_driver driver = {
> .ioctls = ivpu_drm_ioctls,
> .num_ioctls = ARRAY_SIZE(ivpu_drm_ioctls),
> .fops = &ivpu_fops,
> -#if CONFIG_PROC_FS
> +#ifdef CONFIG_PROC_FS
> .show_fdinfo = drm_show_memory_stats,
> #endif
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] accel/ivpu: Fix warning due to undefined CONFIG_PROC_FS
@ 2025-12-02 17:02 Tommy Lee
0 siblings, 0 replies; 4+ messages in thread
From: Tommy Lee @ 2025-12-02 17:02 UTC (permalink / raw)
To: karol.wachowski
Cc: dri-devel, jeff.hugo, lizhi.hou, maciej.falkowski, oded.gabbay
[-- Attachment #1: Type: text/plain, Size: 215 bytes --]
Good morning to you,I been working solo on this but I did a little
adjustment to make this work and if affects anything of your work please be
mindful and you can change it back to your settings to however you like
[-- Attachment #2: Type: text/html, Size: 237 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-12-03 8:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-12 7:19 [PATCH] accel/ivpu: Fix warning due to undefined CONFIG_PROC_FS Karol Wachowski
2025-11-12 7:52 ` Andrzej Kacprowski
2025-11-12 8:26 ` Falkowski, Maciej
-- strict thread matches above, loose matches on Subject: below --
2025-12-02 17:02 Tommy Lee
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.