All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	Nilay Shroff <nilay@linux.ibm.com>,
	Bart Van Assche <bvanassche@acm.org>
Subject: [PATCH v6 0/2] Fix a recently introduced deadlock
Date: Fri, 14 Nov 2025 13:04:05 -0800	[thread overview]
Message-ID: <20251114210409.3123309-1-bvanassche@acm.org> (raw)

Hi Jens,

This patch series fixes a recently introduced deadlock triggered by modifying
request queue sysfs attributes if the dm-multipath queue_if_no_path attribute
is set. Please consider this patch series for the next merge window.

Thanks,

Bart.

Changes compared to v5:
 - Added a new patch for include/linux/backing-dev-defs.h.
 - Removed the data_race() invocations and added __data_racy annotations
   instead.

Changes compared to v4:
 - Use WRITE_ONCE() to update bdi->ra_pages.
 - Move a data_race() annotation from queue_io_timeout_store() into
   blk_queue_rq_timeout().

Changes compared to v3:
 - Added two data_race() annotations.

Changes compared to v2:
 - Dropped the controversial patch "block: Restrict the duration of sysfs
   attribute changes".

Changes compared to v1:
 - Added patch "block: Restrict the duration of sysfs attribute changes".
 - Remove queue freezing from more sysfs callbacks.

Bart Van Assche (2):
  fs: Add the __data_racy annotation to backing_dev_info.ra_pages
  block: Remove queue freezing from several sysfs store callbacks

 block/blk-sysfs.c                | 26 ++++++++------------------
 include/linux/backing-dev-defs.h |  4 +++-
 include/linux/blkdev.h           |  2 +-
 3 files changed, 12 insertions(+), 20 deletions(-)


             reply	other threads:[~2025-11-14 21:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-14 21:04 Bart Van Assche [this message]
2025-11-14 21:04 ` [PATCH v6 1/2] fs: Add the __data_racy annotation to backing_dev_info.ra_pages Bart Van Assche
2025-11-18  6:55   ` Nilay Shroff
2025-11-14 21:04 ` [PATCH v6 2/2] block: Remove queue freezing from several sysfs store callbacks Bart Van Assche
2025-11-17  9:01   ` Nilay Shroff
2025-11-17 20:44     ` Bart Van Assche
2025-11-18  6:54       ` Nilay Shroff
2025-11-18  6:56   ` Nilay Shroff
2025-11-18 15:38 ` [PATCH v6 0/2] Fix a recently introduced deadlock Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251114210409.3123309-1-bvanassche@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=nilay@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.