Re: [PATCH v6 2/2] block: Remove queue freezing from several sysfs store callbacks

[Nilay Shroff <nilay@linux.ibm.com>]

Hi Bart,

On 11/15/25 2:34 AM, Bart Van Assche wrote:
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 2fff8a80dbd2..cb4ba09959ee 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -495,7 +495,7 @@ struct request_queue {
>  	 */
>  	unsigned long		queue_flags;
>  
> -	unsigned int		rq_timeout;
> +	unsigned int __data_racy rq_timeout;
>  
>  	unsigned int		queue_depth;

This change look good to me however as I mentioned earlier, 
introducing __data_racy would break the kernel build. So 
are you going to raise a separate bug report to fix it? 

  AS      .tmp_vmlinux2.kallsyms.o
  LD      vmlinux.unstripped
  BTFIDS  vmlinux.unstripped
WARN: multiple IDs found for 'task_struct': 116, 10183 - using 116
WARN: multiple IDs found for 'module': 190, 10190 - using 190
WARN: multiple IDs found for 'vm_area_struct': 324, 10227 - using 324
WARN: multiple IDs found for 'inode': 956, 10314 - using 956
WARN: multiple IDs found for 'path': 989, 10344 - using 989
WARN: multiple IDs found for 'file': 765, 10375 - using 765
WARN: multiple IDs found for 'cgroup': 1030, 10409 - using 1030
WARN: multiple IDs found for 'seq_file': 1358, 10593 - using 1358
WARN: multiple IDs found for 'bpf_prog': 2054, 10984 - using 2054
WARN: multiple IDs found for 'bpf_map': 2134, 11012 - using 2134
[...]
[...]
make[2]: *** [scripts/Makefile.vmlinux:72: vmlinux.unstripped] Error 255
make[2]: *** Deleting file 'vmlinux.unstripped'
make[1]: *** [/home/src/linux/Makefile:1242: vmlinux] Error 2
make: *** [Makefile:248: __sub-make] Error 2

Thanks,
--Nilay