From: Nilay Shroff <nilay@linux.ibm.com>
To: Bart Van Assche <bvanassche@acm.org>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Tejun Heo <tj@kernel.org>,
Jan Kara <jack@suse.cz>
Subject: Re: [PATCH v6 1/2] fs: Add the __data_racy annotation to backing_dev_info.ra_pages
Date: Tue, 18 Nov 2025 12:25:08 +0530 [thread overview]
Message-ID: <bd7693b0-42ad-4d71-83bb-7504dc99210a@linux.ibm.com> (raw)
In-Reply-To: <20251114210409.3123309-2-bvanassche@acm.org>
On 11/15/25 2:34 AM, Bart Van Assche wrote:
> Some but not all .ra_pages changes happen while block layer I/O is paused
> with blk_mq_freeze_queue(). Filesystems may read .ra_pages even while
> block layer I/O is paused, e.g. from inside their .fadvise callback.
> Annotating all .ra_pages reads with READ_ONCE() would be cumbersome.
> Hence, add the __data_racy annotatation to the .ra_pages member
> variable.
>
> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> Cc: Christian Brauner <brauner@kernel.org>
> Cc: Nilay Shroff <nilay@linux.ibm.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Looks good to me:
Reviewed-by: Nilay Shroff <nilay@linux.ibm.com>
next prev parent reply other threads:[~2025-11-18 6:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 21:04 [PATCH v6 0/2] Fix a recently introduced deadlock Bart Van Assche
2025-11-14 21:04 ` [PATCH v6 1/2] fs: Add the __data_racy annotation to backing_dev_info.ra_pages Bart Van Assche
2025-11-18 6:55 ` Nilay Shroff [this message]
2025-11-14 21:04 ` [PATCH v6 2/2] block: Remove queue freezing from several sysfs store callbacks Bart Van Assche
2025-11-17 9:01 ` Nilay Shroff
2025-11-17 20:44 ` Bart Van Assche
2025-11-18 6:54 ` Nilay Shroff
2025-11-18 6:56 ` Nilay Shroff
2025-11-18 15:38 ` [PATCH v6 0/2] Fix a recently introduced deadlock Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd7693b0-42ad-4d71-83bb-7504dc99210a@linux.ibm.com \
--to=nilay@linux.ibm.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.