From: Christoph Hellwig <hch@lst.de>
To: Chaitanya Kulkarni <ckulkarnilinux@gmail.com>
Cc: axboe@kernel.dk, agk@redhat.com, snitzer@kernel.org,
mpatocka@redhat.com, song@kernel.org, yukuai@fnnas.com,
hch@lst.de, sagi@grimberg.me, kch@nvidia.com, jaegeuk@kernel.org,
chao@kernel.org, cem@kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, dm-devel@lists.linux.dev,
linux-raid@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH V2 4/5] f2fs: ignore discard return value
Date: Mon, 24 Nov 2025 07:30:11 +0100 [thread overview]
Message-ID: <20251124063011.GA16808@lst.de> (raw)
In-Reply-To: <20251124025737.203571-5-ckulkarnilinux@gmail.com>
On Sun, Nov 23, 2025 at 06:57:36PM -0800, Chaitanya Kulkarni wrote:
> + __blkdev_issue_discard(bdev,
> + SECTOR_FROM_BLOCK(start),
> + SECTOR_FROM_BLOCK(len),
> + GFP_NOFS, &bio);
This can be shortened a bit as well:
__blkdev_issue_discard(bdev, SECTOR_FROM_BLOCK(start),
SECTOR_FROM_BLOCK(len), GFP_NOFS, &bio);
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Chaitanya Kulkarni <ckulkarnilinux@gmail.com>
Cc: axboe@kernel.dk, dm-devel@lists.linux.dev,
linux-f2fs-devel@lists.sourceforge.net, kch@nvidia.com,
sagi@grimberg.me, linux-xfs@vger.kernel.org, cem@kernel.org,
snitzer@kernel.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-raid@vger.kernel.org,
linux-block@vger.kernel.org, song@kernel.org,
mpatocka@redhat.com, jaegeuk@kernel.org, bpf@vger.kernel.org,
yukuai@fnnas.com, hch@lst.de, agk@redhat.com
Subject: Re: [f2fs-dev] [PATCH V2 4/5] f2fs: ignore discard return value
Date: Mon, 24 Nov 2025 07:30:11 +0100 [thread overview]
Message-ID: <20251124063011.GA16808@lst.de> (raw)
In-Reply-To: <20251124025737.203571-5-ckulkarnilinux@gmail.com>
On Sun, Nov 23, 2025 at 06:57:36PM -0800, Chaitanya Kulkarni wrote:
> + __blkdev_issue_discard(bdev,
> + SECTOR_FROM_BLOCK(start),
> + SECTOR_FROM_BLOCK(len),
> + GFP_NOFS, &bio);
This can be shortened a bit as well:
__blkdev_issue_discard(bdev, SECTOR_FROM_BLOCK(start),
SECTOR_FROM_BLOCK(len), GFP_NOFS, &bio);
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2025-11-24 6:30 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 2:57 [PATCH V2 0/5] block: ignore __blkdev_issue_discard() ret value Chaitanya Kulkarni
2025-11-24 2:57 ` [f2fs-dev] " Chaitanya Kulkarni
2025-11-24 2:57 ` [PATCH V2 1/5] block: ignore discard return value Chaitanya Kulkarni
2025-11-24 2:57 ` [f2fs-dev] " Chaitanya Kulkarni
2025-11-24 6:26 ` Christoph Hellwig
2025-11-24 6:26 ` [f2fs-dev] " Christoph Hellwig
2025-11-24 7:50 ` Johannes Thumshirn
2025-11-24 7:50 ` [f2fs-dev] " Johannes Thumshirn via Linux-f2fs-devel
2025-11-24 12:57 ` Martin K. Petersen
2025-11-24 12:57 ` [f2fs-dev] " Martin K. Petersen via Linux-f2fs-devel
2025-11-25 23:33 ` Wilfred Mallawa
2025-11-25 23:33 ` [f2fs-dev] " Wilfred Mallawa
2025-11-24 2:57 ` [PATCH V2 2/5] dm: " Chaitanya Kulkarni
2025-11-24 2:57 ` [f2fs-dev] " Chaitanya Kulkarni
2025-11-24 6:24 ` Yu Kuai
2025-11-24 6:24 ` [f2fs-dev] " Yu Kuai
2025-11-24 6:27 ` Christoph Hellwig
2025-11-24 6:27 ` [f2fs-dev] " Christoph Hellwig
2025-11-24 7:53 ` Johannes Thumshirn
2025-11-24 7:53 ` [f2fs-dev] " Johannes Thumshirn via Linux-f2fs-devel
2025-11-24 12:59 ` Martin K. Petersen
2025-11-24 12:59 ` [f2fs-dev] " Martin K. Petersen via Linux-f2fs-devel
2025-11-25 23:41 ` Wilfred Mallawa
2025-11-25 23:41 ` [f2fs-dev] " Wilfred Mallawa
2025-11-26 9:26 ` Damien Le Moal
2025-11-26 9:26 ` [f2fs-dev] " Damien Le Moal via Linux-f2fs-devel
2025-11-24 2:57 ` [PATCH V2 3/5] nvmet: " Chaitanya Kulkarni
2025-11-24 2:57 ` [f2fs-dev] " Chaitanya Kulkarni
2025-11-24 6:28 ` Christoph Hellwig
2025-11-24 6:28 ` [f2fs-dev] " Christoph Hellwig
2025-11-24 7:54 ` Johannes Thumshirn
2025-11-24 7:54 ` [f2fs-dev] " Johannes Thumshirn via Linux-f2fs-devel
2025-11-24 13:03 ` Martin K. Petersen
2025-11-24 13:03 ` [f2fs-dev] " Martin K. Petersen via Linux-f2fs-devel
2025-11-24 2:57 ` [PATCH V2 4/5] f2fs: " Chaitanya Kulkarni
2025-11-24 2:57 ` [f2fs-dev] " Chaitanya Kulkarni
2025-11-24 6:30 ` Christoph Hellwig [this message]
2025-11-24 6:30 ` Christoph Hellwig
2025-11-24 7:56 ` Johannes Thumshirn
2025-11-24 7:56 ` [f2fs-dev] " Johannes Thumshirn via Linux-f2fs-devel
2025-11-24 12:58 ` Martin K. Petersen
2025-11-24 12:58 ` [f2fs-dev] " Martin K. Petersen via Linux-f2fs-devel
2025-11-24 2:57 ` [PATCH V2 5/5] xfs: " Chaitanya Kulkarni
2025-11-24 2:57 ` [f2fs-dev] " Chaitanya Kulkarni
2025-11-24 6:31 ` Christoph Hellwig
2025-11-24 6:31 ` [f2fs-dev] " Christoph Hellwig
2025-11-24 7:57 ` Johannes Thumshirn
2025-11-24 7:57 ` [f2fs-dev] " Johannes Thumshirn via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251124063011.GA16808@lst.de \
--to=hch@lst.de \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=bpf@vger.kernel.org \
--cc=cem@kernel.org \
--cc=chao@kernel.org \
--cc=ckulkarnilinux@gmail.com \
--cc=dm-devel@lists.linux.dev \
--cc=jaegeuk@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=sagi@grimberg.me \
--cc=snitzer@kernel.org \
--cc=song@kernel.org \
--cc=yukuai@fnnas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.