From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Chaoyi Chen <chaoyi.chen@rock-chips.com>,
Chaoyi Chen <kernel@airkyi.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Peter Chen <hzpeterchen@gmail.com>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Sandy Huang <hjc@rock-chips.com>,
Andy Yan <andy.yan@rock-chips.com>,
Yubing Zhang <yubing.zhang@rock-chips.com>,
Frank Wang <frank.wang@rock-chips.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Amit Sunil Dhamne <amitsd@google.com>,
Dragan Simic <dsimic@manjaro.org>,
Johan Jonker <jbx6244@gmail.com>,
Diederik de Haas <didi.debian@cknow.org>,
Peter Robinson <pbrobinson@gmail.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v10 01/11] usb: typec: Add notifier functions
Date: Tue, 25 Nov 2025 12:49:29 +0100 [thread overview]
Message-ID: <2025112554-uncaring-curator-642a@gregkh> (raw)
In-Reply-To: <aSV_lQYJPxN7oBM-@kuha>
> +static umode_t typec_is_visible(struct kobject *kobj, struct attribute *attr, int n)
> +{
> + if (is_typec_port(kobj_to_dev(kobj)->parent))
Why look at the parent? Doesn't the device have a type that should show
this?
Otherwise, looks good to me.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Chaoyi Chen <chaoyi.chen@rock-chips.com>,
Chaoyi Chen <kernel@airkyi.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Peter Chen <hzpeterchen@gmail.com>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Sandy Huang <hjc@rock-chips.com>,
Andy Yan <andy.yan@rock-chips.com>,
Yubing Zhang <yubing.zhang@rock-chips.com>,
Frank Wang <frank.wang@rock-chips.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Amit Sunil Dhamne <amitsd@google.com>,
Dragan Simic <dsimic@manjaro.org>,
Johan Jonker <jbx6244@gmail.com>,
Diederik de Haas <didi.debian@cknow.org>,
Peter Robinson <pbrobinson@gmail.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v10 01/11] usb: typec: Add notifier functions
Date: Tue, 25 Nov 2025 12:49:29 +0100 [thread overview]
Message-ID: <2025112554-uncaring-curator-642a@gregkh> (raw)
In-Reply-To: <aSV_lQYJPxN7oBM-@kuha>
> +static umode_t typec_is_visible(struct kobject *kobj, struct attribute *attr, int n)
> +{
> + if (is_typec_port(kobj_to_dev(kobj)->parent))
Why look at the parent? Doesn't the device have a type that should show
this?
Otherwise, looks good to me.
thanks,
greg k-h
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Chaoyi Chen <chaoyi.chen@rock-chips.com>,
Chaoyi Chen <kernel@airkyi.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Peter Chen <hzpeterchen@gmail.com>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Sandy Huang <hjc@rock-chips.com>,
Andy Yan <andy.yan@rock-chips.com>,
Yubing Zhang <yubing.zhang@rock-chips.com>,
Frank Wang <frank.wang@rock-chips.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Amit Sunil Dhamne <amitsd@google.com>,
Dragan Simic <dsimic@manjaro.org>,
Johan Jonker <jbx6244@gmail.com>,
Diederik de Haas <didi.debian@cknow.org>,
Peter Robinson <pbrobinson@gmail.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v10 01/11] usb: typec: Add notifier functions
Date: Tue, 25 Nov 2025 12:49:29 +0100 [thread overview]
Message-ID: <2025112554-uncaring-curator-642a@gregkh> (raw)
In-Reply-To: <aSV_lQYJPxN7oBM-@kuha>
> +static umode_t typec_is_visible(struct kobject *kobj, struct attribute *attr, int n)
> +{
> + if (is_typec_port(kobj_to_dev(kobj)->parent))
Why look at the parent? Doesn't the device have a type that should show
this?
Otherwise, looks good to me.
thanks,
greg k-h
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2025-11-25 11:49 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 2:23 [PATCH v10 00/11] Add Type-C DP support for RK3399 EVB IND board Chaoyi Chen
2025-11-20 2:23 ` Chaoyi Chen
2025-11-20 2:23 ` Chaoyi Chen
2025-11-20 2:23 ` [PATCH v10 01/11] usb: typec: Add notifier functions Chaoyi Chen
2025-11-20 2:23 ` Chaoyi Chen
2025-11-20 2:23 ` Chaoyi Chen
2025-11-21 14:07 ` Greg Kroah-Hartman
2025-11-21 14:07 ` Greg Kroah-Hartman
2025-11-21 14:07 ` Greg Kroah-Hartman
2025-11-24 1:40 ` Chaoyi Chen
2025-11-24 1:40 ` Chaoyi Chen
2025-11-24 1:40 ` Chaoyi Chen
2025-11-24 7:10 ` Greg Kroah-Hartman
2025-11-24 7:10 ` Greg Kroah-Hartman
2025-11-24 7:10 ` Greg Kroah-Hartman
2025-11-24 8:05 ` Chaoyi Chen
2025-11-24 8:05 ` Chaoyi Chen
2025-11-24 8:05 ` Chaoyi Chen
2025-11-24 16:33 ` Greg Kroah-Hartman
2025-11-24 16:33 ` Greg Kroah-Hartman
2025-11-24 16:33 ` Greg Kroah-Hartman
2025-11-25 2:23 ` Chaoyi Chen
2025-11-25 2:23 ` Chaoyi Chen
2025-11-25 2:23 ` Chaoyi Chen
2025-11-25 10:06 ` Heikki Krogerus
2025-11-25 10:06 ` Heikki Krogerus
2025-11-25 10:06 ` Heikki Krogerus
2025-11-25 10:54 ` Chaoyi Chen
2025-11-25 10:54 ` Chaoyi Chen
2025-11-25 10:54 ` Chaoyi Chen
2025-11-25 11:49 ` Greg Kroah-Hartman [this message]
2025-11-25 11:49 ` Greg Kroah-Hartman
2025-11-25 11:49 ` Greg Kroah-Hartman
2025-11-26 1:46 ` Chaoyi Chen
2025-11-26 1:46 ` Chaoyi Chen
2025-11-26 1:46 ` Chaoyi Chen
2025-11-26 9:42 ` Heikki Krogerus
2025-11-26 9:42 ` Heikki Krogerus
2025-11-26 9:42 ` Heikki Krogerus
2025-11-26 11:44 ` Greg Kroah-Hartman
2025-11-26 11:44 ` Greg Kroah-Hartman
2025-11-26 11:44 ` Greg Kroah-Hartman
2025-11-26 11:51 ` Chaoyi Chen
2025-11-26 11:51 ` Chaoyi Chen
2025-11-26 11:51 ` Chaoyi Chen
2025-11-26 12:26 ` Heikki Krogerus
2025-11-26 12:26 ` Heikki Krogerus
2025-11-26 12:26 ` Heikki Krogerus
2025-11-20 2:23 ` [PATCH v10 02/11] usb: typec: Export all typec device types Chaoyi Chen
2025-11-20 2:23 ` Chaoyi Chen
2025-11-20 2:23 ` Chaoyi Chen
2025-11-21 14:07 ` Greg Kroah-Hartman
2025-11-21 14:07 ` Greg Kroah-Hartman
2025-11-21 14:07 ` Greg Kroah-Hartman
2025-11-24 1:45 ` Chaoyi Chen
2025-11-24 1:45 ` Chaoyi Chen
2025-11-24 1:45 ` Chaoyi Chen
2025-11-20 2:23 ` [PATCH v10 03/11] drm/bridge: Implement generic USB Type-C DP HPD bridge Chaoyi Chen
2025-11-20 2:23 ` Chaoyi Chen
2025-11-20 2:23 ` Chaoyi Chen
2025-11-26 2:13 ` Chaoyi Chen
2025-11-26 2:13 ` Chaoyi Chen
2025-11-26 2:13 ` Chaoyi Chen
2025-11-20 2:23 ` [PATCH v10 04/11] drm/bridge: aux: Add drm_aux_bridge_register_from_node() Chaoyi Chen
2025-11-20 2:23 ` Chaoyi Chen
2025-11-20 2:23 ` Chaoyi Chen
2025-11-21 14:54 ` Neil Armstrong
2025-11-21 14:54 ` Neil Armstrong
2025-11-21 14:54 ` Neil Armstrong
2025-11-20 2:23 ` [PATCH v10 05/11] dt-bindings: phy: rockchip: rk3399-typec-phy: Support mode-switch Chaoyi Chen
2025-11-20 2:23 ` Chaoyi Chen
2025-11-20 2:23 ` Chaoyi Chen
2025-11-20 2:23 ` [PATCH v10 06/11] phy: rockchip: phy-rockchip-typec: Add typec_mux/typec_switch support Chaoyi Chen
2025-11-20 2:23 ` Chaoyi Chen
2025-11-20 2:23 ` Chaoyi Chen
2025-11-20 2:23 ` [PATCH v10 07/11] phy: rockchip: phy-rockchip-typec: Add DRM AUX bridge Chaoyi Chen
2025-11-20 2:23 ` Chaoyi Chen
2025-11-20 2:23 ` Chaoyi Chen
2025-11-21 14:54 ` Neil Armstrong
2025-11-21 14:54 ` Neil Armstrong
2025-11-21 14:54 ` Neil Armstrong
2025-11-20 2:23 ` [PATCH v10 08/11] drm/rockchip: cdn-dp: Support handle lane info without extcon Chaoyi Chen
2025-11-20 2:23 ` Chaoyi Chen
2025-11-20 2:23 ` Chaoyi Chen
2025-11-20 2:23 ` [PATCH v10 09/11] drm/rockchip: cdn-dp: Add multiple bridges to support PHY port selection Chaoyi Chen
2025-11-20 2:23 ` Chaoyi Chen
2025-11-20 2:23 ` Chaoyi Chen
2025-11-20 2:23 ` [PATCH v10 10/11] arm64: dts: rockchip: Add missing dp_out port for RK3399 CDN-DP Chaoyi Chen
2025-11-20 2:23 ` Chaoyi Chen
2025-11-20 2:23 ` Chaoyi Chen
2025-11-20 2:23 ` [PATCH v10 11/11] arm64: dts: rockchip: rk3399-evb-ind: Add support for DisplayPort Chaoyi Chen
2025-11-20 2:23 ` Chaoyi Chen
2025-11-20 2:23 ` Chaoyi Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025112554-uncaring-curator-642a@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=amitsd@google.com \
--cc=andrzej.hajda@intel.com \
--cc=andy.yan@rock-chips.com \
--cc=chaoyi.chen@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=didi.debian@cknow.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=dsimic@manjaro.org \
--cc=frank.wang@rock-chips.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=hzpeterchen@gmail.com \
--cc=jbx6244@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kernel@airkyi.com \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=pbrobinson@gmail.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=vkoul@kernel.org \
--cc=yubing.zhang@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.