Re: [PATCH next v3] Kconfig: select SPL_USE_TINY_PRINTF_POINTER_SUPPORT for K3

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 2158 bytes --]

On Wed, Dec 17, 2025 at 11:03:43AM +0530, Anshul Dalal wrote:
> On Tue Dec 16, 2025 at 7:31 PM IST, Tom Rini wrote:
> > On Tue, Dec 16, 2025 at 01:52:37PM +0530, Anshul Dalal wrote:
> >> Hi all,
> >> 
> >> Any updates on this patch? If possible could we pull this fix into
> >> master as well for the 2026.01 release?
> >
> > I thought the feedback was that this was a generic problem and so the
> > Kconfig logic should be universal, or there was an incorrectly /
> > sub-optimally handled case in the tiny printf code, that needs fixing.
> 
> We have a few ways to go about fixing this:
> 
> 1. Fix the commit 1e24e84db41a ("tiny-printf: Handle formatting of %p
>    with an extra Kconfig"):
> 
>    Pointer formatting used to fall back to %x handling before the
>    commit. Though going by the commit description, it looks like the
>    change was intended. So, I'm unsure if we should re-introduce the
>    confusing handling back where %p is handled but not %pa or %pap.
> 
> 2. Add SPL_USE_TINY_PRINTF_POINTER_SUPPORT per defconfig:
> 
>    This was what v2 of the series were attempting to do but as Andrew
>    pointed out, there might be other platforms with similar issues and
>    it would be better to fix it for K3 overall.
> 
> 3. Change usage of %p in k3_sysfw_dfu_download to %x:
> 
>    This is a suitable fix imo but we might still have to fix similar
>    usages of %p in other places. We'd also have to be more careful when
>    bringing proper U-Boot code to SPL since %p would not work the same
>    way.
> 
> 4. Unconditionally select SPL_USE_TINY_PRINTF_POINTER_SUPPORT for K3:
> 
>    This allows us to remedy the problems with above 3 solutions with
>    very little overhead to the SPL size (<100 bytes).
> 
> If this problem is faced by non K3 platforms as well, perhaps it might
> be better to take the hit and make SPL_USE_TINY_PRINTF_POINTER_SUPPORT
> default y.

Ah, so now I understand the problem, with point 3. So yes, I think the
right fix is to add "select SPL_USE_TINY_PRINTF_POINTER_SUPPORT if
SPL_USE_TINY_PRINTF && DFU && CPU_V7R" under the ARCH_K3 symbol.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]