All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anshul Dalal <anshuld@ti.com>
To: Tom Rini <trini@konsulko.com>, Anshul Dalal <anshuld@ti.com>
Cc: <u-boot@lists.denx.de>, Andrew Davis <afd@ti.com>,
	Judith Mendez <jm@ti.com>, Udit Kumar <u-kumar1@ti.com>,
	Hrushikesh Salunke <h-salunke@ti.com>,
	Neha Malcom Francis <n-francis@ti.com>,
	Vignesh R <vigneshr@ti.com>,
	Christoph Niedermaier <cniedermaier@dh-electronics.com>
Subject: Re: [PATCH next v3] Kconfig: select SPL_USE_TINY_PRINTF_POINTER_SUPPORT for K3
Date: Wed, 17 Dec 2025 11:03:43 +0530	[thread overview]
Message-ID: <DF08W9D84X84.1DQ1VM5S8TT9D@ti.com> (raw)
In-Reply-To: <20251216140104.GU303283@bill-the-cat>

On Tue Dec 16, 2025 at 7:31 PM IST, Tom Rini wrote:
> On Tue, Dec 16, 2025 at 01:52:37PM +0530, Anshul Dalal wrote:
>> Hi all,
>> 
>> Any updates on this patch? If possible could we pull this fix into
>> master as well for the 2026.01 release?
>
> I thought the feedback was that this was a generic problem and so the
> Kconfig logic should be universal, or there was an incorrectly /
> sub-optimally handled case in the tiny printf code, that needs fixing.

We have a few ways to go about fixing this:

1. Fix the commit 1e24e84db41a ("tiny-printf: Handle formatting of %p
   with an extra Kconfig"):

   Pointer formatting used to fall back to %x handling before the
   commit. Though going by the commit description, it looks like the
   change was intended. So, I'm unsure if we should re-introduce the
   confusing handling back where %p is handled but not %pa or %pap.

2. Add SPL_USE_TINY_PRINTF_POINTER_SUPPORT per defconfig:

   This was what v2 of the series were attempting to do but as Andrew
   pointed out, there might be other platforms with similar issues and
   it would be better to fix it for K3 overall.

3. Change usage of %p in k3_sysfw_dfu_download to %x:

   This is a suitable fix imo but we might still have to fix similar
   usages of %p in other places. We'd also have to be more careful when
   bringing proper U-Boot code to SPL since %p would not work the same
   way.

4. Unconditionally select SPL_USE_TINY_PRINTF_POINTER_SUPPORT for K3:

   This allows us to remedy the problems with above 3 solutions with
   very little overhead to the SPL size (<100 bytes).

If this problem is faced by non K3 platforms as well, perhaps it might
be better to take the hit and make SPL_USE_TINY_PRINTF_POINTER_SUPPORT
default y.

Regards,
Anshul




  reply	other threads:[~2025-12-17  5:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-04 11:12 [PATCH next v3] Kconfig: select SPL_USE_TINY_PRINTF_POINTER_SUPPORT for K3 Anshul Dalal
2025-12-16  8:22 ` Anshul Dalal
2025-12-16 14:01   ` Tom Rini
2025-12-17  5:33     ` Anshul Dalal [this message]
2025-12-18 14:16       ` Tom Rini
2025-12-18 14:41         ` Andrew Davis
2025-12-18 14:58           ` Tom Rini
2025-12-18 15:25             ` Andrew Davis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DF08W9D84X84.1DQ1VM5S8TT9D@ti.com \
    --to=anshuld@ti.com \
    --cc=afd@ti.com \
    --cc=cniedermaier@dh-electronics.com \
    --cc=h-salunke@ti.com \
    --cc=jm@ti.com \
    --cc=n-francis@ti.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=u-kumar1@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.