All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anshul Dalal <anshuld@ti.com>
To: Anshul Dalal <anshuld@ti.com>, <u-boot@lists.denx.de>
Cc: Tom Rini <trini@konsulko.com>, Andrew Davis <afd@ti.com>,
	Judith Mendez <jm@ti.com>, Udit Kumar <u-kumar1@ti.com>,
	Hrushikesh Salunke <h-salunke@ti.com>,
	Neha Malcom Francis <n-francis@ti.com>,
	Vignesh R <vigneshr@ti.com>,
	Christoph Niedermaier <cniedermaier@dh-electronics.com>
Subject: Re: [PATCH next v3] Kconfig: select SPL_USE_TINY_PRINTF_POINTER_SUPPORT for K3
Date: Tue, 16 Dec 2025 13:52:37 +0530	[thread overview]
Message-ID: <DEZHV1ELFZ43.E3FN619R0UNY@ti.com> (raw)
In-Reply-To: <20251204-am65_dfu_fix-v3-1-de18ed3f346d@ti.com>

Hi all,

Any updates on this patch? If possible could we pull this fix into
master as well for the 2026.01 release?

On Thu Dec 4, 2025 at 4:42 PM IST, Anshul Dalal wrote:
> Since the commit 1e24e84db41a ("tiny-printf: Handle formatting of %p
> with an extra Kconfig"), SPL_USE_TINY_PRINTF_POINTER_SUPPORT has been
> made mandatory in order to use %p which would earlier have defaulted to
> a 'long' print.
>
> Without this config symbol, k3_sysfw_dfu_download fails to set the
> correct value for the DFU string with:
>
>  sprintf(dfu_str, "sysfw.itb ram 0x%p 0x%x", addr,
>    CONFIG_K3_SYSFW_IMAGE_SIZE_MAX);
>
> The value we get "sysfw.itb ram 0x? 0x41c29d40" causes a boot failure.
>
> Therefore this patch sets SPL_USE_TINY_PRINTF_POINTER_SUPPORT for all K3
> devices since the size impact is less than 100 bytes.
>
> Signed-off-by: Anshul Dalal <anshuld@ti.com>
> ---
> Changes in v3:
> - Handle setting the config in Kconfig instead of the defconfig
> - Link to v2: https://lore.kernel.org/r/20251105-am65_dfu_fix-v2-1-ccada89d966d@ti.com
>
> Changes in v2:
> - Remove unrelated changes
> - Link to v1: https://lore.kernel.org/r/20251105-am65_dfu_fix-v1-1-acc29111dccf@ti.com
> ---
>  arch/arm/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 3db5474a05b..7756ed000b1 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -830,6 +830,7 @@ config ARCH_K3
>  	bool "Texas Instruments' K3 Architecture"
>  	select SPL
>  	select SUPPORT_SPL
> +	select SPL_USE_TINY_PRINTF_POINTER_SUPPORT
>  	select FIT
>  	select REGEX
>  	select FIT_SIGNATURE if ARM64
>
> ---
> base-commit: dca19206acf2af2d339087bb62aa0b8ee1b0e326
> change-id: 20251105-am65_dfu_fix-1144eec06b19
>
> Best regards,


  reply	other threads:[~2025-12-16  8:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-04 11:12 [PATCH next v3] Kconfig: select SPL_USE_TINY_PRINTF_POINTER_SUPPORT for K3 Anshul Dalal
2025-12-16  8:22 ` Anshul Dalal [this message]
2025-12-16 14:01   ` Tom Rini
2025-12-17  5:33     ` Anshul Dalal
2025-12-18 14:16       ` Tom Rini
2025-12-18 14:41         ` Andrew Davis
2025-12-18 14:58           ` Tom Rini
2025-12-18 15:25             ` Andrew Davis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DEZHV1ELFZ43.E3FN619R0UNY@ti.com \
    --to=anshuld@ti.com \
    --cc=afd@ti.com \
    --cc=cniedermaier@dh-electronics.com \
    --cc=h-salunke@ti.com \
    --cc=jm@ti.com \
    --cc=n-francis@ti.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=u-kumar1@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.