All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chuck Lever <cel@kernel.org>
To: vira, Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>
Cc: <linux-fsdevel@vger.kernel.org>,
	linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
	linux-cifs@vger.kernel.org, <linux-nfs@vger.kernel.org>,
	linux-f2fs-devel@lists.sourceforge.net,
	hirofumi@mail.parknet.co.jp, linkinjeon@kernel.org,
	sj1557.seo@samsung.com, yuezhang.mo@sony.com,
	almaz.alexandrovich@paragon-software.com, slava@dubeyko.com,
	glaubitz@physik.fu-berlin.de, frank.li@vivo.com, tytso@mit.edu,
	adilger.kernel@dilger.ca, cem@kernel.org, sfrench@samba.org,
	pc@manguebit.org, ronniesahlberg@gmail.com,
	sprasad@microsoft.com, trondmy@kernel.org, anna@kernel.org,
	jaegeuk@kernel.org, chao@kernel.org, hansg@kernel.org,
	senozhatsky@chromium.org, Chuck Lever <chuck.lever@oracle.com>
Subject: [PATCH v3 12/16] vboxsf: Implement fileattr_get for case sensitivity
Date: Mon, 12 Jan 2026 12:46:25 -0500	[thread overview]
Message-ID: <20260112174629.3729358-13-cel@kernel.org> (raw)
In-Reply-To: <20260112174629.3729358-1-cel@kernel.org>

From: Chuck Lever <chuck.lever@oracle.com>

Upper layers such as NFSD need a way to query whether a
filesystem handles filenames in a case-sensitive manner. The
file_kattr structure now provides case_insensitive and
case_preserving fields for this purpose, but vboxsf does not
yet report its case sensitivity behavior through this interface.

Implement vboxsf_fileattr_get() to report the case handling
behavior of VirtualBox shared folders. The case sensitivity
property is queried from the VirtualBox host service at mount
time and cached in struct vboxsf_sbi. The host determines case
sensitivity based on the underlying host filesystem (for
example, Windows NTFS is case-insensitive while Linux ext4 is
case-sensitive).

VirtualBox shared folders always preserve filename case exactly
as provided by the guest. The host interface does not expose a
case_preserving property, so this is hardcoded to true.

The callback is registered in all three inode_operations
structures (directory, file, and symlink) to ensure consistent
reporting across all inode types.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 fs/vboxsf/dir.c    |  1 +
 fs/vboxsf/file.c   |  6 ++++--
 fs/vboxsf/super.c  |  4 ++++
 fs/vboxsf/utils.c  | 31 +++++++++++++++++++++++++++++++
 fs/vboxsf/vfsmod.h |  6 ++++++
 5 files changed, 46 insertions(+), 2 deletions(-)

diff --git a/fs/vboxsf/dir.c b/fs/vboxsf/dir.c
index 42bedc4ec7af..c5bd3271aa96 100644
--- a/fs/vboxsf/dir.c
+++ b/fs/vboxsf/dir.c
@@ -477,4 +477,5 @@ const struct inode_operations vboxsf_dir_iops = {
 	.symlink = vboxsf_dir_symlink,
 	.getattr = vboxsf_getattr,
 	.setattr = vboxsf_setattr,
+	.fileattr_get = vboxsf_fileattr_get,
 };
diff --git a/fs/vboxsf/file.c b/fs/vboxsf/file.c
index 4bebd947314a..06308e38a70d 100644
--- a/fs/vboxsf/file.c
+++ b/fs/vboxsf/file.c
@@ -223,7 +223,8 @@ const struct file_operations vboxsf_reg_fops = {
 
 const struct inode_operations vboxsf_reg_iops = {
 	.getattr = vboxsf_getattr,
-	.setattr = vboxsf_setattr
+	.setattr = vboxsf_setattr,
+	.fileattr_get = vboxsf_fileattr_get,
 };
 
 static int vboxsf_read_folio(struct file *file, struct folio *folio)
@@ -390,5 +391,6 @@ static const char *vboxsf_get_link(struct dentry *dentry, struct inode *inode,
 }
 
 const struct inode_operations vboxsf_lnk_iops = {
-	.get_link = vboxsf_get_link
+	.get_link = vboxsf_get_link,
+	.fileattr_get = vboxsf_fileattr_get,
 };
diff --git a/fs/vboxsf/super.c b/fs/vboxsf/super.c
index 241647b060ee..fcabeca2a339 100644
--- a/fs/vboxsf/super.c
+++ b/fs/vboxsf/super.c
@@ -185,6 +185,10 @@ static int vboxsf_fill_super(struct super_block *sb, struct fs_context *fc)
 	if (err)
 		goto fail_unmap;
 
+	err = vboxsf_query_case_sensitive(sbi);
+	if (err)
+		goto fail_unmap;
+
 	sb->s_magic = VBOXSF_SUPER_MAGIC;
 	sb->s_blocksize = 1024;
 	sb->s_maxbytes = MAX_LFS_FILESIZE;
diff --git a/fs/vboxsf/utils.c b/fs/vboxsf/utils.c
index 9515bbf0b54c..0908fc071577 100644
--- a/fs/vboxsf/utils.c
+++ b/fs/vboxsf/utils.c
@@ -11,6 +11,7 @@
 #include <linux/sizes.h>
 #include <linux/pagemap.h>
 #include <linux/vfs.h>
+#include <linux/fileattr.h>
 #include "vfsmod.h"
 
 struct inode *vboxsf_new_inode(struct super_block *sb)
@@ -567,3 +568,33 @@ int vboxsf_dir_read_all(struct vboxsf_sbi *sbi, struct vboxsf_dir_info *sf_d,
 
 	return err;
 }
+
+int vboxsf_query_case_sensitive(struct vboxsf_sbi *sbi)
+{
+	struct shfl_volinfo volinfo;
+	u32 buf_len;
+	int err;
+
+	buf_len = sizeof(volinfo);
+	err = vboxsf_fsinfo(sbi->root, 0, SHFL_INFO_GET | SHFL_INFO_VOLUME,
+			    &buf_len, &volinfo);
+	if (err)
+		return err;
+
+	sbi->case_insensitive = !volinfo.properties.case_sensitive;
+	return 0;
+}
+
+int vboxsf_fileattr_get(struct dentry *dentry, struct file_kattr *fa)
+{
+	struct vboxsf_sbi *sbi = VBOXSF_SBI(dentry->d_sb);
+
+	fa->case_insensitive = sbi->case_insensitive;
+	/*
+	 * VirtualBox shared folders always preserve filename case
+	 * exactly as provided by the guest. The host interface does
+	 * not expose a case_preserving property.
+	 */
+	fa->case_preserving = true;
+	return 0;
+}
diff --git a/fs/vboxsf/vfsmod.h b/fs/vboxsf/vfsmod.h
index 05973eb89d52..b61afd0ce842 100644
--- a/fs/vboxsf/vfsmod.h
+++ b/fs/vboxsf/vfsmod.h
@@ -47,6 +47,7 @@ struct vboxsf_sbi {
 	u32 next_generation;
 	u32 root;
 	int bdi_id;
+	bool case_insensitive;
 };
 
 /* per-inode information */
@@ -111,6 +112,11 @@ void vboxsf_dir_info_free(struct vboxsf_dir_info *p);
 int vboxsf_dir_read_all(struct vboxsf_sbi *sbi, struct vboxsf_dir_info *sf_d,
 			u64 handle);
 
+int vboxsf_query_case_sensitive(struct vboxsf_sbi *sbi);
+
+struct file_kattr;
+int vboxsf_fileattr_get(struct dentry *dentry, struct file_kattr *fa);
+
 /* from vboxsf_wrappers.c */
 int vboxsf_connect(void);
 void vboxsf_disconnect(void);
-- 
2.52.0


WARNING: multiple messages have this Message-ID (diff)
From: Chuck Lever via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: vira, Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>
Cc: pc@manguebit.org, yuezhang.mo@sony.com, cem@kernel.org,
	almaz.alexandrovich@paragon-software.com,
	adilger.kernel@dilger.ca, linux-cifs@vger.kernel.org,
	sfrench@samba.org, slava@dubeyko.com, linux-ext4@vger.kernel.org,
	linkinjeon@kernel.org, sprasad@microsoft.com, frank.li@vivo.com,
	ronniesahlberg@gmail.com, glaubitz@physik.fu-berlin.de,
	jaegeuk@kernel.org, hirofumi@mail.parknet.co.jp,
	linux-nfs@vger.kernel.org, tytso@mit.edu,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-xfs@vger.kernel.org, senozhatsky@chromium.org,
	Chuck Lever <chuck.lever@oracle.com>,
	hansg@kernel.org, anna@kernel.org, linux-fsdevel@vger.kernel.org,
	sj1557.seo@samsung.com, trondmy@kernel.org
Subject: [f2fs-dev] [PATCH v3 12/16] vboxsf: Implement fileattr_get for case sensitivity
Date: Mon, 12 Jan 2026 12:46:25 -0500	[thread overview]
Message-ID: <20260112174629.3729358-13-cel@kernel.org> (raw)
In-Reply-To: <20260112174629.3729358-1-cel@kernel.org>

From: Chuck Lever <chuck.lever@oracle.com>

Upper layers such as NFSD need a way to query whether a
filesystem handles filenames in a case-sensitive manner. The
file_kattr structure now provides case_insensitive and
case_preserving fields for this purpose, but vboxsf does not
yet report its case sensitivity behavior through this interface.

Implement vboxsf_fileattr_get() to report the case handling
behavior of VirtualBox shared folders. The case sensitivity
property is queried from the VirtualBox host service at mount
time and cached in struct vboxsf_sbi. The host determines case
sensitivity based on the underlying host filesystem (for
example, Windows NTFS is case-insensitive while Linux ext4 is
case-sensitive).

VirtualBox shared folders always preserve filename case exactly
as provided by the guest. The host interface does not expose a
case_preserving property, so this is hardcoded to true.

The callback is registered in all three inode_operations
structures (directory, file, and symlink) to ensure consistent
reporting across all inode types.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 fs/vboxsf/dir.c    |  1 +
 fs/vboxsf/file.c   |  6 ++++--
 fs/vboxsf/super.c  |  4 ++++
 fs/vboxsf/utils.c  | 31 +++++++++++++++++++++++++++++++
 fs/vboxsf/vfsmod.h |  6 ++++++
 5 files changed, 46 insertions(+), 2 deletions(-)

diff --git a/fs/vboxsf/dir.c b/fs/vboxsf/dir.c
index 42bedc4ec7af..c5bd3271aa96 100644
--- a/fs/vboxsf/dir.c
+++ b/fs/vboxsf/dir.c
@@ -477,4 +477,5 @@ const struct inode_operations vboxsf_dir_iops = {
 	.symlink = vboxsf_dir_symlink,
 	.getattr = vboxsf_getattr,
 	.setattr = vboxsf_setattr,
+	.fileattr_get = vboxsf_fileattr_get,
 };
diff --git a/fs/vboxsf/file.c b/fs/vboxsf/file.c
index 4bebd947314a..06308e38a70d 100644
--- a/fs/vboxsf/file.c
+++ b/fs/vboxsf/file.c
@@ -223,7 +223,8 @@ const struct file_operations vboxsf_reg_fops = {
 
 const struct inode_operations vboxsf_reg_iops = {
 	.getattr = vboxsf_getattr,
-	.setattr = vboxsf_setattr
+	.setattr = vboxsf_setattr,
+	.fileattr_get = vboxsf_fileattr_get,
 };
 
 static int vboxsf_read_folio(struct file *file, struct folio *folio)
@@ -390,5 +391,6 @@ static const char *vboxsf_get_link(struct dentry *dentry, struct inode *inode,
 }
 
 const struct inode_operations vboxsf_lnk_iops = {
-	.get_link = vboxsf_get_link
+	.get_link = vboxsf_get_link,
+	.fileattr_get = vboxsf_fileattr_get,
 };
diff --git a/fs/vboxsf/super.c b/fs/vboxsf/super.c
index 241647b060ee..fcabeca2a339 100644
--- a/fs/vboxsf/super.c
+++ b/fs/vboxsf/super.c
@@ -185,6 +185,10 @@ static int vboxsf_fill_super(struct super_block *sb, struct fs_context *fc)
 	if (err)
 		goto fail_unmap;
 
+	err = vboxsf_query_case_sensitive(sbi);
+	if (err)
+		goto fail_unmap;
+
 	sb->s_magic = VBOXSF_SUPER_MAGIC;
 	sb->s_blocksize = 1024;
 	sb->s_maxbytes = MAX_LFS_FILESIZE;
diff --git a/fs/vboxsf/utils.c b/fs/vboxsf/utils.c
index 9515bbf0b54c..0908fc071577 100644
--- a/fs/vboxsf/utils.c
+++ b/fs/vboxsf/utils.c
@@ -11,6 +11,7 @@
 #include <linux/sizes.h>
 #include <linux/pagemap.h>
 #include <linux/vfs.h>
+#include <linux/fileattr.h>
 #include "vfsmod.h"
 
 struct inode *vboxsf_new_inode(struct super_block *sb)
@@ -567,3 +568,33 @@ int vboxsf_dir_read_all(struct vboxsf_sbi *sbi, struct vboxsf_dir_info *sf_d,
 
 	return err;
 }
+
+int vboxsf_query_case_sensitive(struct vboxsf_sbi *sbi)
+{
+	struct shfl_volinfo volinfo;
+	u32 buf_len;
+	int err;
+
+	buf_len = sizeof(volinfo);
+	err = vboxsf_fsinfo(sbi->root, 0, SHFL_INFO_GET | SHFL_INFO_VOLUME,
+			    &buf_len, &volinfo);
+	if (err)
+		return err;
+
+	sbi->case_insensitive = !volinfo.properties.case_sensitive;
+	return 0;
+}
+
+int vboxsf_fileattr_get(struct dentry *dentry, struct file_kattr *fa)
+{
+	struct vboxsf_sbi *sbi = VBOXSF_SBI(dentry->d_sb);
+
+	fa->case_insensitive = sbi->case_insensitive;
+	/*
+	 * VirtualBox shared folders always preserve filename case
+	 * exactly as provided by the guest. The host interface does
+	 * not expose a case_preserving property.
+	 */
+	fa->case_preserving = true;
+	return 0;
+}
diff --git a/fs/vboxsf/vfsmod.h b/fs/vboxsf/vfsmod.h
index 05973eb89d52..b61afd0ce842 100644
--- a/fs/vboxsf/vfsmod.h
+++ b/fs/vboxsf/vfsmod.h
@@ -47,6 +47,7 @@ struct vboxsf_sbi {
 	u32 next_generation;
 	u32 root;
 	int bdi_id;
+	bool case_insensitive;
 };
 
 /* per-inode information */
@@ -111,6 +112,11 @@ void vboxsf_dir_info_free(struct vboxsf_dir_info *p);
 int vboxsf_dir_read_all(struct vboxsf_sbi *sbi, struct vboxsf_dir_info *sf_d,
 			u64 handle);
 
+int vboxsf_query_case_sensitive(struct vboxsf_sbi *sbi);
+
+struct file_kattr;
+int vboxsf_fileattr_get(struct dentry *dentry, struct file_kattr *fa);
+
 /* from vboxsf_wrappers.c */
 int vboxsf_connect(void);
 void vboxsf_disconnect(void);
-- 
2.52.0



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  parent reply	other threads:[~2026-01-12 17:47 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-12 17:46 [PATCH v3 00/16] Exposing case folding behavior Chuck Lever
2026-01-12 17:46 ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-01-12 17:46 ` [PATCH v3 01/16] fs: Add case sensitivity info to file_kattr Chuck Lever
2026-01-12 17:46   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-01-13 15:21   ` Christoph Hellwig
2026-01-13 15:21     ` [f2fs-dev] " Christoph Hellwig
2026-01-12 17:46 ` [PATCH v3 02/16] fat: Implement fileattr_get for case sensitivity Chuck Lever
2026-01-12 17:46   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-01-13 15:23   ` Christoph Hellwig
2026-01-13 15:23     ` [f2fs-dev] " Christoph Hellwig
2026-01-12 17:46 ` [PATCH v3 03/16] exfat: " Chuck Lever
2026-01-12 17:46   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-01-14  0:45   ` Namjae Jeon
2026-01-14  0:45     ` [f2fs-dev] " Namjae Jeon via Linux-f2fs-devel
2026-01-12 17:46 ` [PATCH v3 04/16] ntfs3: " Chuck Lever
2026-01-12 17:46   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-01-12 17:46 ` [PATCH v3 05/16] hfs: " Chuck Lever
2026-01-12 17:46   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-01-13 17:35   ` Viacheslav Dubeyko
2026-01-13 17:35     ` [f2fs-dev] " Viacheslav Dubeyko via Linux-f2fs-devel
2026-01-12 17:46 ` [PATCH v3 06/16] hfsplus: Report case sensitivity in fileattr_get Chuck Lever
2026-01-12 17:46   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-01-13 17:36   ` Viacheslav Dubeyko
2026-01-13 17:36     ` [f2fs-dev] " Viacheslav Dubeyko via Linux-f2fs-devel
2026-01-12 17:46 ` [PATCH v3 07/16] ext4: " Chuck Lever
2026-01-12 17:46   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-01-13 11:50   ` Jan Kara
2026-01-13 11:50     ` [f2fs-dev] " Jan Kara
2026-01-12 17:46 ` [PATCH v3 08/16] xfs: " Chuck Lever
2026-01-12 17:46   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-01-13 16:02   ` Darrick J. Wong
2026-01-13 16:02     ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-01-13 16:43     ` Neal Gompa
2026-01-13 16:43       ` [f2fs-dev] " Neal Gompa
2026-01-12 17:46 ` [PATCH v3 09/16] cifs: Implement fileattr_get for case sensitivity Chuck Lever
2026-01-12 17:46   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-01-12 17:46 ` [PATCH v3 10/16] nfs: " Chuck Lever
2026-01-12 17:46   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-01-12 17:46 ` [PATCH v3 11/16] f2fs: Add case sensitivity reporting to fileattr_get Chuck Lever
2026-01-12 17:46   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-01-14  0:50   ` Chao Yu
2026-01-14  0:50     ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-01-12 17:46 ` Chuck Lever [this message]
2026-01-12 17:46   ` [f2fs-dev] [PATCH v3 12/16] vboxsf: Implement fileattr_get for case sensitivity Chuck Lever via Linux-f2fs-devel
2026-01-12 17:46 ` [PATCH v3 13/16] isofs: " Chuck Lever
2026-01-12 17:46   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-01-13 11:50   ` Jan Kara
2026-01-13 11:50     ` [f2fs-dev] " Jan Kara
2026-01-12 17:46 ` [PATCH v3 14/16] nfsd: Report export case-folding via NFSv3 PATHCONF Chuck Lever
2026-01-12 17:46   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-01-12 17:46 ` [PATCH v3 15/16] nfsd: Implement NFSv4 FATTR4_CASE_INSENSITIVE and FATTR4_CASE_PRESERVING Chuck Lever
2026-01-12 17:46   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-01-12 17:46 ` [PATCH v3 16/16] ksmbd: Report filesystem case sensitivity via FS_ATTRIBUTE_INFORMATION Chuck Lever
2026-01-12 17:46   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-01-14  0:46   ` Namjae Jeon
2026-01-14  0:46     ` [f2fs-dev] " Namjae Jeon via Linux-f2fs-devel
2026-01-13  9:04 ` [PATCH v3 00/16] Exposing case folding behavior Christian Brauner
2026-01-13  9:04   ` [f2fs-dev] " Christian Brauner via Linux-f2fs-devel
2026-01-13 13:58   ` Chuck Lever
2026-01-13 13:58     ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260112174629.3729358-13-cel@kernel.org \
    --to=cel@kernel.org \
    --cc=adilger.kernel@dilger.ca \
    --cc=almaz.alexandrovich@paragon-software.com \
    --cc=anna@kernel.org \
    --cc=brauner@kernel.org \
    --cc=cem@kernel.org \
    --cc=chao@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=frank.li@vivo.com \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=hansg@kernel.org \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=jack@suse.cz \
    --cc=jaegeuk@kernel.org \
    --cc=linkinjeon@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=pc@manguebit.org \
    --cc=ronniesahlberg@gmail.com \
    --cc=senozhatsky@chromium.org \
    --cc=sfrench@samba.org \
    --cc=sj1557.seo@samsung.com \
    --cc=slava@dubeyko.com \
    --cc=sprasad@microsoft.com \
    --cc=trondmy@kernel.org \
    --cc=tytso@mit.edu \
    --cc=yuezhang.mo@sony.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.