From: Chuck Lever <cel@kernel.org>
To: vira, Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>
Cc: <linux-fsdevel@vger.kernel.org>,
linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-cifs@vger.kernel.org, <linux-nfs@vger.kernel.org>,
linux-f2fs-devel@lists.sourceforge.net,
hirofumi@mail.parknet.co.jp, linkinjeon@kernel.org,
sj1557.seo@samsung.com, yuezhang.mo@sony.com,
almaz.alexandrovich@paragon-software.com, slava@dubeyko.com,
glaubitz@physik.fu-berlin.de, frank.li@vivo.com, tytso@mit.edu,
adilger.kernel@dilger.ca, cem@kernel.org, sfrench@samba.org,
pc@manguebit.org, ronniesahlberg@gmail.com,
sprasad@microsoft.com, trondmy@kernel.org, anna@kernel.org,
jaegeuk@kernel.org, chao@kernel.org, hansg@kernel.org,
senozhatsky@chromium.org, Chuck Lever <chuck.lever@oracle.com>
Subject: [PATCH v3 16/16] ksmbd: Report filesystem case sensitivity via FS_ATTRIBUTE_INFORMATION
Date: Mon, 12 Jan 2026 12:46:29 -0500 [thread overview]
Message-ID: <20260112174629.3729358-17-cel@kernel.org> (raw)
In-Reply-To: <20260112174629.3729358-1-cel@kernel.org>
From: Chuck Lever <chuck.lever@oracle.com>
ksmbd hard-codes FILE_CASE_SENSITIVE_SEARCH and
FILE_CASE_PRESERVED_NAMES in FS_ATTRIBUTE_INFORMATION responses,
incorrectly indicating all exports are case-sensitive. This breaks
clients accessing case-insensitive filesystems like exFAT or
ext4/f2fs directories with casefold enabled.
Query actual case behavior via vfs_fileattr_get() and report accurate
attributes to SMB clients. Filesystems without ->fileattr_get continue
reporting default POSIX behavior (case-sensitive, case-preserving).
SMB's FS_ATTRIBUTE_INFORMATION reports per-share attributes from the
share root, not per-file. Shares mixing casefold and non-casefold
directories report the root directory's behavior.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
fs/smb/server/smb2pdu.c | 30 ++++++++++++++++++++++++------
1 file changed, 24 insertions(+), 6 deletions(-)
diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c
index 2fcd0d4d1fb0..2db189fef4da 100644
--- a/fs/smb/server/smb2pdu.c
+++ b/fs/smb/server/smb2pdu.c
@@ -13,6 +13,7 @@
#include <linux/falloc.h>
#include <linux/mount.h>
#include <linux/filelock.h>
+#include <linux/fileattr.h>
#include "glob.h"
#include "smbfsctl.h"
@@ -5486,16 +5487,33 @@ static int smb2_get_info_filesystem(struct ksmbd_work *work,
case FS_ATTRIBUTE_INFORMATION:
{
FILE_SYSTEM_ATTRIBUTE_INFO *info;
+ struct file_kattr fa = {};
size_t sz;
+ u32 attrs;
+ int err;
info = (FILE_SYSTEM_ATTRIBUTE_INFO *)rsp->Buffer;
- info->Attributes = cpu_to_le32(FILE_SUPPORTS_OBJECT_IDS |
- FILE_PERSISTENT_ACLS |
- FILE_UNICODE_ON_DISK |
- FILE_CASE_PRESERVED_NAMES |
- FILE_CASE_SENSITIVE_SEARCH |
- FILE_SUPPORTS_BLOCK_REFCOUNTING);
+ attrs = FILE_SUPPORTS_OBJECT_IDS |
+ FILE_PERSISTENT_ACLS |
+ FILE_UNICODE_ON_DISK |
+ FILE_SUPPORTS_BLOCK_REFCOUNTING;
+ err = vfs_fileattr_get(path.dentry, &fa);
+ if (err && err != -ENOIOCTLCMD) {
+ path_put(&path);
+ return err;
+ }
+ if (err == -ENOIOCTLCMD) {
+ /* Default POSIX: case-sensitive and case-preserving */
+ fa.case_insensitive = false;
+ fa.case_preserving = true;
+ }
+ if (!fa.case_insensitive)
+ attrs |= FILE_CASE_SENSITIVE_SEARCH;
+ if (fa.case_preserving)
+ attrs |= FILE_CASE_PRESERVED_NAMES;
+
+ info->Attributes = cpu_to_le32(attrs);
info->Attributes |= cpu_to_le32(server_conf.share_fake_fscaps);
if (test_share_config_flag(work->tcon->share_conf,
--
2.52.0
WARNING: multiple messages have this Message-ID (diff)
From: Chuck Lever via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: vira, Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>
Cc: pc@manguebit.org, yuezhang.mo@sony.com, cem@kernel.org,
almaz.alexandrovich@paragon-software.com,
adilger.kernel@dilger.ca, linux-cifs@vger.kernel.org,
sfrench@samba.org, slava@dubeyko.com, linux-ext4@vger.kernel.org,
linkinjeon@kernel.org, sprasad@microsoft.com, frank.li@vivo.com,
ronniesahlberg@gmail.com, glaubitz@physik.fu-berlin.de,
jaegeuk@kernel.org, hirofumi@mail.parknet.co.jp,
linux-nfs@vger.kernel.org, tytso@mit.edu,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, senozhatsky@chromium.org,
Chuck Lever <chuck.lever@oracle.com>,
hansg@kernel.org, anna@kernel.org, linux-fsdevel@vger.kernel.org,
sj1557.seo@samsung.com, trondmy@kernel.org
Subject: [f2fs-dev] [PATCH v3 16/16] ksmbd: Report filesystem case sensitivity via FS_ATTRIBUTE_INFORMATION
Date: Mon, 12 Jan 2026 12:46:29 -0500 [thread overview]
Message-ID: <20260112174629.3729358-17-cel@kernel.org> (raw)
In-Reply-To: <20260112174629.3729358-1-cel@kernel.org>
From: Chuck Lever <chuck.lever@oracle.com>
ksmbd hard-codes FILE_CASE_SENSITIVE_SEARCH and
FILE_CASE_PRESERVED_NAMES in FS_ATTRIBUTE_INFORMATION responses,
incorrectly indicating all exports are case-sensitive. This breaks
clients accessing case-insensitive filesystems like exFAT or
ext4/f2fs directories with casefold enabled.
Query actual case behavior via vfs_fileattr_get() and report accurate
attributes to SMB clients. Filesystems without ->fileattr_get continue
reporting default POSIX behavior (case-sensitive, case-preserving).
SMB's FS_ATTRIBUTE_INFORMATION reports per-share attributes from the
share root, not per-file. Shares mixing casefold and non-casefold
directories report the root directory's behavior.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
fs/smb/server/smb2pdu.c | 30 ++++++++++++++++++++++++------
1 file changed, 24 insertions(+), 6 deletions(-)
diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c
index 2fcd0d4d1fb0..2db189fef4da 100644
--- a/fs/smb/server/smb2pdu.c
+++ b/fs/smb/server/smb2pdu.c
@@ -13,6 +13,7 @@
#include <linux/falloc.h>
#include <linux/mount.h>
#include <linux/filelock.h>
+#include <linux/fileattr.h>
#include "glob.h"
#include "smbfsctl.h"
@@ -5486,16 +5487,33 @@ static int smb2_get_info_filesystem(struct ksmbd_work *work,
case FS_ATTRIBUTE_INFORMATION:
{
FILE_SYSTEM_ATTRIBUTE_INFO *info;
+ struct file_kattr fa = {};
size_t sz;
+ u32 attrs;
+ int err;
info = (FILE_SYSTEM_ATTRIBUTE_INFO *)rsp->Buffer;
- info->Attributes = cpu_to_le32(FILE_SUPPORTS_OBJECT_IDS |
- FILE_PERSISTENT_ACLS |
- FILE_UNICODE_ON_DISK |
- FILE_CASE_PRESERVED_NAMES |
- FILE_CASE_SENSITIVE_SEARCH |
- FILE_SUPPORTS_BLOCK_REFCOUNTING);
+ attrs = FILE_SUPPORTS_OBJECT_IDS |
+ FILE_PERSISTENT_ACLS |
+ FILE_UNICODE_ON_DISK |
+ FILE_SUPPORTS_BLOCK_REFCOUNTING;
+ err = vfs_fileattr_get(path.dentry, &fa);
+ if (err && err != -ENOIOCTLCMD) {
+ path_put(&path);
+ return err;
+ }
+ if (err == -ENOIOCTLCMD) {
+ /* Default POSIX: case-sensitive and case-preserving */
+ fa.case_insensitive = false;
+ fa.case_preserving = true;
+ }
+ if (!fa.case_insensitive)
+ attrs |= FILE_CASE_SENSITIVE_SEARCH;
+ if (fa.case_preserving)
+ attrs |= FILE_CASE_PRESERVED_NAMES;
+
+ info->Attributes = cpu_to_le32(attrs);
info->Attributes |= cpu_to_le32(server_conf.share_fake_fscaps);
if (test_share_config_flag(work->tcon->share_conf,
--
2.52.0
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2026-01-12 17:47 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 17:46 [PATCH v3 00/16] Exposing case folding behavior Chuck Lever
2026-01-12 17:46 ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-01-12 17:46 ` [PATCH v3 01/16] fs: Add case sensitivity info to file_kattr Chuck Lever
2026-01-12 17:46 ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-01-13 15:21 ` Christoph Hellwig
2026-01-13 15:21 ` [f2fs-dev] " Christoph Hellwig
2026-01-12 17:46 ` [PATCH v3 02/16] fat: Implement fileattr_get for case sensitivity Chuck Lever
2026-01-12 17:46 ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-01-13 15:23 ` Christoph Hellwig
2026-01-13 15:23 ` [f2fs-dev] " Christoph Hellwig
2026-01-12 17:46 ` [PATCH v3 03/16] exfat: " Chuck Lever
2026-01-12 17:46 ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-01-14 0:45 ` Namjae Jeon
2026-01-14 0:45 ` [f2fs-dev] " Namjae Jeon via Linux-f2fs-devel
2026-01-12 17:46 ` [PATCH v3 04/16] ntfs3: " Chuck Lever
2026-01-12 17:46 ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-01-12 17:46 ` [PATCH v3 05/16] hfs: " Chuck Lever
2026-01-12 17:46 ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-01-13 17:35 ` Viacheslav Dubeyko
2026-01-13 17:35 ` [f2fs-dev] " Viacheslav Dubeyko via Linux-f2fs-devel
2026-01-12 17:46 ` [PATCH v3 06/16] hfsplus: Report case sensitivity in fileattr_get Chuck Lever
2026-01-12 17:46 ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-01-13 17:36 ` Viacheslav Dubeyko
2026-01-13 17:36 ` [f2fs-dev] " Viacheslav Dubeyko via Linux-f2fs-devel
2026-01-12 17:46 ` [PATCH v3 07/16] ext4: " Chuck Lever
2026-01-12 17:46 ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-01-13 11:50 ` Jan Kara
2026-01-13 11:50 ` [f2fs-dev] " Jan Kara
2026-01-12 17:46 ` [PATCH v3 08/16] xfs: " Chuck Lever
2026-01-12 17:46 ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-01-13 16:02 ` Darrick J. Wong
2026-01-13 16:02 ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-01-13 16:43 ` Neal Gompa
2026-01-13 16:43 ` [f2fs-dev] " Neal Gompa
2026-01-12 17:46 ` [PATCH v3 09/16] cifs: Implement fileattr_get for case sensitivity Chuck Lever
2026-01-12 17:46 ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-01-12 17:46 ` [PATCH v3 10/16] nfs: " Chuck Lever
2026-01-12 17:46 ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-01-12 17:46 ` [PATCH v3 11/16] f2fs: Add case sensitivity reporting to fileattr_get Chuck Lever
2026-01-12 17:46 ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-01-14 0:50 ` Chao Yu
2026-01-14 0:50 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-01-12 17:46 ` [PATCH v3 12/16] vboxsf: Implement fileattr_get for case sensitivity Chuck Lever
2026-01-12 17:46 ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-01-12 17:46 ` [PATCH v3 13/16] isofs: " Chuck Lever
2026-01-12 17:46 ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-01-13 11:50 ` Jan Kara
2026-01-13 11:50 ` [f2fs-dev] " Jan Kara
2026-01-12 17:46 ` [PATCH v3 14/16] nfsd: Report export case-folding via NFSv3 PATHCONF Chuck Lever
2026-01-12 17:46 ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-01-12 17:46 ` [PATCH v3 15/16] nfsd: Implement NFSv4 FATTR4_CASE_INSENSITIVE and FATTR4_CASE_PRESERVING Chuck Lever
2026-01-12 17:46 ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-01-12 17:46 ` Chuck Lever [this message]
2026-01-12 17:46 ` [f2fs-dev] [PATCH v3 16/16] ksmbd: Report filesystem case sensitivity via FS_ATTRIBUTE_INFORMATION Chuck Lever via Linux-f2fs-devel
2026-01-14 0:46 ` Namjae Jeon
2026-01-14 0:46 ` [f2fs-dev] " Namjae Jeon via Linux-f2fs-devel
2026-01-13 9:04 ` [PATCH v3 00/16] Exposing case folding behavior Christian Brauner
2026-01-13 9:04 ` [f2fs-dev] " Christian Brauner via Linux-f2fs-devel
2026-01-13 13:58 ` Chuck Lever
2026-01-13 13:58 ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260112174629.3729358-17-cel@kernel.org \
--to=cel@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=anna@kernel.org \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=chao@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=frank.li@vivo.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=hansg@kernel.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=pc@manguebit.org \
--cc=ronniesahlberg@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=sfrench@samba.org \
--cc=sj1557.seo@samsung.com \
--cc=slava@dubeyko.com \
--cc=sprasad@microsoft.com \
--cc=trondmy@kernel.org \
--cc=tytso@mit.edu \
--cc=yuezhang.mo@sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.