From: kernel test robot <lkp@intel.com>
To: Markus Probst <markus.probst@posteo.de>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH RFC 4/4] leds: add disk trigger for each ata port
Date: Mon, 26 Jan 2026 01:57:04 +0800 [thread overview]
Message-ID: <202601260105.4AcOxoMJ-lkp@intel.com> (raw)
In-Reply-To: <20260123-ledtrig_disk_-v1-4-07004756467b@posteo.de>
Hi Markus,
[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:
[auto build test ERROR on 24d479d26b25bce5faea3ddd9fa8f3a6c3129ea7]
url: https://github.com/intel-lab-lkp/linux/commits/Markus-Probst/leds-dt-bindings-add-disk-trigger-led-pattern/20260124-030650
base: 24d479d26b25bce5faea3ddd9fa8f3a6c3129ea7
patch link: https://lore.kernel.org/r/20260123-ledtrig_disk_-v1-4-07004756467b%40posteo.de
patch subject: [PATCH RFC 4/4] leds: add disk trigger for each ata port
config: x86_64-buildonly-randconfig-002-20260125 (https://download.01.org/0day-ci/archive/20260126/202601260105.4AcOxoMJ-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260126/202601260105.4AcOxoMJ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601260105.4AcOxoMJ-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
>> Warning: drivers/ata/libata-core.c:5543 function parameter 'port_no' not described in 'ata_port_alloc'
>> Warning: drivers/ata/libata-core.c:5543 function parameter 'port_no' not described in 'ata_port_alloc'
--
drivers/leds/trigger/ledtrig-disk.c: In function 'pattern_init':
drivers/leds/trigger/ledtrig-disk.c:119:9: error: cleanup argument not a function
119 | u32 *pattern __free(kfree) = led_get_default_pattern(led_cdev, &size);
| ^~~
drivers/leds/trigger/ledtrig-disk.c: In function 'ledtrig_disk_activate':
drivers/leds/trigger/ledtrig-disk.c:139:21: error: implicit declaration of function 'kzalloc' [-Wimplicit-function-declaration]
139 | disk_data = kzalloc(sizeof(*disk_data), GFP_KERNEL);
| ^~~~~~~
drivers/leds/trigger/ledtrig-disk.c:139:19: error: assignment to 'struct ledtrig_disk_data *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
139 | disk_data = kzalloc(sizeof(*disk_data), GFP_KERNEL);
| ^
drivers/leds/trigger/ledtrig-disk.c: In function 'ledtrig_disk_blink_oneshot':
drivers/leds/trigger/ledtrig-disk.c:186:9: error: implicit declaration of function 'list_for_each_entry_rcu'; did you mean 'list_for_each_entry_from'? [-Wimplicit-function-declaration]
186 | list_for_each_entry_rcu(led_cdev, &trig->led_cdevs, trig_list) {
| ^~~~~~~~~~~~~~~~~~~~~~~
| list_for_each_entry_from
drivers/leds/trigger/ledtrig-disk.c:186:61: error: 'trig_list' undeclared (first use in this function); did you mean 'lru_list'?
186 | list_for_each_entry_rcu(led_cdev, &trig->led_cdevs, trig_list) {
| ^~~~~~~~~
| lru_list
drivers/leds/trigger/ledtrig-disk.c:186:61: note: each undeclared identifier is reported only once for each function it appears in
drivers/leds/trigger/ledtrig-disk.c:186:71: error: expected ';' before '{' token
186 | list_for_each_entry_rcu(led_cdev, &trig->led_cdevs, trig_list) {
| ^~
| ;
drivers/leds/trigger/ledtrig-disk.c:183:35: warning: unused variable 'disk_data' [-Wunused-variable]
183 | struct ledtrig_disk_data *disk_data;
| ^~~~~~~~~
drivers/leds/trigger/ledtrig-disk.c: In function 'ledtrig_disk_trigger_register':
>> drivers/leds/trigger/ledtrig-disk.c:214:48: error: initialization of 'struct ledtrig_disk_trigger *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
214 | struct ledtrig_disk_trigger *trigger = kzalloc(sizeof(*trigger), GFP_KERNEL);
| ^~~~~~~
>> drivers/leds/trigger/ledtrig-disk.c:220:27: error: assignment to 'const char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
220 | trigger->all.name = kzalloc(TRIG_NAME_MAX, GFP_KERNEL);
| ^
drivers/leds/trigger/ledtrig-disk.c:239:28: error: assignment to 'const char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
239 | trigger->read.name = kzalloc(TRIG_NAME_MAX, GFP_KERNEL);
| ^
drivers/leds/trigger/ledtrig-disk.c:258:29: error: assignment to 'const char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
258 | trigger->write.name = kzalloc(TRIG_NAME_MAX, GFP_KERNEL);
| ^
>> drivers/leds/trigger/ledtrig-disk.c:284:9: error: implicit declaration of function 'kfree' [-Wimplicit-function-declaration]
284 | kfree(trigger->all.name);
| ^~~~~
vim +214 drivers/leds/trigger/ledtrig-disk.c
211
212 struct ledtrig_disk_trigger *ledtrig_disk_trigger_register(const char *name)
213 {
> 214 struct ledtrig_disk_trigger *trigger = kzalloc(sizeof(*trigger), GFP_KERNEL);
215 int ret, n;
216
217 if (!trigger)
218 return ERR_PTR(-ENOMEM);
219
> 220 trigger->all.name = kzalloc(TRIG_NAME_MAX, GFP_KERNEL);
221 if (!trigger->all.name) {
222 ret = -ENOMEM;
223 goto err1;
224 }
225
226 n = snprintf((char *)trigger->all.name, TRIG_NAME_MAX, "%s-disk-activity", name);
227 if (n >= TRIG_NAME_MAX) {
228 ret = -E2BIG;
229 goto err1;
230 }
231
232 trigger->all.activate = ledtrig_disk_activate;
233 trigger->all.groups = ledtrig_disk_groups;
234
235 ret = led_trigger_register(&trigger->all);
236 if (ret)
237 goto err1;
238
239 trigger->read.name = kzalloc(TRIG_NAME_MAX, GFP_KERNEL);
240 if (!trigger->read.name) {
241 ret = -ENOMEM;
242 goto err2;
243 }
244
245 n = snprintf((char *)trigger->read.name, TRIG_NAME_MAX, "%s-disk-read", name);
246 if (n >= TRIG_NAME_MAX) {
247 ret = -E2BIG;
248 goto err2;
249 }
250
251 trigger->read.activate = ledtrig_disk_activate;
252 trigger->read.groups = ledtrig_disk_groups;
253
254 ret = led_trigger_register(&trigger->read);
255 if (ret)
256 goto err2;
257
258 trigger->write.name = kzalloc(TRIG_NAME_MAX, GFP_KERNEL);
259 if (!trigger->write.name) {
260 ret = -ENOMEM;
261 goto err3;
262 }
263
264 n = snprintf((char *)trigger->write.name, TRIG_NAME_MAX, "%s-disk-write", name);
265 if (n >= TRIG_NAME_MAX) {
266 ret = -E2BIG;
267 goto err3;
268 }
269
270 trigger->write.activate = ledtrig_disk_activate;
271 trigger->write.groups = ledtrig_disk_groups;
272
273 ret = led_trigger_register(&trigger->write);
274 if (ret)
275 goto err3;
276
277 return trigger;
278
279 err3:
280 led_trigger_unregister(&trigger->read);
281 err2:
282 led_trigger_unregister(&trigger->all);
283 err1:
> 284 kfree(trigger->all.name);
285 kfree(trigger->read.name);
286 kfree(trigger->write.name);
287 kfree(trigger);
288
289 return ERR_PTR(ret);
290 }
291 EXPORT_SYMBOL(ledtrig_disk_trigger_register);
292
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2026-01-25 17:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 19:05 [PATCH RFC 0/4] leds: extend disk trigger Markus Probst
2026-01-23 19:05 ` [PATCH RFC 1/4] leds: dt-bindings: add disk trigger led pattern Markus Probst
2026-01-23 19:05 ` [PATCH RFC 2/4] leds: dt-bindings: add disk trigger for each ata port Markus Probst
2026-01-23 19:05 ` [PATCH RFC 3/4] leds: add delay_on, delay_off and invert attributes to disk trigger Markus Probst
2026-01-23 19:18 ` Markus Probst
2026-01-25 17:14 ` kernel test robot
2026-01-26 0:42 ` kernel test robot
2026-01-23 19:05 ` [PATCH RFC 4/4] leds: add disk trigger for each ata port Markus Probst
2026-01-25 17:57 ` kernel test robot [this message]
2026-01-26 6:34 ` Damien Le Moal
2026-01-24 23:21 ` [PATCH RFC 0/4] leds: extend disk trigger Pavel Machek
2026-01-25 0:19 ` Markus Probst
2026-01-26 9:00 ` Niklas Cassel
2026-01-26 16:19 ` Ian Pilcher
2026-01-26 19:03 ` Niklas Cassel
2026-01-26 22:06 ` Markus Probst
2026-01-27 9:32 ` Niklas Cassel
2026-01-27 15:34 ` Markus Probst
2026-01-28 6:34 ` Damien Le Moal
2026-01-28 15:44 ` Markus Probst
2026-01-28 21:51 ` Niklas Cassel
2026-01-29 4:41 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202601260105.4AcOxoMJ-lkp@intel.com \
--to=lkp@intel.com \
--cc=markus.probst@posteo.de \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.