Re: [PATCH RFC 3/4] leds: add delay_on, delay_off and invert attributes to disk trigger

[kernel test robot <lkp@intel.com>]

Hi Markus,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on 24d479d26b25bce5faea3ddd9fa8f3a6c3129ea7]

url:    https://github.com/intel-lab-lkp/linux/commits/Markus-Probst/leds-dt-bindings-add-disk-trigger-led-pattern/20260124-030650
base:   24d479d26b25bce5faea3ddd9fa8f3a6c3129ea7
patch link:    https://lore.kernel.org/r/20260123-ledtrig_disk_-v1-3-07004756467b%40posteo.de
patch subject: [PATCH RFC 3/4] leds: add delay_on, delay_off and invert attributes to disk trigger
config: x86_64-buildonly-randconfig-002-20260125 (https://download.01.org/0day-ci/archive/20260126/202601260156.pfrTEEer-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260126/202601260156.pfrTEEer-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601260156.pfrTEEer-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   drivers/leds/trigger/ledtrig-disk.c: In function 'pattern_init':
>> drivers/leds/trigger/ledtrig-disk.c:119:9: error: cleanup argument not a function
     119 |         u32 *pattern __free(kfree) = led_get_default_pattern(led_cdev, &size);
         |         ^~~
   drivers/leds/trigger/ledtrig-disk.c: In function 'ledtrig_disk_activate':
>> drivers/leds/trigger/ledtrig-disk.c:139:21: error: implicit declaration of function 'kzalloc' [-Wimplicit-function-declaration]
     139 |         disk_data = kzalloc(sizeof(*disk_data), GFP_KERNEL);
         |                     ^~~~~~~
>> drivers/leds/trigger/ledtrig-disk.c:139:19: error: assignment to 'struct ledtrig_disk_data *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     139 |         disk_data = kzalloc(sizeof(*disk_data), GFP_KERNEL);
         |                   ^
   drivers/leds/trigger/ledtrig-disk.c: In function 'ledtrig_disk_blink_oneshot':
>> drivers/leds/trigger/ledtrig-disk.c:184:9: error: implicit declaration of function 'list_for_each_entry_rcu'; did you mean 'list_for_each_entry_from'? [-Wimplicit-function-declaration]
     184 |         list_for_each_entry_rcu(led_cdev, &trig->led_cdevs, trig_list) {
         |         ^~~~~~~~~~~~~~~~~~~~~~~
         |         list_for_each_entry_from
>> drivers/leds/trigger/ledtrig-disk.c:184:61: error: 'trig_list' undeclared (first use in this function); did you mean 'lru_list'?
     184 |         list_for_each_entry_rcu(led_cdev, &trig->led_cdevs, trig_list) {
         |                                                             ^~~~~~~~~
         |                                                             lru_list
   drivers/leds/trigger/ledtrig-disk.c:184:61: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/leds/trigger/ledtrig-disk.c:184:71: error: expected ';' before '{' token
     184 |         list_for_each_entry_rcu(led_cdev, &trig->led_cdevs, trig_list) {
         |                                                                       ^~
         |                                                                       ;
>> drivers/leds/trigger/ledtrig-disk.c:181:35: warning: unused variable 'disk_data' [-Wunused-variable]
     181 |         struct ledtrig_disk_data *disk_data;
         |                                   ^~~~~~~~~


vim +119 drivers/leds/trigger/ledtrig-disk.c

   114	
   115	static void pattern_init(struct led_classdev *led_cdev, struct ledtrig_disk_data *disk_data)
   116	{
   117		unsigned int size = 0;
   118	
 > 119		u32 *pattern __free(kfree) = led_get_default_pattern(led_cdev, &size);
   120		if (!pattern)
   121			return;
   122	
   123		if (size != 3) {
   124			dev_warn(led_cdev->dev,
   125				 "Expected 3 but got %u values for delays + invert pattern\n",
   126				 size);
   127			return;
   128		}
   129	
   130		disk_data->delay_on = pattern[0];
   131		disk_data->delay_off = pattern[1];
   132		disk_data->invert = !!pattern[2];
   133	}
   134	
   135	static int ledtrig_disk_activate(struct led_classdev *led_cdev)
   136	{
   137		struct ledtrig_disk_data *disk_data;
   138	
 > 139		disk_data = kzalloc(sizeof(*disk_data), GFP_KERNEL);
   140		if (!disk_data)
   141			return -ENOMEM;
   142	
   143		disk_data->delay_on = DEFAULT_BLINK_DELAY;
   144		disk_data->delay_off = DEFAULT_BLINK_DELAY;
   145	
   146		led_set_trigger_data(led_cdev, disk_data);
   147	
   148		if (led_cdev->flags & LED_INIT_DEFAULT_TRIGGER) {
   149			pattern_init(led_cdev, disk_data);
   150			/*
   151			 * Mark as initialized even on pattern_init() error because
   152			 * any consecutive call to it would produce the same error.
   153			 */
   154			led_cdev->flags &= ~LED_INIT_DEFAULT_TRIGGER;
   155		}
   156	
   157		led_set_brightness_nosleep(led_cdev, disk_data->invert ? LED_FULL : LED_OFF);
   158	
   159		return 0;
   160	}
   161	
   162	static struct led_trigger ledtrig_disk = {
   163		.name = "disk-activity",
   164		.activate = ledtrig_disk_activate,
   165		.groups = ledtrig_disk_groups,
   166	};
   167	static struct led_trigger ledtrig_disk_read = {
   168		.name = "disk-read",
   169		.activate = ledtrig_disk_activate,
   170		.groups = ledtrig_disk_groups,
   171	};
   172	static struct led_trigger ledtrig_disk_write = {
   173		.name = "disk-write",
   174		.activate = ledtrig_disk_activate,
   175		.groups = ledtrig_disk_groups,
   176	};
   177	
   178	static void ledtrig_disk_blink_oneshot(struct led_trigger *trig)
   179	{
   180		struct led_classdev *led_cdev;
 > 181		struct ledtrig_disk_data *disk_data;
   182	
   183		rcu_read_lock();
 > 184		list_for_each_entry_rcu(led_cdev, &trig->led_cdevs, trig_list) {
   185			disk_data = led_get_trigger_data(led_cdev);
   186			led_blink_set_oneshot(led_cdev, &disk_data->delay_on, &disk_data->delay_off,
   187					      disk_data->invert);
   188		}
   189		rcu_read_unlock();
   190	}
   191	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki