From: Niklas Cassel <cassel@kernel.org>
To: Ian Pilcher <arequipeno@gmail.com>
Cc: Markus Probst <markus.probst@posteo.de>,
Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Damien Le Moal <dlemoal@kernel.org>,
John Garry <john.g.garry@oracle.com>,
Jason Yan <yanaijie@huawei.com>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Pavel Machek <pavel@ucw.cz>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH RFC 0/4] leds: extend disk trigger
Date: Mon, 26 Jan 2026 20:03:07 +0100 [thread overview]
Message-ID: <aXe6a7X6QZmEZHjI@ryzen> (raw)
In-Reply-To: <03a91568-d1a0-4779-a465-2788f4765a42@gmail.com>
Hello Ian,
On Mon, Jan 26, 2026 at 10:19:07AM -0600, Ian Pilcher wrote:
> On 1/26/26 3:00 AM, Niklas Cassel wrote:
> > But I'm not a fan of making the driver more complex.
> > If we want something more complex than what is already there, then it
> > is probably much better handled in user space, considering the amount
> > of possible configuration options.
> >
> > Basically the same argument as used in:
> > https://lore.kernel.org/linux-nvme/20220227234258.24619-1-ematsumiya@suse.de/T/#u
>
> Niklas -
>
> Can you provide some links on how this might be done in userspace?
See the link to the thread above.
Ming suggests "tracking iostat in a fixed period, and triggering one
led activity if any read/write IO happens during 0.5sec."
There is also a link to an nvme-led-daemon in the thread:
https://github.com/scarlion1/nvme-led-daemon
But considering that it is using:
https://www.kernel.org/doc/Documentation/block/stat.txt
I don't see why it can't be used for any block device.
Kind regards,
Niklas
next prev parent reply other threads:[~2026-01-26 19:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 19:05 [PATCH RFC 0/4] leds: extend disk trigger Markus Probst
2026-01-23 19:05 ` [PATCH RFC 1/4] leds: dt-bindings: add disk trigger led pattern Markus Probst
2026-01-23 19:05 ` [PATCH RFC 2/4] leds: dt-bindings: add disk trigger for each ata port Markus Probst
2026-01-23 19:05 ` [PATCH RFC 3/4] leds: add delay_on, delay_off and invert attributes to disk trigger Markus Probst
2026-01-23 19:18 ` Markus Probst
2026-01-25 17:14 ` kernel test robot
2026-01-26 0:42 ` kernel test robot
2026-01-23 19:05 ` [PATCH RFC 4/4] leds: add disk trigger for each ata port Markus Probst
2026-01-25 17:57 ` kernel test robot
2026-01-26 6:34 ` Damien Le Moal
2026-01-24 23:21 ` [PATCH RFC 0/4] leds: extend disk trigger Pavel Machek
2026-01-25 0:19 ` Markus Probst
2026-01-26 9:00 ` Niklas Cassel
2026-01-26 16:19 ` Ian Pilcher
2026-01-26 19:03 ` Niklas Cassel [this message]
2026-01-26 22:06 ` Markus Probst
2026-01-27 9:32 ` Niklas Cassel
2026-01-27 15:34 ` Markus Probst
2026-01-28 6:34 ` Damien Le Moal
2026-01-28 15:44 ` Markus Probst
2026-01-28 21:51 ` Niklas Cassel
2026-01-29 4:41 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXe6a7X6QZmEZHjI@ryzen \
--to=cassel@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=arequipeno@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlemoal@kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=john.g.garry@oracle.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=markus.probst@posteo.de \
--cc=martin.petersen@oracle.com \
--cc=pavel@kernel.org \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.